Staging: vt6655: device_main: cleanup long line
PATCH 1/1 Staging: vt6655: device_main: cleanup long line
Code cleanup: long line found by checkpatch.
Changes to be committed:
modified: drivers/staging/vt6655/device_main.c
--- drivers/staging/vt6655/device_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/device_main.c +2 -1
@@ -1075,7 +1075,8 @@ static void vnt_interrupt_process(struct vnt_private *priv) priv->op_mode == NL80211_IFTYPE_ADHOC) && priv->vif->bss_conf.enable_beacon) {MACvOneShotTimer1MicroSec (priv, - (priv->vif->bss_conf.beacon_int -MAKE_BEACON_RESERVED ) <<10 ); + (priv->vif->bss_conf.beacon_int - +MAKE_BEACON_RESERVED ) <<10 ); }/* TODO: adhoc PS mode */
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 4 lines · Lourdes Pedrajas
Code cleanup: long line found by checkpatch.
Changes to be committed:
modified:drivers/staging/vt6655/device_main.c
Why are these two lines in the changelog text?
Quoted 11 lines
Signed-off-by Lourdes Pedrajas <[email protected]>--- drivers/staging/vt6655/device_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/vt6655/device_main.c +0
-0
drivers/staging/vt6655/device_main.c static void vnt_interrupt_process(struct vnt_private *priv) · line 1079
Quoted 6 lines
drivers/staging/vt6655/device_main.c +2
-1@@ -1075,7 +1075,8 @@ static void vnt_interrupt_process(struct vnt_private *priv) priv->op_mode == NL80211_IFTYPE_ADHOC) && priv->vif->bss_conf.enable_beacon) {MACvOneShotTimer1MicroSec (priv, - (priv->vif->bss_conf.beacon_int -MAKE_BEACON_RESERVED ) <<10 ); + (priv->vif->bss_conf.beacon_int - +MAKE_BEACON_RESERVED ) <<10 );
Now you have another checkpatch warning :(
THe original is fine, the line-length is a "strong hint" that sometimes needs to be gone over.
sorry.
greg k-h
Quoted 8 lines · Greg KH
Quoted 4 lines · Lourdes Pedrajas
Code cleanup: long line found by checkpatch.
Changes to be committed:
modified:drivers/staging/vt6655/device_main.cWhy are these two lines in the changelog text?
My mistake, I thought it is correct to include them, sorry!
Quoted 20 lines
Quoted 11 lines
Signed-off-by Lourdes Pedrajas <[email protected]>--- drivers/staging/vt6655/device_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/vt6655/device_main.c +0
-0drivers/staging/vt6655/device_main.c static void vnt_interrupt_process(struct vnt_private *priv) · line 1079
Quoted 6 lines
drivers/staging/vt6655/device_main.c +2
-1@@ -1075,7 +1075,8 @@ static void vnt_interrupt_process(struct vnt_private *priv) priv->op_mode == NL80211_IFTYPE_ADHOC) && priv->vif->bss_conf.enable_beacon) {MACvOneShotTimer1MicroSec (priv, - (priv->vif->bss_conf.beacon_int -MAKE_BEACON_RESERVED ) <<10 ); + (priv->vif->bss_conf.beacon_int - +MAKE_BEACON_RESERVED ) <<10 );Now you have another checkpatch warning :(
Quoted 6 lines
THe original is fine, the line-length is a "strong hint" that sometimes needs to be gone over.
sorry.
greg k-h
I also had my doubts about this one, thank you for clarifying!
Lourdes.
Quoted 10 lines · Lourdes Pedrajas
Quoted 8 lines · Greg KH
Quoted 4 lines · Lourdes Pedrajas
Code cleanup: long line found by checkpatch.
Changes to be committed:
modified:drivers/staging/vt6655/device_main.cWhy are these two lines in the changelog text?
My mistake, I thought it is correct to include them, sorry!
Take a quick look at https://lkml.org/ and see patches that other people have sent. If you look at some examples, you will get some intuition about what information should be put where.
julia
Quoted 37 lines
Quoted 21 lines
Quoted 12 lines
Signed-off-by Lourdes Pedrajas <[email protected]>--- drivers/staging/vt6655/device_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/vt6655/device_main.c +0
-0drivers/staging/vt6655/device_main.c static void vnt_interrupt_process(struct vnt_private *priv) · line 1079
Quoted 6 lines
drivers/staging/vt6655/device_main.c +2
-1@@ -1075,7 +1075,8 @@ static void vnt_interrupt_process(struct vnt_private *priv) priv->op_mode == NL80211_IFTYPE_ADHOC) && priv->vif->bss_conf.enable_beacon) {MACvOneShotTimer1MicroSec (priv, - (priv->vif->bss_conf.beacon_int -MAKE_BEACON_RESERVED ) <<10 ); + (priv->vif->bss_conf.beacon_int - +MAKE_BEACON_RESERVED ) <<10 );Now you have another checkpatch warning :(
Quoted 6 lines
THe original is fine, the line-length is a "strong hint" that sometimes needs to be gone over.
sorry.
greg k-h
I also had my doubts about this one, thank you for clarifying!
Lourdes.
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200308134915.GA4173%40supernova.
Quoted 11 lines · Julia Lawall
Quoted 9 lines · Lourdes Pedrajas
Quoted 8 lines · Greg KH
Quoted 4 lines · Lourdes Pedrajas
Code cleanup: long line found by checkpatch.
Changes to be committed:
modified:drivers/staging/vt6655/device_main.cWhy are these two lines in the changelog text?
Quoted 9 lines
Quoted 1 line
My mistake, I thought it is correct to include them, sorry!
Take a quick look at https://lkml.org/ and see patches that other people have sent. If you look at some examples, you will get some intuition about what information should be put where.
julia
Yes, thank you!
Quoted 37 lines
Quoted 37 lines
Quoted 21 lines
Quoted 12 lines
Signed-off-by Lourdes Pedrajas <[email protected]>--- drivers/staging/vt6655/device_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/vt6655/device_main.c +0
-0drivers/staging/vt6655/device_main.c static void vnt_interrupt_process(struct vnt_private *priv) · line 1079
Quoted 6 lines
drivers/staging/vt6655/device_main.c +2
-1@@ -1075,7 +1075,8 @@ static void vnt_interrupt_process(struct vnt_private *priv) priv->op_mode == NL80211_IFTYPE_ADHOC) && priv->vif->bss_conf.enable_beacon) {MACvOneShotTimer1MicroSec (priv, - (priv->vif->bss_conf.beacon_int -MAKE_BEACON_RESERVED ) <<10 ); + (priv->vif->bss_conf.beacon_int - +MAKE_BEACON_RESERVED ) <<10 );Now you have another checkpatch warning :(
Quoted 6 lines
THe original is fine, the line-length is a "strong hint" that sometimes needs to be gone over.
sorry.
greg k-h
I also had my doubts about this one, thank you for clarifying!
Lourdes.
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200308134915.GA4173%40supernova.