Skip to contentSkip to conversation

package/qt5: add qt5remoteobjects library

PATCH New Sven Fischer 3 participants 5 messages Mar 7, 2020 – Mar 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/qt5: add qt5remoteobjects library

Qt 5.12 adds a library for IPC. This library is missing from the distributed qt5 package. Added it by using the library qt5serialport as a template and replaced serialport with remoteobjects, recalculated the sha256 sums.

---
package/qt5/Config.in | 1 + .../5.12.7/qt5remoteobjects.hash | 8 +++ package/qt5/qt5remoteobjects/Config.in | 12 +++++ .../qt5remoteobjects/qt5remoteobjects.hash | 2 + .../qt5/qt5remoteobjects/qt5remoteobjects.mk | 50 +++++++++++++++++++

5 files changed, 73 insertions(+)

create mode 100644 package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash create mode 100644 package/qt5/qt5remoteobjects/Config.in
create mode 100644 package/qt5/qt5remoteobjects/qt5remoteobjects.hash create mode 100644 package/qt5/qt5remoteobjects/qt5remoteobjects.mk

package/qt5/Config.in +0 -0
index 7051bf517a..2178c7d545 100644
@@ -54,6 +54,7 @@ source "package/qt5/qt5location/Config.in"

source "package/qt5/qt5multimedia/Config.in"
source "package/qt5/qt5quickcontrols/Config.in"
source "package/qt5/qt5quickcontrols2/Config.in"
+source "package/qt5/qt5remoteobjects/Config.in"
source "package/qt5/qt5script/Config.in"
source "package/qt5/qt5scxml/Config.in"
source "package/qt5/qt5sensors/Config.in"

(quoted diff) +0 -0

b/package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash new file mode 100644
index 0000000000..4097dd8d54

package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash new file +1 -0
@@ -0,0 +1,8 @@
+# Hash from:

https://download.qt.io/official_releases/qt/5.12/5.12.7/submodules/qtremoteobjects-everywhere-src-5.12.7.tar.xz.sha256
+sha256 6d6aaec4e9c140c027b0badaabc6322ea3c16cf649495a27fec1f261e891120f qtremoteobjects-everywhere-src-5.12.7.tar.xz
+
+# Hashes for license files:
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 LICENSE.GPL2
+sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 LICENSE.GPL3
+sha256 0dbe024961f6ab5c52689cbd036c977975d0d0f6a67ff97762d96cb819dd5652 LICENSE.GPL3-EXCEPT
+sha256 da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768 LICENSE.LGPL3

(quoted diff) +0 -0

b/package/qt5/qt5remoteobjects/Config.in
new file mode 100644
index 0000000000..bba5c5af1c

package/qt5/qt5remoteobjects/Config.in new file +12 -0
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_QT5REMOTEOBJECTS
+ bool "qt5remoteobjects"
+ select BR2_PACKAGE_QT5BASE
+ help
+ Qt is a cross-platform application and UI framework for
+ developers using C++.
+
+ Qt Remote Objects (QtRO) is an Inter-Process Communication (IPC) module
+ developed for Qt. This module extends Qt's existing functionalities to
+ enable information exchange between processes or computers, easily.
+
+ http://doc.qt.io/qt-5/qtremoteobjects-index.html
(quoted diff) +0 -0

b/package/qt5/qt5remoteobjects/qt5remoteobjects.hash new file mode 100644
index 0000000000..5316f03b10

package/qt5/qt5remoteobjects/qt5remoteobjects.hash new file +2 -0
@@ -0,0 +1,2 @@
+# This hash file is not used; instead, update the
+# hash files in the per-version sub-directories.
(quoted diff) +0 -0

b/package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file mode 100644
index 0000000000..7e9bd53aa0

package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +9 -0
@@ -0,0 +1,50 @@
+################################################################################
+#
+# qt5remoteobjects
+#
+################################################################################
+
+QT5REMOTEOBJECTS_VERSION = $(QT5_VERSION)
+QT5REMOTEOBJECTS_SITE = $(QT5_SITE)
+QT5REMOTEOBJECTS_SOURCE =

qtremoteobjects-$(QT5_SOURCE_TARBALL_PREFIX)-$(QT5REMOTEOBJECTS_VERSION).tar.xz +QT5REMOTEOBJECTS_DEPENDENCIES = qt5base +QT5REMOTEOBJECTS_INSTALL_STAGING = YES
+
+ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y) +QT5REMOTEOBJECTS_LICENSE = GPL-2.0+ or LGPL-3.0, GPL-3.0 with exception(tools), GFDL-1.3 (docs)
+QT5REMOTEOBJECTS_LICENSE_FILES = LICENSE.GPL2 LICENSE.GPL3 LICENSE.GPL3-EXCEPT LICENSE.LGPL3 LICENSE.FDL
+else
+QT5REMOTEOBJECTS_LICENSE = GPL-2.0 or GPL-3.0 or LGPL-2.1 with exception or LGPL-3.0, GFDL-1.3 (docs) +QT5REMOTEOBJECTS_LICENSE_FILES = LICENSE.GPLv2 LICENSE.GPLv3 LICENSE.LGPLv21 LGPL_EXCEPTION.txt LICENSE.LGPLv3 LICENSE.FDL +endif
+
+define QT5REMOTEOBJECTS_CONFIGURE_CMDS
+ (cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/bin/qmake)
+endef
+
+define QT5REMOTEOBJECTS_BUILD_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define QT5REMOTEOBJECTS_INSTALL_STAGING_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install
+endef
+
+ifeq ($(BR2_STATIC_LIBS),)
+define QT5REMOTEOBJECTS_INSTALL_TARGET_LIBS
+ cp -dpf $(STAGING_DIR)/usr/lib/libQt5RemoteObjects.so.* $(TARGET_DIR)/usr/lib
+endef
+endif
+
+ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
+define QT5REMOTEOBJECTS_INSTALL_TARGET_EXAMPLES
+ cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/remoteobjects $(TARGET_DIR)/usr/lib/qt/examples/
+endef
+endif
+
+define QT5REMOTEOBJECTS_INSTALL_TARGET_CMDS
+ $(QT5REMOTEOBJECTS_INSTALL_TARGET_LIBS)
+ $(QT5REMOTEOBJECTS_INSTALL_TARGET_EXAMPLES)
+endef
+
+$(eval $(generic-package))

Signature · 10 lines
2.25.1


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4052 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200307/bb95df98/attachment.p7s>
#1 lore raw

PATCH 1/1 package/qt5: add qt5remoteobjects library

Hello Sven,

Quoted 6 lines · On Sat, 7 Mar 2020 16:19:12 +0100 Sven Fischer <[email protected]> wrote:

Qt 5.12 adds a library for IPC. This library is missing from the distributed qt5 package. Added it by using the library qt5serialport as a template and replaced serialport with remoteobjects, recalculated the sha256 sums.

Thanks a lot for your patch. However, it has been badly line-wrapped by your e-mail client, which makes it impossible to apply, and difficult to review.

Could you resend it using "git send-email", as instructed in the Buildroot manual
(https://buildroot.org/downloads/manual/manual.html#submitting-patches) ?

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/qt5: add qt5remoteobjects library

In reply to Sven Fischer

Hello Sven,

despite the line-wrapped/e-mail client problems some basic review...

Subject should be:

package/qt5remoteobjects: new package

Quoted 4 lines · Sven Fischer

Qt 5.12 adds a library for IPC. This library is missing from the distributed qt5 package. Added it by using the library qt5serialport as a template and replaced serialport with remoteobjects, recalculated the sha256 sums.

All but the first sentence is better moved to patch cover-letter or note below the first '---' (see below for example)...

Quoted 3 lines

---

Notes:
- Added it by using the library qt5serialport as a template and replaced serialport with remoteobjects, recalculated the sha256 sums.

Quoted 51 lines

package/qt5/Config.in | 1 + .../5.12.7/qt5remoteobjects.hash | 8 +++ package/qt5/qt5remoteobjects/Config.in | 12 +++++ .../qt5remoteobjects/qt5remoteobjects.hash | 2 + .../qt5/qt5remoteobjects/qt5remoteobjects.mk | 50 +++++++++++++++++++

5 files changed, 73 insertions(+)

create mode 100644 package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash create mode 100644 package/qt5/qt5remoteobjects/Config.in
create mode 100644 package/qt5/qt5remoteobjects/qt5remoteobjects.hash create mode 100644 package/qt5/qt5remoteobjects/qt5remoteobjects.mk

package/qt5/Config.in +0 -0
index 7051bf517a..2178c7d545 100644
@@ -54,6 +54,7 @@ source "package/qt5/qt5location/Config.in"

source "package/qt5/qt5multimedia/Config.in"
source "package/qt5/qt5quickcontrols/Config.in"
source "package/qt5/qt5quickcontrols2/Config.in"
+source "package/qt5/qt5remoteobjects/Config.in"
source "package/qt5/qt5script/Config.in"
source "package/qt5/qt5scxml/Config.in"
source "package/qt5/qt5sensors/Config.in"

package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash new file +1 -0
new file mode 100644
index 0000000000..4097dd8d54
@@ -0,0 +1,8 @@
+# Hash from:

https://download.qt.io/official_releases/qt/5.12/5.12.7/submodules/qtremoteobjects-everywhere-src-5.12.7.tar.xz.sha256
+sha256 6d6aaec4e9c140c027b0badaabc6322ea3c16cf649495a27fec1f261e891120f qtremoteobjects-everywhere-src-5.12.7.tar.xz

package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash new file +3 -0
+
+# Hashes for license files:
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643

LICENSE.GPL2
+sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 LICENSE.GPL3
+sha256 0dbe024961f6ab5c52689cbd036c977975d0d0f6a67ff97762d96cb819dd5652 LICENSE.GPL3-EXCEPT
+sha256 da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768 LICENSE.LGPL3

package/qt5/qt5remoteobjects/Config.in new file +0 -0
new file mode 100644
index 0000000000..bba5c5af1c

package/qt5/qt5remoteobjects/Config.in line 3

Quoted 3 lines
package/qt5/qt5remoteobjects/Config.in new file +3 -0
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_QT5REMOTEOBJECTS
+ bool "qt5remoteobjects"
+ select BR2_PACKAGE_QT5BASE
$ head -1 build/qt5remoteobjects-5.12.7/qtremoteobjects.pro
requires(qtHaveModule(network))

Missing:

select BR2_PACKAGE_QT5BASE_NETWORK

Quoted 16 lines
package/qt5/qt5remoteobjects/Config.in new file +9 -0
+ help
+ Qt is a cross-platform application and UI framework for
+ developers using C++.
+
+ Qt Remote Objects (QtRO) is an Inter-Process Communication (IPC) module
+ developed for Qt. This module extends Qt's existing functionalities to
+ enable information exchange between processes or computers, easily.
+
+ http://doc.qt.io/qt-5/qtremoteobjects-index.html
package/qt5/qt5remoteobjects/qt5remoteobjects.hash new file +0 -0
new file mode 100644
index 0000000000..5316f03b10

package/qt5/qt5remoteobjects/qt5remoteobjects.hash line 2

Quoted 2 lines
package/qt5/qt5remoteobjects/qt5remoteobjects.hash new file +2 -0
@@ -0,0 +1,2 @@
+# This hash file is not used; instead, update the
+# hash files in the per-version sub-directories.

Please re-base your patch against git next (the distinction between LTS and Lates is gone), only Qt-5.12.x is supported, no more need for an extra 5.12.7 subdirectory...

Quoted 16 lines
package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +9 -0
new file mode 100644
index 0000000000..7e9bd53aa0
@@ -0,0 +1,50 @@
+################################################################################
+#
+# qt5remoteobjects
+#
+################################################################################
+
+QT5REMOTEOBJECTS_VERSION = $(QT5_VERSION)
+QT5REMOTEOBJECTS_SITE = $(QT5_SITE)
+QT5REMOTEOBJECTS_SOURCE =
Quoted 2 lines

qtremoteobjects-$(QT5_SOURCE_TARBALL_PREFIX)-$(QT5REMOTEOBJECTS_VERSION).tar.xz +QT5REMOTEOBJECTS_DEPENDENCIES = qt5base

$ find build/qt5remoteobjects-5.12.7 -name "*.pro" | xargs grep QT

build/qt5remoteobjects-5.12.7/src/imports/compat/compat.pro:QT += qml remoteobjects

--> at least an optional dependency is missing

Quoted 38 lines
package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +4 -0
+QT5REMOTEOBJECTS_INSTALL_STAGING = YES
+
+ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
+QT5REMOTEOBJECTS_LICENSE = GPL-2.0+ or LGPL-3.0, GPL-3.0 with

exception(tools), GFDL-1.3 (docs) +QT5REMOTEOBJECTS_LICENSE_FILES = LICENSE.GPL2 LICENSE.GPL3 LICENSE.GPL3-EXCEPT LICENSE.LGPL3 LICENSE.FDL

package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +2 -0
+else
+QT5REMOTEOBJECTS_LICENSE = GPL-2.0 or GPL-3.0 or LGPL-2.1 with

exception or LGPL-3.0, GFDL-1.3 (docs) +QT5REMOTEOBJECTS_LICENSE_FILES = LICENSE.GPLv2 LICENSE.GPLv3 LICENSE.LGPLv21 LGPL_EXCEPTION.txt LICENSE.LGPLv3 LICENSE.FDL

package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +17 -0
+endif
+
+define QT5REMOTEOBJECTS_CONFIGURE_CMDS
+ (cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/bin/qmake)
+endef
+
+define QT5REMOTEOBJECTS_BUILD_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define QT5REMOTEOBJECTS_INSTALL_STAGING_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install
+endef
+
+ifeq ($(BR2_STATIC_LIBS),)
+define QT5REMOTEOBJECTS_INSTALL_TARGET_LIBS
+ cp -dpf $(STAGING_DIR)/usr/lib/libQt5RemoteObjects.so.*

$(TARGET_DIR)/usr/lib

package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +6 -0
+endef
+endif
+
+ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
+define QT5REMOTEOBJECTS_INSTALL_TARGET_EXAMPLES
+ cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/remoteobjects

$(TARGET_DIR)/usr/lib/qt/examples/

package/qt5/qt5remoteobjects/qt5remoteobjects.mk

Quoted 9 lines
package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +9 -0
+endef
+endif
+
+define QT5REMOTEOBJECTS_INSTALL_TARGET_CMDS
+ $(QT5REMOTEOBJECTS_INSTALL_TARGET_LIBS)
+ $(QT5REMOTEOBJECTS_INSTALL_TARGET_EXAMPLES)
+endef
+
+$(eval $(generic-package))

Otherwise looks good (and compiles)...

Regards,
Peter

#3 lore raw

PATCH 1/1 package/qt5: add qt5remoteobjects library

Hi Peter,

Am 07.03.20 um 23:00 schrieb Peter Seiderer:

Quoted 5 lines

despite the line-wrapped/e-mail client problems some basic review...

Subject should be:

package/qt5remoteobjects: new package

But it is not a new package, but a sub-package for Qt5. That's the reason for the subject. But I can write any subject you like ;-)

Quoted 16 lines · Sven Fischer
Quoted 5 lines

Qt 5.12 adds a library for IPC. This library is missing from the distributed qt5 package. Added it by using the library qt5serialport as a template and replaced serialport with remoteobjects, recalculated the sha256 sums.

All but the first sentence is better moved to patch cover-letter or note below the first '---' (see below for example)...

Quoted 2 lines

---

Notes:
- Added it by using the library qt5serialport as a template and replaced serialport with remoteobjects, recalculated the sha256 sums.

Quoted 8 lines
Quoted 3 lines

+QT5REMOTEOBJECTS_SOURCE = qtremoteobjects-$(QT5_SOURCE_TARBALL_PREFIX)-$(QT5REMOTEOBJECTS_VERSION).tar.xz +QT5REMOTEOBJECTS_DEPENDENCIES = qt5base

$ find build/qt5remoteobjects-5.12.7 -name "*.pro" | xargs grep QT

build/qt5remoteobjects-5.12.7/src/imports/compat/compat.pro:QT += qml remoteobjects

--> at least an optional dependency is missing

Okay, trying to find out what to add to have the qtHaveModule(quick) condition satisfied...

Quoted 1 line

Otherwise looks good (and compiles)...

Thx.

Regards, Sven

Signature · 12 lines
Sven Fischer -- Platzer H?henweg 34, 51429 Bergisch Gladbach, Germany
                Tel: +49-(0)2204-480985, Fax: +49-(0)2204-9670019
                sven at leiderfischer.de


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4052 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200308/814c59fa/attachment.p7s>
#4 lore raw

PATCH 1/1 package/qt5: add qt5remoteobjects library

Hello Sven,

Quoted 10 lines · Sven Fischer

Hi Peter,

Am 07.03.20 um 23:00 schrieb Peter Seiderer:

Quoted 5 lines

despite the line-wrapped/e-mail client problems some basic review...

Subject should be:

package/qt5remoteobjects: new package

But it is not a new package, but a sub-package for Qt5. That's the reason for the subject. But I can write any subject you like ;-)

I see..., but from the buildroot perspective it is a 'new package', and the de-facto standard of buildroot, see e.g.:

$ git log --oneline package/qt5/qt5serialport | tail -1
Quoted 21 lines
Quoted 21 lines · Sven Fischer
Quoted 5 lines

Qt 5.12 adds a library for IPC. This library is missing from the distributed qt5 package. Added it by using the library qt5serialport as a template and replaced serialport with remoteobjects, recalculated the sha256 sums.

All but the first sentence is better moved to patch cover-letter or note below the first '---' (see below for example)...

Quoted 2 lines

---

Notes:
- Added it by using the library qt5serialport as a template and replaced serialport with remoteobjects, recalculated the sha256 sums.

Quoted 3 lines

+QT5REMOTEOBJECTS_SOURCE = qtremoteobjects-$(QT5_SOURCE_TARBALL_PREFIX)-$(QT5REMOTEOBJECTS_VERSION).tar.xz +QT5REMOTEOBJECTS_DEPENDENCIES = qt5base

$ find build/qt5remoteobjects-5.12.7 -name "*.pro" | xargs grep QT
Quoted 5 lines
Quoted 3 lines

build/qt5remoteobjects-5.12.7/src/imports/compat/compat.pro:QT += qml remoteobjects

--> at least an optional dependency is missing

Okay, trying to find out what to add to have the qtHaveModule(quick) condition satisfied...

It is the qt5declarative buildroot package, interesting is if it is optional or not...

Regards,
Peter

Quoted 6 lines
Quoted 1 line

Otherwise looks good (and compiles)...

Thx.

Regards, Sven