: dt-bindings: display: fix panel warnings

PATCH In review Sam Ravnborg 4 participants 7 messages Mar 8, 2020 – Mar 14, 2020

Subsystems (5)

Device tree bindings DRM drivers DRM misc DRM panel drivers +1 more subsystems

lore

Share & tools

lore

Sam Ravnborg

author

2020-03-08 11:50 UTC #0 lore raw

cover : dt-bindings: display: fix panel warnings

While experiemnting with latest kbuild changes for DT Schema support there was a couple a new warnings - in may use-case where I only check one binding file.

Fix the warnings in display/panel/
There are plenty more to go after in other directories, which I have left for others to have fun with.

Patch is on top of drm-misc-next, where it will be applied once acked/reviewed.

Sam

Sam Ravnborg (1):
dt-bindings: display: fix panel warnings

 Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml   | 2 +-
 .../devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml       | 2 +-
 Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml  | 4 ++--
 .../devicetree/bindings/display/panel/orisetech,otm8009a.yaml         | 2 +-
 Documentation/devicetree/bindings/display/panel/panel-dpi.yaml        | 2 +-
 Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 +-
 Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml  | 2 +-
 .../devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml         | 2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Sam Ravnborg

author

2020-03-08 11:50 UTC #1 lore raw

PATCH 1/1 dt-bindings: display: fix panel warnings

Fix following type af warnings in the panel bindings:

Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property

Removing the "@xxx" from the node name fixed first warning. Adding a missing reg property fixed the second warning

Signed-off-by Sam Ravnborg <[email protected]>

Cc Thierry Reding <[email protected]>

Cc Linus Walleij <[email protected]>

Cc Rob Herring <[email protected]>

Cc Heiko Stuebner <[email protected]>

Cc Maxime Ripard <[email protected]>

Cc Benjamin Gaignard <[email protected]>

Cc Laurent Pinchart <[email protected]>

---
 .../devicetree/bindings/display/panel/elida,kd35t133.yaml     | 2 +-
 .../bindings/display/panel/leadtek,ltk500hd1829.yaml          | 2 +-
 .../devicetree/bindings/display/panel/novatek,nt35510.yaml    | 4 ++--
 .../devicetree/bindings/display/panel/orisetech,otm8009a.yaml | 2 +-
 .../devicetree/bindings/display/panel/panel-dpi.yaml          | 2 +-
 .../devicetree/bindings/display/panel/panel-simple-dsi.yaml   | 2 +-
 .../devicetree/bindings/display/panel/raydium,rm68200.yaml    | 2 +-
 .../devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml | 2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)

Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml +1 -1

index 4bd74eaa61be..aa761f697b7a 100644
@@ -34,7 +34,7 @@ additionalProperties: false
 
 examples:
   - |
-    dsi@ff450000 {
+    dsi {
         #address-cells = <1>;
         #size-cells = <0>;
         panel@0 {

Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml +1 -1

index 4ebcea7d0c63..2c9b8aa34815 100644
@@ -34,7 +34,7 @@ additionalProperties: false
 
 examples:
   - |
-    dsi@ff450000 {
+    dsi {
         #address-cells = <1>;
         #size-cells = <0>;
         panel@0 {

Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml +2 -2

index 791fc9daa68b..73d2ff3baaff 100644
@@ -40,10 +40,10 @@ examples:
   - |
     #include <dt-bindings/gpio/gpio.h>
 
-    dsi@a0351000 {
+    dsi {
         #address-cells = <1>;
         #size-cells = <0>;
-        panel {
+        panel@0 {
             compatible = "hydis,hva40wv1", "novatek,nt35510";
             reg = <0>;
             vdd-supply = <&ab8500_ldo_aux4_reg>;

Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml +1 -1

index 6e6ac995c27b..4b6dda6dbc0f 100644
@@ -39,7 +39,7 @@ required:
 
 examples:
   - |
-    dsi@0 {
+    dsi {
       #address-cells = <1>;
       #size-cells = <0>;
       panel@0 {

Documentation/devicetree/bindings/display/panel/panel-dpi.yaml +1 -1

index 5275d350f8cb..f63870384c00 100644
@@ -48,7 +48,7 @@ additionalProperties: false
 
 examples:
   - |
-    panel@0 {
+    panel {
         compatible = "osddisplays,osd057T0559-34ts", "panel-dpi";
         label = "osddisplay";
         power-supply = <&vcc_supply>;

Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml +1 -1

index 8b60368a2425..cefe19b6bf44 100644
@@ -50,7 +50,7 @@ required:
 
 examples:
   - |
-    mdss_dsi@fd922800 {
+    mdss_dsi {
       #address-cells = <1>;
       #size-cells = <0>;
       panel@0 {

Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml +1 -1

index 09149f140d5f..a35ba16fc000 100644
@@ -42,7 +42,7 @@ required:
 
 examples:
   - |
-    dsi@0 {
+    dsi {
       #address-cells = <1>;
       #size-cells = <0>;
       panel@0 {

Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml +1 -1

index 186e5e1c8fa3..39ec7ae525ad 100644
@@ -34,7 +34,7 @@ additionalProperties: false
 
 examples:
   - |
-    dsi@ff450000 {
+    dsi {
         #address-cells = <1>;
         #size-cells = <0>;
         panel@0 {

Signature · 1 line

2.20.1

Linus Walleij

Reviewed-by on v1 1/1

2020-03-12 09:45 UTC #2 lore raw

Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings

Quoted 8 lines · Sam Ravnborg

Fix following type af warnings in the panel bindings:
Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property
Removing the "@xxx" from the node name fixed first warning. Adding a missing reg property fixed the second warning

Quoted 8 lines

Signed-off-by Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Rob Herring <[email protected]>
Cc Heiko Stuebner <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Benjamin Gaignard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Reviewed-by Linus Walleij <[email protected]>

Yours,
Linus Walleij

Benjamin GAIGNARD

Reviewed-by on v1 1/1

2020-03-12 10:22 UTC #3 lore raw

Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings

In reply to Sam Ravnborg

Quoted 8 lines · Sam Ravnborg

Fix following type af warnings in the panel bindings:
Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property
Removing the "@xxx" from the node name fixed first warning. Adding a missing reg property fixed the second warning

Quoted 8 lines

Signed-off-by Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Rob Herring <[email protected]>
Cc Heiko Stuebner <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Benjamin Gaignard <[email protected]>
Cc Laurent Pinchart <[email protected]>

I will add W=1 in my command line when check the yaml files to not reproduce this later.

Reviewed-by Benjamin Gaignard <[email protected]>

Thanks,
Benjamin

Quoted 119 lines

---
  .../devicetree/bindings/display/panel/elida,kd35t133.yaml     | 2 +-
  .../bindings/display/panel/leadtek,ltk500hd1829.yaml          | 2 +-
  .../devicetree/bindings/display/panel/novatek,nt35510.yaml    | 4 ++--
  .../devicetree/bindings/display/panel/orisetech,otm8009a.yaml | 2 +-
  .../devicetree/bindings/display/panel/panel-dpi.yaml          | 2 +-
  .../devicetree/bindings/display/panel/panel-simple-dsi.yaml   | 2 +-
  .../devicetree/bindings/display/panel/raydium,rm68200.yaml    | 2 +-
  .../devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml | 2 +-
  8 files changed, 9 insertions(+), 9 deletions(-)

Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml +1 -1

index 4bd74eaa61be..aa761f697b7a 100644
@@ -34,7 +34,7 @@ additionalProperties: false
 
  examples:
    - |
-    dsi@ff450000 {
+    dsi {
          #address-cells = <1>;
          #size-cells = <0>;
          panel@0 {

Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml +1 -1

index 4ebcea7d0c63..2c9b8aa34815 100644
@@ -34,7 +34,7 @@ additionalProperties: false
 
  examples:
    - |
-    dsi@ff450000 {
+    dsi {
          #address-cells = <1>;
          #size-cells = <0>;
          panel@0 {

Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml +2 -2

index 791fc9daa68b..73d2ff3baaff 100644
@@ -40,10 +40,10 @@ examples:
    - |
      #include <dt-bindings/gpio/gpio.h>
 
-    dsi@a0351000 {
+    dsi {
          #address-cells = <1>;
          #size-cells = <0>;
-        panel {
+        panel@0 {
              compatible = "hydis,hva40wv1", "novatek,nt35510";
              reg = <0>;
              vdd-supply = <&ab8500_ldo_aux4_reg>;

Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml +1 -1

index 6e6ac995c27b..4b6dda6dbc0f 100644
@@ -39,7 +39,7 @@ required:
 
  examples:
    - |
-    dsi@0 {
+    dsi {
        #address-cells = <1>;
        #size-cells = <0>;
        panel@0 {

Documentation/devicetree/bindings/display/panel/panel-dpi.yaml +1 -1

index 5275d350f8cb..f63870384c00 100644
@@ -48,7 +48,7 @@ additionalProperties: false
 
  examples:
    - |
-    panel@0 {
+    panel {
          compatible = "osddisplays,osd057T0559-34ts", "panel-dpi";
          label = "osddisplay";
          power-supply = <&vcc_supply>;

Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml +1 -1

index 8b60368a2425..cefe19b6bf44 100644
@@ -50,7 +50,7 @@ required:
 
  examples:
    - |
-    mdss_dsi@fd922800 {
+    mdss_dsi {
        #address-cells = <1>;
        #size-cells = <0>;
        panel@0 {

Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml +1 -1

index 09149f140d5f..a35ba16fc000 100644
@@ -42,7 +42,7 @@ required:
 
  examples:
    - |
-    dsi@0 {
+    dsi {
        #address-cells = <1>;
        #size-cells = <0>;
        panel@0 {

Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml +1 -1

index 186e5e1c8fa3..39ec7ae525ad 100644
@@ -34,7 +34,7 @@ additionalProperties: false
 
  examples:
    - |
-    dsi@ff450000 {
+    dsi {
          #address-cells = <1>;
          #size-cells = <0>;
          panel@0 {

Rob Herring

maintainer

2020-03-12 13:13 UTC #4 lore raw

Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings

Quoted 21 lines · Benjamin GAIGNARD

Quoted 8 lines · Sam Ravnborg
Fix following type af warnings in the panel bindings:
Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property
Removing the "@xxx" from the node name fixed first warning. Adding a missing reg property fixed the second warning
Quoted 8 lines
Signed-off-by Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Rob Herring <[email protected]>
Cc Heiko Stuebner <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Benjamin Gaignard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Quoted 2 lines

I will add W=1 in my command line when check the yaml files to not reproduce this later.

No need to starting in 5.7.

Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Rob Herring

maintainer Reviewed-by on v1 1/1

2020-03-12 13:19 UTC #5 lore raw

Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings

In reply to Sam Ravnborg

Quoted 102 lines · Sam Ravnborg

Fix following type af warnings in the panel bindings:
Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property
Removing the "@xxx" from the node name fixed first warning. Adding a missing reg property fixed the second warning
Signed-off-by Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Rob Herring <[email protected]>
Cc Heiko Stuebner <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Benjamin Gaignard <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 .../devicetree/bindings/display/panel/elida,kd35t133.yaml     | 2 +-
 .../bindings/display/panel/leadtek,ltk500hd1829.yaml          | 2 +-
 .../devicetree/bindings/display/panel/novatek,nt35510.yaml    | 4 ++--
 .../devicetree/bindings/display/panel/orisetech,otm8009a.yaml | 2 +-
 .../devicetree/bindings/display/panel/panel-dpi.yaml          | 2 +-
 .../devicetree/bindings/display/panel/panel-simple-dsi.yaml   | 2 +-
 .../devicetree/bindings/display/panel/raydium,rm68200.yaml    | 2 +-
 .../devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml | 2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)
Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml +1 -1
index 4bd74eaa61be..aa761f697b7a 100644
@@ -34,7 +34,7 @@ additionalProperties: false
 
 examples:
   - |
-    dsi@ff450000 {
+    dsi {
         #address-cells = <1>;
         #size-cells = <0>;
         panel@0 {
Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml +1 -1
index 4ebcea7d0c63..2c9b8aa34815 100644
@@ -34,7 +34,7 @@ additionalProperties: false
 
 examples:
   - |
-    dsi@ff450000 {
+    dsi {
         #address-cells = <1>;
         #size-cells = <0>;
         panel@0 {
Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml +2 -2
index 791fc9daa68b..73d2ff3baaff 100644
@@ -40,10 +40,10 @@ examples:
   - |
     #include <dt-bindings/gpio/gpio.h>
 
-    dsi@a0351000 {
+    dsi {
         #address-cells = <1>;
         #size-cells = <0>;
-        panel {
+        panel@0 {
             compatible = "hydis,hva40wv1", "novatek,nt35510";
             reg = <0>;
             vdd-supply = <&ab8500_ldo_aux4_reg>;
Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml +1 -1
index 6e6ac995c27b..4b6dda6dbc0f 100644
@@ -39,7 +39,7 @@ required:
 
 examples:
   - |
-    dsi@0 {
+    dsi {
       #address-cells = <1>;
       #size-cells = <0>;
       panel@0 {
Documentation/devicetree/bindings/display/panel/panel-dpi.yaml +1 -1
index 5275d350f8cb..f63870384c00 100644
@@ -48,7 +48,7 @@ additionalProperties: false
 
 examples:
   - |
-    panel@0 {
+    panel {
         compatible = "osddisplays,osd057T0559-34ts", "panel-dpi";
         label = "osddisplay";
         power-supply = <&vcc_supply>;
Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml +0 -0
index 8b60368a2425..cefe19b6bf44 100644

Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml required: · line 53

Quoted 5 lines

Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml +1 -1
@@ -50,7 +50,7 @@ required:
 
 examples:
   - |
-    mdss_dsi@fd922800 {
+    mdss_dsi {

dsi {

With that,

Reviewed-by Rob Herring <[email protected]>

Sam Ravnborg

author

2020-03-14 07:26 UTC #6 lore raw

Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings

In reply to Sam Ravnborg

Quoted 8 lines · Sam Ravnborg

Fix following type af warnings in the panel bindings:
Warning (unit_address_vs_reg): /example-0/dsi/panel: node has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): /example-0/dsi@ff450000: node has a unit name, but no reg property
Removing the "@xxx" from the node name fixed first warning. Adding a missing reg property fixed the second warning

Quoted 8 lines

Signed-off-by Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Rob Herring <[email protected]>
Cc Heiko Stuebner <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Benjamin Gaignard <[email protected]>
Cc Laurent Pinchart <[email protected]>

Applied and pushed to drm-misc-next with Rob's fix. Thanks for the reviews!

Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel