staging: greybus: remove line over 80 characters
Subsystems (3)
PATCH v2 1/1 staging: greybus: remove line over 80 characters
Remove line over 80 characters.
In this version-2, comment and field are grouped together. A whitespace is added after "bi-dir,".
--- drivers/staging/greybus/arche-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/greybus/arche-platform.c +2 -1
@@ -47,7 +47,8 @@ struct arche_platform_drvdata {struct gpio_desc *svc_reset;bool is_reset_act_hi;struct gpio_desc *svc_sysboot; -struct gpio_desc *wake_detect;/* bi-dir,maps to WAKE_MOD & WAKE_FRAME signals */ +/* bi-dir, maps to WAKE_MOD & WAKE_FRAME signals */ +struct gpio_desc *wake_detect;enum arche_platform_state state;
Signature · 1 line
2.17.1
Quoted 3 lines · Payal Kshirsagar
Remove line over 80 characters.
In this version-2, comment and field are grouped together. A whitespace is added after "bi-dir,".
This is not the correct way to present the revision of a patch. Put a log message that would be appropriate if there were no version 1. The patch will ultimately go in the git history where there is no trace of version 1.
Then under the --- write v2: and then describe what you have changed.
See https://kernelnewbies.org/Outreachyfirstpatch and search for v2.
julia
Quoted 28 lines
Signed-off-by Payal Kshirsagar <[email protected]>--- drivers/staging/greybus/arche-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/greybus/arche-platform.c +2
-2@@ -47,7 +47,8 @@ struct arche_platform_drvdata {struct gpio_desc *svc_reset;bool is_reset_act_hi;struct gpio_desc *svc_sysboot; -struct gpio_desc *wake_detect;/* bi-dir,maps to WAKE_MOD & WAKE_FRAME signals */ +/* bi-dir, maps to WAKE_MOD & WAKE_FRAME signals */ +struct gpio_desc *wake_detect;enum arche_platform_state state; --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200308132643.4256-1-payalskshirsagar1234%40gmail.com.
Quoted 42 lines · Julia Lawall
Quoted 3 lines · Payal Kshirsagar
Remove line over 80 characters.
In this version-2, comment and field are grouped together. A whitespace is added after "bi-dir,".This is not the correct way to present the revision of a patch. Put a log message that would be appropriate if there were no version 1. The patch will ultimately go in the git history where there is no trace of version 1.
Then under the --- write v2: and then describe what you have changed.
See https://kernelnewbies.org/Outreachyfirstpatch and search for v2.
julia
Review
Quoted 7 lines
Signed-off-by Payal Kshirsagar <[email protected]>--- drivers/staging/greybus/arche-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/staging/greybus/arche-platform.cdrivers/staging/greybus/arche-platform.c struct arche_platform_drvdata { · line 50
Quoted 8 lines
index
eebf0deb39f5..cc5a52fc926f100644drivers/staging/greybus/arche-platform.c +0
-1@@ -47,7 +47,8 @@ struct arche_platform_drvdata {struct gpio_desc *svc_reset;bool is_reset_act_hi;struct gpio_desc *svc_sysboot; -struct gpio_desc *wake_detect;/* bi-dir,maps to WAKE_MOD &
WAKE_FRAMEsignals */Quoted 8 lines
drivers/staging/greybus/arche-platform.c +2
-1+/* bi-dir, maps to WAKE_MOD & WAKE_FRAME signals */ +struct gpio_desc *wake_detect;enum arche_platform_state state; --2.17.1
Quoted 10 lines
Quoted 2 lines
--
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 1 line
To view this discussion on the web visit
Quoted 1 line
Okay, I will do so.
Payal
Quoted 1 line
Quoted 6 lines · On Sun, 8 Mar 2020 14:41:03 +0100 (CET) Julia Lawall <[email protected]>…
Quoted 3 lines · Payal Kshirsagar
Remove line over 80 characters.
In this version-2, comment and field are grouped together. A whitespace is added after "bi-dir,".
Quoted 8 lines
This is not the correct way to present the revision of a patch. Put a log message that would be appropriate if there were no version 1. The patch will ultimately go in the git history where there is no trace of version 1.
Then under the --- write v2: and then describe what you have changed.
See https://kernelnewbies.org/Outreachyfirstpatch and search for v2.
On top of what Julia said, while this is the case in general, and surely for these patches, in case you ever have to submit networking patches (trees: net.git, net-next.git), it's preferred to keep the revision log before the "---". This is the only difference there.
Again, this doesn't apply to this patch.
One further comment about the patch itself:
Quoted 8 lines
julia
Quoted 6 lines
Signed-off-by Payal Kshirsagar <[email protected]>--- drivers/staging/greybus/arche-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 11 lines
drivers/staging/greybus/arche-platform.c struct arche_platform_drvdata { · line 51
Quoted 11 lines
drivers/staging/greybus/arche-platform.c +2
-1@@ -47,7 +47,8 @@ struct arche_platform_drvdata {struct gpio_desc *svc_reset;bool is_reset_act_hi;struct gpio_desc *svc_sysboot; -struct gpio_desc *wake_detect;/* bi-dir,maps to WAKE_MOD & WAKE_FRAME signals */ +/* bi-dir, maps to WAKE_MOD & WAKE_FRAME signals */ +struct gpio_desc *wake_detect;
By grouping, I really meant that you should add a line *before* the comment you are moving -- it's clearer that way.
Quoted 12 lines
Quoted 11 lines
drivers/staging/greybus/arche-platform.c +0
-1enum arche_platform_state state; --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200308132643.4256-1-payalskshirsagar1234%40gmail.com.
Signature · 1 line
Stefano
Quoted 15 lines · Stefano Brivio
Quoted 7 lines · On Sun, 8 Mar 2020 14:41:03 +0100 (CET) Julia Lawall <[email protected]>…
Quoted 3 lines · Payal Kshirsagar
Remove line over 80 characters.
In this version-2, comment and field are grouped together. A whitespace is added after "bi-dir,".This is not the correct way to present the revision of a patch. Put a
log
Quoted 4 lines
message that would be appropriate if there were no version 1. The patch will ultimately go in the git history where there is no trace of version 1.
Quoted 9 lines
Quoted 3 lines
Then under the --- write v2: and then describe what you have changed.
See https://kernelnewbies.org/Outreachyfirstpatch and search for v2.
On top of what Julia said, while this is the case in general, and surely for these patches, in case you ever have to submit networking patches (trees: net.git, net-next.git), it's preferred to keep the revision log before the "---". This is the only difference there.
Thanks for the information.
I will keep it in mind.
Again, this doesn't apply to this patch.
Quoted 22 lines
One further comment about the patch itself:
Quoted 9 lines
julia
Review
Quoted 7 lines
Signed-off-by Payal Kshirsagar <[email protected]>--- drivers/staging/greybus/arche-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/staging/greybus/arche-platform.cQuoted 8 lines
drivers/staging/greybus/arche-platform.c struct arche_platform_drvdata { · line 50
Quoted 8 lines
index
eebf0deb39f5..cc5a52fc926f100644drivers/staging/greybus/arche-platform.c +0
-1@@ -47,7 +47,8 @@ struct arche_platform_drvdata {struct gpio_desc *svc_reset;bool is_reset_act_hi;struct gpio_desc *svc_sysboot; -struct gpio_desc *wake_detect;/* bi-dir,maps to WAKE_MOD &
WAKE_FRAMEsignals */
Quoted 6 lines
Quoted 2 lines
drivers/staging/greybus/arche-platform.c struct arche_platform_drvdata { · line 51
Quoted 2 lines
drivers/staging/greybus/arche-platform.c +2
-0+/* bi-dir, maps to WAKE_MOD & WAKE_FRAME signals */ +struct gpio_desc *wake_detect;By grouping, I really meant that you should add a line *before* the comment you are moving -- it's clearer that way.
Okay, my bad
Quoted 20 lines
Quoted 8 lines
Quoted 8 lines
drivers/staging/greybus/arche-platform.c +0
-1enum arche_platform_state state; --2.17.1
--
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 1 line
Quoted 1 line
To view this discussion on the web visit
Quoted 2 lines
Quoted 1 line
--
Stefano
Quoted 9 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20200308145100.7e07abf5%40elisabeth
.
Payal