staging: greybus: remove line over 80 characters
Subsystems (3)
PATCH 1/1 staging: greybus: remove line over 80 characters
Remove line over 80 characters.
--- drivers/staging/greybus/arche-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/greybus/arche-platform.c +2 -1
@@ -47,7 +47,8 @@ struct arche_platform_drvdata {struct gpio_desc *svc_reset;bool is_reset_act_hi;struct gpio_desc *svc_sysboot; -struct gpio_desc *wake_detect;/* bi-dir,maps to WAKE_MOD & WAKE_FRAME signals */ +struct gpio_desc *wake_detect; +/* bi-dir,maps to WAKE_MOD & WAKE_FRAME signals */ enum arche_platform_state state;
Signature · 1 line
2.17.1
Hi Payal,
Quoted 12 lines · On Sun, 8 Mar 2020 17:43:07 +0530 Payal Kshirsagar…
Remove line over 80 characters.
Signed-off-by Payal Kshirsagar <[email protected]>--- drivers/staging/greybus/arche-platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/greybus/arche-platform.c +0
-0
drivers/staging/greybus/arche-platform.c struct arche_platform_drvdata { · line 51
Quoted 6 lines
drivers/staging/greybus/arche-platform.c +2
-1@@ -47,7 +47,8 @@ struct arche_platform_drvdata {struct gpio_desc *svc_reset;bool is_reset_act_hi;struct gpio_desc *svc_sysboot; -struct gpio_desc *wake_detect;/* bi-dir,maps to WAKE_MOD & WAKE_FRAME signals */ +struct gpio_desc *wake_detect; +/* bi-dir,maps to WAKE_MOD & WAKE_FRAME signals */
The comment you are moving here needs to clearly refer to struct gpio_desc *wake_detect. If you move it below, I think it's a bit less clear.
As there's already an empty line after this, you might consider to add a line before, move the comment before 'struct gpio_desc *wake_detect', so that comment and field are clearly grouped together.
Also mind that the comment refers to two things:
- the GPIOs
(https://en.wikipedia.org/wiki/General-purpose_input/output) handled here are bi-directional
- they map to those signals
...so you might want to fix that, too: a whitespace is clearly missing after "bi-dir,".
Signature · 1 line
Stefano