Skip to contentSkip to conversation

net: rmnet: set NETIF_F_LLTX flag

PATCH Applied Taehee Yoo 4 participants 4 messages Mar 8, 2020 – Mar 9, 2020

Subsystems (3)
lore
Share & tools
lore

Taehee Yoo

author
#0 lore raw

PATCH 1/1 net: rmnet: set NETIF_F_LLTX flag

The rmnet_vnd_setup(), which is the callback of ->ndo_start_xmit() is allowed to call concurrently because it uses RCU protected data. So, it doesn't need tx lock.

---
 drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c +2 -0
index d7c52e398e4a..d58b51d277f1 100644
@@ -212,6 +212,8 @@ void rmnet_vnd_setup(struct net_device *rmnet_dev)
 	rmnet_dev->needs_free_netdev = true;
 	rmnet_dev->ethtool_ops = &rmnet_ethtool_ops;
 
+	rmnet_dev->features |= NETIF_F_LLTX;
+
 	/* This perm addr will be used as interface identifier by IPv6 */
 	rmnet_dev->addr_assign_type = NET_ADDR_RANDOM;
 	eth_random_addr(rmnet_dev->perm_addr);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 15 lines · Taehee Yoo

The rmnet_vnd_setup(), which is the callback of ->ndo_start_xmit() is allowed to call concurrently because it uses RCU protected data. So, it doesn't need tx lock.

---
 drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c +0 -0
index d7c52e398e4a..d58b51d277f1 100644

drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c void rmnet_vnd_setup(struct net_device *rmnet_dev) · line 219

Quoted 8 lines
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c +2 -0
@@ -212,6 +212,8 @@ void rmnet_vnd_setup(struct net_device *rmnet_dev)
 	rmnet_dev->needs_free_netdev = true;
 	rmnet_dev->ethtool_ops = &rmnet_ethtool_ops;
 
+	rmnet_dev->features |= NETIF_F_LLTX;
+
 	/* This perm addr will be used as interface identifier by IPv6 */
 	rmnet_dev->addr_assign_type = NET_ADDR_RANDOM;
 	eth_random_addr(rmnet_dev->perm_addr);

Hi Taehee

It seems the flag is deprecated per documentation.

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/Documentation/networking/netdevices.txt#n73

#2 lore raw
Quoted 27 lines · On 3/8/20 5:28 PM, [email protected] wrote:
Quoted 15 lines · Taehee Yoo

The rmnet_vnd_setup(), which is the callback of ->ndo_start_xmit() is allowed to call concurrently because it uses RCU protected data. So, it doesn't need tx lock.

---
 drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 2 ++

 1 file changed, 2 insertions(+)
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c +0 -0
index d7c52e398e4a..d58b51d277f1 100644

drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c void rmnet_vnd_setup(struct net_device *rmnet_dev) · line 219

Quoted 8 lines
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c +2 -0
@@ -212,6 +212,8 @@ void rmnet_vnd_setup(struct net_device *rmnet_dev)
      rmnet_dev->needs_free_netdev = true;
      rmnet_dev->ethtool_ops = &rmnet_ethtool_ops;
 
+    rmnet_dev->features |= NETIF_F_LLTX;
+
      /* This perm addr will be used as interface identifier by IPv6 */
      rmnet_dev->addr_assign_type = NET_ADDR_RANDOM;
      eth_random_addr(rmnet_dev->perm_addr);

Hi Taehee

Quoted 3 lines

It seems the flag is deprecated per documentation.

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/Documentation/networking/netdevices.txt#n73

This does not count for virtual drivers, like macvlan, bonding, tunnels...

If your ndo_start_xmit() calls dev_queue_xmit() after switching skb->dev to another device, you do not need a lock.