check: Inform about missing ranges
PATCH 1/1 check: Inform about missing ranges
In check_unit_address_vs_reg() warning message already says 'reg _or_ ranges' when reg or ranges are present but unit name is missing. Add this message for compatibility to say "reg _or_ ranges" when unit name is present but neither reg nor ranges are present.
Signed-off-by Arkadiusz Drabczyk <[email protected]>
--- checks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
checks.c +1 -1
@@ -352,7 +352,7 @@ static void check_unit_address_vs_reg(struct check *c, struct dt_info *dti,FAIL (c, dti, node,"node has a reg or ranges property, but no unit name" ); }else {if (unitname[0 ]) -FAIL (c, dti, node,"node has a unit name, but no reg property" ); +FAIL (c, dti, node,"node has a unit name, but no reg or ranges property" ); } }WARNING (unit_address_vs_reg, check_unit_address_vs_reg,NULL );
Signature · 1 line
2.9.0
A message that is not in the archive (sent off-list or not yet received): 20200308165643.19281-1-arkadiusz-42WfZ8EewN5g9hUCZPvPmw@public.gmane.org
David Gibson
AppliedQuoted 6 lines · Arkadiusz Drabczyk
In
check_unit_address_vs_reg()warning message already says 'reg _or_ ranges' when reg or ranges are present but unit name is missing. Add this message for compatibility to say "reg _or_ ranges" when unit name is present but neither reg nor ranges are present.Signed-off-by Arkadiusz Drabczyk <[email protected]>
Applied, thanks.
Quoted 17 lines
--- checks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)checks.c +1
-1@@ -352,7 +352,7 @@ static void check_unit_address_vs_reg(struct check *c, struct dt_info *dti,FAIL (c, dti, node,"node has a reg or ranges property, but no unit name" ); }else {if (unitname[0 ]) -FAIL (c, dti, node,"node has a unit name, but no reg property" ); +FAIL (c, dti, node,"node has a unit name, but no reg or ranges property" ); } }WARNING (unit_address_vs_reg, check_unit_address_vs_reg,NULL );
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson