Skip to contentSkip to conversation

staging: wfx: alignment should match open parenthesis

PATCH In review Payal Kshirsagar 2 participants 4 messages Mar 8, 2020 – Mar 9, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wfx: alignment should match open parenthesis

Align code to open parenthesis.

---
 drivers/staging/wfx/data_tx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wfx/data_tx.c +3 -3
index 8b0c52392319..0038dc7666cf 100644
@@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
 }
 
 static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
-				      struct ieee80211_sta *sta,
-				      struct ieee80211_hdr *hdr)
+				 struct ieee80211_sta *sta,
+				 struct ieee80211_hdr *hdr)
 {
 	struct wfx_sta_priv *sta_priv =
 		sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
@@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
 }
 
 static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
-				  struct ieee80211_tx_info *tx_info)
+			     struct ieee80211_tx_info *tx_info)
 {
 	bool tx_policy_renew = false;
 	u8 rate_id;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 23 lines · On Mon, 9 Mar 2020 00:25:18 +0530 Payal Kshirsagar…

Align code to open parenthesis.

---
 drivers/staging/wfx/data_tx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wfx/data_tx.c +2 -2
index 8b0c52392319..0038dc7666cf 100644
@@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
 }
 
 static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
-				      struct ieee80211_sta *sta,
-				      struct ieee80211_hdr *hdr)
+				 struct ieee80211_sta *sta,
+				 struct ieee80211_hdr *hdr)
 {
 	struct wfx_sta_priv *sta_priv =
 		sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;

drivers/staging/wfx/data_tx.c static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates) · line 375

Quoted 8 lines
drivers/staging/wfx/data_tx.c +1 -1
@@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
 }
 
 static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
-				  struct ieee80211_tx_info *tx_info)
+			     struct ieee80211_tx_info *tx_info)
 {
 	bool tx_policy_renew = false;
 	u8 rate_id;

Change looks good, more Cc:'s needed.

Signature · 1 line
Stefano
#2 lore raw
Quoted 31 lines · Stefano Brivio

Review

Quoted 8 lines · On Mon, 9 Mar 2020 00:25:18 +0530 Payal Kshirsagar…

Align code to open parenthesis.

---
 drivers/staging/wfx/data_tx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/wfx/data_tx.c

drivers/staging/wfx/data_tx.c static void wfx_tx_manage_pm(struct wfx_vif *wvif,

Quoted 4 lines

index 8b0c52392319..0038dc7666cf 100644

drivers/staging/wfx/data_tx.c +0 -0
@@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif,

struct ieee80211_hdr *hdr,

drivers/staging/wfx/data_tx.c static void wfx_tx_fixup_rates(struct

Quoted 11 lines
drivers/staging/wfx/data_tx.c +2 -2
 }
 
 static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
-                                   struct ieee80211_sta *sta,
-                                   struct ieee80211_hdr *hdr)
+                              struct ieee80211_sta *sta,
+                              struct ieee80211_hdr *hdr)
 {
      struct wfx_sta_priv *sta_priv =
              sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
@@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct

ieee80211_tx_rate *rates)

Quoted 2 lines
drivers/staging/wfx/data_tx.c +0 -0
 }
 
Quoted 9 lines

drivers/staging/wfx/data_tx.c static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates) · line 375

Quoted 6 lines
drivers/staging/wfx/data_tx.c +1 -1
 static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
-                               struct ieee80211_tx_info *tx_info)
+                          struct ieee80211_tx_info *tx_info)
 {
      bool tx_policy_renew = false;
      u8 rate_id;

Change looks good, more Cc:'s needed.

Is is needed to resend all these patches to send them to the other maintainers?

Payal

Quoted 3 lines

Stefano

#3 lore raw
Quoted 40 lines · On Mon, 9 Mar 2020 17:23:42 +0530 Payal Kshirsagar…
Quoted 38 lines · Stefano Brivio

Review

Quoted 8 lines · On Mon, 9 Mar 2020 00:25:18 +0530 Payal Kshirsagar…

Align code to open parenthesis.

---
 drivers/staging/wfx/data_tx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/wfx/data_tx.c

drivers/staging/wfx/data_tx.c static void wfx_tx_manage_pm(struct wfx_vif *wvif,

Quoted 4 lines

index 8b0c52392319..0038dc7666cf 100644

drivers/staging/wfx/data_tx.c +0 -0
@@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif,  

struct ieee80211_hdr *hdr,

drivers/staging/wfx/data_tx.c static void wfx_tx_fixup_rates(struct

Quoted 11 lines
drivers/staging/wfx/data_tx.c +2 -2
 }
 
 static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
-                                   struct ieee80211_sta *sta,
-                                   struct ieee80211_hdr *hdr)
+                              struct ieee80211_sta *sta,
+                              struct ieee80211_hdr *hdr)
 {
      struct wfx_sta_priv *sta_priv =
              sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
@@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct  

ieee80211_tx_rate *rates)

Quoted 8 lines
drivers/staging/wfx/data_tx.c +1 -1
 }
 
 static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
-                               struct ieee80211_tx_info *tx_info)
+                          struct ieee80211_tx_info *tx_info)
 {
      bool tx_policy_renew = false;
      u8 rate_id;  
Quoted 5 lines
Quoted 2 lines

Change looks good, more Cc:'s needed.

Is is needed to resend all these patches to send them to the other maintainers?

I think it would be nice, yes.

Signature · 1 line
Stefano