staging: qlge: remove blank line
PATCH 1/1 staging: qlge: remove blank line
Remove unnecessary multiple blank lines.
--- drivers/staging/qlge/qlge_dbg.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/staging/qlge/qlge_dbg.c +0 -4
@@ -552,7 +552,6 @@ static int ql_get_probe_dump(struct ql_adapter *qdev, unsigned int *buf) buf =ql_get_probe (qdev,PRB_MX_ADDR_FC_CLOCK ,PRB_MX_ADDR_VALID_FC_MOD , buf);return 0 ; - }/* Read out the routing index registers */
@@ -610,7 +609,6 @@ static void ql_get_mac_protocol_registers(struct ql_adapter *qdev, u32 *buf)for (type =0 ; type <MAC_ADDR_TYPE_COUNT ; type++) {switch (type) { -case 0 :/* CAM */ initial_val |=MAC_ADDR_ADR ; max_index =MAC_ADDR_MAX_CAM_ENTRIES ;
@@ -1204,7 +1202,6 @@ int ql_core_dump(struct ql_adapter *qdev, struct ql_mpi_coredump *mpi_coredump) err:ql_sem_unlock (qdev,SEM_PROC_REG_MASK );/* does flush too */ return status; - }static void ql_get_core_dump (struct ql_adapter *qdev)
@@ -1838,7 +1835,6 @@ void ql_dump_tx_desc(struct tx_buf_desc *tbd)pr_err ("tbd->flags = %s %s\n" , tbd->len &TX_DESC_C ?"C" :"." , tbd->len &TX_DESC_E ?"E" :"." ); - }void ql_dump_ob_mac_iocb (struct ob_mac_iocb_req *ob_mac_iocb)
Signature · 1 line
2.17.1
Quoted 36 lines · On Mon, 9 Mar 2020 15:10:36 +0530 Payal Kshirsagar…
Remove unnecessary multiple blank lines.
Signed-off-by Payal Kshirsagar <[email protected]>--- drivers/staging/qlge/qlge_dbg.c | 4 ---- 1 file changed, 4 deletions(-)drivers/staging/qlge/qlge_dbg.c +0
-3@@ -552,7 +552,6 @@ static int ql_get_probe_dump(struct ql_adapter *qdev, unsigned int *buf) buf =ql_get_probe (qdev,PRB_MX_ADDR_FC_CLOCK ,PRB_MX_ADDR_VALID_FC_MOD , buf);return 0 ; - }/* Read out the routing index registers */ @@ -610,7 +609,6 @@ static void ql_get_mac_protocol_registers(struct ql_adapter *qdev, u32 *buf)for (type =0 ; type <MAC_ADDR_TYPE_COUNT ; type++) {switch (type) { -case 0 :/* CAM */ initial_val |=MAC_ADDR_ADR ; max_index =MAC_ADDR_MAX_CAM_ENTRIES ;@@ -1204,7 +1202,6 @@ int ql_core_dump(struct ql_adapter *qdev, struct ql_mpi_coredump *mpi_coredump) err:ql_sem_unlock (qdev,SEM_PROC_REG_MASK );/* does flush too */ return status; - }static void ql_get_core_dump (struct ql_adapter *qdev)
drivers/staging/qlge/qlge_dbg.c void ql_dump_tx_desc(struct tx_buf_desc *tbd) · line 1840
Quoted 7 lines
drivers/staging/qlge/qlge_dbg.c +0
-1@@ -1838,7 +1835,6 @@ void ql_dump_tx_desc(struct tx_buf_desc *tbd)pr_err ("tbd->flags = %s %s\n" , tbd->len &TX_DESC_C ?"C" :"." , tbd->len &TX_DESC_E ?"E" :"." ); - }void ql_dump_ob_mac_iocb (struct ob_mac_iocb_req *ob_mac_iocb)
You should update the commit title to reflect the fact you're removing multiple excess newlines. For my taste, that doesn't warrant a re-send, though.
Signature · 1 line
Stefano
Payal Kshirsagar
Reviewed-by Stefano BrivioQuoted 49 lines · Stefano Brivio
Review
Quoted 8 lines · On Mon, 9 Mar 2020 15:10:36 +0530 Payal Kshirsagar…
Remove unnecessary multiple blank lines.
Signed-off-by Payal Kshirsagar <[email protected]>--- drivers/staging/qlge/qlge_dbg.c | 4 ---- 1 file changed, 4 deletions(-)(quoted diff) +0
-0
b/drivers/staging/qlge/qlge_dbg.cdrivers/staging/qlge/qlge_dbg.c static int ql_get_probe_dump(struct ql_adapter
Quoted 4 lines
index
44fb3a317b8d..670361873d1d100644drivers/staging/qlge/qlge_dbg.c +0
-0@@ -552,7 +552,6 @@ static int ql_get_probe_dump(struct ql_adapter*qdev, unsigned int *buf)
drivers/staging/qlge/qlge_dbg.c static void ql_get_mac_protocol_registers(struct
Quoted 8 lines
drivers/staging/qlge/qlge_dbg.c +0
-1buf =ql_get_probe (qdev,PRB_MX_ADDR_FC_CLOCK ,PRB_MX_ADDR_VALID_FC_MOD , buf);return 0 ; - }/* Read out the routing index registers */ @@ -610,7 +609,6 @@ static void ql_get_mac_protocol_registers(struct
ql_adapter*qdev, u32 *buf)drivers/staging/qlge/qlge_dbg.c int ql_core_dump(struct ql_adapter *qdev, struct
Quoted 8 lines
drivers/staging/qlge/qlge_dbg.c +0
-1for (type =0 ; type <MAC_ADDR_TYPE_COUNT ; type++) {switch (type) { -case 0 :/* CAM */ initial_val |=MAC_ADDR_ADR ; max_index =MAC_ADDR_MAX_CAM_ENTRIES ;@@ -1204,7 +1202,6 @@ int ql_core_dump(struct ql_adapter *qdev, struct
ql_mpi_coredump*mpi_coredump)Quoted 14 lines
drivers/staging/qlge/qlge_dbg.c +0
-2err:ql_sem_unlock (qdev,SEM_PROC_REG_MASK );/* does flush too */ return status; - }static void ql_get_core_dump (struct ql_adapter *qdev)@@ -1838,7 +1835,6 @@ void ql_dump_tx_desc(struct tx_buf_desc *tbd)pr_err ("tbd->flags = %s %s\n" , tbd->len &TX_DESC_C ?"C" :"." , tbd->len &TX_DESC_E ?"E" :"." ); - }
Quoted 4 lines
drivers/staging/qlge/qlge_dbg.c void ql_dump_tx_desc(struct tx_buf_desc *tbd) · line 1840
Quoted 1 line
drivers/staging/qlge/qlge_dbg.c +0
-0void ql_dump_ob_mac_iocb (struct ob_mac_iocb_req *ob_mac_iocb)You should update the commit title to reflect the fact you're removing multiple excess newlines. For my taste, that doesn't warrant a re-send,
though.
Quoted 1 line
Okay:)
Payal
Quoted 5 lines
--
Stefano