Skip to contentSkip to conversation

qt5remoteobjects: new pacḱage

PATCH New Sven Fischer 2 participants 3 messages Mar 9, 2020 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qt5remoteobjects: new pacḱage

Qt 5.12 adds a library for IPC.

---
Notes:
This library is missing from the
distributed qt5 package. Added it by using the library qt5serialport as a template and replaced serialport with remoteobjects, recalculated the sha256 sums.

Dependency on qtdeclarative is optional.

 package/qt5/Config.in                         |  1 +
 .../5.12.7/qt5remoteobjects.hash              |  8 +++
 package/qt5/qt5remoteobjects/Config.in        | 13 +++++
 .../qt5remoteobjects/qt5remoteobjects.hash    |  2 +
 .../qt5/qt5remoteobjects/qt5remoteobjects.mk  | 54 +++++++++++++++++++
 5 files changed, 78 insertions(+)
 create mode 100644 package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash
 create mode 100644 package/qt5/qt5remoteobjects/Config.in
 create mode 100644 package/qt5/qt5remoteobjects/qt5remoteobjects.hash
 create mode 100644 package/qt5/qt5remoteobjects/qt5remoteobjects.mk
package/qt5/Config.in +1 -0
index 4bbc688249..6fb77fb9a6 100644
@@ -50,6 +50,7 @@ source "package/qt5/qt5location/Config.in"
 source "package/qt5/qt5multimedia/Config.in"
 source "package/qt5/qt5quickcontrols/Config.in"
 source "package/qt5/qt5quickcontrols2/Config.in"
+source "package/qt5/qt5remoteobjects/Config.in"
 source "package/qt5/qt5script/Config.in"
 source "package/qt5/qt5scxml/Config.in"
 source "package/qt5/qt5sensors/Config.in"
package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash new file +8 -0
new file mode 100644
index 0000000000..4097dd8d54
@@ -0,0 +1,8 @@
+# Hash from: https://download.qt.io/official_releases/qt/5.12/5.12.7/submodules/qtremoteobjects-everywhere-src-5.12.7.tar.xz.sha256
+sha256 6d6aaec4e9c140c027b0badaabc6322ea3c16cf649495a27fec1f261e891120f  qtremoteobjects-everywhere-src-5.12.7.tar.xz
+
+# Hashes for license files:
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 LICENSE.GPL2
+sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 LICENSE.GPL3
+sha256 0dbe024961f6ab5c52689cbd036c977975d0d0f6a67ff97762d96cb819dd5652 LICENSE.GPL3-EXCEPT
+sha256 da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768 LICENSE.LGPL3
package/qt5/qt5remoteobjects/Config.in new file +13 -0
new file mode 100644
index 0000000000..05f22ada88
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_QT5REMOTEOBJECTS
+	bool "qt5remoteobjects"
+	select BR2_PACKAGE_QT5BASE
+    select BR2_PACKAGE_QT5BASE_NETWORK
+    help
+      Qt is a cross-platform application and UI framework for
+	  developers using C++.
+
+	  Qt Remote Objects (QtRO) is an Inter-Process Communication (IPC) module
+	  developed for Qt. This module extends Qt's existing functionalities to
+	  enable information exchange between processes or computers, easily.
+
+	  http://doc.qt.io/qt-5/qtremoteobjects-index.html
package/qt5/qt5remoteobjects/qt5remoteobjects.hash new file +2 -0
new file mode 100644
index 0000000000..5316f03b10
@@ -0,0 +1,2 @@
+# This hash file is not used; instead, update the
+# hash files in the per-version sub-directories.
package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +54 -0

54 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 qt5remoteobjects: new pacḱage

Hello Seven,

thanks for the new patch iteration!

The good news, at applies cleanly this time...,
but still some defects....

The subject now is 'qt5remoteobjects: new pac?age' with a funny '?' instead of a simple 'k'...

And some wrong indents:

./utils/check-package package/qt5/qt5remoteobjects/*
package/qt5/qt5remoteobjects/Config.in:4: should be indented with one tab (http://nightly.buildroot.org/#_config_files)
package/qt5/qt5remoteobjects/Config.in:5: should be indented with one tab (http://nightly.buildroot.org/#_config_files)
package/qt5/qt5remoteobjects/Config.in:6: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
package/qt5/qt5remoteobjects/Config.in:9: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
package/qt5/qt5remoteobjects/Config.in:10: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
package/qt5/qt5remoteobjects/Config.in:11: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

Quoted 11 lines · Sven Fischer

Qt 5.12 adds a library for IPC.

---
Notes:
This library is missing from the
distributed qt5 package. Added it by using the library qt5serialport as a template and replaced serialport with remoteobjects, recalculated the sha256 sums.

Dependency on qtdeclarative is optional.

Yes, I can confirm it (this one is maybe worth mentioning in the commit message above)...

Quoted 74 lines
 package/qt5/Config.in                         |  1 +
 .../5.12.7/qt5remoteobjects.hash              |  8 +++
 package/qt5/qt5remoteobjects/Config.in        | 13 +++++
 .../qt5remoteobjects/qt5remoteobjects.hash    |  2 +
 .../qt5/qt5remoteobjects/qt5remoteobjects.mk  | 54 +++++++++++++++++++
 5 files changed, 78 insertions(+)
 create mode 100644 package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash
 create mode 100644 package/qt5/qt5remoteobjects/Config.in
 create mode 100644 package/qt5/qt5remoteobjects/qt5remoteobjects.hash
 create mode 100644 package/qt5/qt5remoteobjects/qt5remoteobjects.mk
package/qt5/Config.in +1 -0
index 4bbc688249..6fb77fb9a6 100644
@@ -50,6 +50,7 @@ source "package/qt5/qt5location/Config.in"
 source "package/qt5/qt5multimedia/Config.in"
 source "package/qt5/qt5quickcontrols/Config.in"
 source "package/qt5/qt5quickcontrols2/Config.in"
+source "package/qt5/qt5remoteobjects/Config.in"
 source "package/qt5/qt5script/Config.in"
 source "package/qt5/qt5scxml/Config.in"
 source "package/qt5/qt5sensors/Config.in"
package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash new file +8 -0
new file mode 100644
index 0000000000..4097dd8d54
@@ -0,0 +1,8 @@
+# Hash from: https://download.qt.io/official_releases/qt/5.12/5.12.7/submodules/qtremoteobjects-everywhere-src-5.12.7.tar.xz.sha256
+sha256 6d6aaec4e9c140c027b0badaabc6322ea3c16cf649495a27fec1f261e891120f  qtremoteobjects-everywhere-src-5.12.7.tar.xz
+
+# Hashes for license files:
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 LICENSE.GPL2
+sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 LICENSE.GPL3
+sha256 0dbe024961f6ab5c52689cbd036c977975d0d0f6a67ff97762d96cb819dd5652 LICENSE.GPL3-EXCEPT
+sha256 da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768 LICENSE.LGPL3
package/qt5/qt5remoteobjects/Config.in new file +13 -0
new file mode 100644
index 0000000000..05f22ada88
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_QT5REMOTEOBJECTShttps://patchwork.ozlabs.org/patch/1251290/mbox/
+	bool "qt5remoteobjects"
+	select BR2_PACKAGE_QT5BASE
+    select BR2_PACKAGE_QT5BASE_NETWORK
+    help
+      Qt is a cross-platform application and UI framework for
+	  developers using C++.
+
+	  Qt Remote Objects (QtRO) is an Inter-Process Communication (IPC) module
+	  developed for Qt. This module extends Qt's existing functionalities to
+	  enable information exchange between processes or computers, easily.
+
+	  http://doc.qt.io/qt-5/qtremoteobjects-index.html
package/qt5/qt5remoteobjects/qt5remoteobjects.hash new file +2 -0
new file mode 100644
index 0000000000..5316f03b10
@@ -0,0 +1,2 @@
+# This hash file is not used; instead, update the
+# hash files in the per-version sub-directories.
package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +3 -0
new file mode 100644
index 0000000000..e98f51b131
@@ -0,0 +1,54 @@
+################################################################################
+#
+# qt5remoteobjects

package/qt5/qt5remoteobjects/qt5remoteobjects.mk line 13

Quoted 10 lines
package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +10 -0
+#
+################################################################################
+
+QT5REMOTEOBJECTS_VERSION = $(QT5_VERSION)
+QT5REMOTEOBJECTS_SITE = $(QT5_SITE)
+QT5REMOTEOBJECTS_SOURCE = qtremoteobjects-$(QT5_SOURCE_TARBALL_PREFIX)-$(QT5REMOTEOBJECTS_VERSION).tar.xz
+QT5REMOTEOBJECTS_DEPENDENCIES = qt5base
+QT5REMOTEOBJECTS_INSTALL_STAGING = YES
+
+ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)

No more need for the version check...

package/qt5/qt5remoteobjects/qt5remoteobjects.mk line 19

Quoted 6 lines
package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +6 -0
+QT5REMOTEOBJECTS_LICENSE = GPL-2.0+ or LGPL-3.0, GPL-3.0 with exception(tools), GFDL-1.3 (docs)
+QT5REMOTEOBJECTS_LICENSE_FILES = LICENSE.GPL2 LICENSE.GPL3 LICENSE.GPL3-EXCEPT LICENhttps://patchwork.ozlabs.org/patch/1251290/mbox/SE.LGPL3 LICENSE.FDL
+else
+QT5REMOTEOBJECTS_LICENSE = GPL-2.0 or GPL-3.0 or LGPL-2.1 with exception or LGPL-3.0, GFDL-1.3 (docs)
+QT5REMOTEOBJECTS_LICENSE_FILES = LICENSE.GPLv2 LICENSE.GPLv3 LICENSE.LGPLv21 LGPL_EXCEPTION.txt LICENSE.LGPLv3 LICENSE.FDL
+endif

And the else branch can be dropped entirely...

Quoted 13 lines
package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +13 -0
+
+ifeq ($(BR2_PACKAGE_QT5DECLARATIVE),y)
+QT5REMOTEOBJECTS_DEPENDENCIES += qt5declarative
+endif
+
+define QT5REMOTEOBJECTS_CONFIGURE_CMDS
+	(cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/bin/qmake)
+endef
+
+define QT5REMOTEOBJECTS_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+

package/qt5/qt5remoteobjects/qt5remoteobjects.mk line 42

Quoted 10 lines
package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +10 -0
+define QT5REMOTEOBJECTS_INSTALL_STAGING_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install
+endef
+
+ifeq ($(BR2_STATIC_LIBS),)
+define QT5REMOTEOBJECTS_INSTALL_TARGET_LIBS
+	cp -dpf $(STAGING_DIR)/usr/lib/libQt5RemoteObjects.so.* $(TARGET_DIR)/usr/lib
+endef
+endif
+

Install of the qml files is missing (part I):

ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
define QT5REMOTEOBJECTS_INSTALL_TARGET_QMLS

        cp -dpfr $(STAGING_DIR)/usr/qml/QtQml $(TARGET_DIR)/usr/qml/
        cp -dpfr $(STAGING_DIR)/usr/qml/QtRemoteObjects $(TARGET_DIR)/usr/qml/

endef
endif

package/qt5/qt5remoteobjects/qt5remoteobjects.mk line 50

Quoted 8 lines
package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +8 -0
+ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
+define QT5REMOTEOBJECTS_INSTALL_TARGET_EXAMPLES
+	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/remoteobjects $(TARGET_DIR)/usr/lib/qt/examples/
+endef
+endif
+
+define QT5REMOTEOBJECTS_INSTALL_TARGET_CMDS
+	$(QT5REMOTEOBJECTS_INSTALL_TARGET_LIBS)

Install of the qml files is missing (part II):

        $(QT5REMOTEOBJECTS_INSTALL_TARGET_QMLS)

Regards,
Peter

Quoted 4 lines
package/qt5/qt5remoteobjects/qt5remoteobjects.mk new file +4 -0
+	$(QT5REMOTEOBJECTS_INSTALL_TARGET_EXAMPLES)
+endef
+
+$(eval $(generic-package))

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH 1/1 qt5remoteobjects: new pacḱage

Hello Sven,

re-added to CC buildroot, Juien Crojon

Quoted 6 lines · Sven Fischer

Hi Peter,

Am 09.03.20 um 09:49 schrieb Peter Seiderer:

Quoted 1 line

Hello Seven,

just like my weird k in the commit message ;-) Sometimes characters do what they want ;-)

Quoted 7 lines
Quoted 5 lines

thanks for the new patch iteration!
And some wrong indents:

./utils/check-package package/qt5/qt5remoteobjects/*
package/qt5/qt5remoteobjects/Config.in:4: should be indented with one tab (http://nightly.buildroot.org/#_config_files)

Wasn't aware of the strict indentation rules, fixed that...

O.k.

Quoted 3 lines

What is preferred? Should I reply to your mail or should I submit the patch again with git send-mail?

Resend a v3 with git send-mail...

Regards,
Peter

Quoted 3 lines

Cheers, Sven