staging: greybus: remove commented out function
Subsystems (3)
PATCH 1/1 staging: greybus: remove commented out function
Remove function gb_i2c_smbus_xfer() which is unused.
--- drivers/staging/greybus/i2c.c | 14 -------------- 1 file changed, 14 deletions(-)
drivers/staging/greybus/i2c.c +0 -14
@@ -215,20 +215,6 @@ static int gb_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,return gb_i2c_transfer_operation (gb_i2c_dev, msgs, msg_count); } -#if 0 -/* Later */ -static int gb_i2c_smbus_xfer (struct i2c_adapter *adap, -u16 addr,unsigned short flags,char read_write, -u8 command,int size,union i2c_smbus_data *data) -{ -struct gb_i2c_device *gb_i2c_dev; - - gb_i2c_dev =i2c_get_adapdata (adap); - -return 0 ; -} -#endif -static u32 gb_i2c_functionality (struct i2c_adapter *adap) {struct gb_i2c_device *gb_i2c_dev =i2c_get_adapdata (adap);
Signature · 1 line
2.17.1
Quoted 22 lines · On Sun, 8 Mar 2020 23:22:18 +0100 Lourdes Pedrajas <[email protected]> wrote:
Remove function
gb_i2c_smbus_xfer()which is unused.Signed-off-by Lourdes Pedrajas <[email protected]>--- drivers/staging/greybus/i2c.c | 14 -------------- 1 file changed, 14 deletions(-)drivers/staging/greybus/i2c.c +0
-7@@ -215,20 +215,6 @@ static int gb_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,return gb_i2c_transfer_operation (gb_i2c_dev, msgs, msg_count); } -#if 0 -/* Later */ -static int gb_i2c_smbus_xfer (struct i2c_adapter *adap, -u16 addr,unsigned short flags,char read_write, -u8 command,int size,union i2c_smbus_data *data) -{ -struct gb_i2c_device *gb_i2c_dev;
drivers/staging/greybus/i2c.c static int gb_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, · line 220
Quoted 10 lines
drivers/staging/greybus/i2c.c +0
-7- - gb_i2c_dev =i2c_get_adapdata (adap); - - return 0; -} -#endif -static u32 gb_i2c_functionality (struct i2c_adapter *adap) {struct gb_i2c_device *gb_i2c_dev =i2c_get_adapdata (adap);
In case of doubt, this function isn't even a draft, and nobody implemented it in six years, touched last time by commit ed8800dc376e ("greybus: add i2c driver"). Change looks good to me.
However, you should at least Cc: the maintainers returned by get_maintainer.pl.
Signature · 1 line
Stefano
Quoted 6 lines · Stefano Brivio
On Sun, 8 Mar 2020 23:22:18 +0100
Lourdes Pedrajas <[email protected]> wrote:However, you should at least Cc: the maintainers returned by get_maintainer.pl.
Yes, I was about to ask because I read somewhere in kernelnewbies wiki that Outreachy paths hould no be CCd to everyone in the get_maintainer.pl list, but I was wondering if this was really correct. So thank you for the hint!
Quoted 10 lines · Lourdes Pedrajas
Quoted 6 lines · Stefano Brivio
On Sun, 8 Mar 2020 23:22:18 +0100
Lourdes Pedrajas <[email protected]> wrote:However, you should at least Cc: the maintainers returned by get_maintainer.pl.
Yes, I was about to ask because I read somewhere in kernelnewbies wiki that Outreachy paths hould no be CCd to everyone in the get_maintainer.pl list, but I was wondering if this was really correct. So thank you for the hint!
Please search for get_maintainer in the tutorial and follow the instructions there. It gives some options that will get your patch to the main people who are responsible for the file.
julia
Quoted 15 lines · Julia Lawall
Quoted 10 lines · Lourdes Pedrajas
Quoted 6 lines · Stefano Brivio
On Sun, 8 Mar 2020 23:22:18 +0100
Lourdes Pedrajas <[email protected]> wrote:However, you should at least Cc: the maintainers returned by get_maintainer.pl.
Yes, I was about to ask because I read somewhere in kernelnewbies wiki that Outreachy paths hould no be CCd to everyone in the get_maintainer.pl list, but I was wondering if this was really correct. So thank you for the hint!
Quoted 5 lines
Please search for
get_maintainerin the tutorial and follow the instructions there. It gives some options that will get your patch to the main people who are responsible for the file.julia
Yes, if is not too much spam I will resend the patches including them, thank you!
Greg KH
maintainerQuoted 16 lines · Lourdes Pedrajas
Quoted 15 lines · Julia Lawall
Quoted 10 lines · Lourdes Pedrajas
Quoted 6 lines · Stefano Brivio
On Sun, 8 Mar 2020 23:22:18 +0100
Lourdes Pedrajas <[email protected]> wrote:However, you should at least Cc: the maintainers returned by get_maintainer.pl.
Yes, I was about to ask because I read somewhere in kernelnewbies wiki that Outreachy paths hould no be CCd to everyone in the get_maintainer.pl list, but I was wondering if this was really correct. So thank you for the hint!
Quoted 8 lines
Quoted 5 lines
Please search for
get_maintainerin the tutorial and follow the instructions there. It gives some options that will get your patch to the main people who are responsible for the file.julia
Yes, if is not too much spam I will resend the patches including them, thank you!
Please do.
thanks,
greg k-h
Quoted 11 lines · Lourdes Pedrajas
Quoted 6 lines · Stefano Brivio
On Sun, 8 Mar 2020 23:22:18 +0100
Lourdes Pedrajas <[email protected]> wrote:However, you should at least Cc: the maintainers returned by get_maintainer.pl.
Yes, I was about to ask because I read somewhere in kernelnewbies wiki that Outreachy paths hould no be CCd to everyone in the get_maintainer.pl list, but I was wondering if this was really correct. So thank you for the hint!
Hi Lourdes,
Could you please tell me which part of the kernel first patch tutorial says that no other email addresses should be CC'ed? I thought we had cleared the instructions under 'submit the first patch' part some rounds ago but given that the tutorial is quite big, we might have missed some part(s).
Quoted 4 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200309162655.GA3949%40supernova.
Quoted 13 lines · Vaishali Thakkar
Quoted 11 lines · Lourdes Pedrajas
Quoted 6 lines · Stefano Brivio
On Sun, 8 Mar 2020 23:22:18 +0100
Lourdes Pedrajas <[email protected]> wrote:However, you should at least Cc: the maintainers returned by get_maintainer.pl.
Yes, I was about to ask because I read somewhere in kernelnewbies wiki that Outreachy paths hould no be CCd to everyone in the get_maintainer.pl list, but I was wondering if this was really correct. So thank you for the hint!
Quoted 7 lines
Hi Lourdes,
Could you please tell me which part of the kernel first patch tutorial says that no other email addresses should be CC'ed? I thought we had cleared the instructions under 'submit the first patch' part some rounds ago but given that the tutorial is quite big, we might have missed some part(s).
Hi Vaishali,
My bad, I was in a rush to read the instructions and this line:
On the other hand, the maintainers of staging/vc04_services would prefer not to be CCd on Outreachy patches.
In https://kernelnewbies.org/Outreachyfirstpatch confused me. I am so sorry!
Lourdes.