fscache: drop fscache_cookie_put on duplicated cookies in the hash
PATCH 1/1 fscache: drop fscache_cookie_put on duplicated cookies in the hash
When there's a collision due to a duplicate cookie, __fscache_register_netfs will do an fscache_cookie_put. This, however, isn't required as fscache_cookie_get hasn't been executed, and will lead to a NULL pointer as fscache_unhash_cookie will be called.
Signed-off-by Luis Henriques <[email protected]>
--- fs/fscache/netfs.c | 1 - 1 file changed, 1 deletion(-)
fs/fscache/netfs.c +0 -1
@@ -52,7 +52,6 @@ int __fscache_register_netfs(struct fscache_netfs *netfs)return 0 ; already_registered: -fscache_cookie_put (candidate, fscache_cookie_put_dup_netfs);_leave (" = -EEXIST" );return -EEXIST ; }
Ping?
Cheers,
--
Luis
Quoted 22 lines · Luis Henriques
When there's a collision due to a duplicate cookie,
__fscache_register_netfswill do anfscache_cookie_put. This, however, isn't required asfscache_cookie_gethasn't been executed, and will lead to a NULL pointer asfscache_unhash_cookiewill be called.Signed-off-by Luis Henriques <[email protected]>--- fs/fscache/netfs.c | 1 - 1 file changed, 1 deletion(-)fs/fscache/netfs.c +0
-1@@ -52,7 +52,6 @@ int __fscache_register_netfs(struct fscache_netfs *netfs)return 0 ; already_registered: -fscache_cookie_put (candidate, fscache_cookie_put_dup_netfs);_leave (" = -EEXIST" );return -EEXIST ; }