Skip to contentSkip to conversation

staging: vt6655: power.c: remove unused code and improve formatting

PATCH In review Lourdes Pedrajas 2 participants 2 messages Mar 9, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vt6655: power.c: remove unused code and improve formatting

Remove unused code and improve formatting.

---
 drivers/staging/vt6655/power.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/staging/vt6655/power.c +2 -5
index bfd598a93b04..f1c221f5dcd2 100644
@@ -58,14 +58,11 @@ void PSvEnablePowerSaving(struct vnt_private *priv,
 	if (priv->op_mode != NL80211_IFTYPE_ADHOC) {
 		/* set AID */
 		VNSvOutPortW(priv->PortOffset + MAC_REG_AIDATIM, wAID);
-	} else {
-		/* set ATIM Window */
-#if 0 /* TODO atim window */
-		MACvWriteATIMW(priv->PortOffset, pMgmt->wCurrATIMWindow);
-#endif
 	}
+
 	/* Set AutoSleep */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
+
 	/* Set HWUTSF */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_TFTCTL, TFTCTL_HWUTSF);
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · Lourdes Pedrajas

Remove unused code and improve formatting.

A patch should do only one thing. This patch does two things.

Also, it would be good to try to find something more to say in the log message than just repeating the subject line. Why did you consider that it was a good idea to remove the code or to add the blank lines?

julia

Quoted 35 lines
---
 drivers/staging/vt6655/power.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/staging/vt6655/power.c +2 -6
index bfd598a93b04..f1c221f5dcd2 100644
@@ -58,14 +58,11 @@ void PSvEnablePowerSaving(struct vnt_private *priv,
 	if (priv->op_mode != NL80211_IFTYPE_ADHOC) {
 		/* set AID */
 		VNSvOutPortW(priv->PortOffset + MAC_REG_AIDATIM, wAID);
-	} else {
-		/* set ATIM Window */
-#if 0 /* TODO atim window */
-		MACvWriteATIMW(priv->PortOffset, pMgmt->wCurrATIMWindow);
-#endif
 	}
+
 	/* Set AutoSleep */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
+
 	/* Set HWUTSF */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_TFTCTL, TFTCTL_HWUTSF);
 
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200309192610.23541-1-lu%40pplo.net.