drm/imx: parallel-display: Adjust bus_flags handling
Subsystems (3)
PATCH v2 1/1 drm/imx: parallel-display: Adjust bus_flags handling
The bus_flags handling logic does not seem to cover all potential usecases. Specifically, this seems to fail with an "edt,etm0700g0edh6" display attached to an 24bit display interface, with interface-pix-fmt = "rgb24" set in DT.
This patch fixes the problem by overriding the imx_crtc_state->bus_flags from the imxpd->bus_flags only if the DT property "interface-pix-fmt" is present or if the DI provides no formats.
To: [email protected]
---
V2: Rebase on next, update description
--- drivers/gpu/drm/imx/parallel-display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/imx/parallel-display.c +1 -1
@@ -216,7 +216,7 @@ static int imx_pd_bridge_atomic_check(struct drm_bridge *bridge,if (next_bridge_state) bus_flags = next_bridge_state->input_bus_cfg.flags; -else if (!imxpd->bus_format && di->num_bus_formats) +else if (di->num_bus_formats) bus_flags = di->bus_flags;else bus_flags = imxpd->bus_flags;
Signature · 7 lines
2.25.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Marek,
Quoted 18 lines · Marek Vasut
The
bus_flagshandling logic does not seem to cover all potential usecases. Specifically, this seems to fail with an "edt,etm0700g0edh6" display attached to an 24bit display interface, with interface-pix-fmt = "rgb24" set in DT.This patch fixes the problem by overriding the
imx_crtc_state->bus_flagsfrom theimxpd->bus_flagsonly if the DT property "interface-pix-fmt" is present or if the DI provides no formats.Signed-off-by Marek Vasut <[email protected]>Cc Daniel Vetter <[email protected]>Cc David Airlie <[email protected]>Cc Fabio Estevam <[email protected]>Cc NXP Linux Team <[email protected]>Cc Philipp Zabel <[email protected]>Cc Sascha Hauer <[email protected]>Cc Shawn Guo <[email protected]>
Quoted 3 lines
To: [email protected]
---
V2: Rebase on next, update description
Thank you for the update, I've applied this patch to imx-drm/next.
regards
Philipp
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel