package/mesa3d: select vc4 and kmsro driver for gallium v3d
PATCH 1/2 package/mesa3d: select vc4 and kmsro driver for gallium v3d
Currently, when building for rpi2/3 it is only necessary to to select vc4 to get acceleration working. However, when building for rpi4 v3d, vc4 and kmsro have to be selected. Therefore this commit forces the selection of vc4 and kmsro when v3d is selected.
--- package/mesa3d/Config.in | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
package/mesa3d/Config.in +3 -5
@@ -257,12 +257,10 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_TEGRA config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D bool "Gallium v3d driver" depends on BR2_arm || BR2_aarch64 - select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER - select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO - select BR2_PACKAGE_LIBDRM_VC4 - select BR2_PACKAGE_MESA3D_OPENGL_EGL + select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 + select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO help - Driver for Broadcom VC6 (rpi4) GPUs (needs kmsro and vc4). + Driver for Broadcom VC6 (rpi4) GPUs. It requires a kernel 4.18+ with DRM V3D support enabled:
Signature · 1 line
2.17.1
PATCH 2/2 package/mesa3d: get glxgears working for v3d/vc4 minimal builds
Currently a minimal build for rpi2/3/4 (i.e. only v3d and/or vc4 selected, no dri drivers selected) results in working X11 except that glxgears shows a blank window. This commit effectively results in the following conf options being added: -Dglx-direct=true -Ddri3=true
--- package/mesa3d/Config.in | 1 + 1 file changed, 1 insertion(+)
package/mesa3d/Config.in +1 -0
@@ -274,6 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO select BR2_PACKAGE_LIBDRM_VC4 select BR2_PACKAGE_MESA3D_OPENGL_EGL + select BR2_PACKAGE_MESA3D_DRI_DRIVER help Driver for Broadcom VC4 (rpi2/3) GPUs. It requires a vanilla 4.5+ kernel with drm vc4 (open) support.
Signature · 1 line
2.17.1
PATCH 2/2 package/mesa3d: get glxgears working for v3d/vc4 minimal builds
Hello Howard,
Quoted 15 lines · Howard Mitchell
Currently a minimal build for rpi2/3/4 (i.e. only v3d and/or vc4 selected, no dri drivers selected) results in working X11 except that glxgears shows a blank window. This commit effectively results in the following conf options being added: -Dglx-direct=true -Ddri3=true
Signed-off-by Howard Mitchell <[email protected]>--- package/mesa3d/Config.in | 1 + 1 file changed, 1 insertion(+)package/mesa3d/Config.in +0
-0
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 · line 277
Quoted 4 lines
package/mesa3d/Config.in +1
-0@@ -274,6 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO select BR2_PACKAGE_LIBDRM_VC4 select BR2_PACKAGE_MESA3D_OPENGL_EGL + select BR2_PACKAGE_MESA3D_DRI_DRIVER
On rpi4 v3d/vc4 work definitely for the Qt/eglfs case without MESA3D_DRI_DRIVER, so this should at minimum depend on X11 (or only be selected by x11/glxgears)?
Regards,
Peter
Quoted 3 lines
package/mesa3d/Config.in +0
-0help Driver for Broadcom VC4 (rpi2/3) GPUs. It requires a vanilla 4.5+ kernel with drm vc4 (open) support.
PATCH 2/2 package/mesa3d: get glxgears working for v3d/vc4 minimal builds
Hello Peter,
Quoted 14 lines · Peter Seiderer
Hello Howard,
Quoted 10 lines · Howard Mitchell
Currently a minimal build for rpi2/3/4 (i.e. only v3d and/or vc4 selected, no dri drivers selected) results in working X11 except that glxgears shows a blank window. This commit effectively results in the following conf options being added: -Dglx-direct=true -Ddri3=true
Signed-off-by Howard Mitchell <[email protected]>--- package/mesa3d/Config.in | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 · line 277
Quoted 9 lines
package/mesa3d/Config.in +1
-0@@ -274,6 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO select BR2_PACKAGE_LIBDRM_VC4 select BR2_PACKAGE_MESA3D_OPENGL_EGL + select BR2_PACKAGE_MESA3D_DRI_DRIVEROn rpi4 v3d/vc4 work definitely for the Qt/eglfs case without
MESA3D_DRI_DRIVER, so this should at minimum depend on X11 (or only be selected by x11/glxgears)?
In fact the '-Ddri3=true' option is already dependent on X11 (in mesa3d.mk) so only '-Dglx-direct=true' would be left without X. Do you think that is likelyto break Qt/eglfs?
Regards,
Howard
PATCH 2/2 package/mesa3d: get glxgears working for v3d/vc4 minimal builds
Hello Howard,
Quoted 30 lines · Howard Mitchell
Hello Peter,
Quoted 14 lines · Peter Seiderer
Hello Howard,
Quoted 10 lines · Howard Mitchell
Currently a minimal build for rpi2/3/4 (i.e. only v3d and/or vc4 selected, no dri drivers selected) results in working X11 except that glxgears shows a blank window. This commit effectively results in the following conf options being added: -Dglx-direct=true -Ddri3=true
Signed-off-by Howard Mitchell <[email protected]>--- package/mesa3d/Config.in | 1 + 1 file changed, 1 insertion(+)Quoted 12 lines
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 · line 277
Quoted 9 lines
package/mesa3d/Config.in +1
-0@@ -274,6 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO select BR2_PACKAGE_LIBDRM_VC4 select BR2_PACKAGE_MESA3D_OPENGL_EGL + select BR2_PACKAGE_MESA3D_DRI_DRIVEROn rpi4 v3d/vc4 work definitely for the Qt/eglfs case without
MESA3D_DRI_DRIVER, so this should at minimum depend on X11 (or only be selected by x11/glxgears)?
Quoted 3 lines
In fact the '-Ddri3=true' option is already dependent on X11 (in mesa3d.mk) so only '-Dglx-direct=true' would be left without X. Do you think that is likelyto break Qt/eglfs?
Its not so much about breaking the Qt/eglfs case, but about being minimal and not enabling un-needed/-wanted options...
Your list of options above is not very precise when looking at package/mesa3d/mesa3d.mk (missing -Dshared-glapi=true -Ddri-drivers=, and -Ddri3=true/false dependent on BR2_PACKAGE_XLIB_LIBXSHMFENCE)...
Regards,
Peter
Quoted 8 lines
Regards,
Howard_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 2/2 package/mesa3d: get glxgears working for v3d/vc4 minimal builds
Hello Peter,
Quoted 36 lines · Peter Seiderer
Hello Howard,
Quoted 29 lines · Howard Mitchell
Hello Peter,
Quoted 14 lines · Peter Seiderer
Hello Howard,
Quoted 10 lines · Howard Mitchell
Currently a minimal build for rpi2/3/4 (i.e. only v3d and/or vc4 selected, no dri drivers selected) results in working X11 except that glxgears shows a blank window. This commit effectively results in the following conf options being added: -Dglx-direct=true -Ddri3=true
Signed-off-by Howard Mitchell <[email protected]>--- package/mesa3d/Config.in | 1 + 1 file changed, 1 insertion(+)Quoted 12 lines
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 · line 277
Quoted 9 lines
package/mesa3d/Config.in +1
-0@@ -274,6 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO select BR2_PACKAGE_LIBDRM_VC4 select BR2_PACKAGE_MESA3D_OPENGL_EGL + select BR2_PACKAGE_MESA3D_DRI_DRIVEROn rpi4 v3d/vc4 work definitely for the Qt/eglfs case without
MESA3D_DRI_DRIVER, so this should at minimum depend on X11 (or only be selected by x11/glxgears)?Quoted 3 lines
In fact the '-Ddri3=true' option is already dependent on X11 (in mesa3d.mk) so only '-Dglx-direct=true' would be left without X. Do you think that is likelyto break Qt/eglfs?
Quoted 6 lines
Its not so much about breaking the Qt/eglfs case, but about being minimal and not enabling un-needed/-wanted options...
Your list of options above is not very precise when looking at
package/mesa3d/mesa3d.mk(missing -Dshared-glapi=true -Ddri-drivers=, and -Ddri3=true/false dependent onBR2_PACKAGE_XLIB_LIBXSHMFENCE)...
The options I specified are the difference between before and after applying the
patch. I used 'make printvars VARS=MESA3D_CONF_OPTS' to verify. Looking at mesa3d.mk, -Dshared_glapi=true is already included because BR2_PACKAGE_MESA3D_GALLIUM_DRIVER=y and is therefore repeated. -Ddri-drivers=
is an empty list with or without the patch. So as I stated before only -Dglx-direct=true is additional if you're building without X11. When building
with X11 then additionally -Ddri3 changes from false to true when the patch is
applied.
To see how much difference the -Dglx-direct=true option makes I built mesa3d without X11 both with and without the patch applied and compared the file sizes
produced. Interestingly there was no difference at all, all output files were
exactly the same size with or without the patch. I was a bit surprised by this
so I retraced my steps to be absolutely sure. I suspect it is because -Dglx=disabled so -Dglx-direct=true has no effect.
Regards,
Howard
PATCH 2/2 package/mesa3d: get glxgears working for v3d/vc4 minimal builds
Hello Howard,
Quoted 46 lines · Howard Mitchell
Hello Peter,
Quoted 36 lines · Peter Seiderer
Hello Howard,
Quoted 29 lines · Howard Mitchell
Hello Peter,
Quoted 14 lines · Peter Seiderer
Hello Howard,
Quoted 10 lines · Howard Mitchell
Currently a minimal build for rpi2/3/4 (i.e. only v3d and/or vc4 selected, no dri drivers selected) results in working X11 except that glxgears shows a blank window. This commit effectively results in the following conf options being added: -Dglx-direct=true -Ddri3=true
Signed-off-by Howard Mitchell <[email protected]>--- package/mesa3d/Config.in | 1 + 1 file changed, 1 insertion(+)Quoted 12 lines
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 · line 277
Quoted 9 lines
package/mesa3d/Config.in +1
-0@@ -274,6 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO select BR2_PACKAGE_LIBDRM_VC4 select BR2_PACKAGE_MESA3D_OPENGL_EGL + select BR2_PACKAGE_MESA3D_DRI_DRIVEROn rpi4 v3d/vc4 work definitely for the Qt/eglfs case without
MESA3D_DRI_DRIVER, so this should at minimum depend on X11 (or only be selected by x11/glxgears)?Quoted 3 lines
In fact the '-Ddri3=true' option is already dependent on X11 (in mesa3d.mk) so only '-Dglx-direct=true' would be left without X. Do you think that is likelyto break Qt/eglfs?
Quoted 6 lines
Its not so much about breaking the Qt/eglfs case, but about being minimal and not enabling un-needed/-wanted options...
Your list of options above is not very precise when looking at
package/mesa3d/mesa3d.mk(missing -Dshared-glapi=true -Ddri-drivers=, and -Ddri3=true/false dependent onBR2_PACKAGE_XLIB_LIBXSHMFENCE)...
Quoted 12 lines
The options I specified are the difference between before and after applying the
patch. I used 'make printvars VARS=MESA3D_CONF_OPTS' to verify. Looking at mesa3d.mk, -Dshared_glapi=true is already included because BR2_PACKAGE_MESA3D_GALLIUM_DRIVER=y and is therefore repeated. -Ddri-drivers=
is an empty list with or without the patch. So as I stated before only -Dglx-direct=true is additional if you're building without X11. When building
with X11 then additionally -Ddri3 changes from false to true when the patch is
applied.
But not dependent on X11 but dependent on BR2_PACKAGE_MESA3D_DRI_DRIVER=y/BR2_PACKAGE_XLIB_LIBXSHMFENCE=y?
I still state that forcing BR2_PACKAGE_MESA3D_DRI_DRIVER=y to gain -Ddri=true (or toggle between true/false via random other dependencies) to satisfy glxgears needs feels like the wrong approach...
Regards,
Peter
Quoted 18 lines
To see how much difference the -Dglx-direct=true option makes I built mesa3d without X11 both with and without the patch applied and compared the file sizes
produced. Interestingly there was no difference at all, all output files were
exactly the same size with or without the patch. I was a bit surprised by this
so I retraced my steps to be absolutely sure. I suspect it is because -Dglx=disabled so -Dglx-direct=true has no effect.Regards,
Howard_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 2/2 package/mesa3d: get glxgears working for v3d/vc4 minimal builds
Hello Peter,
Quoted 63 lines · Peter Seiderer
Hello Howard,
Quoted 45 lines · Howard Mitchell
Hello Peter,
Quoted 36 lines · Peter Seiderer
Hello Howard,
Quoted 29 lines · Howard Mitchell
Hello Peter,
Quoted 14 lines · Peter Seiderer
Hello Howard,
Quoted 10 lines · Howard Mitchell
Currently a minimal build for rpi2/3/4 (i.e. only v3d and/or vc4 selected, no dri drivers selected) results in working X11 except that glxgears shows a blank window. This commit effectively results in the following conf options being added: -Dglx-direct=true -Ddri3=true
Signed-off-by Howard Mitchell<[email protected]>--- package/mesa3d/Config.in | 1 + 1 file changed, 1 insertion(+)Quoted 12 lines
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 · line 277
Quoted 9 lines
package/mesa3d/Config.in +1
-0@@ -274,6 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO select BR2_PACKAGE_LIBDRM_VC4 select BR2_PACKAGE_MESA3D_OPENGL_EGL + select BR2_PACKAGE_MESA3D_DRI_DRIVEROn rpi4 v3d/vc4 work definitely for the Qt/eglfs case without
MESA3D_DRI_DRIVER, so this should at minimum depend on X11 (or only be selected by x11/glxgears)?Quoted 3 lines
In fact the '-Ddri3=true' option is already dependent on X11 (in mesa3d.mk) so only '-Dglx-direct=true' would be left without X. Do you think that is likelyto break Qt/eglfs?
Quoted 6 lines
Its not so much about breaking the Qt/eglfs case, but about being minimal and not enabling un-needed/-wanted options...
Your list of options above is not very precise when looking at
package/mesa3d/mesa3d.mk(missing -Dshared-glapi=true -Ddri-drivers=, and -Ddri3=true/false dependent onBR2_PACKAGE_XLIB_LIBXSHMFENCE)...Quoted 12 lines
The options I specified are the difference between before and after applying the
patch. I used 'make printvars VARS=MESA3D_CONF_OPTS' to verify. Looking at mesa3d.mk, -Dshared_glapi=true is already included because BR2_PACKAGE_MESA3D_GALLIUM_DRIVER=y and is therefore repeated. -Ddri-drivers=
is an empty list with or without the patch. So as I stated before only -Dglx-direct=true is additional if you're building without X11. When building
with X11 then additionally -Ddri3 changes from false to true when the patch is
applied.But not dependent on X11 but dependent on BR2_PACKAGE_MESA3D_DRI_DRIVER=y/BR2_PACKAGE_XLIB_LIBXSHMFENCE=y?
Quoted 3 lines
I still state that forcing BR2_PACKAGE_MESA3D_DRI_DRIVER=y to gain -Ddri=true (or toggle between true/false via random other dependencies) to satisfy glxgears needs feels like the wrong approach...
Maybe, but as I'm building for an OpenGL platform I'd expect glxgears to work correctly.
The fact that it didn't suggested that mesa3d was incorrectly configured. Without my patch
to get a 'minimal' build in which glxgears works you need to select one of the dri drivers.
Any one will do. You then get, for example:
-Dglx-direct=true -Ddri3=true -Ddri-drivers=swrast as additional/changed options. So all
my patch effectively does is reduce -Ddri-drivers to an empty list.
Re: [Buildroot] [PATCH 2/2] package/mesa3d: get glxgears working for v3d/vc4 minimal builds
In reply to Howard MitchellQuoted 6 lines · Howard Mitchell
Currently a minimal build for rpi2/3/4 (i.e. only v3d and/or vc4 selected, no dri drivers selected) results in working X11 except that glxgears shows a blank window. This commit effectively results in the following conf options being added: -Dglx-direct=true -Ddri3=true
Signed-off-by Howard Mitchell <[email protected]>
Instead of this patch, I applied [1]. Based on Howard's observation, the key
is in fact the -Dglx-direct=true. I did a bit of investigation and I concluded that we can always enable that if GLX is enabled.
Bernd, Peter, could you shout if that doesn't work for you?
Regards,
Arnout
[1] https://git.buildroot.org/buildroot/commit/?id=6a51177af14a2ddaa6431bb7fc618fe138b59b72
Quoted 10 lines
--- package/mesa3d/Config.in | 1 + 1 file changed, 1 insertion(+)package/mesa3d/Config.in +0
-0
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 · line 280
Quoted 7 lines
package/mesa3d/Config.in +1
-0@@ -274,6 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO select BR2_PACKAGE_LIBDRM_VC4 select BR2_PACKAGE_MESA3D_OPENGL_EGL + select BR2_PACKAGE_MESA3D_DRI_DRIVER help Driver for Broadcom VC4 (rpi2/3) GPUs. It requires a vanilla 4.5+ kernel with drm vc4 (open) support.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Peter,
Quoted 6 lines · On Fri, 6 Mar 2020 09:25:03 +0000 Howard Mitchell <[email protected]> wrote:
Currently, when building for rpi2/3 it is only necessary to to select vc4 to get acceleration working. However, when building for rpi4 v3d, vc4 and kmsro have to be selected. Therefore this commit forces the selection of vc4 and kmsro when v3d is selected.
Signed-off-by Howard Mitchell <[email protected]>
Do you have some feedback on this patch? Could you do some testing perhaps on RPi4 ?
Note that the patch as-is no longer applies, the BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO option no longer exists.
However, the question of whether V3D support needs VC4 support still stands.
Thanks!
Thomas
Quoted 24 lines
--- package/mesa3d/Config.in | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)package/mesa3d/Config.in +3
-5@@ -257,12 +257,10 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_TEGRA config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D bool "Gallium v3d driver" depends on BR2_arm || BR2_aarch64 - select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER - select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO - select BR2_PACKAGE_LIBDRM_VC4 - select BR2_PACKAGE_MESA3D_OPENGL_EGL + select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 + select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO help - Driver for Broadcom VC6 (rpi4) GPUs (needs kmsro and vc4). + Driver for Broadcom VC6 (rpi4) GPUs. It requires a kernel 4.18+ with DRM V3D support enabled:
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] http://lists.busybox.net/mailman/listinfo/buildroot
Quoted 6 lines · Howard Mitchell
Currently, when building for rpi2/3 it is only necessary to to select vc4 to get acceleration working. However, when building for rpi4 v3d, vc4 and kmsro have to be selected. Therefore this commit forces the selection of vc4 and kmsro when v3d is selected.
Signed-off-by Howard Mitchell <[email protected]>
(Finally) applied to master, thanks. I had to fix it up a little since the
KMSRO option was removed.
Regards,
Arnout
Quoted 15 lines
--- package/mesa3d/Config.in | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)package/mesa3d/Config.in +0
-2@@ -257,12 +257,10 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_TEGRA config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D bool "Gallium v3d driver" depends on BR2_arm || BR2_aarch64 - select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER - select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_TEGRA · line 266
Quoted 10 lines
package/mesa3d/Config.in +3
-3- select BR2_PACKAGE_LIBDRM_VC4 - select BR2_PACKAGE_MESA3D_OPENGL_EGL + select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 + select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO help - Driver for Broadcom VC6 (rpi4) GPUs (needs kmsro and vc4). + Driver for Broadcom VC6 (rpi4) GPUs. It requires a kernel 4.18+ with DRM V3D support enabled:
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot