Skip to contentSkip to conversation

x86: Run unit tests with --no-reboot so shutdowns show up as failures

PATCH New Sean Christopherson 1 participant 1 message Mar 10, 2020 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: Run unit tests with --no-reboot so shutdowns show up as failures

Run tests with --no-reboot so that triple fault shutdowns get reported as failures. By default, Qemu automatically reboots on shutdown, i.e. automatically restarts the test, eventually leading to a timeout.

---

I don't think there are any tests would run afoul of --no-reboot?

 x86/run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
x86/run +1 -1
index 1ac91f1..8b2425f 100755
@@ -37,7 +37,7 @@ else
 	pc_testdev="-device testdev,chardev=testlog -chardev file,id=testlog,path=msr.out"
 fi
 
-command="${qemu} -nodefaults $pc_testdev -vnc none -serial stdio $pci_testdev"
+command="${qemu} --no-reboot -nodefaults $pc_testdev -vnc none -serial stdio $pci_testdev"
 command+=" -machine accel=$ACCEL -kernel"
 command="$(timeout_cmd) $command"
 
Signature · 1 line
2.24.1