Skip to contentSkip to conversation

lib/librte_net/rte_ether.h:changed RTE_ETHER_MAX_LEN

PATCH In review Muhammad Ahmad 2 participants 2 messages Mar 10, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/librte_net/rte_ether.h:changed RTE_ETHER_MAX_LEN

Change the RTE_ETHER_MAX_LEN from 1518 to 1526

Bugzilla ID: 296

Fixes c5b2d13 (net: add rte prefix to ether defines)
---
 lib/librte_net/rte_ether.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_net/rte_ether.h +1 -1
index e069dc7fe..8953107f3 100644
@@ -30,7 +30,7 @@ extern "C" {
 	(RTE_ETHER_ADDR_LEN * 2 + \
 		RTE_ETHER_TYPE_LEN) /**< Length of Ethernet header. */
 #define RTE_ETHER_MIN_LEN   64    /**< Minimum frame len, including CRC. */
-#define RTE_ETHER_MAX_LEN   1518  /**< Maximum frame len, including CRC. */
+#define RTE_ETHER_MAX_LEN   1526  /**< Maximum frame len, including CRC. */
 #define RTE_ETHER_MTU       \
 	(RTE_ETHER_MAX_LEN - RTE_ETHER_HDR_LEN - \
 		RTE_ETHER_CRC_LEN) /**< Ethernet MTU. */
Signature · 1 line
2.17.1
#1 lore raw
Quoted 21 lines · On Tue, 10 Mar 2020 11:50:36 +0500 Muhammad Ahmad <[email protected]>…

Change the RTE_ETHER_MAX_LEN from 1518 to 1526

Bugzilla ID: 296

Fixes c5b2d13 (net: add rte prefix to ether defines)
---
 lib/librte_net/rte_ether.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_net/rte_ether.h +0 -0
index e069dc7fe..8953107f3 100644

lib/librte_net/rte_ether.h extern "C" { · line 36

Quoted 8 lines
lib/librte_net/rte_ether.h +1 -1
@@ -30,7 +30,7 @@ extern "C" {
 	(RTE_ETHER_ADDR_LEN * 2 + \
 		RTE_ETHER_TYPE_LEN) /**< Length of Ethernet header. */
 #define RTE_ETHER_MIN_LEN   64    /**< Minimum frame len, including CRC. */
-#define RTE_ETHER_MAX_LEN   1518  /**< Maximum frame len, including CRC. */
+#define RTE_ETHER_MAX_LEN   1526  /**< Maximum frame len, including CRC. */
 #define RTE_ETHER_MTU       \
 	(RTE_ETHER_MAX_LEN - RTE_ETHER_HDR_LEN - \
 		RTE_ETHER_CRC_LEN) /**< Ethernet MTU. */

No that is abi change would impact a lot of code and drivers. The problem is the comment is wrong, not the value.