Skip to contentSkip to conversation

staging: hp: hp100.c: remove commented out code

PATCH In review Lourdes Pedrajas 2 participants 3 messages Mar 9, 2020 – Mar 10, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: hp: hp100.c: remove commented out code

Remove unused code.

---
 drivers/staging/hp/hp100.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/staging/hp/hp100.c +0 -6
index e2f0b58e5dfd..b89c4dcf53f5 100644
@@ -511,12 +511,6 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus,
 	 *   0x2260 -> EISA HP, BusMaster (Shasta Chip)
 	 */
 
-#if 0
-	local_mode = 0x2270;
-	hp100_outw(0xfefe, OPTION_LSW);
-	hp100_outw(local_mode | HP100_SET_LB | HP100_SET_HB, OPTION_LSW);
-#endif
-
 	/* hp100_mode value maybe used in future by another card */
 	local_mode = hp100_mode;
 	if (local_mode < 1 || local_mode > 4)
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · Lourdes Pedrajas

Remove unused code.

This could be a little more informative. For example, you could use git blame to find out how long the code has been there. If it has been there since the driver was introduced n years ago, that could be a useful piece of information to make clear that the code really is unnecessary.

julia

Quoted 31 lines
---
 drivers/staging/hp/hp100.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/staging/hp/hp100.c +0 -7
index e2f0b58e5dfd..b89c4dcf53f5 100644
@@ -511,12 +511,6 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus,
 	 *   0x2260 -> EISA HP, BusMaster (Shasta Chip)
 	 */
 
-#if 0
-	local_mode = 0x2270;
-	hp100_outw(0xfefe, OPTION_LSW);
-	hp100_outw(local_mode | HP100_SET_LB | HP100_SET_HB, OPTION_LSW);
-#endif
-
 	/* hp100_mode value maybe used in future by another card */
 	local_mode = hp100_mode;
 	if (local_mode < 1 || local_mode > 4)
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200309171224.5131-1-lu%40pplo.net.

#2 lore raw
Quoted 11 lines · Julia Lawall
Quoted 1 line · Lourdes Pedrajas

Remove unused code.

This could be a little more informative. For example, you could use git blame to find out how long the code has been there. If it has been there since the driver was introduced n years ago, that could be a useful piece of information to make clear that the code really is unnecessary.

julia

I agree. This patch is being merged, but next time I'll use your hint, it's useful. Thank you for your patience!