usb: typec: ucsi_ccg: workaround for NVIDIA test device
Subsystems (2)
Heikki Krogerus
maintainerPATCH 1/1 usb: typec: ucsi_ccg: workaround for NVIDIA test device
From: Ajay Gupta <[email protected]>
NVIDIA VirtualLink (svid 0x955) has two altmode, vdo=0x1 for VirtualLink DP mode and vdo=0x3 for NVIDIA test mode. NVIDIA test device FTB (Function Test Board) reports altmode list with vdo=0x3 first and then vdo=0x1. The list is:
SVID VDO 0xff01 0xc05 0x28de 0x8085 0x955 0x3 0x955 0x1
Current logic to assign mode value is based on order in altmode list. This causes a mismatch of CON and SOP altmodes since NVIDIA GPU connector has order of vdo=0x1 first and then vdo=0x3. Fixing this by changing the order of vdo values reported by NVIDIA test device. the new list will be:
SVID VDO 0xff01 0xc05 0x28de 0x8085 0x955 0x1085 0x955 0x3
Also NVIDIA VirtualLink (svid 0x955) uses pin E for display mode. NVIDIA test device reports vdo of 0x1 so make sure vdo values always have pin E assignement.
--- drivers/usb/typec/ucsi/ucsi.h | 2 ++ drivers/usb/typec/ucsi/ucsi_ccg.c | 55 ++++++++++++++++++++++++++++--- 2 files changed, 52 insertions(+), 5 deletions(-)
drivers/usb/typec/ucsi/ucsi.h +2 -0
@@ -119,12 +119,14 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num);#define UCSI_SET_PDR_ACCEPT_ROLE_SWAPS BIT(25)/* GET_ALTERNATE_MODES command bits */ +#define UCSI_ALTMODE_RECIPIENT (_r_) (((_r_) >> 16) & 0x7)#define UCSI_GET_ALTMODE_RECIPIENT (_r_) ((u64)(_r_) << 16)#define UCSI_RECIPIENT_CON 0#define UCSI_RECIPIENT_SOP 1#define UCSI_RECIPIENT_SOP_P 2#define UCSI_RECIPIENT_SOP_PP 3#define UCSI_GET_ALTMODE_CONNECTOR_NUMBER (_r_) ((u64)(_r_) << 24) +#define UCSI_ALTMODE_OFFSET (_r_) (((_r_) >> 32) & 0xff)#define UCSI_GET_ALTMODE_OFFSET (_r_) ((u64)(_r_) << 32)#define UCSI_GET_ALTMODE_NUM_ALTMODES (_r_) ((u64)(_r_) << 40)
drivers/usb/typec/ucsi/ucsi_ccg.c +50 -5
80 lines not on this page · raw message
Signature · 1 line
2.25.1