remove unused code and improve readability
Here's a set of patches that performs code cleanup in the file drivers/staging/vt6655/power.c
PATCH 1/2 staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving()
Every time priv->op_mode is not NL80211_IFTYPE_ADHOC it sets ATIM Window, but this feature it is marked TODO in 2014 and did go untouched since 2015.
--- drivers/staging/vt6655/power.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/staging/vt6655/power.c +0 -5
@@ -58,11 +58,6 @@ void PSvEnablePowerSaving(struct vnt_private *priv,if (priv->op_mode !=NL80211_IFTYPE_ADHOC ) {/* set AID */ VNSvOutPortW (priv->PortOffset +MAC_REG_AIDATIM , wAID); - }else { -/* set ATIM Window */ -#if 0 /* TODO atim window */ -MACvWriteATIMW (priv->PortOffset, pMgmt->wCurrATIMWindow); -#endif }/* Set AutoSleep */ MACvRegBitsOn (priv->PortOffset,MAC_REG_PSCFG ,PSCFG_AUTOSLEEP );
Signature · 1 line
2.17.1
PATCH 2/2 staging: exfat: exfat_super.c: code reformatting for improved readability
In reply to Lourdes PedrajasImprove line grouping for better understanding the course of action and where every comment belongs to.
--- drivers/staging/vt6655/power.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/staging/vt6655/power.c +5 -0
@@ -59,8 +59,10 @@ void PSvEnablePowerSaving(struct vnt_private *priv,/* set AID */ VNSvOutPortW (priv->PortOffset +MAC_REG_AIDATIM , wAID); } +/* Set AutoSleep */ MACvRegBitsOn (priv->PortOffset,MAC_REG_PSCFG ,PSCFG_AUTOSLEEP ); +/* Set HWUTSF */ MACvRegBitsOn (priv->PortOffset,MAC_REG_TFTCTL ,TFTCTL_HWUTSF );
@@ -96,10 +98,13 @@ void PSvDisablePowerSaving(struct vnt_private *priv) {/* disable power saving hw function */ MACbPSWakeup (priv); +/* clear AutoSleep */ MACvRegBitsOff (priv->PortOffset,MAC_REG_PSCFG ,PSCFG_AUTOSLEEP ); +/* clear HWUTSF */ MACvRegBitsOff (priv->PortOffset,MAC_REG_TFTCTL ,TFTCTL_HWUTSF ); +/* set always listen beacon */ MACvRegBitsOn (priv->PortOffset,MAC_REG_PSCTL ,PSCTL_ALBCN );
Signature · 1 line
2.17.1
Greg KH
maintainerRe: [PATCH 2/2] staging: exfat: exfat_super.c: code reformatting for improved readability
Quoted 7 lines · Lourdes Pedrajas
Improve line grouping for better understanding the course of action and where every comment belongs to.
Signed-off-by Lourdes Pedrajas <[email protected]>--- drivers/staging/vt6655/power.c | 5 +++++ 1 file changed, 5 insertions(+)
The subject does not match the file changed :(
Greg KH
maintainerQuoted 4 lines · Lourdes Pedrajas
Here's a set of patches that performs code cleanup in the file
drivers/staging/vt6655/power.c
I don't think you created this with 'git format-patch --cover-letter' :(
Quoted 7 lines · Greg KH
Quoted 4 lines · Lourdes Pedrajas
Here's a set of patches that performs code cleanup in the file
drivers/staging/vt6655/power.cI don't think you created this with 'git format-patch --cover-letter' :(
It's git-send-email. Also yes, the file is not correct :( Forgive me, thanks for your patience.
Quoted 4 lines · Lourdes Pedrajas
Here's a set of patches that performs code cleanup in the file
drivers/staging/vt6655/power.c
Please ignore this patchet, I am so sorry, the subject line is not ok. Patched is sent again.
Thank you.