Skip to contentSkip to conversation

staging: exfat: exfat_super.c: remove unused code and improve readability

PATCH In review Lourdes Pedrajas 2 participants 4 messages Mar 10, 2020 Staging

lore
Share & tools
lore
#0 lore raw

cover staging: exfat: exfat_super.c: remove unused code and improve readability

Here's a set of patches that performs code cleanup in the file drivers/staging/vt6655/power.c

#1 lore raw

PATCH 1/2 staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving()

Every time priv->op_mode is not NL80211_IFTYPE_ADHOC it sets ATIM Window, but this feature it is marked TODO in 2014 and did go untouched since 2015.

---
 drivers/staging/vt6655/power.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/staging/vt6655/power.c +0 -5
index bfd598a93b04..a68ec527679a 100644
@@ -58,11 +58,6 @@ void PSvEnablePowerSaving(struct vnt_private *priv,
 	if (priv->op_mode != NL80211_IFTYPE_ADHOC) {
 		/* set AID */
 		VNSvOutPortW(priv->PortOffset + MAC_REG_AIDATIM, wAID);
-	} else {
-		/* set ATIM Window */
-#if 0 /* TODO atim window */
-		MACvWriteATIMW(priv->PortOffset, pMgmt->wCurrATIMWindow);
-#endif
 	}
 	/* Set AutoSleep */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/2 staging: exfat: exfat_super.c: code reformatting for improved readability

In reply to Lourdes Pedrajas

Improve line grouping for better understanding the course of action and where every comment belongs to.

---
 drivers/staging/vt6655/power.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/staging/vt6655/power.c +5 -0
index a68ec527679a..6b0407694e54 100644
@@ -59,8 +59,10 @@ void PSvEnablePowerSaving(struct vnt_private *priv,
 		/* set AID */
 		VNSvOutPortW(priv->PortOffset + MAC_REG_AIDATIM, wAID);
 	}
+
 	/* Set AutoSleep */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
+
 	/* Set HWUTSF */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_TFTCTL, TFTCTL_HWUTSF);
 
@@ -96,10 +98,13 @@ void PSvDisablePowerSaving(struct vnt_private *priv)
 {
 	/* disable power saving hw function */
 	MACbPSWakeup(priv);
+
 	/* clear AutoSleep */
 	MACvRegBitsOff(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
+
 	/* clear HWUTSF */
 	MACvRegBitsOff(priv->PortOffset, MAC_REG_TFTCTL, TFTCTL_HWUTSF);
+
 	/* set always listen beacon */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCTL, PSCTL_ALBCN);
 
Signature · 1 line
2.17.1
maintainer
#3 lore raw
In reply to Lourdes Pedrajas
Quoted 3 lines · Lourdes Pedrajas

Here's a set of patches that performs code cleanup in the file drivers/staging/vt6655/power.c

Still not using --cover-letter.

Also the subject line is very odd for the vt6655 driver :(