Skip to contentSkip to conversation

KVM: nVMX: Don't emulate instructions in guest mode

PATCH In review Jon Maloy 2 participants 2 messages Mar 10, 2020 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jon Maloy

author
#1 lore raw

PATCH 1/3 KVM: nVMX: Don't emulate instructions in guest mode

From: Paolo Bonzini <[email protected]>

vmx_check_intercept is not yet fully implemented. To avoid emulating instructions disallowed by the L1 hypervisor, refuse to emulate instructions by default.

[Made commit, added commit msg - Oliver]
(cherry picked from commit 07721feee46b4b248402133228235318199b05ec)
---
 arch/x86/kvm/vmx/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/vmx/vmx.c +1 -1
index f6f98f7895bf..5e9c77c818a7 100644
@@ -7199,7 +7199,7 @@ static int vmx_check_intercept(struct kvm_vcpu *vcpu,
 	}
 
 	/* TODO: check more intercepts... */
-	return X86EMUL_CONTINUE;
+	return X86EMUL_UNHANDLEABLE;
 }
 
 #ifdef CONFIG_X86_64
Signature · 1 line
2.18.1
maintainer
#2 lore raw
Quoted 11 lines · Jon Maloy

From: Paolo Bonzini <[email protected]>

vmx_check_intercept is not yet fully implemented. To avoid emulating instructions disallowed by the L1 hypervisor, refuse to emulate instructions by default.

[Made commit, added commit msg - Oliver]
Quoted 5 lines
(cherry picked from commit 07721feee46b4b248402133228235318199b05ec)
---
 arch/x86/kvm/vmx/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Please fix your email system to not mail public people internal Red Hat-specific things :(