package: add rtty
PATCH 1/1 package: add rtty
--- package/Config.in | 1 + package/rtty/Config.in | 7 +++++++ package/rtty/rtty.hash | 2 ++ package/rtty/rtty.mk | 15 +++++++++++++++ 4 files changed, 25 insertions(+) create mode 100644 package/rtty/Config.in create mode 100644 package/rtty/rtty.hash create mode 100644 package/rtty/rtty.mk
package/Config.in +1 -0
@@ -2267,6 +2267,7 @@ comment "Utilities" source "package/pdmenu/Config.in" source "package/pinentry/Config.in" source "package/ranger/Config.in" + source "package/rtty/Config.in" source "package/screen/Config.in" source "package/sudo/Config.in" source "package/terminology/Config.in"
package/rtty/Config.in new file +7 -0
@@ -0,0 +1,7 @@ +config BR2_PACKAGE_RTTY + bool "rtty" + select BR2_PACKAGE_LIBEV + help + Access your device's terminal from anywhere via the web. + + https://github.com/zhaojh329/rtty
package/rtty/rtty.hash new file +2 -0
@@ -0,0 +1,2 @@ +sha256 6faafe75d82edbcfe154da5f1ffc0ddfd14dd88a2315f19aeed7f2631df96f41 rtty-7.1.2.tar.gz +sha256 99efed4bbc0b62f96f999ef23399e38234fb91651af734fd389a52b033a85b55 LICENCE
package/rtty/rtty.mk new file +15 -0
@@ -0,0 +1,15 @@ +################################################################################ +# +# rtty +# +################################################################################ + +RTTY_VERSION = 7.1.2 +LIBCURL_SOURCE = rtty-$(RTTY_VERSION).tar.gz +RTTY_SITE = https://github.com/zhaojh329/rtty/releases/download/v$(RTTY_VERSION) +RTTY_LICENSE = MIT +RTTY_LICENSE_FILES = LICENSE + +RTTY_DEPENDENCIES = libev + +$(eval $(cmake-package))
Signature · 1 line
2.17.1
PATCH 1/1 package: add rtty
Hi Jianhui,
Le 10/03/2020 ? 16:06, Jianhui Zhao a ?crit?:
Quoted 50 lines
Signed-off-by Jianhui Zhao <[email protected]>--- package/Config.in | 1 + package/rtty/Config.in | 7 +++++++ package/rtty/rtty.hash | 2 ++ package/rtty/rtty.mk | 15 +++++++++++++++ 4 files changed, 25 insertions(+) create mode 100644 package/rtty/Config.in create mode 100644 package/rtty/rtty.hash create mode 100644 package/rtty/rtty.mkpackage/Config.in +1
-0@@ -2267,6 +2267,7 @@ comment "Utilities" source "package/pdmenu/Config.in" source "package/pinentry/Config.in" source "package/ranger/Config.in" + source "package/rtty/Config.in" source "package/screen/Config.in" source "package/sudo/Config.in" source "package/terminology/Config.in"package/rtty/Config.in new file +7
-0@@ -0,0 +1,7 @@ +config BR2_PACKAGE_RTTY + bool "rtty" + select BR2_PACKAGE_LIBEV + help + Access your device's terminal from anywhere via the web. + + https://github.com/zhaojh329/rttypackage/rtty/rtty.hash new file +2
-0@@ -0,0 +1,2 @@ +sha256 6faafe75d82edbcfe154da5f1ffc0ddfd14dd88a2315f19aeed7f2631df96f41 rtty-7.1.2.tar.gz +sha256 99efed4bbc0b62f96f999ef23399e38234fb91651af734fd389a52b033a85b55 LICENCEpackage/rtty/rtty.mk new file +0
-0
package/rtty/rtty.mk line 8
Quoted 8 lines
package/rtty/rtty.mk new file +8
-0@@ -0,0 +1,15 @@ +################################################################################ +# +# rtty +# +################################################################################ + +RTTY_VERSION = 7.1.2 +LIBCURL_SOURCE = rtty-$(RTTY_VERSION).tar.gz
Wrong prefix.
package/rtty/rtty.mk line 13
Quoted 5 lines
package/rtty/rtty.mk new file +5
-0+RTTY_SITE = https://github.com/zhaojh329/rtty/releases/download/v$(RTTY_VERSION) +RTTY_LICENSE = MIT +RTTY_LICENSE_FILES = LICENSE + +RTTY_DEPENDENCIES = libev
What about optional dependencies: openssl, mbedtls, CyaSSl(wolfssl) ?
You can disable SSL support -DRTTY_SSL_SUPPORT=OFF for now and enable it in a second patch.
We do not recommend adding -Werror unconditionally [1] since rtty can be built by several compiler version and for several architecture.
Also it's not future proof since new compiler can generate new warnings.
Can you test your package using ./utils/test-pkg and ./utils/check-package
Also, add a new entry in DEVELOPERS file [3]
[1] https://github.com/zhaojh329/rtty/blob/master/src/CMakeLists.txt#L1
[2] http://nightly.buildroot.org/manual.html#_tips_and_tricks
[3] http://nightly.buildroot.org/manual.html#DEVELOPERS
Best regards,
Romain
Quoted 3 lines
package/rtty/rtty.mk new file +2
-0+ +$(eval $(cmake-package))
PATCH 1/1 package: add rtty
In reply to Jianhui ZhaoHello,
Quoted 1 line · On Tue, 10 Mar 2020 23:06:06 +0800 Jianhui Zhao <[email protected]> wrote:
Signed-off-by Jianhui Zhao <[email protected]>
Thanks for your contribution. I have applied your patch, after doing a number of changes. See below.
Quoted 6 lines
--- package/Config.in | 1 + package/rtty/Config.in | 7 +++++++ package/rtty/rtty.hash | 2 ++ package/rtty/rtty.mk | 15 +++++++++++++++ 4 files changed, 25 insertions(+)
You forgot to add an entry to the DEVELOPERS files, so I did that.
package/rtty/rtty.hash line 2
Quoted 8 lines
package/rtty/rtty.hash new file +2
-0@@ -0,0 +1,2 @@ +sha256 6faafe75d82edbcfe154da5f1ffc0ddfd14dd88a2315f19aeed7f2631df96f41 rtty-7.1.2.tar.gz +sha256 99efed4bbc0b62f96f999ef23399e38234fb91651af734fd389a52b033a85b55 LICENCE
The license file is named LICENSE (with an S) not LICENCE (with a C).
package/rtty/rtty.hash
Quoted 2 lines
package/rtty/rtty.hash new file +2
-0+RTTY_VERSION = 7.1.2 +LIBCURL_SOURCE = rtty-$(RTTY_VERSION).tar.gz
Wrong prefix, this variable was not needed anyway, so I dropped it.
package/rtty/rtty.hash
Quoted 5 lines
package/rtty/rtty.hash new file +5
-0+RTTY_SITE = https://github.com/zhaojh329/rtty/releases/download/v$(RTTY_VERSION) +RTTY_LICENSE = MIT +RTTY_LICENSE_FILES = LICENSE + +RTTY_DEPENDENCIES = libev
As suggested by Romain Naour, I've added -DRTTY_SSL_SUPPORT=OFF, and then did a follow-up commit to add optional support for SSL.
You will receive e-mail notifications if there are build failures for the rtty package. If there are build failures, it would be nice if you could investigate them, and provide fixes.
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com