mx6cuboxi: don't disable fdt relocation
PATCH 1/1 mx6cuboxi: don't disable fdt relocation
fdt_high value of 0xffffffff disables fdt relocation on boot. We don't need that for Cubox-i/Hummingboard. Rely on generic code to find the optimal fdt location at boot time.
--- include/configs/mx6cuboxi.h | 1 - 1 file changed, 1 deletion(-)
include/configs/mx6cuboxi.h +0 -1
@@ -66,7 +66,6 @@"ramdisk_addr_r=0x13000000\0" \"ramdiskaddr=0x13000000\0" \"initrd_high=0xffffffff\0" \ -"fdt_high=0xffffffff\0" \"ip_dyn=yes\0" \"console=" CONSOLE_DEV ",115200\0" \"bootm_size=0x10000000\0" \
Signature · 1 line
2.24.1
PATCH 1/1 mx6cuboxi: don't disable fdt relocation
Hi Baruch,
Quoted 15 lines · Baruch Siach
fdt_highvalue of0xffffffffdisables fdt relocation on boot. We don't need that for Cubox-i/Hummingboard. Rely on generic code to find the optimal fdt location at boot time.Signed-off-by Baruch Siach <[email protected]>--- include/configs/mx6cuboxi.h | 1 - 1 file changed, 1 deletion(-)include/configs/mx6cuboxi.h +0
-0
include/configs/mx6cuboxi.h line 71
Quoted 7 lines
include/configs/mx6cuboxi.h +0
-1@@ -66,7 +66,6 @@"ramdisk_addr_r=0x13000000\0" \"ramdiskaddr=0x13000000\0" \"initrd_high=0xffffffff\0" \ -"fdt_high=0xffffffff\0" \"ip_dyn=yes\0" \"console=" CONSOLE_DEV ",115200\0" \"bootm_size=0x10000000\0" \
Maybe initrd_high could also be removed?
PATCH 1/1 mx6cuboxi: don't disable fdt relocation
Quoted 13 lines · Fabio Estevam
Hi Baruch,
Quoted 10 lines · Baruch Siach
fdt_highvalue of0xffffffffdisables fdt relocation on boot. We don't need that for Cubox-i/Hummingboard. Rely on generic code to find the optimal fdt location at boot time.Signed-off-by Baruch Siach <[email protected]>--- include/configs/mx6cuboxi.h | 1 - 1 file changed, 1 deletion(-)
Quoted 14 lines
include/configs/mx6cuboxi.h line 71
Quoted 12 lines
include/configs/mx6cuboxi.h +0
-1@@ -66,7 +66,6 @@"ramdisk_addr_r=0x13000000\0" \"ramdiskaddr=0x13000000\0" \"initrd_high=0xffffffff\0" \ -"fdt_high=0xffffffff\0" \"ip_dyn=yes\0" \"console=" CONSOLE_DEV ",115200\0" \"bootm_size=0x10000000\0" \Maybe
initrd_highcould also be removed?
In general, it's not as dangerous to not move it, so long as the rest of the addresses in use are reasonable. Whereas if the FDT isn't 8 byte aligned (but only say 4) on arm64 everything blows up, and initrd:
"must reside entirely within a 1 GB aligned physical memory window of up to 32 GB in size that fully covers the kernel Image as well."
So it's less risky to let it be. Also, while relocating the DTB is usually very quick (being kilobytes in size) initrds are megabytes.
All that said, no, I don't object too initrd_high=0xffffffff being removed everywhere maintainers are happy with the trade-offs of doing so.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200204/2712fe9c/attachment.sig>
PATCH 1/1 mx6cuboxi: don't disable fdt relocation
In reply to Baruch SiachQuoted 4 lines
fdt_highvalue of0xffffffffdisables fdt relocation on boot. We don't need that for Cubox-i/Hummingboard. Rely on generic code to find the optimal fdt location at boot time.Signed-off-by Baruch Siach <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================