blk-iocost: fix incorrect vtime comparison in iocg_is_idle()
Subsystems (2)
Tejun Heo
maintainerPATCH 1/1 blk-iocost: fix incorrect vtime comparison in iocg_is_idle()
vtimes may wrap and time_before/after64() should be used to determine whether a given vtime is before or after another. iocg_is_idle() was incorrectly using plain "<" comparison do determine whether done_vtime is before vtime. Here, the only thing we're interested in is whether done_vtime matches vtime which indicates that there's nothing in flight. Let's test for inequality instead.
--- block/blk-iocost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-iocost.c +1 -1
@@ -1318,7 +1318,7 @@ static bool iocg_is_idle(struct ioc_gq *iocg)return false;/* is something in flight? */ -if (atomic64_read (&iocg->done_vtime) <atomic64_read (&iocg->vtime)) +if (atomic64_read (&iocg->done_vtime) !=atomic64_read (&iocg->vtime))return false;return true;
Quoted 6 lines · Tejun Heo
vtimes may wrap and time_before/after64() should be used to determine whether a given vtime is before or after another.
iocg_is_idle()was incorrectly using plain "<" comparison do determine whetherdone_vtimeis before vtime. Here, the only thing we're interested in is whetherdone_vtimematches vtime which indicates that there's nothing in flight. Let's test for inequality instead.
Applied, thanks.
Signature · 1 line
Jens Axboe