Skip to contentSkip to conversation

staging: vt6655: remove line over 80 characters

PATCH In review Payal Kshirsagar 2 participants 2 messages Mar 10, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: vt6655: remove line over 80 characters

Reformatting code to not have lines over 80 characters.

---
v3: Change in patch description.

 drivers/staging/vt6655/mac.h | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/staging/vt6655/mac.h +6 -3
index c7888c4e96f2..eb56e16637f6 100644
@@ -884,9 +884,11 @@ bool MACbIsIntDisable(struct vnt_private *priv);
 void MACvSetShortRetryLimit(struct vnt_private *priv,
 			    unsigned char byRetryLimit);
 
-void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
+void MACvSetLongRetryLimit(struct vnt_private *priv,
+			   unsigned char byRetryLimit);
 
-void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
+void MACvSetLoopbackMode(struct vnt_private *priv,
+			 unsigned char byLoopbackMode);
 
 void MACvSaveContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
 void MACvRestoreContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
@@ -913,7 +915,8 @@ void MACvSetCurrSyncDescAddrEx(struct vnt_private *priv,
 void MACvSetCurrATIMDescAddrEx(struct vnt_private *priv,
 			       u32 curr_desc_addr);
 void MACvTimer0MicroSDelay(struct vnt_private *priv, unsigned int uDelay);
-void MACvOneShotTimer1MicroSec(struct vnt_private *priv, unsigned int uDelayTime);
+void MACvOneShotTimer1MicroSec(struct vnt_private *priv,
+			       unsigned int uDelayTime);
 
 void MACvSetMISCFifo(struct vnt_private *priv, unsigned short wOffset,
 		     u32 dwData);
Signature · 1 line
2.17.1
#1 lore raw

Payal,

Quoted 1 line · On Tue, 10 Mar 2020 18:02:28 +0530 Payal Kshirsagar…

Reformatting code to not have lines over 80 characters.

The change looks good, but the subject (that is, the commit title) still doesn't match the contents of the change. You're not removing, and it's not a single line.

Also,

Quoted 3 lines

---
v3: Change in patch description.

This should be cumulative, that is:

v4: < you know what :) >
v3: Change in patch
v2: < changes you listed for v2 >

Otherwise, reviewers and maintainers will have a hard time tracking your submissions. Thanks,

Signature · 1 line
Stefano