net: dsa: mt7530: fix macro MIRROR_PORT
Subsystems (5)
PATCH 1/1 net: dsa: mt7530: fix macro MIRROR_PORT
The inner pair of parentheses should be around the variable x
--- drivers/net/dsa/mt7530.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/mt7530.h +1 -1
@@ -37,7 +37,7 @@ enum {#define CPU_PORT (x) ((x) << 4)#define CPU_MASK (0xf << 4)#define MIRROR_EN BIT(3) -#define MIRROR_PORT (x) ((x & 0x7)) +#define MIRROR_PORT (x) ((x) & 0x7)#define MIRROR_MASK 0x7/* Registers for address table access */
Signature · 1 line
2.25.1
From: DENG Qingfang <[email protected]>
Date: Wed, 11 Mar 2020 02:20:50 +0800
Quoted 4 lines
The inner pair of parentheses should be around the variable x
Fixes 37feab6076aa ("net: dsa: mt7530: add support for port mirroring")Signed-off-by DENG Qingfang <[email protected]>
Two things:
1) In the Subject line always indicate the target tree for your changes. This case would be net-next since that is the only tree where the
Fixes: tag commit exists, thus "Subject: [PATCH net-next] ..."
2) Always group the various tags together into a contiguous series of lines of text, starting the the Fixes tag. Make sure there is an empty line between the commit message description text, and the tags.
I fixes it up for you this time, but next time I will not and push back for you to fix it up yourself.
Applied to net-next, thank you.