Skip to contentSkip to conversation

remoteproc: k3-r5: Fix rproc init failure for Main R5FSS0

PATCH New Suman Anna 2 participants 2 messages Mar 10, 2020 – Mar 16, 2020 Remote processor (remoteproc)

lore
Share & tools
lore

Suman Anna

author
#0 lore raw

PATCH 1/1 remoteproc: k3-r5: Fix rproc init failure for Main R5FSS0

The Main R5FSS0 cluster is also enabled to probe the R5F remoteproc driver within R5 SPL for booting the Core0 very early. This results in a ti_sci_power_domain_on failure during the probe from the A72 U-Boot when "rproc init" is executed at U-Boot prompt, and doesn't enumerate all the rproc devices.

Fix this by suppressing the power_domain_on altogether using the flag DM_FLAG_DEFAULT_PD_CTRL_OFF added in commit af94ad418dc7 ("dm: core: Allow for not controlling the power-domain by DM framework").

Fixes fac6aa817a09 ("configs: j721e_evm_r5: Enable R5F remoteproc support")

---
Hi Lokesh,

The recently staged R5 SPL remoteproc boot support causes the rproc init command to fail on U-Boot prompt. This is a fix for the same. Patch is against ti/next branch.

regards
Suman

 drivers/remoteproc/ti_k3_r5f_rproc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/remoteproc/ti_k3_r5f_rproc.c +1 -0
index ea56689552aa..2e2665f3750d 100644
@@ -816,4 +816,5 @@ U_BOOT_DRIVER(k3_r5fss) = {
 	.id = UCLASS_MISC,
 	.probe = k3_r5f_cluster_probe,
 	.priv_auto_alloc_size = sizeof(struct k3_r5f_cluster),
+	.flags = DM_FLAG_DEFAULT_PD_CTRL_OFF,
 };
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 remoteproc: k3-r5: Fix rproc init failure for Main R5FSS0

Quoted 10 lines · Suman Anna

The Main R5FSS0 cluster is also enabled to probe the R5F remoteproc driver within R5 SPL for booting the Core0 very early. This results in a ti_sci_power_domain_on failure during the probe from the A72 U-Boot when "rproc init" is executed at U-Boot prompt, and doesn't enumerate all the rproc devices.

Fix this by suppressing the power_domain_on altogether using the flag DM_FLAG_DEFAULT_PD_CTRL_OFF added in commit af94ad418dc7 ("dm: core: Allow for not controlling the power-domain by DM framework").

Quoted 8 lines
Fixes fac6aa817a09 ("configs: j721e_evm_r5: Enable R5F remoteproc support")

---
Hi Lokesh,

The recently staged R5 SPL remoteproc boot support causes the rproc init command to fail on U-Boot prompt. This is a fix for the same. Patch is against ti/next branch.

Applied to u-boot-ti/next

Thanks and regards,
Lokesh