net: caif: Add lockdep expression to RCU traversal primitive
Subsystems (2)
PATCH 1/1 net: caif: Add lockdep expression to RCU traversal primitive
caifdevs->list is traversed using list_for_each_entry_rcu() outside an RCU read-side critical section but under the protection of rtnl_mutex. Hence, add the corresponding lockdep expression to silence the following false-positive warning:
[ 10.868467] ============================= [ 10.869082] WARNING: suspicious RCU usage [ 10.869817] 5.6.0-rc1-00177-g06ec0a154aae4 #1 Not tainted [ 10.870804] ----------------------------- [ 10.871557] net/caif/caif_dev.c:115 RCU-list traversed in non-reader section!!
Reported-by kernel test robot <[email protected]>
Signed-off-by Amol Grover <[email protected]>
--- net/caif/caif_dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/caif/caif_dev.c +2 -1
@@ -112,7 +112,8 @@ static struct caif_device_entry *caif_get(struct net_device *dev)caif_device_list (dev_net (dev));struct caif_device_entry *caifd; -list_for_each_entry_rcu (caifd, &caifdevs->list, list) { +list_for_each_entry_rcu (caifd, &caifdevs->list, list, +lockdep_rtnl_is_held ()) {if (caifd->netdev == dev)return caifd; }
Signature · 6 lines
2.25.1 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
From: Amol Grover <[email protected]>
Date: Thu, 12 Mar 2020 11:04:20 +0530
Quoted 5 lines
caifdevs->listis traversed usinglist_for_each_entry_rcu()outside an RCU read-side critical section but under the protection ofrtnl_mutex. Hence, add the corresponding lockdep expression to silence the following false-positive warning:
Quoted 8 lines
[ 10.868467] ============================= [ 10.869082] WARNING: suspicious RCU usage [ 10.869817] 5.6.0-rc1-00177-g06ec0a154aae4 #1 Not tainted [ 10.870804] ----------------------------- [ 10.871557] net/caif/caif_dev.c:115 RCU-list traversed in non-reader section!!Reported-by kernel test robot <[email protected]>Signed-off-by Amol Grover <[email protected]>
Applied, thank you.