block: aoe: Use scnprintf() for avoiding potential buffer overflow
Subsystems (2)
PATCH 1/1 block: aoe: Use scnprintf() for avoiding potential buffer overflow
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf().
Signed-off-by Takashi Iwai <[email protected]>
--- drivers/block/aoe/aoeblk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/block/aoe/aoeblk.c +2 -2
@@ -87,9 +87,9 @@ static ssize_t aoedisk_show_netif(struct device *dev,if (*nd ==NULL )return snprintf (page,PAGE_SIZE ,"none\n" );for (p = page; nd < ne; nd++) - p +=snprintf (p,PAGE_SIZE - (p-page),"%s%s" , + p +=scnprintf (p,PAGE_SIZE - (p-page),"%s%s" , p == page ?"" :"," , (*nd)->name); - p +=snprintf (p,PAGE_SIZE - (p-page),"\n" ); + p +=scnprintf (p,PAGE_SIZE - (p-page),"\n" );return p-page; }/* firmware version */
Signature · 1 line
2.16.4
Jens Axboe
maintainerQuoted 3 lines · Takashi Iwai
Since
snprintf()returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing withscnprintf().
Applied for 5.7, thanks.
Signature · 1 line
Jens Axboe