Skip to contentSkip to conversation

dmaengine: ppc4xx: Use scnprintf() for avoiding potential buffer overflow

PATCH Applied Takashi Iwai 2 participants 2 messages Mar 11, 2020 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: ppc4xx: Use scnprintf() for avoiding potential buffer overflow

Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf().

---
 drivers/dma/ppc4xx/adma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/ppc4xx/adma.c +1 -1
index fbabd2e88a18..4db000d5f01c 100644
@@ -4303,7 +4303,7 @@ static ssize_t devices_show(struct device_driver *dev, char *buf)
 	for (i = 0; i < PPC440SPE_ADMA_ENGINES_NUM; i++) {
 		if (ppc440spe_adma_devices[i] == -1)
 			continue;
-		size += snprintf(buf + size, PAGE_SIZE - size,
+		size += scnprintf(buf + size, PAGE_SIZE - size,
 				 "PPC440SP(E)-ADMA.%d: %s\n", i,
 				 ppc_adma_errors[ppc440spe_adma_devices[i]]);
 	}
Signature · 1 line
2.16.4
maintainer Applied
#1 lore raw
Quoted 3 lines · Takashi Iwai

Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf().

Applied, thanks

Signature · 1 line
~Vinod