Skip to contentSkip to conversation

remove unnecessary newline for brace

PATCH In review Enrique Vargas 3 participants 4 messages Mar 11, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove unnecessary newline for brace

put brace at the end of line following coding conventions

---
 drivers/atm/adummy.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/atm/adummy.c +1 -2
index 8157925af824..6eeaa1b21f3b 100644
@@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
 	return 0;
 }
 
-static const struct atmdev_ops adummy_ops =
-{
+static const struct atmdev_ops adummy_ops = {
 	.open =		adummy_open,
 	.close =	adummy_close,	
 	.send =		adummy_send,
Signature · 1 line
2.17.1
#1 lore raw

The subject line should give information about what part of the kernel is being changed. See other patches or the tutorial for examples.

Quoted 5 lines · Enrique Vargas

put brace at the end of line following coding conventions

---
 drivers/atm/adummy.c | 3 +--

Is there a reason why you are working on drivers/atm? Normally for the application period you should only do cleanups on drivers/staging.

julia

Quoted 24 lines
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/atm/adummy.c +1 -3
index 8157925af824..6eeaa1b21f3b 100644
@@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
 	return 0;
 }
 
-static const struct atmdev_ops adummy_ops =
-{
+static const struct atmdev_ops adummy_ops = {
 	.open =		adummy_open,
 	.close =	adummy_close,
 	.send =		adummy_send,
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200311125507.GA9347%40evX1.

#2 lore raw
In reply to Enrique Vargas
Quoted 24 lines · Enrique Vargas

put brace at the end of line following coding conventions

---
 drivers/atm/adummy.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/atm/adummy.c +1 -2
index 8157925af824..6eeaa1b21f3b 100644
@@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
 	return 0;
 }
 
-static const struct atmdev_ops adummy_ops =
-{
+static const struct atmdev_ops adummy_ops = {
 	.open =		adummy_open,
 	.close =	adummy_close,	
 	.send =		adummy_send,
Signature · 1 line
2.17.1

This is an outreachy application patch? You need to do work in drivers/staging/ only. Also, the iio mailing list is not the correct one at all.

greg k-h

#3 lore raw

Sorry, I will pickup a driver from drivers/staging

For the mailing list I misunderstood this comment in the tutorial:  ....However, for IIO drivers, please also include [email protected]....

Quoted 30 lines · Greg KH
Quoted 24 lines · Enrique Vargas

put brace at the end of line following coding conventions

---
 drivers/atm/adummy.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/atm/adummy.c +1 -2
index 8157925af824..6eeaa1b21f3b 100644
@@ -131,8 +131,7 @@ adummy_proc_read(struct atm_dev *dev, loff_t *pos, char *page)
 	return 0;
 }
 
-static const struct atmdev_ops adummy_ops =
-{
+static const struct atmdev_ops adummy_ops = {
 	.open =		adummy_open,
 	.close =	adummy_close,	
 	.send =		adummy_send,
Signature · 1 line
2.17.1

This is an outreachy application patch? You need to do work in drivers/staging/ only. Also, the iio mailing list is not the correct one at all.

greg k-h