staging: sm750fb: makefile variable longline fix
Subsystems (2)
PATCH 1/1 staging: sm750fb: makefile variable longline fix
A simple makefile variable longline definition fix
--- drivers/staging/sm750fb/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/Makefile +4 -2
@@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_FB_SM750) += sm750fb.o -sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o -sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o +sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o +sm750fb-objs += ddk750_chip.o ddk750_power.o ddk750_mode.o +sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o +sm750fb-objs += ddk750_dvi.o ddk750_hwi2c.o
Signature · 1 line
2.20.1
Hi Veera,
Thanks, this mostly looks good, in general. A few notes:
- the commit title is typically in an imperative form, that is, for example, "[...]: Fix long line in Makefile variable"
Also,
Quoted 1 line · On Wed, 11 Mar 2020 18:41:02 +0530 R Veera Kumar <[email protected]> wrote:
A simple makefile variable longline definition fix
It would be nice to also mention if you used a tool to find this.
Quoted 11 lines
Signed-off-by R Veera Kumar <[email protected]>--- drivers/staging/sm750fb/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/staging/sm750fb/Makefile +0
-0
drivers/staging/sm750fb/Makefile line 7
Quoted 9 lines
drivers/staging/sm750fb/Makefile +4
-2@@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_FB_SM750) += sm750fb.o -sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o -sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o +sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o +sm750fb-objs += ddk750_chip.o ddk750_power.o ddk750_mode.o +sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o +sm750fb-objs += ddk750_dvi.o ddk750_hwi2c.o
...and while this fixes the long lines for sure, a more common way is to use backslashes at the end of the lines. Compare it with other similar cases: you don't need to do something like:
drivers/staging/wfx/Makefile
but what's done for example in:
drivers/staging/comedi/Makefile
looks appropriate here (using 3 or 4 lines I guess).
If you send another version of this patch, don't forget to indicate that under "---", see recent discussions on the outreachy-kernel list for examples.
Signature · 1 line
Stefano
Quoted 42 lines · Stefano Brivio
Hi Veera,
Thanks, this mostly looks good, in general. A few notes:
- the commit title is typically in an imperative form, that is, for example, "[...]: Fix long line in
Makefilevariable"Also,
Quoted 1 line · On Wed, 11 Mar 2020 18:41:02 +0530 R Veera Kumar <[email protected]> wrote:
A simple makefile variable longline definition fix
It would be nice to also mention if you used a tool to find this.
Quoted 11 lines
Signed-off-by R Veera Kumar <[email protected]>--- drivers/staging/sm750fb/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/staging/sm750fb/Makefile +0
-0drivers/staging/sm750fb/Makefile line 7
Quoted 9 lines
drivers/staging/sm750fb/Makefile +4
-2@@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_FB_SM750) += sm750fb.o -sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o -sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o +sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o +sm750fb-objs += ddk750_chip.o ddk750_power.o ddk750_mode.o +sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o +sm750fb-objs += ddk750_dvi.o ddk750_hwi2c.o...and while this fixes the long lines for sure, a more common way is to use backslashes at the end of the lines. Compare it with other similar cases: you don't need to do something like:
drivers/staging/wfx/Makefile
Quoted 3 lines
but what's done for example in:
drivers/staging/comedi/Makefile
Yes. I knew it. But thought preserving maintainer style may be right.
Quoted 6 lines
looks appropriate here (using 3 or 4 lines I guess).
If you send another version of this patch, don't forget to indicate that under "---", see recent discussions on the outreachy-kernel list for examples.
I note
Quoted 2 lines
Stefano
Regards,
Veera
Quoted 17 lines · On Thu, 12 Mar 2020 06:44:46 +0530 Veera <[email protected]> wrote:
Quoted 16 lines · Stefano Brivio
drivers/staging/sm750fb/Makefile line 7
Quoted 6 lines · On Wed, 11 Mar 2020 18:41:02 +0530 R Veera Kumar <[email protected]> wrote:
drivers/staging/sm750fb/Makefile +4
-2-sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o -sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o +sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o +sm750fb-objs += ddk750_chip.o ddk750_power.o ddk750_mode.o +sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o +sm750fb-objs += ddk750_dvi.o ddk750_hwi2c.o...and while this fixes the long lines for sure, a more common way is to use backslashes at the end of the lines. Compare it with other similar cases: you don't need to do something like:
drivers/staging/wfx/Makefile
Quoted 5 lines
Quoted 3 lines
but what's done for example in:
drivers/staging/comedi/MakefileYes. I knew it. But thought preserving maintainer style may be right.
As a general rule, absolutely, but I wonder if we can even define a "style" here at all. It's also the single occurrence of this, in this file, and for this driver altogether.
Signature · 1 line
Stefano