Staging: qlge: include newline after declarations
PATCH 1/1 Staging: qlge: include newline after declarations
add newline following coding conventions
--- drivers/staging/qlge/qlge_dbg.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/qlge/qlge_dbg.c +1 -0
@@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) {int i;u32 value; +for (i =0 ; i < qdev->intr_count; i++) {ql_write32 (qdev,INTR_EN , qdev->intr_context[i].intr_read_mask); value =ql_read32 (qdev,INTR_EN );
Signature · 1 line
2.17.1
Quoted 1 line · Enrique Vargas
add newline following coding conventions
The patch seems conceptually fine. But it would be nice to make a proper sentence, ie start with a capital letter and end with a period. Also, if checkpatch helped you find the problem, it could be good to acknowledge that.
julia
Quoted 26 lines
Signed-off-by Enrique Vargas <[email protected]>--- drivers/staging/qlge/qlge_dbg.c | 1 + 1 file changed, 1 insertion(+)drivers/staging/qlge/qlge_dbg.c +1
-1@@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) {int i;u32 value; +for (i =0 ; i < qdev->intr_count; i++) {ql_write32 (qdev,INTR_EN , qdev->intr_context[i].intr_read_mask); value =ql_read32 (qdev,INTR_EN ); --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200311141857.GA16781%40evX1.
Quoted 31 lines · Julia Lawall
Quoted 1 line · Enrique Vargas
add newline following coding conventions
The patch seems conceptually fine. But it would be nice to make a proper sentence, ie start with a capital letter and end with a period. Also, if checkpatch helped you find the problem, it could be good to acknowledge that.
julia
Quoted 20 lines
Signed-off-by Enrique Vargas <[email protected]>--- drivers/staging/qlge/qlge_dbg.c | 1 + 1 file changed, 1 insertion(+)drivers/staging/qlge/qlge_dbg.c +1
-1@@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) {int i;u32 value; +for (i =0 ; i < qdev->intr_count; i++) {ql_write32 (qdev,INTR_EN , qdev->intr_context[i].intr_read_mask); value =ql_read32 (qdev,INTR_EN ); --2.17.1
Quoted 5 lines
Quoted 5 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200311141857.GA16781%40evX1.
Thanks for the feedback, resending with your comments.