Skip to contentSkip to conversation

selftests/bpf: guarantee that useep() calls nanosleep() syscall

PATCH Applied Andrii Nakryiko 2 participants 2 messages Mar 11, 2020 – Mar 13, 2020

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: guarantee that useep() calls nanosleep() syscall

Some implementations of C runtime library won't call nanosleep() syscall from usleep(). But a bunch of kprobe/tracepoint selftests rely on nanosleep being called to trigger them. To make this more reliable, "override" usleep implementation and call nanosleep explicitly.

---
 tools/testing/selftests/bpf/test_progs.c | 9 +++++++++
 1 file changed, 9 insertions(+)
tools/testing/selftests/bpf/test_progs.c +9 -0
index a969c77e9456..2b0bc1171c9c 100644
@@ -29,6 +29,15 @@ struct prog_test_def {
 	int old_error_cnt;
 };
 
+/* Override C runtime library's usleep() implementation to ensure nanosleep()
+ * is always called. Usleep is frequently used in selftests as a way to
+ * trigger kprobe and tracepoints.
+ */
+int usleep(useconds_t usec)
+{
+	return syscall(__NR_nanosleep, usec * 1000UL);
+}
+
 static bool should_run(struct test_selector *sel, int num, const char *name)
 {
 	int i;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 8 lines · Andrii Nakryiko

Some implementations of C runtime library won't call nanosleep() syscall from usleep(). But a bunch of kprobe/tracepoint selftests rely on nanosleep being called to trigger them. To make this more reliable, "override" usleep implementation and call nanosleep explicitly.

Applied. Thanks