firmware: qcom_scm: add ipq806x with no clock
Subsystems (2)
PATCH 1/2 firmware: qcom_scm: add ipq806x with no clock
ipq806x rpm definition was missing for a long time. Add this to make this soc support rpm.
--- drivers/firmware/qcom_scm.c | 1 + 1 file changed, 1 insertion(+)
drivers/firmware/qcom_scm.c +1 -0
@@ -1144,6 +1144,7 @@ static const struct of_device_id qcom_scm_dt_match[] = { SCM_HAS_BUS_CLK) }, { .compatible = "qcom,scm-ipq4019" }, + { .compatible = "qcom,scm-ipq806x" }, { .compatible = "qcom,scm-msm8660", .data = (void *) SCM_HAS_CORE_CLK }, { .compatible = "qcom,scm-msm8960", .data = (void *) SCM_HAS_CORE_CLK }, { .compatible = "qcom,scm-msm8916", .data = (void *)(SCM_HAS_CORE_CLK |
Signature · 1 line
2.25.0
PATCH 2/2 devicetree: bindings: firmware: add ipq806x to qcom_scm
Add ipq806x to compatible list in qcom_scm Documentation
--- Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/firmware/qcom,scm.txt +1 -0
@@ -10,6 +10,7 @@ Required properties: * "qcom,scm-apq8064" * "qcom,scm-apq8084" * "qcom,scm-ipq4019" + * "qcom,scm-ipq806x" * "qcom,scm-msm8660" * "qcom,scm-msm8916" * "qcom,scm-msm8960"
Signature · 1 line
2.25.0
Bjorn Andersson
AppliedQuoted 3 lines · Ansuel Smith
ipq806x rpm definition was missing for a long time. Add this to make this soc support rpm.
I merged the dt-binding patch, but please update dts to use:
compatible = "qcom,scm-ipq806x", "qcom,scm";
instead of adding the platform specific compatible in the driver.
Regards,
Bjorn
Quoted 20 lines
Signed-off-by Ansuel Smith <[email protected]>--- drivers/firmware/qcom_scm.c | 1 + 1 file changed, 1 insertion(+)drivers/firmware/qcom_scm.c +1
-0@@ -1144,6 +1144,7 @@ static const struct of_device_id qcom_scm_dt_match[] = { SCM_HAS_BUS_CLK) }, { .compatible = "qcom,scm-ipq4019" }, + { .compatible = "qcom,scm-ipq806x" }, { .compatible = "qcom,scm-msm8660", .data = (void *) SCM_HAS_CORE_CLK }, { .compatible = "qcom,scm-msm8960", .data = (void *) SCM_HAS_CORE_CLK }, { .compatible = "qcom,scm-msm8916", .data = (void *)(SCM_HAS_CORE_CLK |Signature · 1 line
2.25.0
R: [PATCH 1/2] firmware: qcom_scm: add ipq806x with no clock
Quoted 6 lines · Ansuel Smith
Quoted 4 lines
ipq806x rpm definition was missing for a long time. Add this to make this soc support rpm.
Quoted 8 lines
I merged the dt-binding patch, but please update dts to use:
compatible = "qcom,scm-ipq806x", "qcom,scm";instead of adding the platform specific compatible in the driver.
Regards,
Bjorn
Should I drop the added compatible in qcom_scm.c or just keep it and add the definition in the ipq806x dts?
Quoted 26 lines
Review
Quoted 6 lines
Signed-off-by Ansuel Smith <[email protected]>--- drivers/firmware/qcom_scm.c | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/firmware/qcom_scm.cdrivers/firmware/qcom_scm.c static const struct of_device_id
Quoted 4 lines
index
059bb0fbae9e..d13ef3cd8cf5100644drivers/firmware/qcom_scm.c +0
-0@@ -1144,6 +1144,7 @@ static const struct of_device_idqcom_scm_dt_match[] = {
Quoted 1 line
SCM_HAS_BUS_CLK)drivers/firmware/qcom_scm.c static const struct of_device_id qcom_scm_dt_match[] = {
Quoted 4 lines
drivers/firmware/qcom_scm.c +1
-0}, { .compatible = "qcom,scm-ipq4019" }, + { .compatible = "qcom,scm-ipq806x" }, { .compatible = "qcom,scm-msm8660", .data = (void *)
SCM_HAS_CORE_CLK},Quoted 1 line
{ .compatible = "qcom,scm-msm8960", .data = (void *)
SCM_HAS_CORE_CLK},Quoted 1 line
{ .compatible = "qcom,scm-msm8916", .data = (void
*)(SCM_HAS_CORE_CLK |
Quoted 3 lines
--
2.25.0