Skip to contentSkip to conversation

monitor: Fix for incorrect len in L2CAP Enhanced Reconfigure

PATCH Applied Łukasz Rymanowski 2 participants 2 messages Mar 12, 2020 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 monitor: Fix for incorrect len in L2CAP Enhanced Reconfigure

---
 monitor/l2cap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
monitor/l2cap.c +2 -2
index 9409604c3..41c766863 100644
@@ -1408,7 +1408,7 @@ static void sig_ecred_conn_rsp(const struct l2cap_frame *frame)
 	const struct bt_l2cap_pdu_ecred_conn_rsp *pdu = frame->data;
 	uint16_t dcid;
 
-	l2cap_frame_pull((void *)frame, frame, sizeof(pdu));
+	l2cap_frame_pull((void *)frame, frame, sizeof(*pdu));
 
 	print_field("MTU: %u", le16_to_cpu(pdu->mtu));
 	print_field("MPS: %u", le16_to_cpu(pdu->mps));
@@ -1426,7 +1426,7 @@ static void sig_ecred_reconf_req(const struct l2cap_frame *frame)
 	const struct bt_l2cap_pdu_ecred_reconf_req *pdu = frame->data;
 	uint16_t scid;
 
-	l2cap_frame_pull((void *)frame, frame, sizeof(pdu));
+	l2cap_frame_pull((void *)frame, frame, sizeof(*pdu));
 
 	print_field("MTU: %u", le16_to_cpu(pdu->mtu));
 	print_field("MPS: %u", le16_to_cpu(pdu->mps));
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw

Hi Łukasz,

Quoted 28 lines · Łukasz Rymanowski
---
 monitor/l2cap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
monitor/l2cap.c +2 -3
index 9409604c3..41c766863 100644
@@ -1408,7 +1408,7 @@ static void sig_ecred_conn_rsp(const struct l2cap_frame *frame)
        const struct bt_l2cap_pdu_ecred_conn_rsp *pdu = frame->data;
        uint16_t dcid;
 
-       l2cap_frame_pull((void *)frame, frame, sizeof(pdu));
+       l2cap_frame_pull((void *)frame, frame, sizeof(*pdu));
 
        print_field("MTU: %u", le16_to_cpu(pdu->mtu));
        print_field("MPS: %u", le16_to_cpu(pdu->mps));
@@ -1426,7 +1426,7 @@ static void sig_ecred_reconf_req(const struct l2cap_frame *frame)
        const struct bt_l2cap_pdu_ecred_reconf_req *pdu = frame->data;
        uint16_t scid;
 
-       l2cap_frame_pull((void *)frame, frame, sizeof(pdu));
+       l2cap_frame_pull((void *)frame, frame, sizeof(*pdu));
 
        print_field("MTU: %u", le16_to_cpu(pdu->mtu));
        print_field("MPS: %u", le16_to_cpu(pdu->mps));
--
Quoted 1 line

2.20.1

Applied, thanks.

Signature · 1 line
Luiz Augusto von Dentz