Skip to contentSkip to conversation

Staging: qlge: include newline after declarations

PATCH In review Enrique Vargas 3 participants 3 messages Mar 11, 2020 – Mar 12, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: qlge: include newline after declarations

Add newline following coding conventions, to eliminate WARNING found using checkpath.

---
 drivers/staging/qlge/qlge_dbg.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/qlge/qlge_dbg.c +1 -0
index 670361873d1d..52704c67e110 100644
@@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
 {
 	int i;
 	u32 value;
+
 	for (i = 0; i < qdev->intr_count; i++) {
 		ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
 		value = ql_read32(qdev, INTR_EN);
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Enrique Vargas

Add newline following coding conventions, to eliminate WARNING found using checkpath.

---
 drivers/staging/qlge/qlge_dbg.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/qlge/qlge_dbg.c +0 -0
index 670361873d1d..52704c67e110 100644

drivers/staging/qlge/qlge_dbg.c static void ql_dump_intr_states(struct ql_adapter *qdev) · line 1338

Quoted 7 lines
drivers/staging/qlge/qlge_dbg.c +1 -0
@@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
 {
 	int i;
 	u32 value;
+
 	for (i = 0; i < qdev->intr_count; i++) {
 		ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
 		value = ql_read32(qdev, INTR_EN);

It looks better now, thanks.

Quoted 8 lines

--
2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200311142836.GA17614%40evX1.

#2 lore raw
In reply to Enrique Vargas
Quoted 7 lines · Enrique Vargas

Add newline following coding conventions, to eliminate WARNING found using checkpath.

---
 drivers/staging/qlge/qlge_dbg.c | 1 +
 1 file changed, 1 insertion(+)

As this is a "version 2" of the patch, you need to tell me that somehow. Please read the submitting patches document in the kernel Documentation directory for how to do that properly.

Please fix up and send a v3.

thanks,

greg k-h