Bluetooth: print fw build version in power-on boot

PATCH Superseded Amit K Bag 2 participants 2 messages Mar 12, 2020 Bluetooth drivers

lore

Share & tools

lore

Amit K Bag

author

2020-03-12 10:21 UTC #0 lore raw

PATCH 1/1 Bluetooth: print fw build version in power-on boot

From: Sukumar Ghorai <[email protected]>

To determine the build version of Bluetooth firmware to ensure reported issue related to a particular release. This is very helpful for every fw downloaded to BT controller and issue reported from field test.

Signed-off-by Amit K Bag <[email protected]>

---
 drivers/bluetooth/btusb.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

drivers/bluetooth/btusb.c +6 -1

index f5924f3e8b8d..d4328008a714 100644
@@ -1930,7 +1930,12 @@ static int btusb_setup_intel(struct hci_dev *hdev)
 	if (err)
 		return err;
 
-	bt_dev_info(hdev, "Intel firmware patch completed and activated");
+       /* Need build number for downloaded fw patches in every power-on boot */
+       err = btintel_read_version(hdev, &ver);
+       if (err)
+               return err;
+       BT_INFO("%s: Intel Bluetooth fw patch 0x%02x completed and activated",
+               hdev->name, ver.fw_patch_num);
 
 	goto complete;

Signature · 1 line

2.17.1

Marcel Holtmann

maintainer

2020-03-12 14:08 UTC #1 lore raw

Hi Amit,

Quoted 14 lines

To determine the build version of Bluetooth firmware to ensure reported issue related to a particular release. This is very helpful for every fw downloaded to BT controller and issue reported from field test.
Signed-off-by Amit K Bag <[email protected]>
---
drivers/bluetooth/btusb.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
drivers/bluetooth/btusb.c +0 -0
index f5924f3e8b8d..d4328008a714 100644

drivers/bluetooth/btusb.c static int btusb_setup_intel(struct hci_dev *hdev) · line 1938

Quoted 10 lines

drivers/bluetooth/btusb.c +6 -1

@@ -1930,7 +1930,12 @@ static int btusb_setup_intel(struct hci_dev *hdev)
 	if (err)
 		return err;
 
-	bt_dev_info(hdev, "Intel firmware patch completed and activated");
+       /* Need build number for downloaded fw patches in every power-on boot */
+       err = btintel_read_version(hdev, &ver);
+       if (err)
+               return err;
+       BT_INFO("%s: Intel Bluetooth fw patch 0x%02x completed and activated",
+               hdev->name, ver.fw_patch_num);

don’t re-introduce the usage of BT_INFO, we have bt_dev_info.

Regards

Marcel