Skip to contentSkip to conversation

counter: 104-quad-8: Add lock guards for filter clock prescaler

PATCH Superseded Syed Nayyar Waris 2 participants 2 messages Mar 12, 2020

Subsystems (3)

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 3/3 counter: 104-quad-8: Add lock guards for filter clock prescaler

Add lock protection from race conditions in the 104-quad-8 counter driver for filter clock prescaler related changes. There is no IRQ handling so used spin_lock calls for protection.

Fixes 9b74dddf79be ("counter: 104-quad-8: Support Filter Clock

Prescaler")

Split the patch from generic interface and differential encoder cable status changes. Also, include more code statements for protection using spin_lock calls and remove protection from few code statements which are unnecessary.

---
 drivers/counter/104-quad-8.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/counter/104-quad-8.c +4 -0
index 9dab190..58615e4 100644
@@ -1230,6 +1230,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
 	if (ret)
 		return ret;
 
+	spin_lock(&priv->lock);
+
 	priv->fck_prescaler[channel_id] = prescaler;
 
 	/* Reset Byte Pointer */
@@ -1240,6 +1242,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
 	outb(QUAD8_CTR_RLD | QUAD8_RLD_RESET_BP | QUAD8_RLD_PRESET_PSC,
 	     base_offset + 1);
 
+	spin_unlock(&priv->lock);
+
 	return len;
 }
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 7 lines · Syed Nayyar Waris

Add lock protection from race conditions in the 104-quad-8 counter driver for filter clock prescaler related changes. There is no IRQ handling so used spin_lock calls for protection.

Fixes 9b74dddf79be ("counter: 104-quad-8: Support Filter Clock

Prescaler")

Quoted 7 lines

Split the patch from generic interface and differential encoder cable status changes. Also, include more code statements for protection using spin_lock calls and remove protection from few code statements which are unnecessary.
---

Hello Syed,

Remove the review comments from the commit message and I think this patch is all right. You can also extend the Fixes line so that it doesn't wrap around. Add the following Signed-off-by line underneath yours and it'll remind me that I've already reviewed this patch when you submit v4 of your patchset:

Thank you,

William Breathitt Gray

Quoted 28 lines
 drivers/counter/104-quad-8.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/counter/104-quad-8.c +4 -0
index 9dab190..58615e4 100644
@@ -1230,6 +1230,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
 	if (ret)
 		return ret;
 
+	spin_lock(&priv->lock);
+
 	priv->fck_prescaler[channel_id] = prescaler;
 
 	/* Reset Byte Pointer */
@@ -1240,6 +1242,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
 	outb(QUAD8_CTR_RLD | QUAD8_RLD_RESET_BP | QUAD8_RLD_PRESET_PSC,
 	     base_offset + 1);
 
+	spin_unlock(&priv->lock);
+
 	return len;
 }
 
Signature · 1 line
2.7.4