staging: ralink-gdma: ralink-gdma: change variable to a non-volatile
PATCH 1/1 staging: ralink-gdma: ralink-gdma: change variable to a non-volatile
Change variable declaration volatile unsigned long chan_issued to unsigned long chan_issued
Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
Issue found with checkpatch.pl
Signed-off-by Lourdes Pedrajas <[email protected]>
--- drivers/staging/ralink-gdma/ralink-gdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ralink-gdma/ralink-gdma.c +1 -1
@@ -122,7 +122,7 @@ struct gdma_dma_dev {struct gdma_data *data;void __iomem *base;struct tasklet_struct task; -volatile unsigned long chan_issued; +unsigned long chan_issued;atomic_t cnt;struct gdma_dmaengine_chan chan[];
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 17 lines · Lourdes Pedrajas
Change variable declaration volatile unsigned long
chan_issuedto unsigned longchan_issuedUse of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rstIssue found with checkpatch.pl
Signed-off-by Lourdes Pedrajas <[email protected]>--- drivers/staging/ralink-gdma/ralink-gdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/ralink-gdma/ralink-gdma.c +0
-0
drivers/staging/ralink-gdma/ralink-gdma.c struct gdma_dma_dev { · line 125
Quoted 5 lines
drivers/staging/ralink-gdma/ralink-gdma.c +1
-1@@ -122,7 +122,7 @@ struct gdma_dma_dev {struct gdma_data *data;void __iomem *base;struct tasklet_struct task; -volatile unsigned long chan_issued; +unsigned long chan_issued;
Same comment here as on the other patch.
thanks,
greg k-h