Skip to contentSkip to conversation

treewide: use fallthrough;

PATCH Applied Joe Perches 30 participants 84 messages Mar 11, 2020 – May 13, 2020

Subsystems (97)
lore
Share & tools
lore
#0 lore raw

cover treewide: use fallthrough;

There is a new fallthrough pseudo-keyword macro that can be used to replace the various /* fallthrough */ style comments that are used to indicate a case label code block is intended to fallthrough to the next case label block.

See commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use")

These patches are intended to allow clang to detect missing switch/case fallthrough uses.

Do a depth-first pass on the MAINTAINERS file and find the various
F: pattern files and convert the fallthrough comments to fallthrough; for all files matched by all F: patterns in in each section.

Done via the perl script below and the previously posted cvt_fallthrough.pl script.

These patches are based on next-20200310 and are available in

git://repo.or.cz/linux-2.6/trivial-mods.git in branch 20200310_fallthrough_2

$ cat commit_fallthrough.pl
#!/usr/bin/env perl

use sort 'stable';

#
# Reorder a sorted array so file entries are before directory entries

# depends on a trailing / for directories
# so:
#   foo/
#   foo/bar.c
# becomes
#   foo/bar.c
#   foo/
#
sub file_before_directory {
    my ($array_ref) = (@_);
    my $count = scalar(@$array_ref);

    for (my $i = 1; $i < $count; $i++) {
	if (substr(@$array_ref[$i - 1], -1) eq '/' &&
	    substr(@$array_ref[$i], 0, length(@$array_ref[$i - 1])) eq @$array_ref[$i - 1]) {
		my $string = @$array_ref[$i - 1];
		@$array_ref[$i - 1] = @$array_ref[$i];
		@$array_ref[$i] = $string;
	    }
	}
}
sub uniq {
    my (@parms) = @_;

    my %saw;
    @parms = grep(!$saw{$_}++, @parms);

    return @parms;
}

# Get all the F: file patterns in MAINTAINERS that could be a .[ch] file my $maintainer_patterns = grep -P '^F:\\s+' MAINTAINERS; my @patterns = split('\n', $maintainer_patterns);
s/^F:\s*// for @patterns;
@patterns = grep(!/^(?:Documentation|tools|scripts)\//, @patterns); @patterns = grep(!/\.(?:dtsi?|rst|config)$/, @patterns); @patterns = sort @patterns;
@patterns = sort { $b =~ tr/\//\// cmp $a =~ tr/\//\// } @patterns; file_before_directory(\@patterns);

my %sections_done;

foreach my $pattern (@patterns) {

# Find the files the pattern matches

    my $pattern_files = `git ls-files -- $pattern`;
    my @new_patterns = split('\n', $pattern_files);
    $pattern_files = join(' ', @new_patterns);
    next if ($pattern_files =~ /^\s*$/);

# Find the section the first file matches

    my $pattern_file = @new_patterns[0];
    my $section_output = `./scripts/get_maintainer.pl --nogit --nogit-fallback --sections --pattern-depth=1 $pattern_file`;
    my @section = split('\n', $section_output);
    my $section_header = @section[0];

    print("Section: <$section_header>\n");

# Skip the section if it's already done

    print("Already done '$section_header'\n") if ($sections_done{$section_header});
    next if ($sections_done{$section_header}++);

# Find all the .[ch] files in all F: lines in that section

    my @new_section;
    foreach my $line (@section) {
	last if ($line =~ /^\s*$/);
	push(@new_section, $line);
    }
    @section = grep(/^F:/, @new_section);
    s/^F:\s*// for @section;

    @section = grep(!/^(?:Documentation|tools|scripts)\//, @section);
    @section = grep(!/\.(?:dtsi?|rst|config)$/, @section);
    @section = sort @section;
    @section = uniq(@section);

    my $section_files = join(' ', @section);

    print("section_files: <$section_files>\n");

    next if ($section_files =~ /^\s*$/);

    my $cvt_files = `git ls-files -- $section_files`;
    my @files = split('\n', $cvt_files);

    @files = grep(!/^(?:Documentation|tools|scripts)\//, @files);
    @files = grep(!/\.(?:dtsi?|rst|config)$/, @files);
    @files = grep(/\.[ch]$/, @files);
    @files = sort @files;
    @files = uniq(@files);

    $cvt_files = join(' ', @files);
    print("files: <$cvt_files>\n");

    next if (scalar(@files) < 1);

# Convert fallthroughs for all [.ch] files in the section

    print("doing cvt_fallthrough.pl -- $cvt_files\n");

    `cvt_fallthrough.pl -- $cvt_files`;

# If nothing changed, nothing to commit

    `git diff-index --quiet HEAD --`;
    next if (!$?);

# Commit the changes

    my $fh;

    open($fh, "+>", "cvt_fallthrough.commit_msg") or die "$0: can't create temporary file: $!\n";
    print $fh <<EOF

$section_header: Use fallthrough;

Convert the various uses of fallthrough comments to fallthrough;

Done via script

EOF

;
    close $fh;

    `git commit -s -a -F cvt_fallthrough.commit_msg`;
}

Joe Perches (491):
MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; MARVELL OCTEONTX2 RVU ADMIN FUNCTION DRIVER: Use fallthrough; MELLANOX MLX5 core VPI driver: Use fallthrough; PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough; ARM/UNIPHIER ARCHITECTURE: Use fallthrough; ARM/RISCPC ARCHITECTURE: Use fallthrough;
KERNEL VIRTUAL MACHINE FOR ARM/ARM64 (KVM/arm, KVM/arm64): Use

    fallthrough;
  ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: Use fallthrough;
  ARM/Amlogic Meson SoC support: Use fallthrough;
  ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: Use fallthrough;
  ARM/QUALCOMM SUPPORT: Use fallthrough;
  ARM/ZTE ARCHITECTURE: Use fallthrough;
  INGENIC JZ47xx SoCs: Use fallthrough;
  DECSTATION PLATFORM SUPPORT: Use fallthrough;
  KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): Use fallthrough;
  KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): Use fallthrough;
  CELL BROADBAND ENGINE ARCHITECTURE: Use fallthrough;
  KERNEL VIRTUAL MACHINE for s390 (KVM/s390): Use fallthrough;
  Hyper-V CORE AND DRIVERS: Use fallthrough;
  XEN HYPERVISOR INTERFACE: Use fallthrough;
  KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86): Use fallthrough;
  X86 MCE INFRASTRUCTURE: Use fallthrough;
  AMD KFD: Use fallthrough;
  AMD DISPLAY CORE: Use fallthrough;
  AMD POWERPLAY: Use fallthrough;
  INTEL GVT-g DRIVERS (Intel GPU Virtualization): Use fallthrough;
  AMD XGBE DRIVER: Use fallthrough;
  BROADCOM BNX2X 10 GIGABIT ETHERNET DRIVER: Use fallthrough;
  BROADCOM BNXT_EN 50 GIGABIT ETHERNET DRIVER: Use fallthrough;
  BROADCOM GENET ETHERNET DRIVER: Use fallthrough;
  BROCADE BNA 10 GIGABIT ETHERNET DRIVER: Use fallthrough;
  CAVIUM LIQUIDIO NETWORK DRIVER: Use fallthrough;
  ARM/CAVIUM THUNDER NETWORK DRIVER: Use fallthrough;
  CXGB3 ETHERNET DRIVER (CXGB3): Use fallthrough;
  CXGB4 ETHERNET DRIVER (CXGB4): Use fallthrough;
  CXGB4VF ETHERNET DRIVER (CXGB4VF): Use fallthrough;
  CISCO VIC ETHERNET NIC DRIVER: Use fallthrough;
  TULIP NETWORK DRIVERS: Use fallthrough;
  Emulex 10Gbps NIC BE2, BE3-R, Lancer, Skyhawk-R DRIVER (be2net): Use
    fallthrough;
  DPAA2 ETHERNET DRIVER: Use fallthrough;
  HISILICON NETWORK SUBSYSTEM 3 DRIVER (HNS3): Use fallthrough;
  EHEA (IBM pSeries eHEA 10Gb ethernet adapter) DRIVER: Use fallthrough;
  INTEL ETHERNET DRIVERS: Use fallthrough;
  MELLANOX ETHERNET DRIVER (mlx4_en): Use fallthrough;
  MELLANOX MLX4 core VPI driver: Use fallthrough;
  MELLANOX FIRMWARE FLASH LIBRARY (mlxfw): Use fallthrough;
  MELLANOX ETHERNET SWITCH DRIVERS: Use fallthrough;
  NETXEN (1/10) GbE SUPPORT: Use fallthrough;
  QLOGIC QL4xxx ETHERNET DRIVER: Use fallthrough;
  QLOGIC QLCNIC (1/10)Gb ETHERNET DRIVER: Use fallthrough;
  SAMSUNG SXGBE DRIVERS: Use fallthrough;
  STMMAC ETHERNET DRIVER: Use fallthrough;
  QUALCOMM ATHEROS ATH10K WIRELESS DRIVER: Use fallthrough;
  QUALCOMM ATHEROS ATH11K WIRELESS DRIVER: Use fallthrough;
  ATHEROS ATH5K WIRELESS DRIVER: Use fallthrough;
  ATHEROS ATH6KL WIRELESS DRIVER: Use fallthrough;
  QUALCOMM ATHEROS ATH9K WIRELESS DRIVER: Use fallthrough;
  CARL9170 LINUX COMMUNITY WIRELESS DRIVER: Use fallthrough;
  QUALCOMM WCN36XX WIRELESS DRIVER: Use fallthrough;
  B43 WIRELESS DRIVER: Use fallthrough;
  B43LEGACY WIRELESS DRIVER: Use fallthrough;
  BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER: Use fallthrough;
  INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy): Use fallthrough;
  INTEL WIRELESS WIFI LINK (iwlwifi): Use fallthrough;
  ORINOCO DRIVER: Use fallthrough;
  PRISM54 WIRELESS DRIVER: Use fallthrough;
  MARVELL MWIFIEX WIRELESS DRIVER: Use fallthrough;
  MEDIATEK MT76 WIRELESS LAN DRIVER: Use fallthrough;
  MEDIATEK MT7601U WIRELESS LAN DRIVER: Use fallthrough;
  RALINK RT2X00 WIRELESS LAN DRIVER: Use fallthrough;
  RTL8XXXU WIRELESS DRIVER (rtl8xxxu): Use fallthrough;
  REALTEK WIRELESS DRIVER (rtlwifi family): Use fallthrough;
  REALTEK WIRELESS DRIVER (rtw88): Use fallthrough;
  TRACING: Use fallthrough;
  OPROFILE: Use fallthrough;
  PTRACE SUPPORT: Use fallthrough;
  HIBERNATION (aka Software Suspend, aka swsusp): Use fallthrough;
  ARM PMU PROFILING AND DEBUGGING: Use fallthrough;
  ARM/ARTPEC MACHINE SUPPORT: Use fallthrough;
  ARM/Marvell Dove/MV78xx0/Orion SOC support: Use fallthrough;
  MMP SUPPORT: Use fallthrough;
  PXA2xx/PXA3xx SUPPORT: Use fallthrough;
  ARM/RDA MICRO ARCHITECTURE: Use fallthrough;
  ARM/Rockchip SoC support: Use fallthrough;
  ARM/NOMADIK/U300/Ux500 ARCHITECTURES: Use fallthrough;
  PS3 PLATFORM SUPPORT: Use fallthrough;
  LINUX FOR POWER MACINTOSH: Use fallthrough;
  SCx200 CPU SUPPORT: Use fallthrough;
  CAVIUM OCTEON-TX CRYPTO DRIVER: Use fallthrough;
  ARM MALI-DP DRM DRIVER: Use fallthrough;
  DRM DRIVER FOR AST SERVER GRAPHICS CHIPS: Use fallthrough;
  DRM DRIVERS FOR BRIDGE CHIPS: Use fallthrough;
  DRM DRIVERS FOR EXYNOS: Use fallthrough;
  DRM DRIVERS FOR FREESCALE DCU: Use fallthrough;
  INTEL DRM DRIVERS (excluding Poulsbo, Moorestown and derivative
    chipsets): Use fallthrough;
  DRM DRIVERS FOR FREESCALE IMX: Use fallthrough;
  DRM DRIVERS FOR AMLOGIC SOCS: Use fallthrough;
  DRM DRIVER FOR MSM ADRENO GPU: Use fallthrough;
  DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS: Use fallthrough;
  DRM DRIVERS FOR TI OMAP: Use fallthrough;
  RADEON and AMDGPU DRM DRIVERS: Use fallthrough;
  DRM DRIVER FOR SAVAGE VIDEO CARDS: Use fallthrough;
  DRM DRIVERS FOR ALLWINNER A10: Use fallthrough;
  DRM DRIVERS FOR NVIDIA TEGRA: Use fallthrough;
  DRM DRIVERS FOR TI LCDC: Use fallthrough;
  DRM TTM SUBSYSTEM: Use fallthrough;
  DRM DRIVERS FOR XEN: Use fallthrough;
  BROADCOM NETXTREME-E ROCE DRIVER: Use fallthrough;
  CXGB4 IWARP RNIC DRIVER (IW_CXGB4): Use fallthrough;
  INTEL RDMA RNIC DRIVER: Use fallthrough;
  MELLANOX MLX4 IB driver: Use fallthrough;
  MELLANOX MLX5 IB driver: Use fallthrough;
  EMULEX ONECONNECT ROCE DRIVER: Use fallthrough;
  QLOGIC QL4xxx RDMA DRIVER: Use fallthrough;
  QIB DRIVER: Use fallthrough;
  VMWARE PVRDMA DRIVER: Use fallthrough;
  SOFT-ROCE DRIVER (rxe): Use fallthrough;
  SOFT-IWARP DRIVER (siw): Use fallthrough;
  ISCSI EXTENSIONS FOR RDMA (ISER) INITIATOR: Use fallthrough;
  SIANO DVB DRIVER: Use fallthrough;
  VIDEOBUF2 FRAMEWORK: Use fallthrough;
  SAMSUNG S5C73M3 CAMERA DRIVER: Use fallthrough;
  SMIA AND SMIA++ IMAGE SENSOR DRIVER: Use fallthrough;
  BTTV VIDEO4LINUX DRIVER: Use fallthrough;
  CX88 VIDEO4LINUX DRIVER: Use fallthrough;
  MEDIA DRIVERS FOR DIGITAL DEVICES PCIE DEVICES: Use fallthrough;
  MOTION EYE VAIO PICTUREBOOK CAMERA DRIVER: Use fallthrough;
  SAA7134 VIDEO4LINUX DRIVER: Use fallthrough;
  SOFTLOGIC 6x10 MPEG CODEC: Use fallthrough;
  CODA V4L2 MEM2MEM DRIVER: Use fallthrough;
  SAMSUNG S5P/EXYNOS4 SOC SERIES CAMERA SUBSYSTEM DRIVERS: Use
    fallthrough;
  CAFE CMOS INTEGRATED CAMERA CONTROLLER DRIVER: Use fallthrough;
  OMAP IMAGING SUBSYSTEM (OMAP3 ISP and OMAP4 ISS): Use fallthrough;
  VICODEC VIRTUAL CODEC DRIVER: Use fallthrough;
  VIVID VIRTUAL VIDEO DRIVER: Use fallthrough;
  SI4713 FM RADIO TRANSMITTER I2C DRIVER: Use fallthrough;
  CEC FRAMEWORK: Use fallthrough;
  DVB_USB_AF9015 MEDIA DRIVER: Use fallthrough;
  DVB_USB_GL861 MEDIA DRIVER: Use fallthrough;
  LME2510 MEDIA DRIVER: Use fallthrough;
  DVB_USB_MXL111SF MEDIA DRIVER: Use fallthrough;
  EM28XX VIDEO4LINUX DRIVER: Use fallthrough;
  GO7007 MPEG CODEC: Use fallthrough;
  GSPCA SN9C20X SUBDRIVER: Use fallthrough;
  GSPCA USB WEBCAM DRIVER: Use fallthrough;
  PULSE8-CEC DRIVER: Use fallthrough;
  PWC WEBCAM DRIVER: Use fallthrough;
  TM6000 VIDEO4LINUX DRIVER: Use fallthrough;
  USB VIDEO CLASS: Use fallthrough;
  ONENAND FLASH DRIVER: Use fallthrough;
  BROADCOM B53 ETHERNET SWITCH DRIVER: Use fallthrough;
  MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER: Use fallthrough;
  MARVELL 88E6XXX ETHERNET SWITCH FABRIC DRIVER: Use fallthrough;
  8390 NETWORK DRIVERS [WD80x3/SMC-ELITE, SMC-ULTRA, NE2000, 3C503,
    etc.]: Use fallthrough;
  ALACRITECH GIGABIT ETHERNET DRIVER: Use fallthrough;
  ACENIC DRIVER: Use fallthrough;
  BROADCOM BNX2 GIGABIT ETHERNET DRIVER: Use fallthrough;
  BROADCOM TG3 GIGABIT ETHERNET DRIVER: Use fallthrough;
  ATMEL MACB ETHERNET DRIVER: Use fallthrough;
  FREESCALE QORIQ DPAA ETHERNET DRIVER: Use fallthrough;
  FREESCALE QORIQ DPAA FMAN DRIVER: Use fallthrough;
  FREESCALE QUICC ENGINE UCC ETHERNET DRIVER: Use fallthrough;
  HISILICON NETWORK SUBSYSTEM DRIVER: Use fallthrough;
  LINUX FOR POWERPC (32-BIT AND 64-BIT): Use fallthrough;
  MARVELL MVNETA ETHERNET DRIVER: Use fallthrough;
  MARVELL GIGABIT ETHERNET DRIVERS (skge/sky2): Use fallthrough;
  MEDIATEK ETHERNET DRIVER: Use fallthrough;
  MICROCHIP LAN743X ETHERNET DRIVER: Use fallthrough;
  MICROSEMI ETHERNET SWITCH DRIVER: Use fallthrough;
  NATSEMI ETHERNET DRIVER (DP8381x): Use fallthrough;
  NETERION 10GbE DRIVERS (s2io/vxge): Use fallthrough;
  NETRONOME ETHERNET DRIVERS: Use fallthrough;
  QLOGIC QLA3XXX NETWORK DRIVER: Use fallthrough;
  8169 10/100/1000 GIGABIT ETHERNET DRIVER: Use fallthrough;
  ROCKER DRIVER: Use fallthrough;
  SFC NETWORK DRIVER: Use fallthrough;
  SIS 900/7016 FAST ETHERNET DRIVER: Use fallthrough;
  SOCIONEXT (SNI) NETSEC NETWORK DRIVER: Use fallthrough;
  TI ETHERNET SWITCH DRIVER (CPSW): Use fallthrough;
  TLAN NETWORK DRIVER: Use fallthrough;
  SPIDERNET NETWORK DRIVER for CELL: Use fallthrough;
  INTEL WIRELESS WIMAX CONNECTION 2400: Use fallthrough;
  ATMEL WIRELESS DRIVER: Use fallthrough;
  TI WILINK WIRELESS DRIVERS: Use fallthrough;
  USB ZD1201 DRIVER: Use fallthrough;
  PCI DRIVER FOR IMX6: Use fallthrough;
  ANALOG DEVICES INC IIO DRIVERS: Use fallthrough;
  HANTRO VPU CODEC DRIVER: Use fallthrough;
  MEDIA DRIVERS FOR FREESCALE IMX: Use fallthrough;
  SOC-CAMERA V4L2 SUBSYSTEM: Use fallthrough;
  USB VISION DRIVER: Use fallthrough;
  PARISC ARCHITECTURE: Use fallthrough;
  MICROCHIP USBA UDC DRIVER: Use fallthrough;
  FREESCALE USB PERIPHERAL DRIVERS: Use fallthrough;
  USB TYPEC PORT CONTROLLER DRIVERS: Use fallthrough;
  RADEON FRAMEBUFFER DISPLAY DRIVER: Use fallthrough;
  ARC FRAMEBUFFER DRIVER: Use fallthrough;
  NVIDIA (rivafb and nvidiafb) FRAMEBUFFER DRIVER: Use fallthrough;
  OMAP FRAMEBUFFER SUPPORT: Use fallthrough;
  OMAP DISPLAY SUBSYSTEM and FRAMEBUFFER SUPPORT (DSS2): Use
    fallthrough;
  S3 SAVAGE FRAMEBUFFER DRIVER: Use fallthrough;
  SIS FRAMEBUFFER DRIVER: Use fallthrough;
  VIA UNICHROME(PRO)/CHROME9 FRAMEBUFFER DRIVER: Use fallthrough;
  CAN NETWORK DRIVERS: Use fallthrough;
  WOLFSON MICROELECTRONICS DRIVERS: Use fallthrough;
  DIALOG SEMICONDUCTOR DRIVERS: Use fallthrough;
  MEDIA INPUT INFRASTRUCTURE (V4L/DVB): Use fallthrough;
  CAN NETWORK LAYER: Use fallthrough;
  HSI SUBSYSTEM: Use fallthrough;
  MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND SDIO SUBSYSTEM: Use
    fallthrough;
  KERNEL NFSD, SUNRPC, AND LOCKD SERVERS: Use fallthrough;
  SOFTWARE RAID (Multiple Disks) SUPPORT: Use fallthrough;
  SPI SUBSYSTEM: Use fallthrough;
  NFS, SUNRPC, AND LOCKD CLIENTS: Use fallthrough;
  TC subsystem: Use fallthrough;
  FCOE SUBSYSTEM (libfc, libfcoe, fcoe): Use fallthrough;
  CRYPTO API: Use fallthrough;
  BPF (Safe dynamic programs and tools): Use fallthrough;
  OMAP USB SUPPORT: Use fallthrough;
  OMAP1 SUPPORT: Use fallthrough;
  OMAP2+ SUPPORT: Use fallthrough;
  ARM SUB-ARCHITECTURES: Use fallthrough;
  M68K ON APPLE MACINTOSH: Use fallthrough;
  PCI SUBSYSTEM: Use fallthrough;
  FPU EMULATOR: Use fallthrough;
  X86 MM: Use fallthrough;
  NETWORKING [IPv4/IPv6]: Use fallthrough;
  USER-MODE LINUX (UML): Use fallthrough;
  ACPI COMPONENT ARCHITECTURE (ACPICA): Use fallthrough;
  FIRMWARE LOADER (request_firmware): Use fallthrough;
  ATA OVER ETHERNET (AOE) DRIVER: Use fallthrough;
  DRBD DRIVER: Use fallthrough;
  PARIDE DRIVERS FOR PARALLEL PORT IDE DEVICES: Use fallthrough;
  FLASH ADAPTER DRIVER (IBM Flash Adapter 900GB Full Height PCI Flash
    Card): Use fallthrough;
  XEN BLOCK SUBSYSTEM: Use fallthrough;
  AGPGART DRIVER: Use fallthrough;
  IPMI SUBSYSTEM: Use fallthrough;
  TI DAVINCI SERIES CLOCK DRIVER: Use fallthrough;
  H8/300 ARCHITECTURE: Use fallthrough;
  VIRTIO CORE AND NET DRIVERS: Use fallthrough;
  DRM DRIVERS AND MISC GPU PATCHES: Use fallthrough;
  USB HID/HIDBP DRIVERS (USB KEYBOARDS, MICE, REMOTE CONTROLS, ...): Use
    fallthrough;
  ARM/CORESIGHT FRAMEWORK AND DRIVERS: Use fallthrough;
  INTEL(R) TRACE HUB: Use fallthrough;
  I2C SUBSYSTEM HOST DRIVERS: Use fallthrough;
  ARM/ZYNQ ARCHITECTURE: Use fallthrough;
  I3C DRIVER FOR SYNOPSYS DESIGNWARE: Use fallthrough;
  SENSIRION SPS30 AIR POLLUTION SENSOR DRIVER: Use fallthrough;
  IIO DIGITAL POTENTIOMETER DAC: Use fallthrough;
  ASAHI KASEI AK8974 DRIVER: Use fallthrough;
  HFI1 DRIVER: Use fallthrough;
  RDMAVT - RDMA verbs software: Use fallthrough;
  ISCSI EXTENSIONS FOR RDMA (ISER) TARGET: Use fallthrough;
  OPA-VNIC DRIVER: Use fallthrough;
  FLYSKY FSIA6B RC RECEIVER: Use fallthrough;
  WACOM PROTOCOL 4 SERIAL TABLETS: Use fallthrough;
  ATMEL MAXTOUCH DRIVER: Use fallthrough;
  ISDN/mISDN SUBSYSTEM: Use fallthrough;
  BCACHE (BLOCK LAYER CACHE): Use fallthrough;
  DEVICE-MAPPER (LVM): Use fallthrough;
  TI FLASH MEDIA MEMORYSTICK/MMC DRIVERS: Use fallthrough;
  LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI): Use fallthrough;
  INTEL MIC DRIVERS (mic): Use fallthrough;
  SGI GRU DRIVER: Use fallthrough;
  SGI XP/XPC/XPNET DRIVER: Use fallthrough;
  BLOCK2MTD DRIVER: Use fallthrough;
  PHRAM MTD DRIVER: Use fallthrough;
  NAND FLASH SUBSYSTEM: Use fallthrough;
  SPI NOR SUBSYSTEM: Use fallthrough;
  UNSORTED BLOCK IMAGES (UBI): Use fallthrough;
  APPLETALK NETWORK LAYER: Use fallthrough;
  ARCNET NETWORK LAYER: Use fallthrough;
  BONDING DRIVER: Use fallthrough;
  MEDIATEK SWITCH DRIVER: Use fallthrough;
  NETWORKING [DSA]: Use fallthrough;
  BAYCOM/HDLCDRV DRIVERS FOR AX.25: Use fallthrough;
  IEEE 802.15.4 SUBSYSTEM: Use fallthrough;
  NETDEVSIM: Use fallthrough;
  ANALOG DEVICES INC ADIN DRIVER: Use fallthrough;
  PTP HARDWARE CLOCK SUPPORT: Use fallthrough;
  SFF/SFP/SFP+ MODULE SUPPORT: Use fallthrough;
  ETHERNET PHY LIBRARY: Use fallthrough;
  USB LAN78XX ETHERNET DRIVER: Use fallthrough;
  USB PEGASUS DRIVER: Use fallthrough;
  USB RTL8150 DRIVER: Use fallthrough;
  USB "USBNET" DRIVER FRAMEWORK: Use fallthrough;
  USB NETWORKING DRIVERS: Use fallthrough;
  FRAME RELAY DLCI/FRAD (Sangoma drivers too): Use fallthrough;
  MAC80211: Use fallthrough;
  RAYLINK/WEBGEAR 802.11 WIRELESS LAN DRIVER: Use fallthrough;
  NETWORKING DRIVERS (WIRELESS): Use fallthrough;
  XEN NETWORK BACKEND DRIVER: Use fallthrough;
  NVM EXPRESS FC TRANSPORT DRIVERS: Use fallthrough;
  NVM EXPRESS DRIVER: Use fallthrough;
  NVM EXPRESS TARGET DRIVER: Use fallthrough;
  ACPI: Use fallthrough;
  BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE: Use fallthrough;
  PIN CONTROLLER - INTEL: Use fallthrough;
  MIPS: Use fallthrough;
  X86 PLATFORM DRIVERS: Use fallthrough;
  CHROMEOS EC SUBDRIVERS: Use fallthrough;
  POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS: Use fallthrough;
  S390 COMMON I/O LAYER: Use fallthrough;
  S390 VFIO AP DRIVER: Use fallthrough;
  S390 ZCRYPT DRIVER: Use fallthrough;
  S390 IUCV NETWORK LAYER: Use fallthrough;
  S390 NETWORK DRIVERS: Use fallthrough;
  S390 ZFCP DRIVER: Use fallthrough;
  AACRAID SCSI RAID DRIVER: Use fallthrough;
  AIC7XXX / AIC79XX SCSI DRIVER: Use fallthrough;
  NCR 5380 SCSI DRIVERS: Use fallthrough;
  Emulex 10Gbps iSCSI - OneConnect DRIVER: Use fallthrough;
  BROCADE BFA FC SCSI DRIVER: Use fallthrough;
  BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER: Use fallthrough;
  CXGB3 ISCSI DRIVER (CXGB3I): Use fallthrough;
  CXGB4 ISCSI DRIVER (CXGB4I): Use fallthrough;
  CXLFLASH (IBM Coherent Accelerator Processor Interface CAPI Flash)
    SCSI DRIVER: Use fallthrough;
  HISILICON SAS Controller: Use fallthrough;
  IBM Power Virtual SCSI Device Target Driver: Use fallthrough;
  INTEL C600 SERIES SAS CONTROLLER DRIVER: Use fallthrough;
  EMULEX/BROADCOM LPFC FC/FCOE SCSI DRIVER: Use fallthrough;
  MEGARAID SCSI/SAS DRIVERS: Use fallthrough;
  NINJA SCSI-3 / NINJA SCSI-32Bi (16bit/CardBus) PCMCIA SCSI HOST
    ADAPTER DRIVER: Use fallthrough;
  QLOGIC QLA2XXX FC-SCSI DRIVER: Use fallthrough;
  QLOGIC QLA4XXX iSCSI DRIVER: Use fallthrough;
  MICROSEMI SMART ARRAY SMARTPQI DRIVER (smartpqi): Use fallthrough;
  LSILOGIC/SYMBIOS/NCR 53C8XX and 53C1010 PCI-SCSI drivers: Use
    fallthrough;
  UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER: Use fallthrough;
  STAGING - COMEDI: Use fallthrough;
  DPAA2 ETHERNET SWITCH DRIVER: Use fallthrough;
  QLOGIC QLGE 10Gb ETHERNET DRIVER: Use fallthrough;
  STAGING - REALTEK RTL8188EU DRIVERS: Use fallthrough;
  STAGING - REALTEK RTL8712U DRIVERS: Use fallthrough;
  STAGING - VIA VT665X DRIVERS: Use fallthrough;
  HYPERVISOR VIRTUAL CONSOLE DRIVER: Use fallthrough;
  SYNOPSYS ARC ARCHITECTURE: Use fallthrough;
  MICROCHIP AT91 SERIAL DRIVER: Use fallthrough;
  KGDB / KDB /debug_core: Use fallthrough;
  TEGRA SERIAL DRIVER: Use fallthrough;
  TTY LAYER: Use fallthrough;
  CONEXANT ACCESSRUNNER USB DRIVER: Use fallthrough;
  USB CYPRESS C67X00 DRIVER: Use fallthrough;
  DESIGNWARE USB3 DRD IP DRIVER: Use fallthrough;
  USB GADGET/PERIPHERAL SUBSYSTEM: Use fallthrough;
  USB EHCI DRIVER: Use fallthrough;
  USB ISP116X DRIVER: Use fallthrough;
  USB OHCI DRIVER: Use fallthrough;
  USB XHCI DRIVER: Use fallthrough;
  MEDIATEK USB3 DRD IP DRIVER: Use fallthrough;
  MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER: Use fallthrough;
  USB PHY LAYER: Use fallthrough;
  USB SERIAL SUBSYSTEM: Use fallthrough;
  USB ATTACHED SCSI: Use fallthrough;
  USB MASS STORAGE DRIVER: Use fallthrough;
  USB OVER IP DRIVER: Use fallthrough;
  ADP8860 BACKLIGHT DRIVER (ADP8860/ADP8861/ADP8863): Use fallthrough;
  MICROCHIP LCDFB DRIVER: Use fallthrough;
  FREESCALE DIU FRAMEBUFFER DRIVER: Use fallthrough;
  SAMSUNG FRAMEBUFFER DRIVER: Use fallthrough;
  VIRTUAL BOX GUEST DEVICE DRIVER: Use fallthrough;
  FANOTIFY: Use fallthrough;
  MULTIFUNCTION DEVICES (MFD): Use fallthrough;
  MULTIPLEXER SUBSYSTEM: Use fallthrough;
  VOLTAGE AND CURRENT REGULATOR FRAMEWORK: Use fallthrough;
  RESET CONTROLLER FRAMEWORK: Use fallthrough;
  SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEMENT (ASoC): Use
    fallthrough;
  CEPH COMMON CODE (LIBCEPH): Use fallthrough;
  GPIO SUBSYSTEM: Use fallthrough;
  GREYBUS SUBSYSTEM: Use fallthrough;
  INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN) DRIVERS: Use
    fallthrough;

MEMORY TECHNOLOGY DEVICES (MTD): Use fallthrough; ETHERNET BRIDGE: Use fallthrough;
PIN CONTROL SUBSYSTEM: Use fallthrough;
NFC SUBSYSTEM: Use fallthrough;
REAL TIME CLOCK (RTC) SUBSYSTEM: Use fallthrough;
CPU FREQUENCY SCALING FRAMEWORK: Use fallthrough;
NOHZ, DYNTICKS SUPPORT: Use fallthrough;
SONICS SILICON BACKPLANE DRIVER (SSB): Use fallthrough; USB SUBSYSTEM: Use fallthrough;
9P FILE SYSTEM: Use fallthrough;
BLUETOOTH SUBSYSTEM: Use fallthrough;
NETFILTER: Use fallthrough;
PHONET PROTOCOL: Use fallthrough;
SCTP PROTOCOL: Use fallthrough;
AFS FILESYSTEM: Use fallthrough;
EROFS FILE SYSTEM: Use fallthrough;
F2FS FILE SYSTEM: Use fallthrough;
FILESYSTEM DIRECT ACCESS (DAX): Use fallthrough;
HARDWARE MONITORING: Use fallthrough;
INFINIBAND SUBSYSTEM: Use fallthrough;
NILFS2 FILESYSTEM: Use fallthrough;
RXRPC SOCKETS (AF_RXRPC): Use fallthrough;
ATM: Use fallthrough;
AUDIT SUBSYSTEM: Use fallthrough;
BTRFS FILE SYSTEM: Use fallthrough;
CAPABILITIES: Use fallthrough;
HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa): Use fallthrough; DCCP PROTOCOL: Use fallthrough;
DEVLINK: Use fallthrough;
XFS FILESYSTEM: Use fallthrough;
FRAMEBUFFER LAYER: Use fallthrough;
FILE LOCKING (flock() and fcntl()/lockf()): Use fallthrough; FIREWIRE SUBSYSTEM: Use fallthrough;
FILESYSTEMS (VFS and infrastructure): Use fallthrough; FUTEX SUBSYSTEM: Use fallthrough;
HID CORE LAYER: Use fallthrough;
I2C SUBSYSTEM: Use fallthrough;
NETWORKING DRIVERS: Use fallthrough;
NETWORKING [GENERAL]: Use fallthrough;
KEYS/KEYRINGS: Use fallthrough;
LIGHTNVM PLATFORM SUPPORT: Use fallthrough;
PARALLEL PORT SUBSYSTEM: Use fallthrough;
SCHEDULER: Use fallthrough;
SELINUX SECURITY MODULE: Use fallthrough;
THERMAL: Use fallthrough;
TIMEKEEPING, CLOCKSOURCE CORE, NTP, ALARMTIMER: Use fallthrough; VFIO DRIVER: Use fallthrough;
VIRTIO BLOCK AND SCSI DRIVERS: Use fallthrough;
WATCHDOG DEVICE DRIVERS: Use fallthrough;
SOUND: Use fallthrough;
INTEGRITY MEASUREMENT ARCHITECTURE (IMA): Use fallthrough; ALPHA PORT: Use fallthrough;
ARM PORT: Use fallthrough;
ARM64 PORT (AARCH64 ARCHITECTURE): Use fallthrough;
C6X ARCHITECTURE: Use fallthrough;
C-SKY ARCHITECTURE: Use fallthrough;
QUALCOMM HEXAGON ARCHITECTURE: Use fallthrough;
IA64 (Itanium) PLATFORM: Use fallthrough;
MICROBLAZE ARCHITECTURE: Use fallthrough;
ANDES ARCHITECTURE: Use fallthrough;
OPENRISC ARCHITECTURE: Use fallthrough;
RISC-V ARCHITECTURE: Use fallthrough;
S390: Use fallthrough;
SUPERH: Use fallthrough;
SPARC + UltraSPARC (sparc/sparc64): Use fallthrough; UNICORE32 ARCHITECTURE: Use fallthrough;
X86 ARCHITECTURE (32-BIT AND 64-BIT): Use fallthrough; TENSILICA XTENSA PORT (xtensa): Use fallthrough; ASYNCHRONOUS TRANSFERS/TRANSFORMS (IOAT) API: Use fallthrough; LIBATA SATA AHCI PLATFORM devices support: Use fallthrough; LIBATA PATA DRIVERS: Use fallthrough;
LIBATA SATA PROMISE TX2/TX4 CONTROLLER DRIVER: Use fallthrough; LIBATA SUBSYSTEM (Serial and Parallel ATA drivers): Use fallthrough; PARALLEL LCD/KEYPAD PANEL DRIVER: Use fallthrough;
FLOPPY DRIVER: Use fallthrough;
RADOS BLOCK DEVICE (RBD): Use fallthrough;
STEC S1220 SKD DRIVER: Use fallthrough;
BLOCK LAYER: Use fallthrough;
BLUETOOTH DRIVERS: Use fallthrough;
CHAR and MISC DRIVERS: Use fallthrough;
COMMON CLK FRAMEWORK: Use fallthrough;
EDAC-AMD64: Use fallthrough;
EDAC-PND2: Use fallthrough;
IDE/ATAPI DRIVERS: Use fallthrough;
IDE SUBSYSTEM: Use fallthrough;
IIO SUBSYSTEM AND DRIVERS: Use fallthrough;
AMD IOMMU (AMD-VI): Use fallthrough;
ARM SMMU DRIVERS: Use fallthrough;
INTEL IOMMU (VT-d): Use fallthrough;
VIRTIO IOMMU DRIVER: Use fallthrough;
IRQCHIP DRIVERS: Use fallthrough;
OMAP GENERAL PURPOSE MEMORY CONTROLLER SUPPORT: Use fallthrough; SONY MEMORYSTICK SUBSYSTEM: Use fallthrough;
NTB DRIVER CORE: Use fallthrough;
PCMCIA SUBSYSTEM: Use fallthrough;
RAPIDIO SUBSYSTEM: Use fallthrough;
53C700 AND 53C700-66 SCSI DRIVER: Use fallthrough; BUSLOGIC SCSI DRIVER: Use fallthrough;
ATTO EXPRESSSAS SAS/SATA RAID SCSI DRIVER: Use fallthrough; MYLEX DAC960 PCI RAID Controller: Use fallthrough;
SCSI CDROM DRIVER: Use fallthrough;
SCSI TAPE DRIVER: Use fallthrough;
VMware PVSCSI driver: Use fallthrough;
SCSI SUBSYSTEM: Use fallthrough;
STAGING SUBSYSTEM: Use fallthrough;
SCSI TARGET SUBSYSTEM: Use fallthrough;
THUNDERBOLT DRIVER: Use fallthrough;
M68K ARCHITECTURE: Use fallthrough;
EXTRA BOOT CONFIG: Use fallthrough;
HIGH-RESOLUTION TIMERS, CLOCKEVENTS: Use fallthrough; DYNAMIC INTERRUPT MODERATION: Use fallthrough;
MEMORY MANAGEMENT: Use fallthrough;
SIPHASH PRF ROUTINES: Use fallthrough;
POSIX CLOCKS and TIMERS: Use fallthrough;
GCOV BASED KERNEL PROFILING: Use fallthrough;
IRQ SUBSYSTEM: Use fallthrough;
APPARMOR SECURITY MODULE: Use fallthrough;
SMACK SECURITY MODULE: Use fallthrough;
TOMOYO SECURITY MODULE: Use fallthrough;
VSPRINTF: Use fallthrough;
THE REST: Use fallthrough;

 arch/alpha/kernel/module.c                    |   2 +-
 arch/alpha/kernel/signal.c                    |   2 +-
 arch/alpha/kernel/traps.c                     |   6 +-
 arch/arc/kernel/disasm.c                      |   3 +-
 arch/arc/kernel/signal.c                      |   3 +-
 arch/arc/kernel/unwind.c                      |   6 +-
 arch/arm/kernel/hw_breakpoint.c               |  10 +-
 arch/arm/kernel/signal.c                      |   2 +-
 arch/arm/mach-ep93xx/crunch.c                 |   3 +-
 arch/arm/mach-mmp/pm-mmp2.c                   |   8 +-
 arch/arm/mach-mmp/pm-pxa910.c                 |  10 +-
 arch/arm/mach-omap2/id.c                      |   8 --
 arch/arm/mach-omap2/omap_device.c             |   2 +-
 arch/arm/mach-orion5x/dns323-setup.c          |   2 +-
 arch/arm/mach-rpc/riscpc.c                    |   2 +-
 arch/arm/mach-tegra/reset.c                   |   2 +-
 arch/arm/mm/alignment.c                       |   6 +-
 arch/arm/plat-omap/dma.c                      |   6 +-
 arch/arm/probes/decode.c                      |   2 +-
 arch/arm/probes/kprobes/core.c                |   2 +-
 arch/arm64/kernel/cpufeature.c                |   2 +-
 arch/arm64/kernel/cpuinfo.c                   |   2 +-
 arch/arm64/kernel/hw_breakpoint.c             |   8 +-
 arch/arm64/kernel/module.c                    |   8 +-
 arch/arm64/kernel/smp.c                       |   2 +-
 arch/arm64/kvm/handle_exit.c                  |   2 +-
 arch/arm64/kvm/hyp/debug-sr.c                 |  60 ++++-----
 arch/arm64/mm/context.c                       |   2 +-
 arch/c6x/kernel/signal.c                      |   5 +-
 arch/csky/kernel/signal.c                     |   2 +-
 arch/h8300/kernel/signal.c                    |   2 +-
 arch/hexagon/kernel/module.c                  |   2 +-
 arch/hexagon/kernel/signal.c                  |   2 +-
 arch/ia64/kernel/crash.c                      |   2 +-
 arch/ia64/kernel/module.c                     |   2 +-
 arch/ia64/kernel/perfmon.c                    |   2 +-
 arch/ia64/kernel/signal.c                     |   2 +-
 arch/ia64/kernel/unaligned.c                  |   6 +-
 arch/ia64/kernel/unwind.c                     |   2 +-
 arch/m68k/amiga/config.c                      |   4 +-
 arch/m68k/atari/atakeyb.c                     |   3 +-
 arch/m68k/kernel/signal.c                     |   2 +-
 arch/m68k/mac/config.c                        |   2 +-
 arch/m68k/mac/via.c                           |   2 +-
 arch/m68k/mm/fault.c                          |   2 +-
 arch/microblaze/kernel/signal.c               |   2 +-
 arch/mips/alchemy/devboards/db1550.c          |   2 +-
 arch/mips/ar7/setup.c                         |   2 +-
 arch/mips/ath79/setup.c                       |   3 +-
 arch/mips/bcm63xx/cpu.c                       |   2 +-
 arch/mips/bcm63xx/dev-flash.c                 |   2 +-
 arch/mips/cavium-octeon/executive/cvmx-pko.c  |   2 +-
 arch/mips/cavium-octeon/octeon-platform.c     |   4 +-
 arch/mips/cavium-octeon/octeon-usb.c          |   2 +-
 arch/mips/dec/tc.c                            |   2 +-
 arch/mips/include/asm/fpu.h                   |   2 +-
 arch/mips/include/asm/octeon/cvmx-sli-defs.h  |   2 +-
 arch/mips/include/asm/page.h                  |   2 +-
 arch/mips/include/asm/unroll.h                |  64 +++++-----
 arch/mips/kernel/branch.c                     |  26 ++--
 arch/mips/kernel/cpu-probe.c                  |  22 ++--
 arch/mips/kernel/idle.c                       |   2 +-
 arch/mips/kernel/mips-r2-to-r6-emul.c         |   2 +-
 arch/mips/kernel/perf_event_mipsxx.c          |   6 +-
 arch/mips/kernel/signal.c                     |   2 +-
 arch/mips/kernel/traps.c                      |   3 +-
 arch/mips/kernel/watch.c                      |  26 ++--
 arch/mips/kvm/emulate.c                       |   8 +-
 arch/mips/math-emu/cp1emu.c                   |  28 ++---
 arch/mips/math-emu/dp_add.c                   |   3 +-
 arch/mips/math-emu/dp_div.c                   |   3 +-
 arch/mips/math-emu/dp_fmax.c                  |   6 +-
 arch/mips/math-emu/dp_fmin.c                  |   6 +-
 arch/mips/math-emu/dp_maddf.c                 |   3 +-
 arch/mips/math-emu/dp_mul.c                   |   3 +-
 arch/mips/math-emu/dp_sqrt.c                  |   5 +-
 arch/mips/math-emu/dp_sub.c                   |   3 +-
 arch/mips/math-emu/sp_add.c                   |   3 +-
 arch/mips/math-emu/sp_div.c                   |   3 +-
 arch/mips/math-emu/sp_fdp.c                   |   3 +-
 arch/mips/math-emu/sp_fmax.c                  |   6 +-
 arch/mips/math-emu/sp_fmin.c                  |   6 +-
 arch/mips/math-emu/sp_maddf.c                 |   3 +-
 arch/mips/math-emu/sp_mul.c                   |   3 +-
 arch/mips/math-emu/sp_sub.c                   |   3 +-
 arch/mips/mm/c-r4k.c                          |   6 +-
 arch/mips/mm/tlbex.c                          |   2 +-
 arch/mips/oprofile/op_model_mipsxx.c          |  26 ++--
 arch/mips/pci/fixup-sni.c                     |   3 +-
 arch/mips/pci/ops-bcm63xx.c                   |   2 +-
 arch/nds32/kernel/fpu.c                       |  12 +-
 arch/nds32/kernel/signal.c                    |   4 +-
 arch/openrisc/kernel/signal.c                 |   2 +-
 arch/parisc/kernel/signal.c                   |   2 +-
 arch/parisc/kernel/traps.c                    |  10 +-
 arch/parisc/mm/fault.c                        |   5 +-
 arch/powerpc/kernel/align.c                   |   8 +-
 arch/powerpc/kvm/book3s_32_mmu.c              |   2 +-
 arch/powerpc/kvm/book3s_64_mmu.c              |   2 +-
 arch/powerpc/kvm/book3s_pr.c                  |   2 +-
 arch/powerpc/kvm/booke.c                      |   6 +-
 arch/powerpc/kvm/powerpc.c                    |   1 -
 arch/powerpc/platforms/cell/spufs/switch.c    |   2 +-
 arch/powerpc/platforms/powermac/feature.c     |   2 +-
 arch/powerpc/platforms/powernv/opal-async.c   |   2 +-
 arch/powerpc/platforms/pseries/hvcserver.c    |   2 +-
 arch/powerpc/xmon/xmon.c                      |   2 +-
 arch/riscv/kernel/signal.c                    |   2 +-
 arch/riscv/net/bpf_jit_comp32.c               |   5 +-
 arch/s390/kernel/signal.c                     |   4 +-
 arch/s390/kernel/topology.c                   |   2 +-
 arch/s390/kvm/gaccess.c                       |  23 ++--
 arch/s390/kvm/interrupt.c                     |   2 +-
 arch/s390/kvm/kvm-s390.c                      |   4 +-
 arch/s390/mm/fault.c                          |  13 +-
 arch/s390/mm/gmap.c                           |   6 +-
 arch/s390/mm/pgalloc.c                        |   2 +-
 arch/sh/drivers/platform_early.c              |   2 +-
 arch/sh/kernel/disassemble.c                  |   4 +-
 arch/sh/kernel/kgdb.c                         |   2 +-
 arch/sh/kernel/signal_32.c                    |   2 +-
 arch/sh/kernel/signal_64.c                    |   2 +-
 arch/sparc/kernel/auxio_64.c                  |   1 -
 arch/sparc/kernel/central.c                   |   2 +-
 arch/sparc/kernel/kgdb_32.c                   |   3 +-
 arch/sparc/kernel/kgdb_64.c                   |   3 +-
 arch/sparc/kernel/pcr.c                       |   2 +-
 arch/sparc/kernel/prom_32.c                   |   3 +-
 arch/sparc/kernel/signal32.c                  |   4 +-
 arch/sparc/kernel/signal_32.c                 |   4 +-
 arch/sparc/kernel/signal_64.c                 |   4 +-
 arch/sparc/math-emu/math_32.c                 |   8 +-
 arch/sparc/net/bpf_jit_comp_32.c              |   2 +-
 arch/um/kernel/signal.c                       |   2 +-
 arch/unicore32/kernel/signal.c                |   2 +-
 arch/x86/boot/cmdline.c                       |   6 +-
 arch/x86/boot/compressed/kaslr.c              |   2 +-
 arch/x86/events/intel/core.c                  |   7 +-
 arch/x86/events/intel/lbr.c                   |   2 +-
 arch/x86/kernel/alternative.c                 |   4 +-
 arch/x86/kernel/apic/io_apic.c                |   4 +-
 arch/x86/kernel/apic/probe_32.c               |   2 +-
 arch/x86/kernel/cpu/cacheinfo.c               |   2 +-
 arch/x86/kernel/cpu/mce/inject.c              |   2 +-
 arch/x86/kernel/cpu/mce/intel.c               |   4 +-
 arch/x86/kernel/cpu/mtrr/cyrix.c              |   2 +-
 arch/x86/kernel/hw_breakpoint.c               |   2 +-
 arch/x86/kernel/kgdb.c                        |   4 +-
 arch/x86/kernel/mpparse.c                     |   4 +-
 arch/x86/kernel/ptrace.c                      |   3 +-
 arch/x86/kernel/reboot.c                      |   3 +-
 arch/x86/kernel/signal.c                      |   2 +-
 arch/x86/kernel/uprobes.c                     |   4 +-
 arch/x86/kvm/emulate.c                        |   2 +-
 arch/x86/kvm/hyperv.c                         |   2 +-
 arch/x86/kvm/irq_comm.c                       |   2 +-
 arch/x86/kvm/lapic.c                          |   6 +-
 arch/x86/kvm/mmu/mmu.c                        |   2 +-
 arch/x86/kvm/svm.c                            |   2 +-
 arch/x86/kvm/vmx/vmx.c                        |  15 ++-
 arch/x86/kvm/x86.c                            |  12 +-
 arch/x86/lib/cmdline.c                        |  12 +-
 arch/x86/lib/insn-eval.c                      |   8 +-
 arch/x86/math-emu/errors.c                    |   2 +-
 arch/x86/math-emu/fpu_trig.c                  |   2 +-
 arch/x86/mm/ioremap.c                         |   3 +-
 arch/xtensa/kernel/signal.c                   |   2 +-
 block/badblocks.c                             |   2 +-
 block/bfq-iosched.c                           |   4 +-
 block/blk-wbt.c                               |   2 +-
 crypto/drbg.c                                 |   3 +-
 crypto/tcrypt.c                               | 114 +++++++++---------
 .../accessibility/braille/braille_console.c   |   2 +-
 drivers/acpi/ac.c                             |   2 +-
 drivers/acpi/acpi_processor.c                 |   3 +-
 drivers/acpi/acpica/dscontrol.c               |   4 +-
 drivers/acpi/acpica/dswexec.c                 |   3 +-
 drivers/acpi/acpica/dswload.c                 |   4 +-
 drivers/acpi/acpica/dswload2.c                |   4 +-
 drivers/acpi/acpica/exfldio.c                 |   4 +-
 drivers/acpi/acpica/exresop.c                 |   7 +-
 drivers/acpi/acpica/exstore.c                 |   8 +-
 drivers/acpi/acpica/hwgpe.c                   |   4 +-
 drivers/acpi/acpica/utdelete.c                |   4 +-
 drivers/acpi/acpica/utprint.c                 |   3 +-
 drivers/acpi/button.c                         |   2 +-
 drivers/acpi/dock.c                           |   2 +-
 drivers/acpi/processor_idle.c                 |   3 +-
 drivers/acpi/resource.c                       |   2 +-
 drivers/acpi/spcr.c                           |   4 +-
 drivers/ata/ahci_brcm.c                       |   2 +-
 drivers/ata/libahci_platform.c                |   2 +-
 drivers/ata/libata-core.c                     |  16 +--
 drivers/ata/libata-eh.c                       |   6 +-
 drivers/ata/libata-scsi.c                     |   2 +-
 drivers/ata/pata_atp867x.c                    |   4 +-
 drivers/ata/pata_serverworks.c                |   2 +-
 drivers/ata/sata_mv.c                         |  12 +-
 drivers/ata/sata_promise.c                    |   8 +-
 drivers/ata/sata_sx4.c                        |   2 +-
 drivers/atm/firestream.c                      |   2 +-
 drivers/atm/fore200e.c                        |  24 ++--
 drivers/atm/he.c                              |   4 +-
 drivers/atm/idt77105.c                        |   2 +-
 drivers/atm/lanai.c                           |   2 +-
 drivers/atm/zatm.c                            |   2 +-
 drivers/auxdisplay/panel.c                    |   6 +-
 drivers/base/firmware_loader/fallback.c       |   4 +-
 drivers/block/aoe/aoecmd.c                    |   2 +-
 drivers/block/ataflop.c                       |   2 +-
 drivers/block/drbd/drbd_int.h                 |   2 +-
 drivers/block/drbd/drbd_main.c                |   2 +-
 drivers/block/drbd/drbd_nl.c                  |   2 +-
 drivers/block/drbd/drbd_receiver.c            |  13 +-
 drivers/block/drbd/drbd_req.c                 |   5 +-
 drivers/block/floppy.c                        |   4 +-
 drivers/block/loop.c                          |   4 +-
 drivers/block/paride/pd.c                     |   4 +-
 drivers/block/rbd.c                           |   8 +-
 drivers/block/rsxx/core.c                     |   2 +-
 drivers/block/skd_main.c                      |   3 +-
 drivers/block/xen-blkback/blkback.c           |   2 +-
 drivers/block/xen-blkfront.c                  |   5 +-
 drivers/bluetooth/bcm203x.c                   |   2 +-
 drivers/bluetooth/bluecard_cs.c               |   2 -
 drivers/bluetooth/hci_ll.c                    |   2 +-
 drivers/bluetooth/hci_qca.c                   |   8 +-
 drivers/bus/ti-sysc.c                         |   2 +-
 drivers/char/agp/ali-agp.c                    |   2 +-
 drivers/char/ipmi/kcs_bmc.c                   |   3 +-
 drivers/char/lp.c                             |   4 +-
 drivers/char/mem.c                            |   2 +-
 drivers/char/nvram.c                          |   2 +-
 drivers/clk/davinci/pll.c                     |   2 +-
 drivers/clk/imx/clk-pllv3.c                   |   4 +-
 drivers/clk/samsung/clk-s3c2443.c             |   2 +-
 drivers/clocksource/timer-cadence-ttc.c       |   5 +-
 drivers/cpufreq/p4-clockmod.c                 |   2 +-
 drivers/cpufreq/speedstep-lib.c               |   2 +-
 drivers/cpufreq/ti-cpufreq.c                  |   4 +-
 drivers/crypto/axis/artpec6_crypto.c          |   3 +-
 drivers/crypto/cavium/cpt/cptvf_reqmanager.c  |   4 +-
 drivers/crypto/chelsio/chcr_ktls.c            |   4 +-
 drivers/crypto/qat/qat_common/adf_pf2vf_msg.c |   2 +-
 drivers/crypto/qat/qat_common/qat_uclo.c      |   6 +-
 drivers/crypto/ux500/cryp/cryp.c              |  18 +--
 drivers/dma/amba-pl08x.c                      |  10 +-
 drivers/dma/fsldma.c                          |   2 +-
 drivers/dma/imx-dma.c                         |   2 +-
 drivers/dma/iop-adma.h                        |  12 +-
 drivers/dma/nbpfaxi.c                         |   2 +-
 drivers/dma/pl330.c                           |  13 +-
 drivers/dma/sh/shdma-base.c                   |   2 +-
 drivers/edac/amd64_edac.c                     |   2 +-
 drivers/edac/pnd2_edac.c                      |   2 +-
 drivers/firewire/core-device.c                |   2 +-
 drivers/firewire/core-iso.c                   |   3 +-
 drivers/firewire/core-topology.c              |   2 +-
 drivers/firewire/core-transaction.c           |   6 +-
 drivers/firewire/ohci.c                       |   5 +-
 drivers/gpio/gpio-aspeed-sgpio.c              |   6 +-
 drivers/gpio/gpio-aspeed.c                    |   6 +-
 drivers/gpio/gpio-ath79.c                     |   2 +-
 drivers/gpio/gpio-eic-sprd.c                  |   4 +-
 drivers/gpio/gpio-stmpe.c                     |   4 +-
 drivers/gpio/gpiolib-acpi.c                   |   2 +-
 .../drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c   |   2 +-
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c         |   3 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c         |   2 +-
 drivers/gpu/drm/amd/amdgpu/si_dpm.c           |   4 +-
 .../drm/amd/display/dc/bios/bios_parser2.c    |   4 +-
 drivers/gpu/drm/amd/display/dc/dce/dce_aux.c  |   2 +-
 .../drm/amd/display/dc/dce/dce_mem_input.c    |   2 +-
 .../gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c  |   6 +-
 drivers/gpu/drm/arm/malidp_hw.c               |   6 +-
 drivers/gpu/drm/ast/ast_main.c                |   2 +-
 .../drm/bridge/synopsys/dw-hdmi-i2s-audio.c   |   4 +-
 drivers/gpu/drm/bridge/ti-sn65dsi86.c         |   6 +-
 drivers/gpu/drm/drm_bufs.c                    |   2 +-
 drivers/gpu/drm/drm_dp_helper.c               |   2 +-
 drivers/gpu/drm/drm_modes.c                   |   2 +-
 drivers/gpu/drm/drm_vm.c                      |   4 +-
 drivers/gpu/drm/exynos/exynos_drm_dsi.c       |  10 +-
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c   |   6 +-
 drivers/gpu/drm/i915/display/icl_dsi.c        |   6 +-
 drivers/gpu/drm/i915/display/intel_bios.c     |   6 +-
 drivers/gpu/drm/i915/display/intel_cdclk.c    |  10 +-
 .../gpu/drm/i915/display/intel_combo_phy.c    |   6 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |   4 +-
 drivers/gpu/drm/i915/display/intel_display.c  |  20 +--
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |   8 +-
 drivers/gpu/drm/i915/display/intel_sdvo.c     |  12 +-
 drivers/gpu/drm/i915/display/intel_sprite.c   |  22 ++--
 drivers/gpu/drm/i915/display/intel_tc.c       |   2 +-
 drivers/gpu/drm/i915/gem/i915_gem_mman.c      |   2 +-
 drivers/gpu/drm/i915/gem/i915_gem_pages.c     |   2 +-
 drivers/gpu/drm/i915/gem/i915_gem_stolen.c    |   6 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |   2 +-
 drivers/gpu/drm/i915/gt/intel_ggtt.c          |   2 +-
 drivers/gpu/drm/i915/gt/intel_lrc.c           |   2 +-
 .../gpu/drm/i915/gt/intel_ring_submission.c   |   2 +-
 drivers/gpu/drm/i915/gvt/handlers.c           |   2 +-
 drivers/gpu/drm/i915/i915_gpu_error.c         |   2 +-
 drivers/gpu/drm/i915/i915_pmu.c               |   2 +-
 drivers/gpu/drm/i915/intel_device_info.c      |   4 +-
 drivers/gpu/drm/imx/ipuv3-plane.c             |   3 +-
 drivers/gpu/drm/ingenic/ingenic-drm.c         |   2 +-
 drivers/gpu/drm/meson/meson_crtc.c            |   4 +-
 drivers/gpu/drm/meson/meson_osd_afbcd.c       |   2 +-
 drivers/gpu/drm/meson/meson_overlay.c         |   4 +-
 drivers/gpu/drm/msm/adreno/a5xx_gpu.c         |   4 +-
 drivers/gpu/drm/msm/adreno/a6xx_gmu.c         |   2 +-
 drivers/gpu/drm/msm/adreno/a6xx_gpu.c         |   2 +-
 drivers/gpu/drm/msm/adreno/adreno_gpu.c       |   2 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.c       |   2 +-
 drivers/gpu/drm/nouveau/nouveau_bo.c          |   2 +-
 drivers/gpu/drm/nouveau/nouveau_connector.c   |   4 +-
 .../gpu/drm/nouveau/nvkm/engine/disp/hdmi.c   |  34 +++---
 .../drm/nouveau/nvkm/engine/dma/usernv04.c    |   2 +-
 .../gpu/drm/nouveau/nvkm/engine/fifo/nv04.c   |   4 +-
 .../gpu/drm/nouveau/nvkm/engine/fifo/nv40.c   |   2 +-
 .../gpu/drm/nouveau/nvkm/subdev/bios/dcb.c    |   3 +-
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c |   2 +-
 .../gpu/drm/nouveau/nvkm/subdev/bios/perf.c   |   2 +-
 .../gpu/drm/nouveau/nvkm/subdev/bios/pll.c    |   2 +-
 .../gpu/drm/nouveau/nvkm/subdev/bios/timing.c |  10 +-
 .../gpu/drm/nouveau/nvkm/subdev/clk/base.c    |   2 +-
 .../gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c   |   2 +-
 .../drm/nouveau/nvkm/subdev/devinit/nv04.c    |  18 ++-
 .../gpu/drm/nouveau/nvkm/subdev/fb/ramnv40.c  |   4 +-
 .../gpu/drm/nouveau/nvkm/subdev/mxm/nv50.c    |   2 +-
 drivers/gpu/drm/omapdrm/dss/venc.c            |   2 +-
 drivers/gpu/drm/radeon/ci_dpm.c               |   4 +-
 drivers/gpu/drm/radeon/r300.c                 |   4 +-
 drivers/gpu/drm/radeon/r420.c                 |   2 +-
 drivers/gpu/drm/radeon/r600_cs.c              |   4 +-
 drivers/gpu/drm/radeon/radeon_uvd.c           |   3 +-
 drivers/gpu/drm/radeon/si_dpm.c               |   4 +-
 drivers/gpu/drm/radeon/uvd_v1_0.c             |   3 +-
 drivers/gpu/drm/savage/savage_state.c         |  10 +-
 drivers/gpu/drm/sti/sti_hdmi.c                |   6 +-
 drivers/gpu/drm/sun4i/sun4i_tcon.c            |   4 +-
 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c        |   3 +-
 drivers/gpu/drm/tegra/dc.c                    |   2 +-
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c          |   2 +-
 drivers/gpu/drm/ttm/ttm_bo_vm.c               |   2 +-
 drivers/gpu/drm/via/via_dmablit.c             |   8 +-
 drivers/gpu/drm/xen/xen_drm_front.c           |   3 -
 drivers/gpu/ipu-v3/ipu-dc.c                   |   2 +-
 drivers/greybus/es2.c                         |   2 +-
 drivers/greybus/interface.c                   |   2 +-
 drivers/hid/hid-lg-g15.c                      |   2 +-
 drivers/hid/hid-logitech-dj.c                 |   2 +-
 drivers/hid/hid-microsoft.c                   |   3 -
 drivers/hid/hid-rmi.c                         |   1 -
 drivers/hid/hid-roccat-kone.c                 |   2 +-
 drivers/hid/hid-uclogic-params.c              |   2 +-
 drivers/hid/hid-wiimote-core.c                |   2 -
 drivers/hid/usbhid/hiddev.c                   |   1 -
 drivers/hid/wacom_wac.c                       |  47 +++-----
 drivers/hsi/clients/ssi_protocol.c            |   4 +-
 drivers/hsi/controllers/omap_ssi_core.c       |   2 +-
 drivers/hv/hv_kvp.c                           |   4 +-
 drivers/hv/vmbus_drv.c                        |   2 +-
 drivers/hwmon/adt7462.c                       |   8 +-
 drivers/hwmon/emc1403.c                       |   4 +-
 drivers/hwmon/f71882fg.c                      |   4 +-
 drivers/hwmon/hwmon-vid.c                     |   4 +-
 drivers/hwmon/ina3221.c                       |   3 +-
 drivers/hwmon/nct6775.c                       |   2 +-
 drivers/hwmon/occ/common.c                    |   6 +-
 drivers/hwmon/w83627hf.c                      |   2 +-
 drivers/hwmon/w83781d.c                       |   2 +-
 drivers/hwmon/w83795.c                        |   2 +-
 .../hwtracing/coresight/coresight-cpu-debug.c |   4 +-
 drivers/hwtracing/coresight/coresight-etm4x.c |   1 -
 .../hwtracing/coresight/coresight-platform.c  |   3 +-
 drivers/hwtracing/coresight/coresight-tmc.c   |   2 -
 drivers/hwtracing/intel_th/sth.c              |   6 +-
 drivers/i2c/busses/i2c-amd8111.c              |   2 +-
 drivers/i2c/busses/i2c-aspeed.c               |   4 +-
 drivers/i2c/busses/i2c-designware-pcidrv.c    |   2 +-
 drivers/i2c/busses/i2c-digicolor.c            |   2 +-
 drivers/i2c/busses/i2c-i801.c                 |   8 +-
 drivers/i2c/busses/i2c-mv64xxx.c              |   9 +-
 drivers/i2c/busses/i2c-omap.c                 |   1 -
 drivers/i2c/busses/i2c-opal.c                 |   2 +-
 drivers/i2c/busses/i2c-s3c2410.c              |   3 +-
 drivers/i2c/busses/i2c-synquacer.c            |   4 +-
 drivers/i2c/busses/i2c-viapro.c               |   2 +-
 drivers/i2c/busses/scx200_acb.c               |   3 +-
 drivers/i2c/i2c-slave-eeprom.c                |   2 +-
 drivers/i3c/master/dw-i3c-master.c            |   2 +-
 drivers/ide/hpt366.c                          |   6 +-
 drivers/ide/ide-cd.c                          |   4 +-
 drivers/ide/ide-floppy.c                      |   2 +-
 drivers/ide/ide-probe.c                       |   2 +-
 drivers/ide/ide-taskfile.c                    |  12 +-
 drivers/ide/sis5513.c                         |   2 +-
 drivers/iio/accel/mma8452.c                   |   2 +-
 drivers/iio/adc/ab8500-gpadc.c                |   2 +-
 drivers/iio/adc/cpcap-adc.c                   |   2 +-
 drivers/iio/chemical/sps30.c                  |   2 +-
 drivers/iio/dac/ad5592r-base.c                |   2 -
 drivers/iio/dac/dpot-dac.c                    |   2 +-
 drivers/iio/health/max30102.c                 |   4 +-
 drivers/iio/imu/adis.c                        |   6 +-
 drivers/iio/industrialio-core.c               |   2 +-
 drivers/iio/light/si1145.c                    |   2 +-
 drivers/iio/magnetometer/ak8974.c             |   2 +-
 drivers/infiniband/core/cm.c                  |  14 +--
 drivers/infiniband/core/cma.c                 |   3 +-
 drivers/infiniband/core/ucma.c                |   4 +-
 drivers/infiniband/core/uverbs_ioctl.c        |   5 +-
 drivers/infiniband/hw/bnxt_re/ib_verbs.c      |   2 +-
 drivers/infiniband/hw/bnxt_re/qplib_fp.c      |   2 +-
 drivers/infiniband/hw/cxgb4/cm.c              |   4 +-
 drivers/infiniband/hw/cxgb4/qp.c              |   2 +-
 drivers/infiniband/hw/hfi1/chip.c             |   8 +-
 drivers/infiniband/hw/hfi1/firmware.c         |  16 ---
 drivers/infiniband/hw/hfi1/mad.c              |   9 +-
 drivers/infiniband/hw/hfi1/pio.c              |   2 +-
 drivers/infiniband/hw/hfi1/pio_copy.c         |  12 +-
 drivers/infiniband/hw/hfi1/platform.c         |  12 +-
 drivers/infiniband/hw/hfi1/qp.c               |   2 +-
 drivers/infiniband/hw/hfi1/qsfp.c             |   4 +-
 drivers/infiniband/hw/hfi1/rc.c               |  25 ++--
 drivers/infiniband/hw/hfi1/sdma.c             |   9 +-
 drivers/infiniband/hw/hfi1/tid_rdma.c         |   5 +-
 drivers/infiniband/hw/hfi1/uc.c               |   8 +-
 drivers/infiniband/hw/i40iw/i40iw_cm.c        |   2 +-
 drivers/infiniband/hw/i40iw/i40iw_ctrl.c      |   5 +-
 drivers/infiniband/hw/i40iw/i40iw_hw.c        |   3 +-
 drivers/infiniband/hw/i40iw/i40iw_main.c      |  21 ++--
 drivers/infiniband/hw/i40iw/i40iw_puda.c      |   4 +-
 drivers/infiniband/hw/i40iw/i40iw_utils.c     |   8 +-
 drivers/infiniband/hw/i40iw/i40iw_verbs.c     |   5 +-
 drivers/infiniband/hw/mlx4/cq.c               |   4 +-
 drivers/infiniband/hw/mlx4/mcg.c              |   2 +-
 drivers/infiniband/hw/mlx4/qp.c               |   6 +-
 drivers/infiniband/hw/mlx5/cq.c               |   4 +-
 drivers/infiniband/hw/mlx5/mad.c              |   3 +-
 drivers/infiniband/hw/mlx5/main.c             |   6 +-
 drivers/infiniband/hw/mlx5/qp.c               |  11 +-
 drivers/infiniband/hw/mthca/mthca_av.c        |   2 +-
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c   |   4 +-
 drivers/infiniband/hw/qedr/verbs.c            |   3 +-
 drivers/infiniband/hw/qib/qib_iba6120.c       |   4 +-
 drivers/infiniband/hw/qib/qib_iba7220.c       |   4 +-
 drivers/infiniband/hw/qib/qib_iba7322.c       |   6 +-
 drivers/infiniband/hw/qib/qib_mad.c           |  14 +--
 drivers/infiniband/hw/qib/qib_rc.c            |  18 +--
 drivers/infiniband/hw/qib/qib_sdma.c          |   2 +-
 drivers/infiniband/hw/qib/qib_uc.c            |   8 +-
 drivers/infiniband/hw/qib/qib_verbs.c         |   2 +-
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c  |   2 +-
 drivers/infiniband/sw/rdmavt/qp.c             |   2 +-
 drivers/infiniband/sw/rxe/rxe_task.c          |   2 +-
 drivers/infiniband/sw/rxe/rxe_verbs.c         |   2 +-
 drivers/infiniband/sw/siw/siw_cm.c            |   2 -
 drivers/infiniband/sw/siw/siw_qp_rx.c         |   6 +-
 drivers/infiniband/sw/siw/siw_qp_tx.c         |   6 +-
 drivers/infiniband/ulp/ipoib/ipoib_cm.c       |   4 +-
 drivers/infiniband/ulp/ipoib/ipoib_main.c     |   2 +-
 drivers/infiniband/ulp/iser/iser_verbs.c      |   2 +-
 drivers/infiniband/ulp/isert/ib_isert.c       |  10 +-
 .../infiniband/ulp/opa_vnic/opa_vnic_vema.c   |   1 -
 drivers/input/joystick/db9.c                  |  11 +-
 drivers/input/joystick/fsia6b.c               |   4 +-
 drivers/input/joystick/gamecon.c              |  10 +-
 drivers/input/joystick/sidewinder.c           |  15 ++-
 drivers/input/joystick/spaceball.c            |   8 +-
 drivers/input/keyboard/adp5589-keys.c         |   2 +-
 drivers/input/keyboard/atkbd.c                |   3 +-
 drivers/input/keyboard/gpio_keys.c            |   1 -
 drivers/input/misc/pwm-vibra.c                |   3 +-
 drivers/input/misc/xen-kbdfront.c             |   5 +-
 drivers/input/mouse/appletouch.c              |   2 +-
 drivers/input/mouse/cyapa_gen3.c              |   6 +-
 drivers/input/mouse/cyapa_gen5.c              |   3 +-
 drivers/input/mouse/cyapa_gen6.c              |   3 +-
 drivers/input/mouse/elantech.c                |   6 +-
 drivers/input/mouse/hgpk.c                    |   8 +-
 drivers/input/mouse/navpoint.c                |   2 +-
 drivers/input/mouse/sentelic.c                |   3 +-
 drivers/input/mouse/sermouse.c                |   6 +-
 drivers/input/serio/i8042.c                   |   2 +-
 drivers/input/serio/libps2.c                  |   2 +-
 drivers/input/sparse-keymap.c                 |   3 +-
 drivers/input/tablet/gtco.c                   |   9 +-
 drivers/input/tablet/pegasus_notetaker.c      |   3 +-
 drivers/input/tablet/wacom_serial4.c          |   2 +-
 drivers/input/touchscreen/atmel_mxt_ts.c      |   2 +-
 drivers/input/touchscreen/edt-ft5x06.c        |   5 +-
 drivers/input/touchscreen/elants_i2c.c        |   3 +-
 drivers/input/touchscreen/elo.c               |   3 +-
 drivers/input/touchscreen/iqs5xx.c            |   2 +-
 drivers/input/touchscreen/max11801_ts.c       |   1 -
 drivers/input/touchscreen/stmfts.c            |   3 +-
 drivers/input/touchscreen/wm831x-ts.c         |   2 +-
 drivers/iommu/amd_iommu_init.c                |   2 +-
 drivers/iommu/arm-smmu-v3.c                   |  11 +-
 drivers/iommu/intel-iommu.c                   |   1 -
 drivers/iommu/virtio-iommu.c                  |   2 +-
 drivers/irqchip/irq-gic-v3-its.c              |   4 +-
 drivers/irqchip/irq-gic-v3.c                  |   8 +-
 drivers/irqchip/irq-imx-gpcv2.c               |   2 +-
 drivers/irqchip/irq-mips-gic.c                |   2 +-
 drivers/irqchip/irq-vic.c                     |   2 +-
 drivers/isdn/hardware/mISDN/avmfritz.c        |   2 +-
 drivers/isdn/hardware/mISDN/hfcpci.c          |   2 +-
 drivers/isdn/hardware/mISDN/hfcsusb.c         |   2 +-
 drivers/isdn/hardware/mISDN/isdnhdlc.c        |   2 +-
 drivers/isdn/hardware/mISDN/mISDNinfineon.c   |   2 +-
 drivers/isdn/hardware/mISDN/mISDNisar.c       |   8 +-
 drivers/isdn/mISDN/stack.c                    |   2 +-
 drivers/lightnvm/pblk-core.c                  |   2 +-
 drivers/macintosh/adbhid.c                    |   3 +-
 drivers/macintosh/smu.c                       |   2 +-
 drivers/md/bcache/journal.c                   |   3 +-
 drivers/md/bcache/util.c                      |  14 +--
 drivers/md/dm-mpath.c                         |   2 +-
 drivers/md/dm.c                               |   2 +-
 drivers/md/md-bitmap.c                        |   2 +-
 drivers/md/raid5.c                            |   4 +-
 drivers/media/cec/cec-adap.c                  |   2 +-
 drivers/media/cec/cec-pin.c                   |   6 +-
 drivers/media/common/v4l2-tpg/v4l2-tpg-core.c |  36 +++---
 .../media/common/videobuf2/videobuf2-v4l2.c   |   2 +-
 drivers/media/dvb-core/dvb_net.c              |   2 +-
 drivers/media/dvb-frontends/af9013.c          |   2 +-
 drivers/media/dvb-frontends/bcm3510.c         |   2 +-
 drivers/media/dvb-frontends/dib0090.c         |   3 +-
 drivers/media/dvb-frontends/dib3000mb.c       |   2 +-
 drivers/media/dvb-frontends/dib7000p.c        |   2 +-
 drivers/media/dvb-frontends/drx39xyj/drxj.c   |  99 ++++++++-------
 drivers/media/dvb-frontends/drxd_hard.c       |  12 +-
 drivers/media/dvb-frontends/drxk_hard.c       |  24 ++--
 drivers/media/dvb-frontends/lg2160.c          |   2 +-
 drivers/media/dvb-frontends/lgdt3306a.c       |   2 +-
 drivers/media/dvb-frontends/mt352.c           |   2 +-
 drivers/media/dvb-frontends/mxl5xx.c          |   2 +-
 drivers/media/dvb-frontends/or51132.c         |   2 +-
 drivers/media/dvb-frontends/s5h1411.c         |   2 +-
 drivers/media/dvb-frontends/zl10353.c         |   4 +-
 drivers/media/i2c/adv7180.c                   |   2 +-
 drivers/media/i2c/adv7511-v4l2.c              |   4 +-
 drivers/media/i2c/msp3400-kthreads.c          |   2 +-
 drivers/media/i2c/ov5640.c                    |   2 +-
 drivers/media/i2c/ov6650.c                    |   4 +-
 drivers/media/i2c/ov9640.c                    |   2 +-
 drivers/media/i2c/s5c73m3/s5c73m3-ctrls.c     |   2 +-
 drivers/media/i2c/smiapp/smiapp-core.c        |   6 +-
 drivers/media/i2c/tda1997x.c                  |  10 +-
 drivers/media/i2c/tvp5150.c                   |   2 +-
 drivers/media/pci/bt8xx/bttv-driver.c         |   2 +-
 drivers/media/pci/cx23885/cx23885-cards.c     |   4 +-
 drivers/media/pci/cx88/cx88-cards.c           |   2 +-
 drivers/media/pci/cx88/cx88-video.c           |   2 +-
 drivers/media/pci/ddbridge/ddbridge-core.c    |  23 ++--
 drivers/media/pci/meye/meye.c                 |   2 +-
 drivers/media/pci/saa7134/saa7134-cards.c     |   4 +-
 drivers/media/pci/solo6x10/solo6x10-core.c    |   2 +-
 drivers/media/pci/solo6x10/solo6x10-i2c.c     |   2 +-
 drivers/media/pci/ttpci/av7110.c              |   6 +-
 drivers/media/pci/ttpci/av7110_hw.c           |   2 +-
 drivers/media/pci/ttpci/av7110_ipack.c        |   2 +-
 drivers/media/pci/ttpci/budget-av.c           |   2 +-
 drivers/media/pci/ttpci/budget.c              |   5 +-
 drivers/media/platform/coda/coda-bit.c        |   4 +-
 drivers/media/platform/coda/coda-common.c     |  10 +-
 .../media/platform/exynos4-is/fimc-capture.c  |   6 +-
 drivers/media/platform/exynos4-is/fimc-reg.c  |   2 +-
 drivers/media/platform/exynos4-is/media-dev.c |   2 +-
 .../media/platform/marvell-ccic/mcam-core.c   |   2 +-
 drivers/media/platform/omap3isp/ispvideo.c    |   2 +-
 drivers/media/platform/pxa_camera.c           |   6 +-
 drivers/media/platform/qcom/venus/vdec.c      |   2 +-
 drivers/media/platform/renesas-ceu.c          |   4 +-
 drivers/media/platform/sh_vou.c               |   4 +-
 drivers/media/platform/vicodec/vicodec-core.c |   2 +-
 drivers/media/platform/vivid/vivid-vbi-gen.c  |   2 +-
 drivers/media/radio/radio-si476x.c            |   3 +-
 drivers/media/radio/si4713/si4713.c           |   2 +-
 drivers/media/radio/tea575x.c                 |   2 +-
 drivers/media/rc/bpf-lirc.c                   |   2 +-
 drivers/media/rc/iguanair.c                   |   2 +-
 drivers/media/rc/ir-rc6-decoder.c             |   2 +-
 drivers/media/rc/ir-sony-decoder.c            |   3 +-
 drivers/media/tuners/fc0011.c                 |   2 +-
 drivers/media/tuners/tda18271-fe.c            |   2 +-
 drivers/media/tuners/xc5000.c                 |   2 +-
 drivers/media/usb/b2c2/flexcop-usb.c          |   2 +-
 drivers/media/usb/cpia2/cpia2_core.c          |  36 +++---
 drivers/media/usb/cx231xx/cx231xx-video.c     |   2 +-
 drivers/media/usb/dvb-usb-v2/af9015.c         |   2 +-
 drivers/media/usb/dvb-usb-v2/gl861.c          |   2 +-
 drivers/media/usb/dvb-usb-v2/lmedm04.c        |   8 +-
 drivers/media/usb/dvb-usb-v2/mxl111sf-gpio.c  |   4 +-
 drivers/media/usb/dvb-usb/dib0700_devices.c   |   2 +-
 drivers/media/usb/dvb-usb/dw2102.c            |   6 +-
 drivers/media/usb/em28xx/em28xx-audio.c       |   8 +-
 drivers/media/usb/go7007/go7007-driver.c      |   2 +-
 drivers/media/usb/gspca/mr97310a.c            |  10 +-
 drivers/media/usb/gspca/nw80x.c               |   2 +-
 drivers/media/usb/gspca/ov519.c               |   6 +-
 drivers/media/usb/gspca/sn9c20x.c             |   2 +-
 drivers/media/usb/gspca/sunplus.c             |   4 +-
 drivers/media/usb/gspca/xirlink_cit.c         |   4 +-
 drivers/media/usb/gspca/zc3xx.c               |   4 +-
 drivers/media/usb/pulse8-cec/pulse8-cec.c     |   2 +-
 drivers/media/usb/pwc/pwc-v4l.c               |   2 +-
 drivers/media/usb/siano/smsusb.c              |   2 +-
 drivers/media/usb/tm6000/tm6000-alsa.c        |   8 +-
 drivers/media/usb/uvc/uvc_video.c             |   4 +-
 drivers/media/v4l2-core/v4l2-ctrls.c          |   2 +-
 drivers/media/v4l2-core/v4l2-ioctl.c          |   2 -
 drivers/media/v4l2-core/videobuf-core.c       |   2 +-
 drivers/memory/omap-gpmc.c                    |   1 -
 drivers/memstick/core/ms_block.c              |  18 +--
 drivers/memstick/host/jmb38x_ms.c             |   4 +-
 drivers/memstick/host/tifm_ms.c               |   4 +-
 drivers/message/fusion/mptbase.c              |   7 +-
 drivers/message/fusion/mptsas.c               |   3 +-
 drivers/message/fusion/mptscsih.c             |   5 +-
 drivers/mfd/db8500-prcmu.c                    |   4 +-
 drivers/mfd/iqs62x.c                          |  12 +-
 drivers/mfd/mxs-lradc.c                       |   2 +-
 drivers/mfd/omap-usb-host.c                   |   6 +-
 drivers/mfd/rave-sp.c                         |   6 +-
 drivers/mfd/syscon.c                          |   2 +-
 drivers/misc/eeprom/at25.c                    |  10 +-
 drivers/misc/mic/scif/scif_api.c              |   4 +-
 drivers/misc/mic/scif/scif_rma.c              |   2 +-
 drivers/misc/sgi-gru/grukservices.c           |   4 +-
 drivers/misc/sgi-xp/xpc_main.c                |   6 +-
 drivers/misc/sgi-xp/xpc_partition.c           |   4 +-
 drivers/misc/sgi-xp/xpc_uv.c                  |   2 +-
 drivers/mmc/core/host.c                       |   2 +-
 drivers/mmc/host/atmel-mci.c                  |   8 +-
 drivers/mmc/host/davinci_mmc.c                |   2 +-
 drivers/mmc/host/dw_mmc-k3.c                  |   2 +-
 drivers/mmc/host/dw_mmc.c                     |  11 +-
 drivers/mmc/host/jz4740_mmc.c                 |   6 +-
 drivers/mmc/host/meson-mx-sdio.c              |   2 +-
 drivers/mmc/host/renesas_sdhi_core.c          |   2 +-
 drivers/mmc/host/sdhci-esdhc-imx.c            |   3 +-
 drivers/mmc/host/sdhci-s3c.c                  |   2 +-
 drivers/mmc/host/sdhci-sprd.c                 |   2 +-
 drivers/mmc/host/sdhci-xenon-phy.c            |   2 +-
 drivers/mmc/host/sdhci.c                      |   3 +-
 drivers/mmc/host/tifm_sd.c                    |   2 +-
 drivers/mmc/host/usdhi6rol0.c                 |   6 +-
 drivers/mtd/chips/cfi_cmdset_0001.c           |   4 +-
 drivers/mtd/chips/cfi_cmdset_0002.c           |   5 +-
 drivers/mtd/chips/cfi_cmdset_0020.c           |  17 +--
 drivers/mtd/chips/cfi_util.c                  |  12 +-
 drivers/mtd/devices/block2mtd.c               |   4 +-
 drivers/mtd/devices/phram.c                   |   4 +-
 drivers/mtd/lpddr/lpddr_cmds.c                |   3 +-
 drivers/mtd/maps/sa1100-flash.c               |   3 +-
 drivers/mtd/nand/onenand/onenand_base.c       |   2 +-
 drivers/mtd/nand/raw/diskonchip.c             |   2 +-
 drivers/mtd/nand/raw/fsl_elbc_nand.c          |   3 +-
 .../mtd/nand/raw/ingenic/ingenic_nand_drv.c   |   2 +-
 drivers/mtd/nand/raw/ingenic/jz4725b_bch.c    |   4 +-
 drivers/mtd/nand/raw/ingenic/jz4780_bch.c     |   4 +-
 drivers/mtd/nand/raw/nand_base.c              |   9 +-
 drivers/mtd/nand/raw/nand_legacy.c            |   6 +-
 drivers/mtd/nand/raw/nandsim.c                |   4 +-
 drivers/mtd/nand/raw/omap_elm.c               |   8 +-
 drivers/mtd/spi-nor/aspeed-smc.c              |   2 +-
 drivers/mtd/spi-nor/spi-nor.c                 |   1 -
 drivers/mtd/ubi/attach.c                      |   2 +-
 drivers/mtd/ubi/build.c                       |   4 +-
 drivers/mux/adgs1408.c                        |   2 +-
 drivers/net/appletalk/cops.c                  |   2 +-
 drivers/net/arcnet/arc-rimi.c                 |   6 +-
 drivers/net/arcnet/com20020-isa.c             |  12 +-
 drivers/net/arcnet/com90io.c                  |   4 +-
 drivers/net/arcnet/com90xx.c                  |   6 +-
 drivers/net/bonding/bond_3ad.c                |   6 +-
 drivers/net/bonding/bond_main.c               |   8 +-
 drivers/net/can/at91_can.c                    |   4 +-
 drivers/net/can/peak_canfd/peak_pciefd_main.c |   3 +-
 drivers/net/can/sja1000/sja1000_platform.c    |   2 +-
 drivers/net/can/slcan.c                       |   4 +-
 drivers/net/can/spi/mcp251x.c                 |   2 +-
 drivers/net/can/usb/peak_usb/pcan_usb.c       |   3 +-
 drivers/net/can/usb/peak_usb/pcan_usb_core.c  |   2 +-
 drivers/net/can/usb/peak_usb/pcan_usb_pro.c   |   4 +-
 drivers/net/dsa/b53/b53_common.c              |   2 +-
 drivers/net/dsa/b53/b53_serdes.c              |   2 +-
 drivers/net/dsa/bcm_sf2.c                     |   2 +-
 drivers/net/dsa/microchip/ksz9477.c           |   2 +-
 drivers/net/dsa/mt7530.c                      |   2 +-
 drivers/net/dsa/mv88e6xxx/chip.c              |   2 +-
 drivers/net/ethernet/3com/3c509.c             |   4 +-
 drivers/net/ethernet/3com/3c574_cs.c          |   2 +-
 drivers/net/ethernet/8390/axnet_cs.c          |   2 +-
 drivers/net/ethernet/8390/pcnet_cs.c          |   2 +-
 drivers/net/ethernet/alacritech/slicoss.c     |   8 +-
 drivers/net/ethernet/alteon/acenic.c          |   2 +-
 drivers/net/ethernet/amd/amd8111e.c           |   3 +-
 drivers/net/ethernet/amd/xgbe/xgbe-drv.c      |   6 +-
 drivers/net/ethernet/broadcom/bgmac-bcma.c    |   2 +-
 .../net/ethernet/broadcom/bgmac-platform.c    |   2 +-
 drivers/net/ethernet/broadcom/bnx2.c          |  15 ++-
 .../net/ethernet/broadcom/bnx2x/bnx2x_link.c  |  14 +--
 .../net/ethernet/broadcom/bnx2x/bnx2x_main.c  |   6 +-
 .../net/ethernet/broadcom/bnx2x/bnx2x_sriov.c |   4 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  17 ++-
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |   4 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c |   4 +-
 drivers/net/ethernet/broadcom/cnic.c          |   4 +-
 .../net/ethernet/broadcom/genet/bcmgenet.c    |   4 +-
 drivers/net/ethernet/broadcom/genet/bcmmii.c  |   2 +-
 drivers/net/ethernet/broadcom/tg3.c           |  58 +++++----
 drivers/net/ethernet/brocade/bna/bfa_ioc.c    |   8 +-
 drivers/net/ethernet/brocade/bna/bna_enet.c   |   2 +-
 drivers/net/ethernet/brocade/bna/bna_tx_rx.c  |   3 +-
 drivers/net/ethernet/cadence/macb_ptp.c       |   2 +-
 .../net/ethernet/cavium/liquidio/lio_main.c   |  42 +++----
 .../ethernet/cavium/liquidio/lio_vf_main.c    |  37 ++----
 .../ethernet/cavium/thunder/nicvf_ethtool.c   |   2 +-
 .../net/ethernet/cavium/thunder/nicvf_main.c  |   4 +-
 .../net/ethernet/chelsio/cxgb3/cxgb3_main.c   |   2 +-
 drivers/net/ethernet/chelsio/cxgb3/l2t.c      |   2 +-
 drivers/net/ethernet/chelsio/cxgb4/l2t.c      |   2 +-
 drivers/net/ethernet/chelsio/cxgb4/t4_hw.c    |   6 +-
 .../ethernet/chelsio/cxgb4vf/cxgb4vf_main.c   |   3 +-
 drivers/net/ethernet/cisco/enic/enic_main.c   |   4 +-
 drivers/net/ethernet/davicom/dm9000.c         |   2 +-
 drivers/net/ethernet/dec/tulip/de4x5.c        |   9 +-
 drivers/net/ethernet/dec/tulip/tulip_core.c   |   3 +-
 drivers/net/ethernet/dec/tulip/winbond-840.c  |   3 +-
 .../net/ethernet/emulex/benet/be_ethtool.c    |   2 +-
 .../net/ethernet/freescale/dpaa/dpaa_eth.c    |   2 +-
 .../ethernet/freescale/dpaa/dpaa_ethtool.c    |   2 +-
 .../net/ethernet/freescale/dpaa2/dpaa2-eth.c  |   4 +-
 .../net/ethernet/freescale/fman/fman_memac.c  |   2 +-
 .../net/ethernet/freescale/fman/fman_port.c   |   4 +-
 drivers/net/ethernet/freescale/ucc_geth.c     |   2 +-
 .../net/ethernet/hisilicon/hns/hns_ethtool.c  |   2 +-
 .../net/ethernet/hisilicon/hns3/hns3_enet.c   |   2 +-
 .../hisilicon/hns3/hns3pf/hclge_main.c        |   4 +-
 drivers/net/ethernet/ibm/ehea/ehea_main.c     |   3 +-
 drivers/net/ethernet/ibm/emac/core.c          |   2 +-
 drivers/net/ethernet/intel/e1000/e1000_hw.c   |   4 +-
 drivers/net/ethernet/intel/e1000/e1000_main.c |   2 +-
 .../net/ethernet/intel/e1000/e1000_param.c    |   2 +-
 drivers/net/ethernet/intel/e1000e/82571.c     |   4 +-
 drivers/net/ethernet/intel/e1000e/ethtool.c   |  11 +-
 drivers/net/ethernet/intel/e1000e/ich8lan.c   |  16 ++-
 drivers/net/ethernet/intel/e1000e/netdev.c    |  13 +-
 drivers/net/ethernet/intel/e1000e/param.c     |   2 +-
 drivers/net/ethernet/intel/e1000e/phy.c       |   2 +-
 drivers/net/ethernet/intel/e1000e/ptp.c       |   3 +-
 .../net/ethernet/intel/fm10k/fm10k_ethtool.c  |   4 +-
 drivers/net/ethernet/intel/fm10k/fm10k_main.c |   2 +-
 drivers/net/ethernet/intel/fm10k/fm10k_mbx.c  |   8 +-
 .../net/ethernet/intel/fm10k/fm10k_netdev.c   |   2 +-
 drivers/net/ethernet/intel/fm10k/fm10k_pf.c   |   8 +-
 drivers/net/ethernet/intel/i40e/i40e_adminq.c |   2 +-
 .../net/ethernet/intel/i40e/i40e_ethtool.c    |   2 +-
 drivers/net/ethernet/intel/i40e/i40e_main.c   |   5 +-
 drivers/net/ethernet/intel/i40e/i40e_ptp.c    |   2 +-
 drivers/net/ethernet/intel/i40e/i40e_txrx.c   |   4 +-
 drivers/net/ethernet/intel/i40e/i40e_xsk.c    |   4 +-
 drivers/net/ethernet/intel/igb/e1000_82575.c  |   4 +-
 drivers/net/ethernet/intel/igb/e1000_nvm.c    |   2 +-
 drivers/net/ethernet/intel/igb/e1000_phy.c    |   4 +-
 drivers/net/ethernet/intel/igb/igb_ethtool.c  |   8 +-
 drivers/net/ethernet/intel/igb/igb_main.c     |  25 ++--
 drivers/net/ethernet/intel/igb/igb_ptp.c      |   2 +-
 drivers/net/ethernet/intel/igbvf/netdev.c     |   4 +-
 drivers/net/ethernet/intel/igc/igc_ethtool.c  |  16 +--
 drivers/net/ethernet/intel/igc/igc_main.c     |   5 +-
 drivers/net/ethernet/intel/igc/igc_ptp.c      |   2 +-
 .../net/ethernet/intel/ixgbe/ixgbe_82598.c    |   2 +-
 .../net/ethernet/intel/ixgbe/ixgbe_82599.c    |   6 +-
 .../net/ethernet/intel/ixgbe/ixgbe_common.c   |   5 +-
 .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  |  10 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  30 ++---
 drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c  |   4 +-
 .../net/ethernet/intel/ixgbe/ixgbe_sriov.c    |   4 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c |  10 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c  |   4 +-
 .../net/ethernet/intel/ixgbevf/ixgbevf_main.c |   8 +-
 drivers/net/ethernet/intel/ixgbevf/vf.c       |   6 +-
 drivers/net/ethernet/marvell/mvneta.c         |   4 +-
 .../net/ethernet/marvell/mvpp2/mvpp2_cls.c    |   2 +-
 .../net/ethernet/marvell/mvpp2/mvpp2_main.c   |   4 +-
 .../ethernet/marvell/octeontx2/af/rvu_nix.c   |   2 +-
 drivers/net/ethernet/marvell/skge.c           |   3 +-
 drivers/net/ethernet/marvell/sky2.c           |   5 +-
 drivers/net/ethernet/mediatek/mtk_eth_soc.c   |   6 +-
 drivers/net/ethernet/mellanox/mlx4/en_rx.c    |   4 +-
 drivers/net/ethernet/mellanox/mlx4/eq.c       |   2 +-
 drivers/net/ethernet/mellanox/mlx4/mcg.c      |   6 +-
 .../net/ethernet/mellanox/mlx5/core/en/txrx.h |   2 +-
 .../net/ethernet/mellanox/mlx5/core/en/xdp.c  |   4 +-
 .../mellanox/mlx5/core/en_accel/ktls_tx.c     |   2 +-
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  |   2 +-
 .../mellanox/mlx5/core/eswitch_offloads.c     |   2 +-
 .../ethernet/mellanox/mlx5/core/fpga/conn.c   |   4 +-
 .../net/ethernet/mellanox/mlx5/core/lag_mp.c  |   8 +-
 .../net/ethernet/mellanox/mlx5/core/vport.c   |   2 +-
 .../net/ethernet/mellanox/mlxfw/mlxfw_fsm.c   |   4 +-
 drivers/net/ethernet/mellanox/mlxsw/core.c    |  18 +--
 .../net/ethernet/mellanox/mlxsw/core_env.c    |   8 +-
 .../net/ethernet/mellanox/mlxsw/core_hwmon.c  |   4 +-
 .../net/ethernet/mellanox/mlxsw/spectrum.c    |   4 +-
 .../net/ethernet/mellanox/mlxsw/spectrum.h    |  10 +-
 .../ethernet/mellanox/mlxsw/spectrum_router.c |  32 ++---
 .../mellanox/mlxsw/spectrum_switchdev.c       |  12 +-
 .../net/ethernet/microchip/lan743x_ethtool.c  |   2 +-
 drivers/net/ethernet/mscc/ocelot.c            |   2 +-
 drivers/net/ethernet/mscc/ocelot_tc.c         |   2 +-
 drivers/net/ethernet/natsemi/natsemi.c        |   3 +-
 .../net/ethernet/neterion/vxge/vxge-config.c  |   6 +-
 .../net/ethernet/netronome/nfp/crypto/tls.c   |   2 +-
 .../ethernet/netronome/nfp/flower/action.c    |   2 +-
 .../net/ethernet/netronome/nfp/flower/cmsg.c  |   2 +-
 .../ethernet/netronome/nfp/flower/offload.c   |   2 +-
 drivers/net/ethernet/netronome/nfp/nfp_asm.c  |   2 +-
 .../ethernet/netronome/nfp/nfp_net_common.c   |   4 +-
 .../netronome/nfp/nfpcore/nfp6000_pcie.c      |   4 +-
 .../netronome/nfp/nfpcore/nfp_rtsym.c         |   2 +-
 .../ethernet/oki-semi/pch_gbe/pch_gbe_param.c |   2 +-
 .../net/ethernet/packetengines/yellowfin.c    |   3 +-
 .../qlogic/netxen/netxen_nic_ethtool.c        |   4 +-
 drivers/net/ethernet/qlogic/qed/qed_cxt.c     |   2 +-
 drivers/net/ethernet/qlogic/qed/qed_dev.c     |   5 +-
 drivers/net/ethernet/qlogic/qed/qed_main.c    |   6 +-
 drivers/net/ethernet/qlogic/qed/qed_mcp.c     |  10 +-
 drivers/net/ethernet/qlogic/qede/qede_fp.c    |   4 +-
 drivers/net/ethernet/qlogic/qla3xxx.c         |   3 +-
 .../ethernet/qlogic/qlcnic/qlcnic_ethtool.c   |   4 +-
 drivers/net/ethernet/realtek/r8169_main.c     |   4 +-
 drivers/net/ethernet/rocker/rocker_main.c     |   8 +-
 .../ethernet/samsung/sxgbe/sxgbe_ethtool.c    |   4 +-
 drivers/net/ethernet/sfc/falcon/ethtool.c     |   2 +-
 drivers/net/ethernet/sfc/falcon/farch.c       |  14 +--
 drivers/net/ethernet/sfc/farch.c              |  14 +--
 drivers/net/ethernet/sfc/mcdi_filters.c       |   2 +-
 drivers/net/ethernet/sfc/mcdi_port_common.c   |   2 +-
 drivers/net/ethernet/sfc/rx.c                 |   2 +-
 drivers/net/ethernet/sis/sis900.c             |   3 +-
 drivers/net/ethernet/smsc/smc911x.c           |   2 +-
 drivers/net/ethernet/socionext/netsec.c       |   4 +-
 .../ethernet/stmicro/stmmac/dwmac-anarion.c   |   5 +-
 .../ethernet/stmicro/stmmac/dwmac-meson8b.c   |   3 +-
 .../stmicro/stmmac/stmmac_selftests.c         |   4 +-
 .../net/ethernet/stmicro/stmmac/stmmac_tc.c   |   2 +-
 drivers/net/ethernet/sun/cassini.c            |   3 +-
 drivers/net/ethernet/sun/niu.c                |   6 +-
 drivers/net/ethernet/sun/sungem.c             |   3 +-
 drivers/net/ethernet/ti/cpsw-phy-sel.c        |   4 +-
 drivers/net/ethernet/ti/cpsw_priv.c           |   4 +-
 drivers/net/ethernet/ti/cpts.c                |   2 +-
 drivers/net/ethernet/ti/tlan.c                |   4 +-
 .../net/ethernet/toshiba/ps3_gelic_wireless.c |   2 +-
 drivers/net/ethernet/toshiba/spider_net.c     |  29 +++--
 drivers/net/ethernet/xircom/xirc2ps_cs.c      |   2 +-
 drivers/net/fddi/skfp/pcmplc.c                |   4 +-
 drivers/net/fjes/fjes_main.c                  |   2 +-
 drivers/net/hamradio/baycom_epp.c             |   3 +-
 drivers/net/hamradio/mkiss.c                  |   5 +-
 drivers/net/macvlan.c                         |   2 +-
 drivers/net/mii.c                             |   3 +-
 drivers/net/netdevsim/bus.c                   |   2 +-
 drivers/net/netdevsim/fib.c                   |   6 +-
 drivers/net/phy/adin.c                        |   4 +-
 drivers/net/phy/dp83640.c                     |   8 +-
 drivers/net/phy/fixed_phy.c                   |   4 +-
 drivers/net/phy/phy.c                         |   6 +-
 drivers/net/phy/phylink.c                     |   6 +-
 drivers/net/phy/sfp-bus.c                     |   4 +-
 drivers/net/phy/sfp.c                         |  12 +-
 drivers/net/plip/plip.c                       |  38 ++----
 drivers/net/tun.c                             |   6 +-
 drivers/net/usb/aqc111.c                      |   6 +-
 drivers/net/usb/catc.c                        |   2 +-
 drivers/net/usb/cdc-phonet.c                  |   2 +-
 drivers/net/usb/lan78xx.c                     |   7 +-
 drivers/net/usb/pegasus.c                     |   4 +-
 drivers/net/usb/r8152.c                       |   7 +-
 drivers/net/usb/rtl8150.c                     |   2 +-
 drivers/net/usb/usbnet.c                      |   7 +-
 drivers/net/veth.c                            |   8 +-
 drivers/net/virtio_net.c                      |   6 +-
 drivers/net/wan/lapbether.c                   |   2 +-
 drivers/net/wan/sdla.c                        |   3 +-
 drivers/net/wan/x25_asy.c                     |   2 +-
 drivers/net/wimax/i2400m/control.c            |   2 +-
 drivers/net/wimax/i2400m/usb-fw.c             |   2 +-
 drivers/net/wimax/i2400m/usb-tx.c             |   2 +-
 drivers/net/wimax/i2400m/usb.c                |   2 +-
 drivers/net/wireless/ath/ath10k/core.c        |   2 +-
 drivers/net/wireless/ath/ath10k/htt_rx.c      |   2 +-
 drivers/net/wireless/ath/ath10k/htt_tx.c      |   6 +-
 drivers/net/wireless/ath/ath10k/mac.c         |  18 +--
 drivers/net/wireless/ath/ath10k/wow.c         |   2 +-
 drivers/net/wireless/ath/ath11k/core.c        |   2 +-
 drivers/net/wireless/ath/ath11k/dp.c          |   2 +-
 drivers/net/wireless/ath/ath11k/mac.c         |  23 ++--
 drivers/net/wireless/ath/ath5k/eeprom.c       |   4 +-
 drivers/net/wireless/ath/ath5k/pcu.c          |   4 +-
 drivers/net/wireless/ath/ath5k/phy.c          |   7 +-
 drivers/net/wireless/ath/ath5k/reset.c        |   2 +-
 drivers/net/wireless/ath/ath6kl/cfg80211.c    |   6 +-
 drivers/net/wireless/ath/ath6kl/main.c        |   2 +-
 drivers/net/wireless/ath/ath9k/ar5008_phy.c   |   4 +-
 drivers/net/wireless/ath/ath9k/ar9002_mac.c   |   2 +-
 drivers/net/wireless/ath/ath9k/ar9002_phy.c   |   2 +-
 drivers/net/wireless/ath/ath9k/ar9003_mac.c   |   2 +-
 drivers/net/wireless/ath/ath9k/channel.c      |   4 +-
 drivers/net/wireless/ath/ath9k/eeprom_def.c   |   2 +-
 drivers/net/wireless/ath/ath9k/hw.c           |   6 +-
 drivers/net/wireless/ath/ath9k/main.c         |   2 +-
 drivers/net/wireless/ath/carl9170/rx.c        |   3 +-
 drivers/net/wireless/ath/carl9170/tx.c        |   9 +-
 drivers/net/wireless/ath/wcn36xx/smd.c        |   2 +-
 drivers/net/wireless/atmel/at76c50x-usb.c     |   2 +-
 drivers/net/wireless/atmel/atmel.c            |   2 +-
 drivers/net/wireless/broadcom/b43/dma.c       |   2 +-
 drivers/net/wireless/broadcom/b43/main.c      |   8 +-
 drivers/net/wireless/broadcom/b43/phy_n.c     |   2 +-
 drivers/net/wireless/broadcom/b43/pio.c       |   2 +-
 .../net/wireless/broadcom/b43/tables_nphy.c   |   2 +-
 drivers/net/wireless/broadcom/b43legacy/dma.c |   2 +-
 .../net/wireless/broadcom/b43legacy/main.c    |   4 +-
 .../broadcom/brcm80211/brcmfmac/cfg80211.c    |   8 +-
 .../broadcom/brcm80211/brcmfmac/chip.c        |   2 +-
 .../broadcom/brcm80211/brcmsmac/rate.c        |   1 -
 .../net/wireless/intel/iwlegacy/3945-mac.c    |   2 +-
 .../net/wireless/intel/iwlegacy/4965-mac.c    |   4 +-
 drivers/net/wireless/intel/iwlegacy/common.c  |   5 +-
 .../net/wireless/intel/iwlwifi/dvm/mac80211.c |   2 +-
 drivers/net/wireless/intel/iwlwifi/dvm/rx.c   |   6 +-
 drivers/net/wireless/intel/iwlwifi/dvm/scan.c |   2 +-
 drivers/net/wireless/intel/iwlwifi/dvm/sta.c  |   2 +-
 drivers/net/wireless/intel/iwlwifi/dvm/tx.c   |   2 +-
 drivers/net/wireless/intel/iwlwifi/iwl-drv.c  |   2 +-
 drivers/net/wireless/intel/iwlwifi/mvm/led.c  |   2 +-
 .../net/wireless/intel/iwlwifi/mvm/mac-ctxt.c |   2 +-
 .../net/wireless/intel/iwlwifi/mvm/mac80211.c |   2 +-
 .../net/wireless/intel/iwlwifi/mvm/phy-ctxt.c |   2 +-
 drivers/net/wireless/intel/iwlwifi/mvm/rx.c   |   3 +-
 drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c |   8 +-
 drivers/net/wireless/intel/iwlwifi/mvm/scan.c |   2 +-
 drivers/net/wireless/intel/iwlwifi/mvm/sta.c  |  10 +-
 drivers/net/wireless/intel/iwlwifi/mvm/tx.c   |   4 +-
 drivers/net/wireless/intersil/orinoco/main.c  |   4 +-
 .../wireless/intersil/orinoco/orinoco_usb.c   |   9 +-
 .../net/wireless/intersil/prism54/isl_38xx.c  |   3 +-
 .../net/wireless/intersil/prism54/isl_ioctl.c |   2 +-
 .../wireless/intersil/prism54/islpci_dev.c    |   2 +-
 drivers/net/wireless/mac80211_hwsim.c         |   2 +-
 .../net/wireless/marvell/mwifiex/cfg80211.c   |   8 +-
 drivers/net/wireless/marvell/mwifiex/ie.c     |   2 +-
 drivers/net/wireless/marvell/mwifiex/scan.c   |   2 +-
 .../net/wireless/mediatek/mt76/mt7603/dma.c   |   2 +-
 .../net/wireless/mediatek/mt76/mt7603/mac.c   |   4 +-
 .../net/wireless/mediatek/mt76/mt7615/dma.c   |   2 +-
 .../net/wireless/mediatek/mt76/mt7615/mac.c   |   4 +-
 .../net/wireless/mediatek/mt76/mt76x0/phy.c   |   2 +-
 .../net/wireless/mediatek/mt76/mt76x02_mac.c  |   6 +-
 drivers/net/wireless/mediatek/mt76/usb.c      |   2 +-
 drivers/net/wireless/mediatek/mt7601u/dma.c   |   4 +-
 drivers/net/wireless/mediatek/mt7601u/mac.c   |   4 +-
 drivers/net/wireless/mediatek/mt7601u/phy.c   |   2 +-
 .../net/wireless/ralink/rt2x00/rt2400pci.c    |   2 +-
 .../net/wireless/ralink/rt2x00/rt2500pci.c    |   2 +-
 .../net/wireless/ralink/rt2x00/rt2800lib.c    |  42 +++----
 .../net/wireless/ralink/rt2x00/rt2800mmio.c   |   1 -
 .../net/wireless/ralink/rt2x00/rt2800usb.c    |   1 -
 drivers/net/wireless/ralink/rt2x00/rt61pci.c  |   3 +-
 drivers/net/wireless/ralink/rt2x00/rt73usb.c  |   1 -
 drivers/net/wireless/ray_cs.c                 |   6 +-
 .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c |   8 +-
 drivers/net/wireless/realtek/rtlwifi/base.c   |   2 +-
 drivers/net/wireless/realtek/rtlwifi/core.c   |   4 +-
 .../wireless/realtek/rtlwifi/rtl8821ae/phy.c  |   2 +-
 drivers/net/wireless/realtek/rtw88/main.c     |   4 +-
 drivers/net/wireless/realtek/rtw88/phy.c      |   6 +-
 drivers/net/wireless/ti/wlcore/main.c         |   4 +-
 drivers/net/wireless/zydas/zd1201.c           |   2 +-
 drivers/net/xen-netback/hash.c                |   2 +-
 drivers/net/xen-netback/xenbus.c              |   2 +-
 drivers/net/xen-netfront.c                    |   2 +-
 drivers/nfc/pn533/pn533.c                     |   4 +-
 drivers/nfc/st21nfca/dep.c                    |   2 +-
 drivers/nfc/trf7970a.c                        |   4 +-
 drivers/ntb/ntb_transport.c                   |   4 +-
 drivers/nvme/host/core.c                      |  10 +-
 drivers/nvme/host/pci.c                       |   2 +-
 drivers/nvme/host/rdma.c                      |   2 +-
 drivers/nvme/target/core.c                    |   2 +-
 drivers/nvme/target/fcloop.c                  |   3 +-
 drivers/nvme/target/io-cmd-bdev.c             |   1 -
 drivers/nvme/target/rdma.c                    |   2 +-
 drivers/parport/ieee1284.c                    |   8 +-
 drivers/parport/parport_pc.c                  |   2 +-
 drivers/pci/controller/dwc/pci-imx6.c         |   6 +-
 drivers/pci/controller/pci-rcar-gen2.c        |   2 +-
 drivers/pci/hotplug/ibmphp_res.c              |   2 +-
 drivers/pci/hotplug/pciehp_ctrl.c             |   4 +-
 drivers/pci/hotplug/shpchp_ctrl.c             |   4 +-
 drivers/pci/pci-acpi.c                        |   6 +-
 drivers/pci/pci.c                             |   4 +-
 drivers/pci/proc.c                            |   2 +-
 drivers/pci/quirks.c                          |   4 +-
 drivers/pci/setup-bus.c                       |   2 +-
 drivers/pci/xen-pcifront.c                    |   2 +-
 drivers/pcmcia/db1xxx_ss.c                    |   8 +-
 drivers/perf/arm-ccn.c                        |   2 +-
 drivers/perf/arm_spe_pmu.c                    |   4 +-
 drivers/phy/qualcomm/phy-qcom-usb-hs.c        |   2 +-
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c |   8 +-
 drivers/pinctrl/intel/pinctrl-baytrail.c      |   4 +-
 drivers/pinctrl/pinctrl-lpc18xx.c             |  12 +-
 drivers/pinctrl/pinctrl-single.c              |   2 +-
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c      |   4 +-
 drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c      |   2 +-
 drivers/platform/olpc/olpc-xo175-ec.c         |   2 +-
 drivers/platform/x86/acer-wmi.c               |   8 +-
 drivers/platform/x86/dell-laptop.c            |   4 +-
 drivers/platform/x86/surfacepro3_button.c     |   8 +-
 drivers/platform/x86/thinkpad_acpi.c          |   8 +-
 drivers/platform/x86/toshiba_acpi.c           |   2 +-
 drivers/power/supply/ab8500_charger.c         |   4 +-
 drivers/power/supply/ab8500_fg.c              |   7 +-
 drivers/power/supply/abx500_chargalg.c        |  39 ++----
 drivers/power/supply/axp20x_usb_power.c       |   2 +-
 drivers/power/supply/cros_usbpd-charger.c     |   2 +-
 drivers/power/supply/max8925_power.c          |   2 +-
 drivers/power/supply/wm831x_power.c           |   2 +-
 drivers/power/supply/wm8350_power.c           |   2 +-
 drivers/ps3/ps3av.c                           |   2 +-
 drivers/ps3/ps3av_cmd.c                       |   4 +-
 drivers/rapidio/devices/rio_mport_cdev.c      |   2 +-
 drivers/regulator/axp20x-regulator.c          |   9 +-
 drivers/regulator/core.c                      |   3 +-
 drivers/regulator/slg51000-regulator.c        |   3 +-
 drivers/regulator/twl6030-regulator.c         |   2 +-
 drivers/reset/reset-imx7.c                    |  10 +-
 drivers/rpmsg/qcom_glink_native.c             |   4 +-
 drivers/rtc/rtc-ds1374.c                      |   2 +-
 drivers/rtc/rtc-m41t80.c                      |   2 +-
 drivers/rtc/rtc-pcf85063.c                    |   2 +-
 drivers/rtc/rtc-pcf8523.c                     |   2 +-
 drivers/rtc/rtc-stmp3xxx.c                    |   2 +-
 drivers/s390/char/con3215.c                   |   2 +-
 drivers/s390/char/hmcdrv_ftp.c                |   2 +-
 drivers/s390/char/sclp_sdias.c                |   2 +-
 drivers/s390/char/tape_core.c                 |   6 +-
 drivers/s390/cio/device.c                     |   4 +-
 drivers/s390/crypto/ap_bus.c                  |   2 +-
 drivers/s390/crypto/ap_queue.c                |   8 +-
 drivers/s390/crypto/vfio_ap_ops.c             |   2 +-
 drivers/s390/crypto/zcrypt_msgtype6.c         |   8 +-
 drivers/s390/net/ctcm_fsms.c                  |   2 +-
 drivers/s390/net/ctcm_mpc.c                   |   6 +-
 drivers/s390/net/qeth_core_main.c             |   4 +-
 drivers/s390/net/qeth_ethtool.c               |   6 +-
 drivers/s390/net/qeth_l2_main.c               |   2 +-
 drivers/s390/net/qeth_l3_main.c               |   2 +-
 drivers/s390/scsi/zfcp_erp.c                  |  10 +-
 drivers/s390/scsi/zfcp_fsf.c                  |  23 ++--
 drivers/scsi/53c700.c                         |   2 +-
 drivers/scsi/BusLogic.c                       |   2 +-
 drivers/scsi/FlashPoint.c                     |   9 +-
 drivers/scsi/NCR5380.c                        |   2 +-
 drivers/scsi/aacraid/aachba.c                 |   9 +-
 drivers/scsi/aacraid/commsup.c                |   2 +-
 drivers/scsi/aacraid/linit.c                  |   2 +-
 drivers/scsi/aic7xxx/aic79xx_core.c           |  40 +++---
 drivers/scsi/aic7xxx/aic79xx_osm.c            |   2 +-
 drivers/scsi/aic7xxx/aic7xxx_core.c           |  28 ++---
 drivers/scsi/aic94xx/aic94xx_scb.c            |  11 +-
 drivers/scsi/aic94xx/aic94xx_tmf.c            |   2 +-
 drivers/scsi/arcmsr/arcmsr_hba.c              |   2 +-
 drivers/scsi/arm/fas216.c                     |  17 +--
 drivers/scsi/be2iscsi/be_iscsi.c              |   2 +-
 drivers/scsi/be2iscsi/be_main.c               |   2 +-
 drivers/scsi/bfa/bfa_fcpim.c                  |   6 +-
 drivers/scsi/bfa/bfa_fcs_lport.c              |   6 +-
 drivers/scsi/bfa/bfa_fcs_rport.c              |  16 ++-
 drivers/scsi/bfa/bfa_ioc.c                    |   8 +-
 drivers/scsi/bfa/bfa_svc.c                    |   3 +-
 drivers/scsi/bnx2fc/bnx2fc_hwi.c              |   1 -
 drivers/scsi/csiostor/csio_hw.c               |   3 +-
 drivers/scsi/csiostor/csio_lnode.c            |   1 -
 drivers/scsi/csiostor/csio_wr.c               |   2 +-
 drivers/scsi/cxgbi/cxgb3i/cxgb3i.c            |   2 +-
 drivers/scsi/cxgbi/cxgb4i/cxgb4i.c            |   2 +-
 drivers/scsi/cxlflash/main.c                  |  29 +++--
 drivers/scsi/cxlflash/superpipe.c             |  13 +-
 drivers/scsi/device_handler/scsi_dh_hp_sw.c   |   4 +-
 drivers/scsi/esas2r/esas2r_flash.c            |   4 +-
 drivers/scsi/esas2r/esas2r_init.c             |   6 +-
 drivers/scsi/esp_scsi.c                       |   6 +-
 drivers/scsi/fcoe/fcoe_ctlr.c                 |   8 +-
 drivers/scsi/g_NCR5380.c                      |   2 +-
 drivers/scsi/hisi_sas/hisi_sas_main.c         |   2 +-
 drivers/scsi/hpsa.c                           |  10 +-
 drivers/scsi/ibmvscsi/ibmvfc.c                |   6 +-
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c      |   6 +-
 drivers/scsi/imm.c                            |  21 ++--
 drivers/scsi/isci/phy.c                       |   2 +-
 drivers/scsi/isci/remote_device.c             |   5 +-
 drivers/scsi/isci/remote_node_context.c       |   6 +-
 drivers/scsi/isci/request.c                   |   2 +-
 drivers/scsi/libfc/fc_exch.c                  |   4 +-
 drivers/scsi/libfc/fc_fcp.c                   |   9 +-
 drivers/scsi/libfc/fc_lport.c                 |   2 +-
 drivers/scsi/libfc/fc_rport.c                 |   2 +-
 drivers/scsi/libiscsi.c                       |   6 +-
 drivers/scsi/libiscsi_tcp.c                   |   2 +-
 drivers/scsi/libsas/sas_ata.c                 |   2 +-
 drivers/scsi/libsas/sas_discover.c            |   4 +-
 drivers/scsi/libsas/sas_expander.c            |   2 +-
 drivers/scsi/libsas/sas_scsi_host.c           |   2 +-
 drivers/scsi/lpfc/lpfc_ct.c                   |   4 +-
 drivers/scsi/lpfc/lpfc_els.c                  |   2 +-
 drivers/scsi/lpfc/lpfc_hbadisc.c              |   6 +-
 drivers/scsi/lpfc/lpfc_nportdisc.c            |   2 +-
 drivers/scsi/lpfc/lpfc_nvme.c                 |   2 +-
 drivers/scsi/lpfc/lpfc_scsi.c                 |   9 +-
 drivers/scsi/lpfc/lpfc_sli.c                  |  30 +++--
 drivers/scsi/megaraid.c                       |  12 +-
 drivers/scsi/megaraid/megaraid_mbox.c         |   4 +-
 drivers/scsi/megaraid/megaraid_sas_base.c     |   3 +-
 drivers/scsi/megaraid/megaraid_sas_fusion.c   |   2 +-
 drivers/scsi/mesh.c                           |   3 +-
 drivers/scsi/mpt3sas/mpt3sas_base.c           |   2 +-
 drivers/scsi/mpt3sas/mpt3sas_ctl.c            |   2 +-
 drivers/scsi/mpt3sas/mpt3sas_scsih.c          |  10 +-
 drivers/scsi/myrb.c                           |   8 +-
 drivers/scsi/ncr53c8xx.c                      |  16 ++-
 drivers/scsi/pcmcia/nsp_cs.c                  |   2 +-
 drivers/scsi/ppa.c                            |  15 +--
 drivers/scsi/qla2xxx/qla_gs.c                 |   2 +-
 drivers/scsi/qla2xxx/qla_init.c               |   2 +-
 drivers/scsi/qla2xxx/qla_iocb.c               |   2 +-
 drivers/scsi/qla2xxx/qla_isr.c                |  10 +-
 drivers/scsi/qla2xxx/qla_sup.c                |   8 +-
 drivers/scsi/qla2xxx/qla_target.c             |   6 +-
 drivers/scsi/qla4xxx/ql4_os.c                 |   2 +-
 drivers/scsi/qlogicpti.c                      |  20 +--
 drivers/scsi/scsi_error.c                     |  29 +++--
 drivers/scsi/scsi_ioctl.c                     |   4 +-
 drivers/scsi/scsi_lib.c                       |   2 +-
 drivers/scsi/smartpqi/smartpqi_init.c         |  17 ++-
 drivers/scsi/sr.c                             |   4 +-
 drivers/scsi/st.c                             |   8 +-
 drivers/scsi/sun3_scsi.c                      |   6 +-
 drivers/scsi/sym53c8xx_2/sym_fw.c             |   2 +-
 drivers/scsi/sym53c8xx_2/sym_hipd.c           |   4 +-
 drivers/scsi/sym53c8xx_2/sym_nvram.c          |   2 +-
 drivers/scsi/ufs/ufs_bsg.c                    |   3 +-
 drivers/scsi/ufs/ufshcd.c                     |   8 +-
 drivers/scsi/virtio_scsi.c                    |   2 +-
 drivers/scsi/vmw_pvscsi.c                     |   3 +-
 drivers/scsi/wd33c93.c                        |   2 +-
 drivers/scsi/xen-scsifront.c                  |   2 +-
 drivers/soc/qcom/socinfo.c                    |  16 +--
 drivers/soc/tegra/pmc.c                       |   3 +-
 drivers/spi/spi-bcm2835aux.c                  |   4 +-
 drivers/spi/spi-fsl-cpm.c                     |   4 +-
 drivers/spi/spi-sprd-adi.c                    |   2 +-
 drivers/ssb/driver_chipcommon.c               |   2 +-
 drivers/ssb/driver_mipscore.c                 |   2 +-
 drivers/ssb/scan.c                            |   2 +-
 drivers/staging/comedi/drivers/s526.c         |   2 +-
 drivers/staging/fsl-dpaa2/ethsw/ethsw.c       |   2 +-
 drivers/staging/gdm724x/gdm_lte.c             |   2 +-
 drivers/staging/ks7010/ks_wlan_net.c          |  18 +--
 .../media/hantro/hantro_g1_mpeg2_dec.c        |   2 +-
 .../media/hantro/rk3399_vpu_hw_mpeg2_dec.c    |   2 +-
 drivers/staging/media/imx/imx-media-csi.c     |   2 +-
 .../staging/media/soc_camera/soc_mediabus.c   |   2 +-
 .../staging/media/usbvision/usbvision-i2c.c   |   6 +-
 drivers/staging/qlge/qlge_mpi.c               |   4 +-
 drivers/staging/rtl8188eu/core/rtw_mlme_ext.c |   2 +-
 drivers/staging/rtl8188eu/hal/usb_halinit.c   |   2 +-
 .../staging/rtl8188eu/os_dep/usb_ops_linux.c  |   2 +-
 drivers/staging/rtl8192e/rtllib_wx.c          |   2 +-
 drivers/staging/rtl8712/usb_ops_linux.c       |   2 +-
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |   2 +-
 .../interface/vchiq_arm/vchiq_core.c          |   2 +-
 drivers/staging/vt6655/channel.c              |   2 +-
 drivers/staging/vt6655/key.c                  |   6 +-
 drivers/staging/vt6656/card.c                 |   4 +-
 drivers/staging/vt6656/channel.c              |   2 +-
 drivers/staging/vt6656/key.c                  |   6 +-
 drivers/target/iscsi/cxgbit/cxgbit_main.c     |   2 +-
 drivers/target/iscsi/iscsi_target.c           |   2 +-
 drivers/target/target_core_pr.c               |   4 +-
 drivers/target/target_core_sbc.c              |   2 +-
 drivers/target/target_core_transport.c        |   4 +-
 drivers/target/tcm_fc/tfc_cmd.c               |   2 +-
 drivers/thermal/clock_cooling.c               |   2 +-
 drivers/thermal/qcom/tsens-v0_1.c             |   8 +-
 drivers/thermal/qcom/tsens-v1.c               |   4 +-
 drivers/thunderbolt/ctl.c                     |   2 +-
 drivers/thunderbolt/switch.c                  |   3 +-
 drivers/thunderbolt/tunnel.c                  |   4 +-
 drivers/tty/hvc/hvc_xen.c                     |   2 +-
 drivers/tty/mips_ejtag_fdc.c                  |   2 +-
 drivers/tty/n_gsm.c                           |   4 +-
 drivers/tty/n_hdlc.c                          |   3 +-
 drivers/tty/n_r3964.c                         |   1 -
 drivers/tty/serial/8250/8250_em.c             |   2 +-
 drivers/tty/serial/8250/8250_fintek.c         |   2 +-
 drivers/tty/serial/8250/8250_pci.c            |   2 +-
 drivers/tty/serial/8250/8250_port.c           |   2 +-
 drivers/tty/serial/8250/8250_uniphier.c       |   6 +-
 drivers/tty/serial/atmel_serial.c             |   2 +-
 drivers/tty/serial/omap-serial.c              |   2 -
 drivers/tty/serial/rda-uart.c                 |   2 +-
 drivers/tty/serial/serial-tegra.c             |   2 +-
 drivers/tty/serial/serial_core.c              |   2 +-
 drivers/tty/serial/sunsu.c                    |   2 +-
 drivers/tty/serial/sunzilog.c                 |   2 +-
 drivers/tty/serial/xilinx_uartps.c            |   2 +-
 drivers/tty/tty_ioctl.c                       |   2 +-
 drivers/tty/vt/vt.c                           |   6 +-
 drivers/usb/atm/cxacru.c                      |   4 +-
 drivers/usb/c67x00/c67x00-sched.c             |   3 +-
 drivers/usb/cdns3/gadget.c                    |   4 +-
 drivers/usb/class/usbtmc.c                    |   2 +-
 drivers/usb/core/config.c                     |   2 +-
 drivers/usb/core/hcd.c                        |   8 +-
 drivers/usb/core/hub.c                        |   2 +-
 drivers/usb/core/urb.c                        |   4 +-
 drivers/usb/dwc3/core.c                       |   5 +-
 drivers/usb/gadget/composite.c                |  16 +--
 drivers/usb/gadget/function/f_fs.c            |   2 +-
 drivers/usb/gadget/function/f_hid.c           |   2 +-
 drivers/usb/gadget/function/f_mass_storage.c  |   2 -
 drivers/usb/gadget/function/f_phonet.c        |   4 +-
 drivers/usb/gadget/function/f_printer.c       |   7 +-
 drivers/usb/gadget/function/f_rndis.c         |   2 +-
 drivers/usb/gadget/function/f_tcm.c           |   2 +-
 drivers/usb/gadget/function/u_ether.c         |   5 +-
 drivers/usb/gadget/function/u_serial.c        |   6 +-
 drivers/usb/gadget/legacy/inode.c             |   7 +-
 drivers/usb/gadget/udc/atmel_usba_udc.c       |   2 +-
 drivers/usb/gadget/udc/dummy_hcd.c            |  13 +-
 drivers/usb/gadget/udc/fsl_udc_core.c         |   2 +-
 drivers/usb/gadget/udc/goku_udc.c             |   9 +-
 drivers/usb/gadget/udc/omap_udc.c             |   4 +-
 drivers/usb/gadget/udc/pxa25x_udc.c           |   4 +-
 drivers/usb/gadget/udc/s3c2410_udc.c          |   4 +-
 drivers/usb/gadget/udc/tegra-xudc.c           |   2 +-
 drivers/usb/host/ehci-dbg.c                   |   2 +-
 drivers/usb/host/ehci-fsl.c                   |   4 +-
 drivers/usb/host/ehci-hcd.c                   |   4 +-
 drivers/usb/host/ehci-q.c                     |   3 +-
 drivers/usb/host/ehci-sched.c                 |   2 +-
 drivers/usb/host/fotg210-hcd.c                |   9 +-
 drivers/usb/host/isp116x-hcd.c                |   6 +-
 drivers/usb/host/isp1362-hcd.c                |   2 +-
 drivers/usb/host/max3421-hcd.c                |   6 +-
 drivers/usb/host/ohci-hcd.c                   |   4 +-
 drivers/usb/host/ohci-hub.c                   |   2 +-
 drivers/usb/host/ohci-q.c                     |   6 +-
 drivers/usb/host/ohci-tmio.c                  |   6 +-
 drivers/usb/host/oxu210hp-hcd.c               |   9 +-
 drivers/usb/host/pci-quirks.c                 |   3 +-
 drivers/usb/host/xhci-dbgcap.c                |   2 +-
 drivers/usb/host/xhci-hub.c                   |   2 +-
 drivers/usb/host/xhci-mem.c                   |   6 +-
 drivers/usb/host/xhci-ring.c                  |   2 +-
 drivers/usb/host/xhci.c                       |   2 +-
 drivers/usb/image/mdc800.c                    |   3 +-
 drivers/usb/isp1760/isp1760-hcd.c             |   4 +-
 drivers/usb/misc/appledisplay.c               |   2 +-
 drivers/usb/misc/usbtest.c                    |   8 +-
 drivers/usb/misc/yurex.c                      |   2 +-
 drivers/usb/mtu3/mtu3_core.c                  |   2 +-
 drivers/usb/musb/cppi_dma.c                   |   2 +-
 drivers/usb/musb/musb_core.c                  |  13 +-
 drivers/usb/musb/musb_dsps.c                  |   8 +-
 drivers/usb/musb/musb_gadget_ep0.c            |   6 +-
 drivers/usb/musb/musb_host.c                  |   7 +-
 drivers/usb/musb/musb_virthub.c               |   2 +-
 drivers/usb/musb/omap2430.c                   |   2 +-
 drivers/usb/musb/tusb6010.c                   |   2 +-
 drivers/usb/phy/phy-ab8500-usb.c              |  12 +-
 drivers/usb/phy/phy-fsl-usb.c                 |   4 +-
 drivers/usb/phy/phy-isp1301-omap.c            |  15 ++-
 drivers/usb/phy/phy-mv-usb.c                  |   2 +-
 drivers/usb/renesas_usbhs/mod_gadget.c        |   2 +-
 drivers/usb/renesas_usbhs/pipe.c              |   2 +-
 drivers/usb/serial/cypress_m8.c               |   4 +-
 drivers/usb/serial/io_edgeport.c              |   4 +-
 drivers/usb/serial/kobil_sct.c                |   2 +-
 drivers/usb/serial/upd78f0730.c               |   2 +-
 drivers/usb/storage/sddr55.c                  |   2 +-
 drivers/usb/storage/uas.c                     |   2 +-
 drivers/usb/typec/tcpm/tcpci.c                |   2 +-
 drivers/usb/usbip/stub_rx.c                   |   2 +-
 drivers/usb/usbip/vhci_hcd.c                  |   7 +-
 drivers/usb/usbip/vhci_rx.c                   |   2 +-
 drivers/usb/usbip/vudc_transfer.c             |   4 +-
 drivers/vfio/pci/vfio_pci.c                   |   2 +-
 drivers/vfio/vfio_iommu_type1.c               |   2 +-
 drivers/video/backlight/adp8860_bl.c          |   2 +-
 drivers/video/fbdev/acornfb.c                 |   2 +-
 drivers/video/fbdev/arcfb.c                   |   3 +-
 drivers/video/fbdev/atmel_lcdfb.c             |   4 +-
 drivers/video/fbdev/aty/radeon_pm.c           |   6 +-
 drivers/video/fbdev/cirrusfb.c                |   4 +-
 drivers/video/fbdev/controlfb.c               |   2 +-
 drivers/video/fbdev/core/fbmem.c              |   2 +-
 drivers/video/fbdev/fsl-diu-fb.c              |   4 +-
 drivers/video/fbdev/gxt4500.c                 |   2 +-
 drivers/video/fbdev/hyperv_fb.c               |   4 +-
 drivers/video/fbdev/i740fb.c                  |   2 +-
 drivers/video/fbdev/nvidia/nv_hw.c            |   2 +-
 drivers/video/fbdev/offb.c                    |   4 +-
 drivers/video/fbdev/omap/lcdc.c               |   4 +-
 drivers/video/fbdev/omap/omapfb_main.c        |  20 +--
 drivers/video/fbdev/omap2/omapfb/dss/dispc.c  |   4 +-
 .../video/fbdev/omap2/omapfb/omapfb-ioctl.c   |   3 +-
 .../video/fbdev/omap2/omapfb/omapfb-main.c    |   2 +-
 drivers/video/fbdev/pm2fb.c                   |   4 +-
 drivers/video/fbdev/pxafb.c                   |   3 +-
 drivers/video/fbdev/riva/fbdev.c              |   2 +-
 drivers/video/fbdev/s3c-fb.c                  |   7 +-
 drivers/video/fbdev/sa1100fb.c                |   3 +-
 drivers/video/fbdev/savage/savagefb_driver.c  |   4 +-
 drivers/video/fbdev/sh_mobile_lcdcfb.c        |   4 +-
 drivers/video/fbdev/sis/sis_main.c            |   8 +-
 drivers/video/fbdev/sm501fb.c                 |   3 +-
 drivers/video/fbdev/stifb.c                   |   4 +-
 drivers/video/fbdev/tdfxfb.c                  |   2 +-
 drivers/video/fbdev/via/lcd.c                 |   2 +-
 drivers/video/fbdev/xen-fbfront.c             |   2 +-
 drivers/virt/vboxguest/vboxguest_core.c       |   2 +-
 drivers/virt/vboxguest/vboxguest_utils.c      |   2 +-
 drivers/watchdog/advantechwdt.c               |   2 +-
 drivers/watchdog/alim1535_wdt.c               |   2 +-
 drivers/watchdog/alim7101_wdt.c               |   2 +-
 drivers/watchdog/ar7_wdt.c                    |   3 +-
 drivers/watchdog/ath79_wdt.c                  |   3 +-
 drivers/watchdog/eurotechwdt.c                |   3 +-
 drivers/watchdog/f71808e_wdt.c                |   6 +-
 drivers/watchdog/gef_wdt.c                    |   3 +-
 drivers/watchdog/geodewdt.c                   |   2 +-
 drivers/watchdog/ib700wdt.c                   |   3 +-
 drivers/watchdog/it8712f_wdt.c                |   2 +-
 drivers/watchdog/ixp4xx_wdt.c                 |   3 +-
 drivers/watchdog/m54xx_wdt.c                  |   3 +-
 drivers/watchdog/machzwd.c                    |   2 +-
 drivers/watchdog/mv64x60_wdt.c                |   3 +-
 drivers/watchdog/nv_tco.c                     |   2 +-
 drivers/watchdog/pc87413_wdt.c                |   2 +-
 drivers/watchdog/pcwd.c                       |   3 +-
 drivers/watchdog/pcwd_pci.c                   |   3 +-
 drivers/watchdog/pcwd_usb.c                   |   3 +-
 drivers/watchdog/rc32434_wdt.c                |   2 +-
 drivers/watchdog/riowd.c                      |   3 +-
 drivers/watchdog/sa1100_wdt.c                 |   3 +-
 drivers/watchdog/sb_wdog.c                    |   3 +-
 drivers/watchdog/sbc60xxwdt.c                 |   2 +-
 drivers/watchdog/sbc7240_wdt.c                |   2 +-
 drivers/watchdog/sbc_fitpc2_wdt.c             |   3 +-
 drivers/watchdog/sc1200wdt.c                  |   3 +-
 drivers/watchdog/sc520_wdt.c                  |   2 +-
 drivers/watchdog/sch311x_wdt.c                |   2 +-
 drivers/watchdog/scx200_wdt.c                 |   2 +-
 drivers/watchdog/smsc37b787_wdt.c             |   2 +-
 drivers/watchdog/w83877f_wdt.c                |   2 +-
 drivers/watchdog/w83977f_wdt.c                |   3 +-
 drivers/watchdog/wafer5823wdt.c               |   2 +-
 drivers/watchdog/watchdog_dev.c               |   2 +-
 drivers/watchdog/wdrtas.c                     |   3 +-
 drivers/watchdog/wdt.c                        |   2 +-
 drivers/watchdog/wdt285.c                     |   2 +-
 drivers/watchdog/wdt977.c                     |   3 +-
 drivers/watchdog/wdt_pci.c                    |   2 +-
 drivers/xen/pvcalls-front.c                   |   2 +-
 drivers/xen/xen-acpi-memhotplug.c             |   2 +-
 drivers/xen/xen-pciback/xenbus.c              |   2 +-
 drivers/xen/xen-scsiback.c                    |   2 +-
 drivers/xen/xenbus/xenbus_probe_frontend.c    |   6 +-
 fs/9p/vfs_file.c                              |   2 +-
 fs/adfs/dir_f.c                               |  12 +-
 fs/affs/inode.c                               |   2 +-
 fs/affs/super.c                               |   6 +-
 fs/afs/cmservice.c                            |  21 ++--
 fs/afs/file.c                                 |   3 +-
 fs/afs/flock.c                                |   3 +-
 fs/afs/fsclient.c                             |  12 +-
 fs/afs/misc.c                                 |  18 +--
 fs/afs/rotate.c                               |   2 +-
 fs/afs/rxrpc.c                                |   7 +-
 fs/afs/vlclient.c                             |  24 ++--
 fs/afs/write.c                                |   2 +-
 fs/afs/yfsclient.c                            |  24 ++--
 fs/aio.c                                      |   2 +-
 fs/btrfs/ctree.c                              |   2 +-
 fs/btrfs/ref-verify.c                         |   2 +-
 fs/btrfs/super.c                              |   6 +-
 fs/btrfs/volumes.h                            |   2 +-
 fs/buffer.c                                   |   2 +-
 fs/ceph/dir.c                                 |   2 +-
 fs/ceph/file.c                                |   2 +-
 fs/cifs/cifssmb.c                             |   2 +-
 fs/cifs/connect.c                             |  10 +-
 fs/cifs/sess.c                                |   6 +-
 fs/cifs/smb2pdu.c                             |   6 +-
 fs/configfs/dir.c                             |   4 +-
 fs/dax.c                                      |   2 +-
 fs/dlm/lock.c                                 |   2 +-
 fs/erofs/zmap.c                               |   6 +-
 fs/ext2/inode.c                               |   4 +-
 fs/ext2/super.c                               |   2 +-
 fs/ext4/hash.c                                |   4 +-
 fs/ext4/indirect.c                            |  12 +-
 fs/ext4/readpage.c                            |   4 +-
 fs/f2fs/f2fs.h                                |   2 +-
 fs/f2fs/node.c                                |   4 +-
 fs/fcntl.c                                    |   4 +-
 fs/fs_context.c                               |   2 +-
 fs/fsopen.c                                   |   2 +-
 fs/gfs2/bmap.c                                |   4 +-
 fs/gfs2/quota.c                               |   2 +-
 fs/hfsplus/wrapper.c                          |   2 +-
 fs/io_uring.c                                 |   4 +-
 fs/iomap/seek.c                               |   4 +-
 fs/jffs2/fs.c                                 |   3 +-
 fs/jffs2/readinode.c                          |   4 +-
 fs/libfs.c                                    |   4 +-
 fs/locks.c                                    |   6 +-
 fs/namei.c                                    |   2 +-
 fs/nfs/blocklayout/blocklayout.c              |   2 +-
 fs/nfs/dir.c                                  |   2 +-
 fs/nfs/filelayout/filelayout.c                |   2 +-
 fs/nfs/flexfilelayout/flexfilelayout.c        |   2 +-
 fs/nfs/fs_context.c                           |  22 ++--
 fs/nfs/nfs3acl.c                              |   4 +-
 fs/nfs/nfs4file.c                             |   2 +-
 fs/nfs/nfs4idmap.c                            |   4 +-
 fs/nfs/nfs4proc.c                             |  32 ++---
 fs/nfs/nfs4state.c                            |  14 +--
 fs/nfs/pagelist.c                             |   2 +-
 fs/nfs/pnfs.c                                 |   2 +-
 fs/nfs_common/nfsacl.c                        |   2 +-
 fs/nfsd/blocklayout.c                         |   4 +-
 fs/nfsd/nfs4callback.c                        |   2 +-
 fs/nfsd/nfs4layouts.c                         |   2 +-
 fs/nfsd/nfs4proc.c                            |   2 +-
 fs/nfsd/nfs4state.c                           |  12 +-
 fs/nfsd/nfsfh.c                               |   4 +-
 fs/nfsd/nfsproc.c                             |   3 +-
 fs/nfsd/nfssvc.c                              |   2 +-
 fs/nfsd/vfs.c                                 |   4 +-
 fs/nilfs2/bmap.c                              |   2 +-
 fs/nilfs2/recovery.c                          |   2 +-
 fs/nilfs2/segment.c                           |  19 +--
 fs/notify/fanotify/fanotify_user.c            |   2 +-
 fs/ocfs2/cluster/quorum.c                     |   2 +-
 fs/quota/quota.c                              |   2 +-
 fs/seq_file.c                                 |   2 +-
 fs/signalfd.c                                 |   2 +-
 fs/ubifs/lprops.c                             |   4 +-
 fs/udf/symlink.c                              |   2 +-
 fs/ufs/util.h                                 |  12 +-
 fs/vboxsf/utils.c                             |   2 +-
 fs/xfs/libxfs/xfs_ag_resv.c                   |   4 +-
 fs/xfs/libxfs/xfs_alloc.c                     |   2 +-
 fs/xfs/libxfs/xfs_da_btree.c                  |   2 +-
 fs/xfs/libxfs/xfs_inode_buf.c                 |   4 +-
 fs/xfs/scrub/bmap.c                           |   2 +-
 fs/xfs/scrub/btree.c                          |   2 +-
 fs/xfs/scrub/common.c                         |   6 +-
 fs/xfs/scrub/dabtree.c                        |   2 +-
 fs/xfs/scrub/repair.c                         |   2 +-
 fs/xfs/xfs_bmap_util.c                        |   3 +-
 fs/xfs/xfs_export.c                           |   4 +-
 fs/xfs/xfs_file.c                             |   2 +-
 fs/xfs/xfs_fsmap.c                            |   2 +-
 fs/xfs/xfs_inode.c                            |   2 +-
 fs/xfs/xfs_ioctl.c                            |   4 +-
 fs/xfs/xfs_iomap.c                            |   2 +-
 fs/xfs/xfs_log.c                              |   2 +-
 fs/xfs/xfs_trans_buf.c                        |   2 +-
 fs/zonefs/super.c                             |   2 +-
 include/linux/compat.h                        |   6 +-
 include/linux/filter.h                        |   2 +-
 include/linux/jhash.h                         |  39 ++++--
 include/linux/mm.h                            |   9 +-
 include/linux/signal.h                        |  12 +-
 include/linux/skbuff.h                        |  12 +-
 include/math-emu/op-common.h                  |   6 +-
 init/do_mounts_md.c                           |   4 +-
 ipc/sem.c                                     |   4 +-
 ipc/shm.c                                     |   4 +-
 kernel/auditfilter.c                          |   2 +-
 kernel/bpf/cgroup.c                           |   4 +-
 kernel/bpf/syscall.c                          |   2 +-
 kernel/bpf/verifier.c                         |   4 +-
 kernel/capability.c                           |   2 +-
 kernel/compat.c                               |   6 +-
 kernel/debug/gdbstub.c                        |   6 +-
 kernel/debug/kdb/kdb_keyboard.c               |   4 +-
 kernel/debug/kdb/kdb_support.c                |   6 +-
 kernel/events/core.c                          |   3 +-
 kernel/futex.c                                |   4 +-
 kernel/gcov/gcc_3_4.c                         |   6 +-
 kernel/irq/handle.c                           |   3 +-
 kernel/irq/manage.c                           |   5 +-
 kernel/kallsyms.c                             |   4 +-
 kernel/power/hibernate.c                      |   2 +-
 kernel/power/qos.c                            |   4 +-
 kernel/sched/core.c                           |   2 +-
 kernel/sched/topology.c                       |   6 +-
 kernel/signal.c                               |   2 +-
 kernel/sys.c                                  |   3 +-
 kernel/time/hrtimer.c                         |   2 +-
 kernel/time/posix-timers.c                    |   4 +-
 kernel/time/tick-broadcast.c                  |   2 +-
 kernel/time/timer.c                           |   2 +-
 kernel/trace/blktrace.c                       |   2 +-
 kernel/trace/trace_events_filter.c            |   4 +-
 lib/asn1_decoder.c                            |   6 +-
 lib/assoc_array.c                             |   2 +-
 lib/bootconfig.c                              |   4 +-
 lib/cmdline.c                                 |  10 +-
 lib/dim/net_dim.c                             |   2 +-
 lib/dim/rdma_dim.c                            |   4 +-
 lib/glob.c                                    |   2 +-
 lib/nlattr.c                                  |   5 +-
 lib/siphash.c                                 |  54 ++++++---
 lib/ts_fsm.c                                  |   3 +-
 lib/vsprintf.c                                |  18 ++-
 lib/xz/xz_dec_lzma2.c                         |   8 +-
 lib/xz/xz_dec_stream.c                        |  32 ++---
 lib/zlib_inflate/inflate.c                    |  24 ++--
 lib/zstd/bitstream.h                          |  10 +-
 lib/zstd/compress.c                           |   3 +-
 lib/zstd/decompress.c                         |  17 +--
 lib/zstd/huf_compress.c                       |   4 +-
 mm/gup.c                                      |   2 +-
 mm/hugetlb_cgroup.c                           |   6 +-
 mm/ksm.c                                      |   3 +-
 mm/list_lru.c                                 |   2 +-
 mm/memcontrol.c                               |   2 +-
 mm/mempolicy.c                                |   3 -
 mm/mmap.c                                     |   5 +-
 mm/shmem.c                                    |   2 +-
 mm/zsmalloc.c                                 |   2 +-
 net/8021q/vlan_dev.c                          |   2 +-
 net/9p/trans_xen.c                            |   2 +-
 net/atm/common.c                              |   4 +-
 net/atm/lec.c                                 |   2 +-
 net/atm/resources.c                           |   8 +-
 net/bluetooth/hci_event.c                     |   6 +-
 net/bluetooth/hci_sock.c                      |   4 +-
 net/bluetooth/l2cap_core.c                    |  22 ++--
 net/bluetooth/l2cap_sock.c                    |   4 +-
 net/bluetooth/mgmt.c                          |   4 +-
 net/bluetooth/rfcomm/core.c                   |   3 +-
 net/bluetooth/rfcomm/sock.c                   |   3 +-
 net/bluetooth/smp.c                           |   2 +-
 net/bpf/test_run.c                            |   2 +-
 net/bridge/netfilter/ebtables.c               |   2 +-
 net/can/j1939/socket.c                        |   2 +-
 net/can/j1939/transport.c                     |  21 ++--
 net/ceph/ceph_hash.c                          |  20 +--
 net/ceph/crush/mapper.c                       |   2 +-
 net/ceph/messenger.c                          |   4 +-
 net/ceph/mon_client.c                         |   2 +-
 net/ceph/osd_client.c                         |   6 +-
 net/core/dev.c                                |   4 +-
 net/core/dev_ioctl.c                          |   2 +-
 net/core/devlink.c                            |   2 +-
 net/core/drop_monitor.c                       |   2 +-
 net/core/filter.c                             |   2 +-
 net/core/pktgen.c                             |   2 +-
 net/core/skmsg.c                              |   3 +-
 net/core/sock.c                               |   2 +-
 net/dccp/ccids/ccid3.c                        |   2 +-
 net/dccp/feat.c                               |   3 +-
 net/dccp/input.c                              |  10 +-
 net/dccp/options.c                            |   2 +-
 net/dccp/output.c                             |   9 +-
 net/dccp/proto.c                              |   8 +-
 net/decnet/af_decnet.c                        |   6 +-
 net/decnet/dn_nsp_in.c                        |   2 +-
 net/decnet/dn_table.c                         |   2 +-
 net/decnet/sysctl_net_decnet.c                |   2 +-
 net/dsa/slave.c                               |   2 +-
 net/ieee802154/6lowpan/reassembly.c           |   3 +-
 net/ieee802154/6lowpan/rx.c                   |   6 +-
 net/ipv4/af_inet.c                            |   4 +-
 net/ipv4/ah4.c                                |   2 +-
 net/ipv4/arp.c                                |   2 +-
 net/ipv4/devinet.c                            |   6 +-
 net/ipv4/fib_semantics.c                      |   4 +-
 net/ipv4/icmp.c                               |   2 +-
 net/ipv4/ip_output.c                          |   2 +-
 net/ipv4/ipmr.c                               |   2 +-
 net/ipv4/netfilter/nf_log_ipv4.c              |   2 +-
 net/ipv4/netfilter/nf_nat_pptp.c              |   4 +-
 net/ipv4/nexthop.c                            |   2 +-
 net/ipv4/tcp.c                                |   2 +-
 net/ipv4/tcp_input.c                          |   6 +-
 net/ipv4/tcp_ipv4.c                           |   4 +-
 net/ipv4/udp.c                                |   2 +-
 net/ipv6/addrconf.c                           |   6 +-
 net/ipv6/ah6.c                                |   2 +-
 net/ipv6/exthdrs.c                            |   2 +-
 net/ipv6/icmp.c                               |   2 +-
 net/ipv6/ip6_fib.c                            |   8 +-
 net/ipv6/ip6mr.c                              |   2 +-
 net/ipv6/ndisc.c                              |   2 +-
 net/ipv6/netfilter/nf_log_ipv6.c              |   2 +-
 net/ipv6/raw.c                                |   8 +-
 net/ipv6/route.c                              |   2 +-
 net/ipv6/tcp_ipv6.c                           |   2 +-
 net/iucv/af_iucv.c                            |  13 +-
 net/l2tp/l2tp_netlink.c                       |   2 +-
 net/mac80211/cfg.c                            |   6 +-
 net/mac80211/chan.c                           |   2 +-
 net/mac80211/ht.c                             |   4 +-
 net/mac80211/ibss.c                           |   4 +-
 net/mac80211/iface.c                          |  11 +-
 net/mac80211/key.c                            |   3 +-
 net/mac80211/mesh.c                           |   4 +-
 net/mac80211/mesh_hwmp.c                      |   2 +-
 net/mac80211/mesh_plink.c                     |   2 +-
 net/mac80211/mlme.c                           |   4 +-
 net/mac80211/offchannel.c                     |   4 +-
 net/mac80211/rx.c                             |   4 +-
 net/mac80211/tdls.c                           |   8 +-
 net/mac80211/tx.c                             |  12 +-
 net/mac80211/util.c                           |  11 +-
 net/mac80211/wme.c                            |   2 +-
 net/mpls/af_mpls.c                            |   2 +-
 net/mptcp/protocol.c                          |   2 +-
 net/ncsi/ncsi-manage.c                        |   4 +-
 net/netfilter/ipset/ip_set_core.c             |   2 +-
 net/netfilter/ipvs/ip_vs_proto_tcp.c          |   2 +-
 net/netfilter/ipvs/ip_vs_proto_udp.c          |   2 +-
 net/netfilter/nf_conntrack_h323_asn1.c        |   6 +-
 net/netfilter/nf_conntrack_proto.c            |   2 +-
 net/netfilter/nf_conntrack_proto_tcp.c        |   2 +-
 net/netfilter/nf_conntrack_standalone.c       |   2 +-
 net/netfilter/nf_nat_core.c                   |  10 +-
 net/netfilter/nf_synproxy_core.c              |   6 +-
 net/netfilter/nf_tables_api.c                 |   8 +-
 net/netfilter/nf_tables_core.c                |   2 +-
 net/netfilter/nfnetlink_cttimeout.c           |   2 +-
 net/netfilter/nft_cmp.c                       |   4 +-
 net/netfilter/nft_ct.c                        |   4 +-
 net/netfilter/nft_fib.c                       |   2 +-
 net/netfilter/nft_payload.c                   |   2 +-
 net/netfilter/utils.c                         |   8 +-
 net/netfilter/x_tables.c                      |   2 +-
 net/netrom/nr_in.c                            |   2 +-
 net/netrom/nr_route.c                         |   8 +-
 net/openvswitch/conntrack.c                   |   4 +-
 net/openvswitch/flow.c                        |   2 +-
 net/packet/af_packet.c                        |   3 +-
 net/phonet/pep.c                              |  10 +-
 net/rds/send.c                                |   3 +-
 net/rose/rose_in.c                            |   2 +-
 net/rose/rose_route.c                         |   4 +-
 net/rxrpc/af_rxrpc.c                          |   7 +-
 net/rxrpc/call_accept.c                       |   2 +-
 net/rxrpc/conn_client.c                       |   2 +-
 net/rxrpc/input.c                             |   6 +-
 net/rxrpc/local_object.c                      |   2 +-
 net/rxrpc/recvmsg.c                           |   2 +-
 net/rxrpc/sendmsg.c                           |   6 +-
 net/sched/act_csum.c                          |   3 +-
 net/sched/act_ct.c                            |   2 +-
 net/sched/sch_cake.c                          |   2 +-
 net/sched/sch_cbq.c                           |   2 +-
 net/sched/sch_drr.c                           |   2 +-
 net/sched/sch_ets.c                           |   2 +-
 net/sched/sch_fq_codel.c                      |   2 +-
 net/sched/sch_fq_pie.c                        |   2 +-
 net/sched/sch_hfsc.c                          |   2 +-
 net/sched/sch_htb.c                           |   2 +-
 net/sched/sch_multiq.c                        |   2 +-
 net/sched/sch_prio.c                          |   2 +-
 net/sched/sch_qfq.c                           |   2 +-
 net/sched/sch_sfb.c                           |   2 +-
 net/sched/sch_sfq.c                           |   2 +-
 net/sctp/ipv6.c                               |   2 +-
 net/sctp/outqueue.c                           |   6 +-
 net/sctp/sm_make_chunk.c                      |   2 +-
 net/sctp/sm_sideeffect.c                      |   3 +-
 net/sctp/sm_statefuns.c                       |   2 +-
 net/socket.c                                  |   6 +-
 net/sunrpc/auth_gss/gss_krb5_wrap.c           |   2 +-
 net/sunrpc/clnt.c                             |  22 ++--
 net/sunrpc/xprt.c                             |   2 +-
 net/sunrpc/xprtsock.c                         |   8 +-
 net/tipc/bearer.c                             |   2 +-
 net/tipc/group.c                              |   2 +-
 net/tipc/link.c                               |   2 +-
 net/tipc/socket.c                             |   4 +-
 net/unix/af_unix.c                            |   2 +-
 net/wireless/chan.c                           |   4 +-
 net/wireless/mlme.c                           |   2 +-
 net/wireless/nl80211.c                        |  20 +--
 net/wireless/scan.c                           |   2 +-
 net/wireless/sme.c                            |   4 +-
 net/wireless/util.c                           |   4 +-
 net/wireless/wext-compat.c                    |   4 +-
 net/x25/x25_facilities.c                      |   2 +-
 net/x25/x25_in.c                              |   2 +-
 net/xfrm/xfrm_policy.c                        |   2 +-
 samples/bpf/hbm.c                             |   2 +-
 security/apparmor/domain.c                    |   2 +-
 security/apparmor/lib.c                       |   4 +-
 security/integrity/ima/ima_appraise.c         |   4 +-
 security/integrity/ima/ima_policy.c           |   8 +-
 security/integrity/ima/ima_template_lib.c     |   2 +-
 security/keys/process_keys.c                  |   6 +-
 security/keys/request_key.c                   |  12 +-
 security/selinux/hooks.c                      |   8 +-
 security/selinux/ss/mls.c                     |   3 +-
 security/smack/smack_lsm.c                    |   2 +-
 security/tomoyo/common.c                      |  18 +--
 security/tomoyo/file.c                        |   2 +-
 sound/atmel/ac97c.c                           |  16 +--
 sound/core/memalloc.c                         |   2 +-
 sound/core/oss/pcm_oss.c                      |   2 +-
 sound/core/oss/pcm_plugin.c                   |   2 +-
 sound/core/pcm_native.c                       |   8 +-
 sound/core/seq/oss/seq_oss_timer.c            |   2 +-
 sound/core/seq/seq_midi_emul.c                |   2 +-
 sound/drivers/opl3/opl3_midi.c                |   4 +-
 sound/isa/galaxy/galaxy.c                     |   6 +-
 sound/isa/msnd/msnd_pinnacle_mixer.c          |   3 +-
 sound/isa/opti9xx/miro.c                      |  12 +-
 sound/isa/opti9xx/opti92x-ad1848.c            |  13 +-
 sound/isa/sb/sb8_main.c                       |  10 +-
 sound/oss/dmasound/dmasound_atari.c           |   2 +-
 sound/oss/dmasound/dmasound_core.c            |   4 +-
 sound/pci/ac97/ac97_codec.c                   |   4 +-
 sound/pci/atiixp.c                            |   6 +-
 sound/pci/azt3328.c                           |   2 +-
 sound/pci/echoaudio/echoaudio.c               |   4 +-
 sound/pci/emu10k1/emupcm.c                    |   5 +-
 sound/pci/hda/hda_beep.c                      |   2 +-
 sound/pci/hda/patch_conexant.c                |   2 +-
 sound/pci/hda/patch_realtek.c                 |   4 +-
 sound/pci/ice1712/delta.c                     |   2 +-
 sound/pci/intel8x0.c                          |   8 +-
 sound/pci/mixart/mixart.c                     |   2 +-
 sound/pci/mixart/mixart_core.c                |   2 +-
 sound/pci/nm256/nm256.c                       |   6 +-
 sound/pci/oxygen/oxygen_pcm.c                 |   2 +-
 sound/pci/ymfpci/ymfpci_main.c                |   2 +-
 sound/pcmcia/pdaudiocf/pdaudiocf_pcm.c        |   4 +-
 sound/ppc/snd_ps3.c                           |   4 +-
 sound/soc/atmel/mchp-i2s-mcc.c                |   2 +-
 sound/soc/codecs/ab8500-codec.c               |   2 +-
 sound/soc/codecs/adau1761.c                   |   4 +-
 sound/soc/codecs/adau17x1.c                   |   4 +-
 sound/soc/codecs/adav80x.c                    |   2 +-
 sound/soc/codecs/ak4613.c                     |   6 +-
 sound/soc/codecs/es8328.c                     |   4 +-
 sound/soc/codecs/jz4770.c                     |   2 +-
 sound/soc/codecs/max9860.c                    |   2 +-
 sound/soc/codecs/msm8916-wcd-analog.c         |   2 +-
 sound/soc/codecs/rt274.c                      |   4 +-
 sound/soc/codecs/rt5640.c                     |   4 +-
 sound/soc/codecs/rt5677.c                     |   2 +-
 sound/soc/codecs/sta32x.c                     |   2 +-
 sound/soc/codecs/sta350.c                     |   2 +-
 sound/soc/codecs/tas2552.c                    |   2 +-
 sound/soc/codecs/tlv320aic23.c                |   2 +-
 sound/soc/codecs/tlv320aic31xx.c              |   3 +-
 sound/soc/codecs/tpa6130a2.c                  |   2 +-
 sound/soc/codecs/wm8753.c                     |   6 +-
 sound/soc/codecs/wm8903.c                     |   2 +-
 sound/soc/codecs/wm8904.c                     |   5 +-
 sound/soc/codecs/wm8955.c                     |   2 +-
 sound/soc/codecs/wm8960.c                     |   2 +-
 sound/soc/codecs/wm8961.c                     |   2 +-
 sound/soc/codecs/wm8962.c                     |   2 +-
 sound/soc/codecs/wm8993.c                     |   4 +-
 sound/soc/codecs/wm8994.c                     |   4 +-
 sound/soc/codecs/wm8995.c                     |   2 +-
 sound/soc/codecs/wm8996.c                     |   2 +-
 sound/soc/codecs/wm9081.c                     |   2 +-
 sound/soc/fsl/fsl_ssi.c                       |   2 +-
 sound/soc/hisilicon/hi6210-i2s.c              |   4 +-
 sound/soc/intel/baytrail/sst-baytrail-pcm.c   |   2 +-
 sound/soc/intel/boards/bytcht_es8316.c        |   2 +-
 sound/soc/intel/boards/bytcr_rt5651.c         |   4 +-
 sound/soc/intel/skylake/skl-pcm.c             |   3 +-
 sound/soc/meson/axg-tdm-interface.c           |   8 +-
 sound/soc/pxa/pxa-ssp.c                       |   2 +-
 sound/soc/rockchip/rockchip_pdm.c             |   6 +-
 sound/soc/samsung/i2s.c                       |   2 +-
 sound/soc/soc-core.c                          |   3 +-
 sound/soc/soc-topology.c                      |   4 +-
 sound/soc/sof/intel/hda-dai.c                 |   6 +-
 sound/soc/sof/pcm.c                           |   5 +-
 sound/soc/sof/topology.c                      |   2 +-
 sound/soc/ti/davinci-i2s.c                    |   2 +-
 sound/soc/ti/n810.c                           |   2 +-
 sound/soc/ti/omap-dmic.c                      |   4 +-
 sound/soc/ti/omap-mcpdm.c                     |   8 +-
 sound/soc/ti/rx51.c                           |   2 +-
 sound/soc/zte/zx-i2s.c                        |   4 +-
 sound/soc/zte/zx-spdif.c                      |   2 +-
 sound/sparc/dbri.c                            |   8 +-
 sound/usb/caiaq/audio.c                       |   2 +-
 sound/usb/caiaq/device.c                      |   2 +-
 sound/usb/card.c                              |   3 +-
 sound/usb/clock.c                             |   2 +-
 sound/usb/midi.c                              |   2 +-
 sound/usb/pcm.c                               |   2 +-
 sound/usb/stream.c                            |   3 +-
 sound/xen/xen_snd_front.c                     |   3 -
 sound/xen/xen_snd_front_evtchnl.c             |   4 -
 virt/kvm/arm/hyp/vgic-v3-sr.c                 |  16 +--
 1831 files changed, 4064 insertions(+), 4709 deletions(-)
Signature · 7 lines
2.24.0


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#1 lore raw

PATCH 1/491 MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough;

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 2 +-
 drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c        | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c +1 -1
index f260dd..42978f8 100644
@@ -466,7 +466,7 @@ struct sk_buff *mlx5e_ktls_handle_tx_skb(struct net_device *netdev,
 			if (likely(!skb->decrypted))
 				goto out;
 			WARN_ON_ONCE(1);
-			/* fall-through */
+			fallthrough;
 		default: /* MLX5E_KTLS_SYNC_FAIL */
 			goto err_out;
 		}
drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c +2 -2
index 6102113..d35bbc 100644
@@ -339,14 +339,14 @@ static void mlx5_fpga_conn_handle_cqe(struct mlx5_fpga_conn *conn,
 	switch (opcode) {
 	case MLX5_CQE_REQ_ERR:
 		status = ((struct mlx5_err_cqe *)cqe)->syndrome;
-		/* Fall through */
+		fallthrough;
 	case MLX5_CQE_REQ:
 		mlx5_fpga_conn_sq_cqe(conn, cqe, status);
 		break;
 
 	case MLX5_CQE_RESP_ERR:
 		status = ((struct mlx5_err_cqe *)cqe)->syndrome;
-		/* Fall through */
+		fallthrough;
 	case MLX5_CQE_RESP_SEND:
 		mlx5_fpga_conn_rq_cqe(conn, cqe, status);
 		break;
Signature · 1 line
2.24.0
Reviewed-by on v1 1/491
#2 lore raw

Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough;

Quoted 11 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 2 +-
 drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c        | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Thanks,

maintainer
#3 lore raw

Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough;

In reply to Joe Perches

Joe, please use Subject line subsystem prefixes consistent with what would be used for other changes to these drivers.

Thank you.

#4 lore raw

Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough;

Quoted 2 lines · David Miller

Joe, please use Subject line subsystem prefixes consistent with what would be used for other changes to these drivers.

Not easy to do for scripted patches.
There's no mechanism that scriptable.

I'm not going to hand-edit 500 patches.

maintainer
#5 lore raw

Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough;

From: Joe Perches <[email protected]>
Date: Wed, 11 Mar 2020 23:26:59 -0700

Quoted 1 line

I'm not going to hand-edit 500 patches.

Then I'm not applying your stuff, it's as simple as that.

maintainer
#6 lore raw

Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough;

In reply to Joe Perches
Quoted 6 lines · On Wed, 11 Mar 2020 23:26:59 -0700 Joe Perches wrote:
Quoted 2 lines · David Miller

Joe, please use Subject line subsystem prefixes consistent with what would be used for other changes to these drivers.

Not easy to do for scripted patches.
There's no mechanism that scriptable.

I have this to show me the top 3 prefixes used for files currently modified in my tree:

tgs() {
    local fs

    fs=$(git status -s | sed -n 's/ M //p')

    git log --oneline --no-merges -- $fs | \
	sed -e's/[^ ]* \(.*\):[^:]*/\1/' | \
	sort | uniq -c | sort -rn | head -3
}

You could probably massage it to just give you to top one and feed that into git commit template?

#7 lore raw

Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough;

Quoted 21 lines · Jakub Kicinski
Quoted 6 lines · On Wed, 11 Mar 2020 23:26:59 -0700 Joe Perches wrote:
Quoted 2 lines · David Miller

Joe, please use Subject line subsystem prefixes consistent with what would be used for other changes to these drivers.

Not easy to do for scripted patches.
There's no mechanism that scriptable.

I have this to show me the top 3 prefixes used for files currently modified in my tree:

tgs() {
    local fs

    fs=$(git status -s | sed -n 's/ M //p')

    git log --oneline --no-merges -- $fs | \
	sed -e's/[^ ]* \(.*\):[^:]*/\1/' | \
	sort | uniq -c | sort -rn | head -3
}
Quoted 2 lines

You could probably massage it to just give you to top one and feed that into git commit template?

I had already tried that via:

$ cat get_patch_subject_prefix.bash 
#!/bin/bash
git log --format="%s" --no-merges -200 --since=2-years-ago $@ | \
  cut -f1 -d":" | \
  sort  | uniq -c | sort -rn | head -1 | \
  sed 's/^[[:space:]]*[[:digit:]]*[[:space:]]*//'
$ 

It doesn't work very well for many of the subsystems.

For instance, this script produces things like:

ARM/ZYNQ ARCHITECTURE: treewide
FCOE SUBSYSTEM (libfc, libfcoe, fcoe): scsi
WOLFSON MICROELECTRONICS DRIVERS: ASoC

There isn't a great single mechanism for this.

At various times, I have proposed adding a grammar for patch subject titles to MAINTAINERS.

Like:
https://lore.kernel.org/lkml/1289919077.28741.50.camel@Joe-Laptop/

#8 lore raw

PATCH 2/491 MARVELL OCTEONTX2 RVU ADMIN FUNCTION DRIVER: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c +1 -1
index 36953d4..01a7931 100644
@@ -737,7 +737,7 @@ static int rvu_nix_aq_enq_inst(struct rvu *rvu, struct nix_aq_enq_req *req,
 		else if (req->ctype == NIX_AQ_CTYPE_MCE)
 			memcpy(mask, &req->mce_mask,
 			       sizeof(struct nix_rx_mce_s));
-		/* Fall through */
+		fallthrough;
 	case NIX_AQ_INSTOP_INIT:
 		if (req->ctype == NIX_AQ_CTYPE_RQ)
 			memcpy(ctx, &req->rq, sizeof(struct nix_rq_ctx_s));
Signature · 1 line
2.24.0
#9 lore raw

PATCH 3/491 MELLANOX MLX5 core VPI driver: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h         | 2 +-
 drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c          | 4 ++--
 drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c      | 2 +-
 .../net/ethernet/mellanox/mlx5/core/eswitch_offloads.c    | 2 +-
 drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c          | 8 ++++----
 drivers/net/ethernet/mellanox/mlx5/core/vport.c           | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h +1 -1
index a226277..2a1cc2 100644
@@ -223,7 +223,7 @@ mlx5e_set_eseg_swp(struct sk_buff *skb, struct mlx5_wqe_eth_seg *eseg,
 	switch (swp_spec->tun_l4_proto) {
 	case IPPROTO_UDP:
 		eseg->swp_flags |= MLX5_ETH_WQE_SWP_INNER_L4_UDP;
-		/* fall through */
+		fallthrough;
 	case IPPROTO_TCP:
 		eseg->swp_inner_l4_offset = skb_inner_transport_offset(skb) / 2;
 		break;
drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c +2 -2
index f049e0a..f74e50 100644
@@ -167,11 +167,11 @@ bool mlx5e_xdp_handle(struct mlx5e_rq *rq, struct mlx5e_dma_info *di,
 		return true;
 	default:
 		bpf_warn_invalid_xdp_action(act);
-		/* fall through */
+		fallthrough;
 	case XDP_ABORTED:
 xdp_abort:
 		trace_xdp_exception(rq->netdev, prog, act);
-		/* fall through */
+		fallthrough;
 	case XDP_DROP:
 		rq->stats->xdp_drop++;
 		return true;
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +1 -1
index 01539b8..8a3376a 100644
@@ -225,7 +225,7 @@ int mlx5e_ethtool_get_sset_count(struct mlx5e_priv *priv, int sset)
 		return MLX5E_NUM_PFLAGS;
 	case ETH_SS_TEST:
 		return mlx5e_self_test_num(priv);
-	/* fallthrough */
+		fallthrough;
 	default:
 		return -EOPNOTSUPP;
 	}
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +1 -1
index 4b5b661..033454 100644
@@ -2426,7 +2426,7 @@ int mlx5_devlink_eswitch_inline_mode_set(struct devlink *devlink, u8 mode,
 	case MLX5_CAP_INLINE_MODE_NOT_REQUIRED:
 		if (mode == DEVLINK_ESWITCH_INLINE_MODE_NONE)
 			return 0;
-		/* fall through */
+		fallthrough;
 	case MLX5_CAP_INLINE_MODE_L2:
 		NL_SET_ERR_MSG_MOD(extack, "Inline mode can't be set");
 		return -EOPNOTSUPP;
drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c +4 -4
index 416676..a40e43 100644
@@ -199,13 +199,13 @@ static void mlx5_lag_fib_update(struct work_struct *work)
 	/* Protect internal structures from changes */
 	rtnl_lock();
 	switch (fib_work->event) {
-	case FIB_EVENT_ENTRY_REPLACE: /* fall through */
+	case FIB_EVENT_ENTRY_REPLACE:
 	case FIB_EVENT_ENTRY_DEL:
 		mlx5_lag_fib_route_event(ldev, fib_work->event,
 					 fib_work->fen_info.fi);
 		fib_info_put(fib_work->fen_info.fi);
 		break;
-	case FIB_EVENT_NH_ADD: /* fall through */
+	case FIB_EVENT_NH_ADD:
 	case FIB_EVENT_NH_DEL:
 		fib_nh = fib_work->fnh_info.fib_nh;
 		mlx5_lag_fib_nexthop_event(ldev,
@@ -256,7 +256,7 @@ static int mlx5_lag_fib_event(struct notifier_block *nb,
 		return NOTIFY_DONE;
 
 	switch (event) {
-	case FIB_EVENT_ENTRY_REPLACE: /* fall through */
+	case FIB_EVENT_ENTRY_REPLACE:
 	case FIB_EVENT_ENTRY_DEL:
 		fen_info = container_of(info, struct fib_entry_notifier_info,
 					info);
@@ -279,7 +279,7 @@ static int mlx5_lag_fib_event(struct notifier_block *nb,
 		 */
 		fib_info_hold(fib_work->fen_info.fi);
 		break;
-	case FIB_EVENT_NH_ADD: /* fall through */
+	case FIB_EVENT_NH_ADD:
 	case FIB_EVENT_NH_DEL:
 		fnh_info = container_of(info, struct fib_nh_notifier_info,
 					info);
drivers/net/ethernet/mellanox/mlx5/core/vport.c +1 -1
index 1faac31f..aea1065 100644
@@ -125,7 +125,7 @@ void mlx5_query_min_inline(struct mlx5_core_dev *mdev,
 	case MLX5_CAP_INLINE_MODE_VPORT_CONTEXT:
 		if (!mlx5_query_nic_vport_min_inline(mdev, 0, min_inline_mode))
 			break;
-		/* fall through */
+		fallthrough;
 	case MLX5_CAP_INLINE_MODE_L2:
 		*min_inline_mode = MLX5_INLINE_MODE_L2;
 		break;
Signature · 1 line
2.24.0
#10 lore raw

Re: [PATCH -next 003/491] MELLANOX MLX5 core VPI driver: Use fallthrough;

Quoted 51 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h         | 2 +-
 drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c          | 4 ++--
 drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c      | 2 +-
 .../net/ethernet/mellanox/mlx5/core/eswitch_offloads.c    | 2 +-
 drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c          | 8 ++++----
 drivers/net/ethernet/mellanox/mlx5/core/vport.c           | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h +1 -1
index a226277..2a1cc2 100644
@@ -223,7 +223,7 @@ mlx5e_set_eseg_swp(struct sk_buff *skb, struct mlx5_wqe_eth_seg *eseg,
 	switch (swp_spec->tun_l4_proto) {
 	case IPPROTO_UDP:
 		eseg->swp_flags |= MLX5_ETH_WQE_SWP_INNER_L4_UDP;
-		/* fall through */
+		fallthrough;
 	case IPPROTO_TCP:
 		eseg->swp_inner_l4_offset = skb_inner_transport_offset(skb) / 2;
 		break;
drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c +2 -2
index f049e0a..f74e50 100644
@@ -167,11 +167,11 @@ bool mlx5e_xdp_handle(struct mlx5e_rq *rq, struct mlx5e_dma_info *di,
 		return true;
 	default:
 		bpf_warn_invalid_xdp_action(act);
-		/* fall through */
+		fallthrough;
 	case XDP_ABORTED:
 xdp_abort:
 		trace_xdp_exception(rq->netdev, prog, act);
-		/* fall through */
+		fallthrough;
 	case XDP_DROP:
 		rq->stats->xdp_drop++;
 		return true;
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +0 -0
index 01539b8..8a3376a 100644

drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c int mlx5e_ethtool_get_sset_count(struct mlx5e_priv *priv, int sset) · line 228

Quoted 5 lines
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +1 -1
@@ -225,7 +225,7 @@ int mlx5e_ethtool_get_sset_count(struct mlx5e_priv *priv, int sset)
 		return MLX5E_NUM_PFLAGS;
 	case ETH_SS_TEST:
 		return mlx5e_self_test_num(priv);
-	/* fallthrough */
+		fallthrough;

This should be removed, there is return before.

Quoted 70 lines
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +0 -0
 	default:
 		return -EOPNOTSUPP;
 	}
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +1 -1
index 4b5b661..033454 100644
@@ -2426,7 +2426,7 @@ int mlx5_devlink_eswitch_inline_mode_set(struct devlink *devlink, u8 mode,
 	case MLX5_CAP_INLINE_MODE_NOT_REQUIRED:
 		if (mode == DEVLINK_ESWITCH_INLINE_MODE_NONE)
 			return 0;
-		/* fall through */
+		fallthrough;
 	case MLX5_CAP_INLINE_MODE_L2:
 		NL_SET_ERR_MSG_MOD(extack, "Inline mode can't be set");
 		return -EOPNOTSUPP;
drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c +4 -4
index 416676..a40e43 100644
@@ -199,13 +199,13 @@ static void mlx5_lag_fib_update(struct work_struct *work)
 	/* Protect internal structures from changes */
 	rtnl_lock();
 	switch (fib_work->event) {
-	case FIB_EVENT_ENTRY_REPLACE: /* fall through */
+	case FIB_EVENT_ENTRY_REPLACE:
 	case FIB_EVENT_ENTRY_DEL:
 		mlx5_lag_fib_route_event(ldev, fib_work->event,
 					 fib_work->fen_info.fi);
 		fib_info_put(fib_work->fen_info.fi);
 		break;
-	case FIB_EVENT_NH_ADD: /* fall through */
+	case FIB_EVENT_NH_ADD:
 	case FIB_EVENT_NH_DEL:
 		fib_nh = fib_work->fnh_info.fib_nh;
 		mlx5_lag_fib_nexthop_event(ldev,
@@ -256,7 +256,7 @@ static int mlx5_lag_fib_event(struct notifier_block *nb,
 		return NOTIFY_DONE;
 
 	switch (event) {
-	case FIB_EVENT_ENTRY_REPLACE: /* fall through */
+	case FIB_EVENT_ENTRY_REPLACE:
 	case FIB_EVENT_ENTRY_DEL:
 		fen_info = container_of(info, struct fib_entry_notifier_info,
 					info);
@@ -279,7 +279,7 @@ static int mlx5_lag_fib_event(struct notifier_block *nb,
 		 */
 		fib_info_hold(fib_work->fen_info.fi);
 		break;
-	case FIB_EVENT_NH_ADD: /* fall through */
+	case FIB_EVENT_NH_ADD:
 	case FIB_EVENT_NH_DEL:
 		fnh_info = container_of(info, struct fib_nh_notifier_info,
 					info);
drivers/net/ethernet/mellanox/mlx5/core/vport.c +1 -2
index 1faac31f..aea1065 100644
@@ -125,7 +125,7 @@ void mlx5_query_min_inline(struct mlx5_core_dev *mdev,
 	case MLX5_CAP_INLINE_MODE_VPORT_CONTEXT:
 		if (!mlx5_query_nic_vport_min_inline(mdev, 0, min_inline_mode))
 			break;
-		/* fall through */
+		fallthrough;
 	case MLX5_CAP_INLINE_MODE_L2:
 		*min_inline_mode = MLX5_INLINE_MODE_L2;
 		break;
--

2.24.0

#11 lore raw

PATCH 4/491 PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/mips/kernel/perf_event_mipsxx.c | 6 +++---
 arch/x86/events/intel/core.c         | 7 +++----
 arch/x86/events/intel/lbr.c          | 2 +-
 kernel/events/core.c                 | 3 +--
 4 files changed, 8 insertions(+), 10 deletions(-)
arch/mips/kernel/perf_event_mipsxx.c +3 -3
index 128fc9..484948 100644
@@ -790,15 +790,15 @@ static void reset_counters(void *arg)
 	case 4:
 		mipsxx_pmu_write_control(3, 0);
 		mipspmu.write_counter(3, 0);
-		/* fall through */
+		fallthrough;
 	case 3:
 		mipsxx_pmu_write_control(2, 0);
 		mipspmu.write_counter(2, 0);
-		/* fall through */
+		fallthrough;
 	case 2:
 		mipsxx_pmu_write_control(1, 0);
 		mipspmu.write_counter(1, 0);
-		/* fall through */
+		fallthrough;
 	case 1:
 		mipsxx_pmu_write_control(0, 0);
 		mipspmu.write_counter(0, 0);
arch/x86/events/intel/core.c +3 -4
index 332954..8cd3bb 100644
@@ -4637,8 +4637,7 @@ __init int intel_pmu_init(void)
 
 	case INTEL_FAM6_CORE2_MEROM:
 		x86_add_quirk(intel_clovertown_quirk);
-		/* fall through */
-
+		fallthrough;
 	case INTEL_FAM6_CORE2_MEROM_L:
 	case INTEL_FAM6_CORE2_PENRYN:
 	case INTEL_FAM6_CORE2_DUNNINGTON:
@@ -5017,7 +5016,7 @@ __init int intel_pmu_init(void)
 
 	case INTEL_FAM6_SKYLAKE_X:
 		pmem = true;
-		/* fall through */
+		fallthrough;
 	case INTEL_FAM6_SKYLAKE_L:
 	case INTEL_FAM6_SKYLAKE:
 	case INTEL_FAM6_KABYLAKE_L:
@@ -5069,7 +5068,7 @@ __init int intel_pmu_init(void)
 	case INTEL_FAM6_ICELAKE_X:
 	case INTEL_FAM6_ICELAKE_D:
 		pmem = true;
-		/* fall through */
+		fallthrough;
 	case INTEL_FAM6_ICELAKE_L:
 	case INTEL_FAM6_ICELAKE:
 	case INTEL_FAM6_TIGERLAKE_L:
arch/x86/events/intel/lbr.c +1 -1
index 65113b1..2e2c6fb 100644
@@ -967,7 +967,7 @@ static int branch_type(unsigned long from, unsigned long to, int abort)
 			ret = X86_BR_ZERO_CALL;
 			break;
 		}
-		/* fall through */
+		fallthrough;
 	case 0x9a: /* call far absolute */
 		ret = X86_BR_CALL;
 		break;
kernel/events/core.c +1 -2
index 6a47c3..7a8ed4d5 100644
@@ -9762,8 +9762,7 @@ perf_event_parse_addr_filter(struct perf_event *event, char *fstr,
 		case IF_SRC_KERNELADDR:
 		case IF_SRC_KERNEL:
 			kernel = 1;
-			/* fall through */
-
+			fallthrough;
 		case IF_SRC_FILEADDR:
 		case IF_SRC_FILE:
 			if (state != IF_STATE_SOURCE)
Signature · 1 line
2.24.0
maintainer Acked-by on v1 4/491
#12 lore raw

Re: [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough;

Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

The subject can use a little less screaming, but the actual patch is fine.

#13 lore raw

Re: [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough;

Quoted 10 lines · Peter Zijlstra
Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

The subject can use a little less screaming, but the actual patch is fine.

Patch subject come from the MAINTAINERS subsystem/section heading because I don't see a better way to script the patch subject that is more effective.

Using something like:

$ cat get_patch_subject_prefix.bash
#!/bin/bash
git log --format="%s" --no-merges -200 --since=2-years-ago $@ | \
  cut -f1 -d":" | \
  sort  | uniq -c | sort -rn | head -1 | \
  sed 's/^[[:space:]]*[[:digit:]]*[[:space:]]*//'
$

Does well for some sets of files, less well for others.

For instance:

$ ./get_patch_subject_prefix.bash drivers/net/ethernet/intel/
ice

which is just one of 10 or so subsystems of intel/...

And there's no way I'm going to individually edit ~500 patches for every specific maintainer's preference.

maintainer Acked-by on v1 4/491
#14 lore raw

Re: [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: Use fallthrough;

In reply to Joe Perches
Quoted 7 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
#15 lore raw

PATCH 5/491 ARM/UNIPHIER ARCHITECTURE: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/tty/serial/8250/8250_uniphier.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/tty/serial/8250/8250_uniphier.c +3 -3
index e0b73a5..a2978ab 100644
@@ -75,7 +75,7 @@ static unsigned int uniphier_serial_in(struct uart_port *p, int offset)
 		break;
 	case UART_LCR:
 		valshift = 8;
-		/* fall through */
+		fallthrough;
 	case UART_MCR:
 		offset = UNIPHIER_UART_LCR_MCR;
 		break;
@@ -101,7 +101,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
 	case UART_SCR:
 		/* No SCR for this hardware.  Use CHAR as a scratch register */
 		valshift = 8;
-		/* fall through */
+		fallthrough;
 	case UART_FCR:
 		offset = UNIPHIER_UART_CHAR_FCR;
 		break;
@@ -109,7 +109,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
 		valshift = 8;
 		/* Divisor latch access bit does not exist. */
 		value &= ~UART_LCR_DLAB;
-		/* fall through */
+		fallthrough;
 	case UART_MCR:
 		offset = UNIPHIER_UART_LCR_MCR;
 		break;
Signature · 1 line
2.24.0
Acked-by on v1 5/491
#16 lore raw

Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;

Quoted 7 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

But, I think the patch subject should be prefixed:
"serial: 8250_uniphier:"

Quoted 38 lines
---
 drivers/tty/serial/8250/8250_uniphier.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/tty/serial/8250/8250_uniphier.c +3 -4
index e0b73a5..a2978ab 100644
@@ -75,7 +75,7 @@ static unsigned int uniphier_serial_in(struct uart_port *p, int offset)
                break;
        case UART_LCR:
                valshift = 8;
-               /* fall through */
+               fallthrough;
        case UART_MCR:
                offset = UNIPHIER_UART_LCR_MCR;
                break;
@@ -101,7 +101,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
        case UART_SCR:
                /* No SCR for this hardware.  Use CHAR as a scratch register */
                valshift = 8;
-               /* fall through */
+               fallthrough;
        case UART_FCR:
                offset = UNIPHIER_UART_CHAR_FCR;
                break;
@@ -109,7 +109,7 @@ static void uniphier_serial_out(struct uart_port *p, int offset, int value)
                valshift = 8;
                /* Divisor latch access bit does not exist. */
                value &= ~UART_LCR_DLAB;
-               /* fall through */
+               fallthrough;
        case UART_MCR:
                offset = UNIPHIER_UART_LCR_MCR;
                break;
--

2.24.0

Signature · 7 lines
Best Regards
Masahiro Yamada

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#17 lore raw

Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;

Quoted 6 lines · Masahiro Yamada
Quoted 5 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 7 lines
Quoted 1 line

But, I think the patch subject should be prefixed:
"serial: 8250_uniphier:"

Yeah thanks, that's difficult to script though.

#18 lore raw

Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;

Quoted 9 lines · Joe Perches
Quoted 8 lines · Masahiro Yamada
Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 9 lines
Quoted 5 lines

But, I think the patch subject should be prefixed:
"serial: 8250_uniphier:"

Yeah thanks, that's difficult to script though.

Kernel development is hard :)

#19 lore raw

Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;

Quoted 14 lines · Greg Kroah-Hartman
Quoted 12 lines · Joe Perches
Quoted 11 lines · Masahiro Yamada
Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

But, I think the patch subject should be prefixed:
"serial: 8250_uniphier:"

Yeah thanks, that's difficult to script though.

Kernel development is hard :)

It is strange to process this per-platform and to send out a giant series that consists of 491 patches.

This is very trivial conversion.

I think it is better to have a single patch to convert all files under drivers/tty/serial/, with the patch subject "serial:".

Signature · 2 lines
Best Regards
Masahiro Yamada
#20 lore raw

Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;

Quoted 30 lines · Masahiro Yamada
Quoted 14 lines · Greg Kroah-Hartman
Quoted 12 lines · Joe Perches
Quoted 11 lines · Masahiro Yamada
Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

But, I think the patch subject should be prefixed:
"serial: 8250_uniphier:"

Yeah thanks, that's difficult to script though.

Kernel development is hard :)

It is strange to process this per-platform and to send out a giant series that consists of 491 patches.

Quoted 5 lines

This is very trivial conversion.

I think it is better to have a single patch to convert all files under drivers/tty/serial/, with the patch subject "serial:".

I agree.

#21 lore raw

Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;

In reply to Masahiro Yamada
Quoted 28 lines · Masahiro Yamada
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Joe Perches
Quoted 11 lines · Masahiro Yamada
Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

But, I think the patch subject should be prefixed:
"serial: 8250_uniphier:"

Yeah thanks, that's difficult to script though.

Kernel development is hard :)

It is strange to process this per-platform and to send out a giant series that consists of 491 patches.

Quoted 5 lines

This is very trivial conversion.

I think it is better to have a single patch to convert all files under drivers/tty/serial/, with the patch subject "serial:".

The difficulty there is determining where these subsystem spanning blocks should begin and end.

That could not be done for instance with drivers/net.

As I have suggested a few times, better still would be to have a mechanism for scripted patches applied possibly as single treewide patch.

Likely applied only at an -rc1.

The stated negatives to a treewide mechanism
have been difficulty to backport to -stable.

Perhaps a mechanism like

	git format-patch --stdout <treewide_commit_to_backport> | \
	git apply --include=<specific_files>

with some automated rewrite of the treewide patch subject then commit could help.

#22 lore raw

Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;

Quoted 8 lines · Joe Perches

As I have suggested a few times, better still would be to have a mechanism for scripted patches applied possibly as single treewide patch.

Likely applied only at an -rc1.

The stated negatives to a treewide mechanism have been difficulty to backport to -stable.

Any time we do a massive, disruptive change to the code base, it's going to cause problems to -stable. It means that bug fix patches won't necessarily auto-apply, and some will require manual fixups afterwards

Given that this change doesn't really fix any bugs, I'd have to ask the question --- is it *worth* it? We really need to apply a certain amount of cost/benefit analysis around this.

If it were really important, the thing we could do is to apply a single treewide patch at some point after the merge window. I'd suggest after -rc2, myself, but reasonable people can differ. And then, if it were *really* important we could run the same script on the stable kernels.

But for changing "/* fallthrough */" to "fallthrough;"

Does this ***really*** matter? Why are we tying ourselves up in knots trying to do this all at once?

- Ted

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#23 lore raw

Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;

Quoted 7 lines · Theodore Y. Ts'o
Quoted 6 lines · Joe Perches

As I have suggested a few times, better still would be to have a mechanism for scripted patches applied possibly as single treewide patch.

Likely applied only at an -rc1.

Quoted 7 lines
Quoted 2 lines

The stated negatives to a treewide mechanism have been difficulty to backport to -stable.

Any time we do a massive, disruptive change to the code base, it's going to cause problems to -stable. It means that bug fix patches won't necessarily auto-apply, and some will require manual fixups afterwards

That's mostly a tools problem than a real problem.

Quoted 10 lines

Given that this change doesn't really fix any bugs, I'd have to ask the question --- is it *worth* it? We really need to apply a certain amount of cost/benefit analysis around this.

If it were really important, the thing we could do is to apply a single treewide patch at some point after the merge window. I'd suggest after -rc2, myself, but reasonable people can differ. And then, if it were *really* important we could run the same script on the stable kernels.

Quoted 3 lines

But for changing "/* fallthrough */" to "fallthrough;"

Does this ***really*** matter?

That depends a bit on whether clang is your
compiler of choice.

Quoted 2 lines

Why are we tying ourselves up in knots
trying to do this all at once?

Discretely or treewide, all at once or done over time, the impact problem to backports is the same.

#24 lore raw

Re: [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: Use fallthrough;

In reply to Greg Kroah-Hartman
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Joe Perches
Quoted 11 lines · Masahiro Yamada
Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

But, I think the patch subject should be prefixed:
"serial: 8250_uniphier:"

Yeah thanks, that's difficult to script though.

Kernel development is hard :)

Not really, kernel development processes are pretty stupid sometimes.

#25 lore raw

PATCH 6/491 ARM/RISCPC ARCHITECTURE: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/arm/mach-rpc/riscpc.c |  2 +-
 drivers/scsi/arm/fas216.c  | 17 ++++++-----------
 2 files changed, 7 insertions(+), 12 deletions(-)
arch/arm/mach-rpc/riscpc.c +1 -1
index ea2c842..d23970b 100644
@@ -46,7 +46,7 @@ static int __init parse_tag_acorn(const struct tag *tag)
 	switch (tag->u.acorn.vram_pages) {
 	case 512:
 		vram_size += PAGE_SIZE * 256;
-		/* Fall through - ??? */
+		fallthrough;	/* ??? */
 	case 256:
 		vram_size += PAGE_SIZE * 256;
 	default:
drivers/scsi/arm/fas216.c +6 -11
index 6c68c230..bb18be 100644
@@ -603,8 +603,7 @@ static void fas216_handlesync(FAS216_Info *info, char *msg)
 		msgqueue_flush(&info->scsi.msgs);
 		msgqueue_addmsg(&info->scsi.msgs, 1, MESSAGE_REJECT);
 		info->scsi.phase = PHASE_MSGOUT_EXPECT;
-		/* fall through */
-
+		fallthrough;
 	case async:
 		dev->period = info->ifcfg.asyncperiod / 4;
 		dev->sof    = 0;
@@ -916,8 +915,7 @@ static void fas216_disconnect_intr(FAS216_Info *info)
 			fas216_done(info, DID_ABORT);
 			break;
 		}
-		/* else, fall through */
-
+		fallthrough;
 	default:				/* huh?					*/
 		printk(KERN_ERR "scsi%d.%c: unexpected disconnect in phase %s\n",
 			info->host->host_no, fas216_target(info), fas216_drv_phase(info));
@@ -1413,8 +1411,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne
 	case STATE(STAT_STATUS, PHASE_DATAOUT): /* Data Out     -> Status       */
 	case STATE(STAT_STATUS, PHASE_DATAIN):  /* Data In      -> Status       */
 		fas216_stoptransfer(info);
-		/* fall through */
-
+		fallthrough;
 	case STATE(STAT_STATUS, PHASE_SELSTEPS):/* Sel w/ steps -> Status       */
 	case STATE(STAT_STATUS, PHASE_MSGOUT):  /* Message Out  -> Status       */
 	case STATE(STAT_STATUS, PHASE_COMMAND): /* Command      -> Status       */
@@ -1426,8 +1423,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne
 	case STATE(STAT_MESGIN, PHASE_DATAOUT): /* Data Out     -> Message In   */
 	case STATE(STAT_MESGIN, PHASE_DATAIN):  /* Data In      -> Message In   */
 		fas216_stoptransfer(info);
-		/* fall through */
-
+		fallthrough;
 	case STATE(STAT_MESGIN, PHASE_COMMAND):	/* Command	-> Message In	*/
 	case STATE(STAT_MESGIN, PHASE_SELSTEPS):/* Sel w/ steps -> Message In   */
 	case STATE(STAT_MESGIN, PHASE_MSGOUT):  /* Message Out  -> Message In   */
@@ -1581,8 +1577,7 @@ static void fas216_funcdone_intr(FAS216_Info *info, unsigned int stat, unsigned
 			fas216_message(info);
 			break;
 		}
-		/* else, fall through */
-
+		fallthrough;
 	default:
 		fas216_log(info, 0, "internal phase %s for function done?"
 			"  What do I do with this?",
@@ -1964,7 +1959,7 @@ static void fas216_kick(FAS216_Info *info)
 	switch (where_from) {
 	case TYPE_QUEUE:
 		fas216_allocate_tag(info, SCpnt);
-		/* fall through */
+		fallthrough;
 	case TYPE_OTHER:
 		fas216_start_command(info, SCpnt);
 		break;
Signature · 1 line
2.24.0
#26 lore raw

Re: [PATCH -next 006/491] ARM/RISCPC ARCHITECTURE: Use fallthrough;

Quoted 1 line · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

And the point of what on the face of it seems to be useless churn is?

What compilers support this?

I'd check the gcc manual, but debian doesn't provide it.

Quoted 90 lines

Done via script

---
 arch/arm/mach-rpc/riscpc.c |  2 +-
 drivers/scsi/arm/fas216.c  | 17 ++++++-----------
 2 files changed, 7 insertions(+), 12 deletions(-)
arch/arm/mach-rpc/riscpc.c +1 -1
index ea2c842..d23970b 100644
@@ -46,7 +46,7 @@ static int __init parse_tag_acorn(const struct tag *tag)
 	switch (tag->u.acorn.vram_pages) {
 	case 512:
 		vram_size += PAGE_SIZE * 256;
-		/* Fall through - ??? */
+		fallthrough;	/* ??? */
 	case 256:
 		vram_size += PAGE_SIZE * 256;
 	default:
drivers/scsi/arm/fas216.c +6 -11
index 6c68c230..bb18be 100644
@@ -603,8 +603,7 @@ static void fas216_handlesync(FAS216_Info *info, char *msg)
 		msgqueue_flush(&info->scsi.msgs);
 		msgqueue_addmsg(&info->scsi.msgs, 1, MESSAGE_REJECT);
 		info->scsi.phase = PHASE_MSGOUT_EXPECT;
-		/* fall through */
-
+		fallthrough;
 	case async:
 		dev->period = info->ifcfg.asyncperiod / 4;
 		dev->sof    = 0;
@@ -916,8 +915,7 @@ static void fas216_disconnect_intr(FAS216_Info *info)
 			fas216_done(info, DID_ABORT);
 			break;
 		}
-		/* else, fall through */
-
+		fallthrough;
 	default:				/* huh?					*/
 		printk(KERN_ERR "scsi%d.%c: unexpected disconnect in phase %s\n",
 			info->host->host_no, fas216_target(info), fas216_drv_phase(info));
@@ -1413,8 +1411,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne
 	case STATE(STAT_STATUS, PHASE_DATAOUT): /* Data Out     -> Status       */
 	case STATE(STAT_STATUS, PHASE_DATAIN):  /* Data In      -> Status       */
 		fas216_stoptransfer(info);
-		/* fall through */
-
+		fallthrough;
 	case STATE(STAT_STATUS, PHASE_SELSTEPS):/* Sel w/ steps -> Status       */
 	case STATE(STAT_STATUS, PHASE_MSGOUT):  /* Message Out  -> Status       */
 	case STATE(STAT_STATUS, PHASE_COMMAND): /* Command      -> Status       */
@@ -1426,8 +1423,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne
 	case STATE(STAT_MESGIN, PHASE_DATAOUT): /* Data Out     -> Message In   */
 	case STATE(STAT_MESGIN, PHASE_DATAIN):  /* Data In      -> Message In   */
 		fas216_stoptransfer(info);
-		/* fall through */
-
+		fallthrough;
 	case STATE(STAT_MESGIN, PHASE_COMMAND):	/* Command	-> Message In	*/
 	case STATE(STAT_MESGIN, PHASE_SELSTEPS):/* Sel w/ steps -> Message In   */
 	case STATE(STAT_MESGIN, PHASE_MSGOUT):  /* Message Out  -> Message In   */
@@ -1581,8 +1577,7 @@ static void fas216_funcdone_intr(FAS216_Info *info, unsigned int stat, unsigned
 			fas216_message(info);
 			break;
 		}
-		/* else, fall through */
-
+		fallthrough;
 	default:
 		fas216_log(info, 0, "internal phase %s for function done?"
 			"  What do I do with this?",
@@ -1964,7 +1959,7 @@ static void fas216_kick(FAS216_Info *info)
 	switch (where_from) {
 	case TYPE_QUEUE:
 		fas216_allocate_tag(info, SCpnt);
-		/* fall through */
+		fallthrough;
 	case TYPE_OTHER:
 		fas216_start_command(info, SCpnt);
 		break;
Signature · 1 line
2.24.0
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
#27 lore raw

Re: [PATCH -next 006/491] ARM/RISCPC ARCHITECTURE: Use fallthrough;

Quoted 6 lines · Russell King - ARM Linux admin
Quoted 1 line · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

And the point of what on the face of it seems to be useless churn is?

What compilers support this?

gcc 7.1, clang 9

clang does not support the /* fallthrough */ comment styles.

clang does support the __attribute__((__fallthrough__)) and the c++17 [[fallthrough]] weirdness.

see:

commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use")

#28 lore raw

PATCH 7/491 KERNEL VIRTUAL MACHINE FOR ARM/ARM64 (KVM/arm, KVM/arm64): Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/arm64/kvm/handle_exit.c  |  2 +-
 arch/arm64/kvm/hyp/debug-sr.c | 60 +++++++++++++++++------------------
 virt/kvm/arm/hyp/vgic-v3-sr.c | 16 +++++-----
 3 files changed, 39 insertions(+), 39 deletions(-)
arch/arm64/kvm/handle_exit.c +1 -1
index aacfc5..b14d6a 100644
@@ -128,7 +128,7 @@ static int kvm_handle_guest_debug(struct kvm_vcpu *vcpu, struct kvm_run *run)
 	switch (ESR_ELx_EC(hsr)) {
 	case ESR_ELx_EC_WATCHPT_LOW:
 		run->debug.arch.far = vcpu->arch.fault.far_el2;
-		/* fall through */
+		fallthrough;
 	case ESR_ELx_EC_SOFTSTP_LOW:
 	case ESR_ELx_EC_BREAKPT_LOW:
 	case ESR_ELx_EC_BKPT32:
arch/arm64/kvm/hyp/debug-sr.c +30 -30

100 lines not on this page · raw message

virt/kvm/arm/hyp/vgic-v3-sr.c +8 -8
index ccf1fde..93331f2 100644
@@ -349,10 +349,10 @@ void __hyp_text __vgic_v3_save_aprs(struct kvm_vcpu *vcpu)
 	case 7:
 		cpu_if->vgic_ap0r[3] = __vgic_v3_read_ap0rn(3);
 		cpu_if->vgic_ap0r[2] = __vgic_v3_read_ap0rn(2);
-		/* Fall through */
+		fallthrough;
 	case 6:
 		cpu_if->vgic_ap0r[1] = __vgic_v3_read_ap0rn(1);
-		/* Fall through */
+		fallthrough;
 	default:
 		cpu_if->vgic_ap0r[0] = __vgic_v3_read_ap0rn(0);
 	}
@@ -361,10 +361,10 @@ void __hyp_text __vgic_v3_save_aprs(struct kvm_vcpu *vcpu)
 	case 7:
 		cpu_if->vgic_ap1r[3] = __vgic_v3_read_ap1rn(3);
 		cpu_if->vgic_ap1r[2] = __vgic_v3_read_ap1rn(2);
-		/* Fall through */
+		fallthrough;
 	case 6:
 		cpu_if->vgic_ap1r[1] = __vgic_v3_read_ap1rn(1);
-		/* Fall through */
+		fallthrough;
 	default:
 		cpu_if->vgic_ap1r[0] = __vgic_v3_read_ap1rn(0);
 	}
@@ -386,10 +386,10 @@ void __hyp_text __vgic_v3_restore_aprs(struct kvm_vcpu *vcpu)
 	case 7:
 		__vgic_v3_write_ap0rn(cpu_if->vgic_ap0r[3], 3);
 		__vgic_v3_write_ap0rn(cpu_if->vgic_ap0r[2], 2);
-		/* Fall through */
+		fallthrough;
 	case 6:
 		__vgic_v3_write_ap0rn(cpu_if->vgic_ap0r[1], 1);
-		/* Fall through */
+		fallthrough;
 	default:
 		__vgic_v3_write_ap0rn(cpu_if->vgic_ap0r[0], 0);
 	}
@@ -398,10 +398,10 @@ void __hyp_text __vgic_v3_restore_aprs(struct kvm_vcpu *vcpu)
 	case 7:
 		__vgic_v3_write_ap1rn(cpu_if->vgic_ap1r[3], 3);
 		__vgic_v3_write_ap1rn(cpu_if->vgic_ap1r[2], 2);
-		/* Fall through */
+		fallthrough;
 	case 6:
 		__vgic_v3_write_ap1rn(cpu_if->vgic_ap1r[1], 1);
-		/* Fall through */
+		fallthrough;
 	default:
 		__vgic_v3_write_ap1rn(cpu_if->vgic_ap1r[0], 0);
 	}
Signature · 6 lines
2.24.0

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
#29 lore raw

PATCH 8/491 ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/arm/mach-ep93xx/crunch.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/mach-ep93xx/crunch.c +1 -2
index 1c05c5b..f02e978 100644
@@ -49,8 +49,7 @@ static int crunch_do(struct notifier_block *self, unsigned long cmd, void *t)
 		 * FALLTHROUGH: Ensure we don't try to overwrite our newly
 		 * initialised state information on the first fault.
 		 */
-		/* Fall through */
-
+		fallthrough;
 	case THREAD_NOTIFY_EXIT:
 		crunch_task_release(thread);
 		break;
Signature · 1 line
2.24.0
#30 lore raw

Re: [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: Use fallthrough;

Hello Joe,

Quoted 4 lines · On Tue, 10 Mar 2020 21:51:22 -0700 Joe Perches <[email protected]> wrote:

Convert the various uses of fallthrough comments to fallthrough;

Done via script

I think the patch is OK, but the automatically-generated first commit message line has a room for improvement.

But, as I understood, it has chances to be re-sent as one patch for all files.

Quoted 19 lines
---
 arch/arm/mach-ep93xx/crunch.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/mach-ep93xx/crunch.c +1 -2
index 1c05c5b..f02e978 100644
@@ -49,8 +49,7 @@ static int crunch_do(struct notifier_block *self, unsigned long cmd, void *t)
 		 * FALLTHROUGH: Ensure we don't try to overwrite our newly
 		 * initialised state information on the first fault.
 		 */
-		/* Fall through */
-
+		fallthrough;
 	case THREAD_NOTIFY_EXIT:
 		crunch_task_release(thread);
 		break;
Signature · 1 line
Alexander Sverdlin.
#31 lore raw

PATCH 9/491 ARM/Amlogic Meson SoC support: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/mmc/host/meson-mx-sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/meson-mx-sdio.c +1 -1
index 8b038e..d35d81 100644
@@ -291,7 +291,7 @@ static void meson_mx_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 	switch (ios->power_mode) {
 	case MMC_POWER_OFF:
 		vdd = 0;
-		/* fall through */
+		fallthrough;
 	case MMC_POWER_UP:
 		if (!IS_ERR(mmc->supply.vmmc)) {
 			host->error = mmc_regulator_set_ocr(mmc,
Signature · 1 line
2.24.0
#32 lore raw

PATCH 10/491 ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/clk/samsung/clk-s3c2443.c | 2 +-
 drivers/i2c/busses/i2c-s3c2410.c  | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
drivers/clk/samsung/clk-s3c2443.c +1 -1
index 5f30fe7..c7aba1e 100644
@@ -387,7 +387,7 @@ void __init s3c2443_common_clk_init(struct device_node *np, unsigned long xti_f,
 				ARRAY_SIZE(s3c2450_gates));
 		samsung_clk_register_alias(ctx, s3c2450_aliases,
 				ARRAY_SIZE(s3c2450_aliases));
-		/* fall through - as s3c2450 extends the s3c2416 clocks */
+		fallthrough;	/* as s3c2450 extends the s3c2416 clocks */
 	case S3C2416:
 		samsung_clk_register_div(ctx, s3c2416_dividers,
 				ARRAY_SIZE(s3c2416_dividers));
drivers/i2c/busses/i2c-s3c2410.c +1 -2
index c98ef4c..dd1264 100644
@@ -435,8 +435,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
 		 * fall through to the write state, as we will need to
 		 * send a byte as well
 		 */
-		/* Fall through */
-
+		fallthrough;
 	case STATE_WRITE:
 		/*
 		 * we are writing data to the device... check for the
Signature · 1 line
2.24.0
maintainer Reviewed-by on v1 10/491
#34 lore raw

Re: [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: Use fallthrough;

In reply to Joe Perches

Quoting Joe Perches (2020-03-10 21:51:24)

Quoted 5 lines

Convert the various uses of fallthrough comments to fallthrough;

Done via script

This link doesn't work for me. It leads to a redirect for

https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/

Quoted 1 line
 drivers/clk/samsung/clk-s3c2443.c | 2 +-
#35 lore raw

Re: [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: Use fallthrough;

Quoted 7 lines · Stephen Boyd

Quoting Joe Perches (2020-03-10 21:51:24)

Quoted 5 lines

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 7 lines

This link doesn't work for me. It leads to a redirect for

https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/

Quoted 1 line
 drivers/clk/samsung/clk-s3c2443.c | 2 +-

I have changed the link to
https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/

and applied.

Signature · 2 lines
Thanks,
Sylwester
#36 lore raw

PATCH 11/491 ARM/QUALCOMM SUPPORT: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/media/platform/qcom/venus/vdec.c |  2 +-
 drivers/phy/qualcomm/phy-qcom-usb-hs.c   |  2 +-
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c |  4 ++--
 drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c |  2 +-
 drivers/rpmsg/qcom_glink_native.c        |  4 ++--
 drivers/soc/qcom/socinfo.c               | 16 ++++++++--------
 drivers/thermal/qcom/tsens-v0_1.c        |  8 ++++----
 drivers/thermal/qcom/tsens-v1.c          |  4 ++--
 8 files changed, 21 insertions(+), 21 deletions(-)
drivers/media/platform/qcom/venus/vdec.c +1 -1
index f34920..9e0451 100644
@@ -983,7 +983,7 @@ static int vdec_stop_capture(struct venus_inst *inst)
 	switch (inst->codec_state) {
 	case VENUS_DEC_STATE_DECODING:
 		ret = hfi_session_flush(inst, HFI_FLUSH_ALL);
-		/* fallthrough */
+		fallthrough;
 	case VENUS_DEC_STATE_DRAIN:
 		vdec_cancel_dst_buffers(inst);
 		inst->codec_state = VENUS_DEC_STATE_STOPPED;
drivers/phy/qualcomm/phy-qcom-usb-hs.c +1 -1
index 610542..327df1a 100644
@@ -53,7 +53,7 @@ static int qcom_usb_hs_phy_set_mode(struct phy *phy,
 		case PHY_MODE_USB_OTG:
 		case PHY_MODE_USB_HOST:
 			val |= ULPI_INT_IDGRD;
-			/* fall through */
+			fallthrough;
 		case PHY_MODE_USB_DEVICE:
 			val |= ULPI_INT_SESS_VALID;
 		default:
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +2 -2
index fe0be8..3b0ab0e 100644
@@ -793,13 +793,13 @@ static int pmic_gpio_populate(struct pmic_gpio_state *state,
 	switch (subtype) {
 	case PMIC_GPIO_SUBTYPE_GPIO_4CH:
 		pad->have_buffer = true;
-		/* Fall through */
+		fallthrough;
 	case PMIC_GPIO_SUBTYPE_GPIOC_4CH:
 		pad->num_sources = 4;
 		break;
 	case PMIC_GPIO_SUBTYPE_GPIO_8CH:
 		pad->have_buffer = true;
-		/* Fall through */
+		fallthrough;
 	case PMIC_GPIO_SUBTYPE_GPIOC_8CH:
 		pad->num_sources = 8;
 		break;
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c +1 -1
index 338a15..b5949f7 100644
@@ -346,7 +346,7 @@ static int pm8xxx_pin_config_set(struct pinctrl_dev *pctldev,
 				return -EINVAL;
 			}
 			pin->pull_up_strength = arg;
-			/* FALLTHROUGH */
+			fallthrough;
 		case PIN_CONFIG_BIAS_PULL_UP:
 			pin->bias = pin->pull_up_strength;
 			banks |= BIT(2);
drivers/rpmsg/qcom_glink_native.c +2 -2
index 1995f5b..f40312 100644
@@ -553,7 +553,7 @@ static void qcom_glink_receive_version(struct qcom_glink *glink,
 		break;
 	case GLINK_VERSION_1:
 		glink->features &= features;
-		/* FALLTHROUGH */
+		fallthrough;
 	default:
 		qcom_glink_send_version_ack(glink);
 		break;
@@ -584,7 +584,7 @@ static void qcom_glink_receive_version_ack(struct qcom_glink *glink,
 			break;
 
 		glink->features &= features;
-		/* FALLTHROUGH */
+		fallthrough;
 	default:
 		qcom_glink_send_version(glink);
 		break;
drivers/soc/qcom/socinfo.c +8 -8
index 7864b7..8ae5646 100644
@@ -325,7 +325,7 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
 		debugfs_create_x32("raw_device_number", 0400,
 				   qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.raw_device_num);
-		/* Fall through */
+		fallthrough;
 	case SOCINFO_VERSION(0, 11):
 	case SOCINFO_VERSION(0, 10):
 	case SOCINFO_VERSION(0, 9):
@@ -333,12 +333,12 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
 
 		debugfs_create_u32("foundry_id", 0400, qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.foundry_id);
-		/* Fall through */
+		fallthrough;
 	case SOCINFO_VERSION(0, 8):
 	case SOCINFO_VERSION(0, 7):
 		DEBUGFS_ADD(info, pmic_model);
 		DEBUGFS_ADD(info, pmic_die_rev);
-		/* Fall through */
+		fallthrough;
 	case SOCINFO_VERSION(0, 6):
 		qcom_socinfo->info.hw_plat_subtype =
 			__le32_to_cpu(info->hw_plat_subtype);
@@ -346,7 +346,7 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
 		debugfs_create_u32("hardware_platform_subtype", 0400,
 				   qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.hw_plat_subtype);
-		/* Fall through */
+		fallthrough;
 	case SOCINFO_VERSION(0, 5):
 		qcom_socinfo->info.accessory_chip =
 			__le32_to_cpu(info->accessory_chip);
@@ -354,27 +354,27 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
 		debugfs_create_u32("accessory_chip", 0400,
 				   qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.accessory_chip);
-		/* Fall through */
+		fallthrough;
 	case SOCINFO_VERSION(0, 4):
 		qcom_socinfo->info.plat_ver = __le32_to_cpu(info->plat_ver);
 
 		debugfs_create_u32("platform_version", 0400,
 				   qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.plat_ver);
-		/* Fall through */
+		fallthrough;
 	case SOCINFO_VERSION(0, 3):
 		qcom_socinfo->info.hw_plat = __le32_to_cpu(info->hw_plat);
 
 		debugfs_create_u32("hardware_platform", 0400,
 				   qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.hw_plat);
-		/* Fall through */
+		fallthrough;
 	case SOCINFO_VERSION(0, 2):
 		qcom_socinfo->info.raw_ver  = __le32_to_cpu(info->raw_ver);
 
 		debugfs_create_u32("raw_version", 0400, qcom_socinfo->dbg_root,
 				   &qcom_socinfo->info.raw_ver);
-		/* Fall through */
+		fallthrough;
 	case SOCINFO_VERSION(0, 1):
 		DEBUGFS_ADD(info, build_id);
 		break;
drivers/thermal/qcom/tsens-v0_1.c +4 -4
index 4b8dd6..893ce1 100644
@@ -163,7 +163,7 @@ static int calibrate_8916(struct tsens_priv *priv)
 		p2[4] = (qfprom_cdata[1] & MSM8916_S4_P2_MASK) >> MSM8916_S4_P2_SHIFT;
 		for (i = 0; i < priv->num_sensors; i++)
 			p2[i] = ((base1 + p2[i]) << 3);
-		/* Fall through */
+		fallthrough;
 	case ONE_PT_CALIB2:
 		base0 = (qfprom_cdata[0] & MSM8916_BASE0_MASK);
 		p1[0] = (qfprom_cdata[0] & MSM8916_S0_P1_MASK) >> MSM8916_S0_P1_SHIFT;
@@ -228,7 +228,7 @@ static int calibrate_8974(struct tsens_priv *priv)
 			p2[8] = (calib[5] & S8_P2_BKP_MASK) >> S8_P2_BKP_SHIFT;
 			p2[9] = (calib[5] & S9_P2_BKP_MASK) >> S9_P2_BKP_SHIFT;
 			p2[10] = (calib[5] & S10_P2_BKP_MASK) >> S10_P2_BKP_SHIFT;
-			/* Fall through */
+			fallthrough;
 		case ONE_PT_CALIB:
 		case ONE_PT_CALIB2:
 			base1 = bkp[0] & BASE1_MASK;
@@ -263,7 +263,7 @@ static int calibrate_8974(struct tsens_priv *priv)
 			p2[8] = (calib[4] & S8_P2_MASK) >> S8_P2_SHIFT;
 			p2[9] = (calib[4] & S9_P2_MASK) >> S9_P2_SHIFT;
 			p2[10] = (calib[4] & S10_P2_MASK) >> S10_P2_SHIFT;
-			/* Fall through */
+			fallthrough;
 		case ONE_PT_CALIB:
 		case ONE_PT_CALIB2:
 			base1 = calib[0] & BASE1_MASK;
@@ -293,7 +293,7 @@ static int calibrate_8974(struct tsens_priv *priv)
 			p2[i] <<= 2;
 			p2[i] |= BIT_APPEND;
 		}
-		/* Fall through */
+		fallthrough;
 	case ONE_PT_CALIB2:
 		for (i = 0; i < priv->num_sensors; i++) {
 			p1[i] += base1;
drivers/thermal/qcom/tsens-v1.c +2 -2
index bd2ddb..d096d3 100644
@@ -202,7 +202,7 @@ static int calibrate_v1(struct tsens_priv *priv)
 		p2[9] = (qfprom_cdata[3] & S9_P2_MASK) >> S9_P2_SHIFT;
 		for (i = 0; i < priv->num_sensors; i++)
 			p2[i] = ((base1 + p2[i]) << 2);
-		/* Fall through */
+		fallthrough;
 	case ONE_PT_CALIB2:
 		base0 = (qfprom_cdata[4] & BASE0_MASK) >> BASE0_SHIFT;
 		p1[0] = (qfprom_cdata[0] & S0_P1_MASK) >> S0_P1_SHIFT;
@@ -263,7 +263,7 @@ static int calibrate_8976(struct tsens_priv *priv)
 
 		for (i = 0; i < priv->num_sensors; i++)
 			p2[i] = ((base1 + p2[i]) << 2);
-		/* Fall through */
+		fallthrough;
 	case ONE_PT_CALIB2:
 		base0 = qfprom_cdata[0] & MSM8976_BASE0_MASK;
 		p1[0] = (qfprom_cdata[0] & MSM8976_S0_P1_MASK) >> MSM8976_S0_P1_SHIFT;
Signature · 1 line
2.24.0
Reviewed-by on v1 11/491
#37 lore raw

Re: [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: Use fallthrough;

Quoted 5 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 227 lines
---
 drivers/media/platform/qcom/venus/vdec.c |  2 +-
 drivers/phy/qualcomm/phy-qcom-usb-hs.c   |  2 +-
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c |  4 ++--
 drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c |  2 +-
 drivers/rpmsg/qcom_glink_native.c        |  4 ++--
 drivers/soc/qcom/socinfo.c               | 16 ++++++++--------
 drivers/thermal/qcom/tsens-v0_1.c        |  8 ++++----
 drivers/thermal/qcom/tsens-v1.c          |  4 ++--
 8 files changed, 21 insertions(+), 21 deletions(-)
drivers/media/platform/qcom/venus/vdec.c +1 -1
index f34920..9e0451 100644
@@ -983,7 +983,7 @@ static int vdec_stop_capture(struct venus_inst *inst)
        switch (inst->codec_state) {
        case VENUS_DEC_STATE_DECODING:
                ret = hfi_session_flush(inst, HFI_FLUSH_ALL);
-               /* fallthrough */
+               fallthrough;
        case VENUS_DEC_STATE_DRAIN:
                vdec_cancel_dst_buffers(inst);
                inst->codec_state = VENUS_DEC_STATE_STOPPED;
drivers/phy/qualcomm/phy-qcom-usb-hs.c +1 -1
index 610542..327df1a 100644
@@ -53,7 +53,7 @@ static int qcom_usb_hs_phy_set_mode(struct phy *phy,
                case PHY_MODE_USB_OTG:
                case PHY_MODE_USB_HOST:
                        val |= ULPI_INT_IDGRD;
-                       /* fall through */
+                       fallthrough;
                case PHY_MODE_USB_DEVICE:
                        val |= ULPI_INT_SESS_VALID;
                default:
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +2 -2
index fe0be8..3b0ab0e 100644
@@ -793,13 +793,13 @@ static int pmic_gpio_populate(struct pmic_gpio_state *state,
        switch (subtype) {
        case PMIC_GPIO_SUBTYPE_GPIO_4CH:
                pad->have_buffer = true;
-               /* Fall through */
+               fallthrough;
        case PMIC_GPIO_SUBTYPE_GPIOC_4CH:
                pad->num_sources = 4;
                break;
        case PMIC_GPIO_SUBTYPE_GPIO_8CH:
                pad->have_buffer = true;
-               /* Fall through */
+               fallthrough;
        case PMIC_GPIO_SUBTYPE_GPIOC_8CH:
                pad->num_sources = 8;
                break;
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c +1 -1
index 338a15..b5949f7 100644
@@ -346,7 +346,7 @@ static int pm8xxx_pin_config_set(struct pinctrl_dev *pctldev,
                                return -EINVAL;
                        }
                        pin->pull_up_strength = arg;
-                       /* FALLTHROUGH */
+                       fallthrough;
                case PIN_CONFIG_BIAS_PULL_UP:
                        pin->bias = pin->pull_up_strength;
                        banks |= BIT(2);
drivers/rpmsg/qcom_glink_native.c +2 -2
index 1995f5b..f40312 100644
@@ -553,7 +553,7 @@ static void qcom_glink_receive_version(struct qcom_glink *glink,
                break;
        case GLINK_VERSION_1:
                glink->features &= features;
-               /* FALLTHROUGH */
+               fallthrough;
        default:
                qcom_glink_send_version_ack(glink);
                break;
@@ -584,7 +584,7 @@ static void qcom_glink_receive_version_ack(struct qcom_glink *glink,
                        break;
 
                glink->features &= features;
-               /* FALLTHROUGH */
+               fallthrough;
        default:
                qcom_glink_send_version(glink);
                break;
drivers/soc/qcom/socinfo.c +8 -8
index 7864b7..8ae5646 100644
@@ -325,7 +325,7 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
                debugfs_create_x32("raw_device_number", 0400,
                                   qcom_socinfo->dbg_root,
                                   &qcom_socinfo->info.raw_device_num);
-               /* Fall through */
+               fallthrough;
        case SOCINFO_VERSION(0, 11):
        case SOCINFO_VERSION(0, 10):
        case SOCINFO_VERSION(0, 9):
@@ -333,12 +333,12 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
 
                debugfs_create_u32("foundry_id", 0400, qcom_socinfo->dbg_root,
                                   &qcom_socinfo->info.foundry_id);
-               /* Fall through */
+               fallthrough;
        case SOCINFO_VERSION(0, 8):
        case SOCINFO_VERSION(0, 7):
                DEBUGFS_ADD(info, pmic_model);
                DEBUGFS_ADD(info, pmic_die_rev);
-               /* Fall through */
+               fallthrough;
        case SOCINFO_VERSION(0, 6):
                qcom_socinfo->info.hw_plat_subtype =
                        __le32_to_cpu(info->hw_plat_subtype);
@@ -346,7 +346,7 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
                debugfs_create_u32("hardware_platform_subtype", 0400,
                                   qcom_socinfo->dbg_root,
                                   &qcom_socinfo->info.hw_plat_subtype);
-               /* Fall through */
+               fallthrough;
        case SOCINFO_VERSION(0, 5):
                qcom_socinfo->info.accessory_chip =
                        __le32_to_cpu(info->accessory_chip);
@@ -354,27 +354,27 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
                debugfs_create_u32("accessory_chip", 0400,
                                   qcom_socinfo->dbg_root,
                                   &qcom_socinfo->info.accessory_chip);
-               /* Fall through */
+               fallthrough;
        case SOCINFO_VERSION(0, 4):
                qcom_socinfo->info.plat_ver = __le32_to_cpu(info->plat_ver);
 
                debugfs_create_u32("platform_version", 0400,
                                   qcom_socinfo->dbg_root,
                                   &qcom_socinfo->info.plat_ver);
-               /* Fall through */
+               fallthrough;
        case SOCINFO_VERSION(0, 3):
                qcom_socinfo->info.hw_plat = __le32_to_cpu(info->hw_plat);
 
                debugfs_create_u32("hardware_platform", 0400,
                                   qcom_socinfo->dbg_root,
                                   &qcom_socinfo->info.hw_plat);
-               /* Fall through */
+               fallthrough;
        case SOCINFO_VERSION(0, 2):
                qcom_socinfo->info.raw_ver  = __le32_to_cpu(info->raw_ver);
 
                debugfs_create_u32("raw_version", 0400, qcom_socinfo->dbg_root,
                                   &qcom_socinfo->info.raw_ver);
-               /* Fall through */
+               fallthrough;
        case SOCINFO_VERSION(0, 1):
                DEBUGFS_ADD(info, build_id);
                break;
drivers/thermal/qcom/tsens-v0_1.c +4 -4
index 4b8dd6..893ce1 100644
@@ -163,7 +163,7 @@ static int calibrate_8916(struct tsens_priv *priv)
                p2[4] = (qfprom_cdata[1] & MSM8916_S4_P2_MASK) >> MSM8916_S4_P2_SHIFT;
                for (i = 0; i < priv->num_sensors; i++)
                        p2[i] = ((base1 + p2[i]) << 3);
-               /* Fall through */
+               fallthrough;
        case ONE_PT_CALIB2:
                base0 = (qfprom_cdata[0] & MSM8916_BASE0_MASK);
                p1[0] = (qfprom_cdata[0] & MSM8916_S0_P1_MASK) >> MSM8916_S0_P1_SHIFT;
@@ -228,7 +228,7 @@ static int calibrate_8974(struct tsens_priv *priv)
                        p2[8] = (calib[5] & S8_P2_BKP_MASK) >> S8_P2_BKP_SHIFT;
                        p2[9] = (calib[5] & S9_P2_BKP_MASK) >> S9_P2_BKP_SHIFT;
                        p2[10] = (calib[5] & S10_P2_BKP_MASK) >> S10_P2_BKP_SHIFT;
-                       /* Fall through */
+                       fallthrough;
                case ONE_PT_CALIB:
                case ONE_PT_CALIB2:
                        base1 = bkp[0] & BASE1_MASK;
@@ -263,7 +263,7 @@ static int calibrate_8974(struct tsens_priv *priv)
                        p2[8] = (calib[4] & S8_P2_MASK) >> S8_P2_SHIFT;
                        p2[9] = (calib[4] & S9_P2_MASK) >> S9_P2_SHIFT;
                        p2[10] = (calib[4] & S10_P2_MASK) >> S10_P2_SHIFT;
-                       /* Fall through */
+                       fallthrough;
                case ONE_PT_CALIB:
                case ONE_PT_CALIB2:
                        base1 = calib[0] & BASE1_MASK;
@@ -293,7 +293,7 @@ static int calibrate_8974(struct tsens_priv *priv)
                        p2[i] <<= 2;
                        p2[i] |= BIT_APPEND;
                }
-               /* Fall through */
+               fallthrough;
        case ONE_PT_CALIB2:
                for (i = 0; i < priv->num_sensors; i++) {
                        p1[i] += base1;
drivers/thermal/qcom/tsens-v1.c +2 -3
index bd2ddb..d096d3 100644
@@ -202,7 +202,7 @@ static int calibrate_v1(struct tsens_priv *priv)
                p2[9] = (qfprom_cdata[3] & S9_P2_MASK) >> S9_P2_SHIFT;
                for (i = 0; i < priv->num_sensors; i++)
                        p2[i] = ((base1 + p2[i]) << 2);
-               /* Fall through */
+               fallthrough;
        case ONE_PT_CALIB2:
                base0 = (qfprom_cdata[4] & BASE0_MASK) >> BASE0_SHIFT;
                p1[0] = (qfprom_cdata[0] & S0_P1_MASK) >> S0_P1_SHIFT;
@@ -263,7 +263,7 @@ static int calibrate_8976(struct tsens_priv *priv)
 
                for (i = 0; i < priv->num_sensors; i++)
                        p2[i] = ((base1 + p2[i]) << 2);
-               /* Fall through */
+               fallthrough;
        case ONE_PT_CALIB2:
                base0 = qfprom_cdata[0] & MSM8976_BASE0_MASK;
                p1[0] = (qfprom_cdata[0] & MSM8976_S0_P1_MASK) >> MSM8976_S0_P1_SHIFT;
--

2.24.0

#38 lore raw

Re: [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: Use fallthrough;

In reply to Joe Perches

[ Trimming recipients list ]

Quoted 1 line · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

What is the rationale for such a change? Portability to different tool-chains? Something else?

Quoted 2 lines

Done via script

Message-ID <b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com> not found

1 partial match found:

https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#39 lore raw

Re: [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: Use fallthrough;

Quoted 5 lines · Marc Gonzalez
Quoted 1 line · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

What is the rationale for such a change? Portability to different tool-chains? Something else?

Converting /* fallthrough */ style comments to the pseudo-keyword fallthrough allows clang 10 and higher to work at finding missing fallthroughs too.

Acked-by on v1 11/491
#40 lore raw

Re: [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: Use fallthrough;

In reply to Joe Perches

Hi,

Quoted 8 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/media/platform/qcom/venus/vdec.c |  2 +-

For the Venus bits:

Quoted 9 lines
 drivers/phy/qualcomm/phy-qcom-usb-hs.c   |  2 +-
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c |  4 ++--
 drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c |  2 +-
 drivers/rpmsg/qcom_glink_native.c        |  4 ++--
 drivers/soc/qcom/socinfo.c               | 16 ++++++++--------
 drivers/thermal/qcom/tsens-v0_1.c        |  8 ++++----
 drivers/thermal/qcom/tsens-v1.c          |  4 ++--
 8 files changed, 21 insertions(+), 21 deletions(-)
Signature · 2 lines
regards,
Stan
#41 lore raw

PATCH 12/491 ARM/ZTE ARCHITECTURE: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 sound/soc/zte/zx-i2s.c   | 4 ++--
 sound/soc/zte/zx-spdif.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
sound/soc/zte/zx-i2s.c +2 -2
index 568cde6..1c1a44 100644
@@ -294,7 +294,7 @@ static int zx_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
 			zx_i2s_rx_dma_en(zx_i2s->reg_base, true);
 		else
 			zx_i2s_tx_dma_en(zx_i2s->reg_base, true);
-	/* fall thru */
+		fallthrough;
 	case SNDRV_PCM_TRIGGER_RESUME:
 	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
 		if (capture)
@@ -308,7 +308,7 @@ static int zx_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
 			zx_i2s_rx_dma_en(zx_i2s->reg_base, false);
 		else
 			zx_i2s_tx_dma_en(zx_i2s->reg_base, false);
-	/* fall thru */
+		fallthrough;
 	case SNDRV_PCM_TRIGGER_SUSPEND:
 	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
 		if (capture)
sound/soc/zte/zx-spdif.c +1 -1
index a3a07c0..b4168bd 100644
@@ -218,7 +218,7 @@ static int zx_spdif_trigger(struct snd_pcm_substream *substream, int cmd,
 		val = readl_relaxed(zx_spdif->reg_base + ZX_FIFOCTRL);
 		val |= ZX_FIFOCTRL_TX_FIFO_RST;
 		writel_relaxed(val, zx_spdif->reg_base + ZX_FIFOCTRL);
-	/* fall thru */
+		fallthrough;
 	case SNDRV_PCM_TRIGGER_RESUME:
 	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
 		zx_spdif_cfg_tx(zx_spdif->reg_base, true);
Signature · 1 line
2.24.0
#42 lore raw

PATCH 13/491 INGENIC JZ47xx SoCs: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/gpu/drm/ingenic/ingenic-drm.c           | 2 +-
 drivers/mmc/host/jz4740_mmc.c                   | 6 ++----
 drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
 drivers/mtd/nand/raw/ingenic/jz4725b_bch.c      | 4 ++--
 drivers/mtd/nand/raw/ingenic/jz4780_bch.c       | 4 ++--
 sound/soc/codecs/jz4770.c                       | 2 +-
 6 files changed, 9 insertions(+), 11 deletions(-)
drivers/gpu/drm/ingenic/ingenic-drm.c +1 -1
index 9dfe7c..8eefe7 100644
@@ -305,7 +305,7 @@ static void ingenic_drm_crtc_update_ctrl(struct ingenic_drm *priv,
 	switch (finfo->format) {
 	case DRM_FORMAT_XRGB1555:
 		ctrl |= JZ_LCD_CTRL_RGB555;
-		/* fall-through */
+		fallthrough;
 	case DRM_FORMAT_RGB565:
 		ctrl |= JZ_LCD_CTRL_BPP_15_16;
 		break;
drivers/mmc/host/jz4740_mmc.c +2 -4
index fbae87..9026af6 100644
@@ -737,8 +737,7 @@ static irqreturn_t jz_mmc_irq_worker(int irq, void *devid)
 			break;
 
 		jz_mmc_prepare_data_transfer(host);
-		/* fall through */
-
+		fallthrough;
 	case JZ4740_MMC_STATE_TRANSFER_DATA:
 		if (host->use_dma) {
 			/* Use DMA if enabled.
@@ -772,8 +771,7 @@ static irqreturn_t jz_mmc_irq_worker(int irq, void *devid)
 			break;
 		}
 		jz4740_mmc_write_irq_reg(host, JZ_MMC_IRQ_DATA_TRAN_DONE);
-		/* fall through */
-
+		fallthrough;
 	case JZ4740_MMC_STATE_SEND_STOP:
 		if (!req->stop)
 			break;
drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c +1 -1
index 49afeb..935c49 100644
@@ -253,7 +253,7 @@ static int ingenic_nand_attach_chip(struct nand_chip *chip)
 		chip->ecc.hwctl = ingenic_nand_ecc_hwctl;
 		chip->ecc.calculate = ingenic_nand_ecc_calculate;
 		chip->ecc.correct = ingenic_nand_ecc_correct;
-		/* fall through */
+		fallthrough;
 	case NAND_ECC_SOFT:
 		dev_info(nfc->dev, "using %s (strength %d, size %d, bytes %d)\n",
 			 (nfc->ecc) ? "hardware ECC" : "software ECC",
drivers/mtd/nand/raw/ingenic/jz4725b_bch.c +2 -2
index 6c852ea..2d0e0a 100644
@@ -145,10 +145,10 @@ static void jz4725b_bch_read_parity(struct ingenic_ecc *bch, u8 *buf,
 	switch (size8) {
 	case 3:
 		dest8[2] = (val >> 16) & 0xff;
-		/* fall-through */
+		fallthrough;
 	case 2:
 		dest8[1] = (val >> 8) & 0xff;
-		/* fall-through */
+		fallthrough;
 	case 1:
 		dest8[0] = val & 0xff;
 		break;
drivers/mtd/nand/raw/ingenic/jz4780_bch.c +2 -2
index 079266a..d67dbf 100644
@@ -123,10 +123,10 @@ static void jz4780_bch_read_parity(struct ingenic_ecc *bch, void *buf,
 	switch (size8) {
 	case 3:
 		dest8[2] = (val >> 16) & 0xff;
-		/* fall through */
+		fallthrough;
 	case 2:
 		dest8[1] = (val >> 8) & 0xff;
-		/* fall through */
+		fallthrough;
 	case 1:
 		dest8[0] = val & 0xff;
 		break;
sound/soc/codecs/jz4770.c +1 -1
index e7cf2c..6e2a91 100644
@@ -202,7 +202,7 @@ static int jz4770_codec_set_bias_level(struct snd_soc_component *codec,
 				   REG_CR_VIC_SB_SLEEP, REG_CR_VIC_SB_SLEEP);
 		regmap_update_bits(regmap, JZ4770_CODEC_REG_CR_VIC,
 				   REG_CR_VIC_SB, REG_CR_VIC_SB);
-	/* fall-through */
+		fallthrough;
 	default:
 		break;
 	}
Signature · 6 lines
2.24.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer
#43 lore raw

Re: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough;

Hi Joe,

Joe Perches <[email protected]> wrote on Tue, 10 Mar 2020 21:51:27 -0700:

Quoted 6 lines

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 8 lines
---
 drivers/gpu/drm/ingenic/ingenic-drm.c           | 2 +-
 drivers/mmc/host/jz4740_mmc.c                   | 6 ++----
 drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
 drivers/mtd/nand/raw/ingenic/jz4725b_bch.c      | 4 ++--
 drivers/mtd/nand/raw/ingenic/jz4780_bch.c       | 4 ++--
 sound/soc/codecs/jz4770.c                       | 2 +-
 6 files changed, 9 insertions(+), 11 deletions(-)

I like very much the new way to advertise for fallthrough statements, but I am not willing to take any patch converting a single driver anymore. I had too many from Gustavo when these comments had to be inserted. I would really prefer a MTD-wide or a NAND-wide or at least a raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/).

Hope you'll understand!

Thanks,
Miquèl

#44 lore raw

Re: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough;

Quoted 20 lines · Miquel Raynal

Hi Joe,

Joe Perches <[email protected]> wrote on Tue, 10 Mar 2020 21:51:27 -0700:

Quoted 6 lines

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 8 lines
---
 drivers/gpu/drm/ingenic/ingenic-drm.c           | 2 +-
 drivers/mmc/host/jz4740_mmc.c                   | 6 ++----
 drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
 drivers/mtd/nand/raw/ingenic/jz4725b_bch.c      | 4 ++--
 drivers/mtd/nand/raw/ingenic/jz4780_bch.c       | 4 ++--
 sound/soc/codecs/jz4770.c                       | 2 +-
 6 files changed, 9 insertions(+), 11 deletions(-)
Quoted 7 lines

I like very much the new way to advertise for fallthrough statements, but I am not willing to take any patch converting a single driver anymore. I had too many from Gustavo when these comments had to be inserted. I would really prefer a MTD-wide or a NAND-wide or at least a raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/).

Hope you'll understand!

I fully agree (for mmc). One patch please.

Another option is to make a big fat tree wide patch and ask Linus if he want to pick up immediately after an rc1. That should cause less disturbance for everyone, no?

Kind regards
Uffe

maintainer
#45 lore raw

Re: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough;

Ulf Hansson <[email protected]> wrote on Wed, 11 Mar 2020 15:20:59 +0100:

Quoted 27 lines · Miquel Raynal
Quoted 26 lines

Hi Joe,

Joe Perches <[email protected]> wrote on Tue, 10 Mar 2020 21:51:27 -0700:

Quoted 6 lines

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 8 lines
---
 drivers/gpu/drm/ingenic/ingenic-drm.c           | 2 +-
 drivers/mmc/host/jz4740_mmc.c                   | 6 ++----
 drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
 drivers/mtd/nand/raw/ingenic/jz4725b_bch.c      | 4 ++--
 drivers/mtd/nand/raw/ingenic/jz4780_bch.c       | 4 ++--
 sound/soc/codecs/jz4770.c                       | 2 +-
 6 files changed, 9 insertions(+), 11 deletions(-)  

I like very much the new way to advertise for fallthrough statements, but I am not willing to take any patch converting a single driver anymore. I had too many from Gustavo when these comments had to be inserted. I would really prefer a MTD-wide or a NAND-wide or at least a raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/).

Quoted 7 lines
Quoted 1 line

Hope you'll understand!

I fully agree (for mmc). One patch please.

Another option is to make a big fat tree wide patch and ask Linus if he want to pick up immediately after an rc1. That should cause less disturbance for everyone, no?

Absolutely.

Miquèl

#46 lore raw

Re: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough;

In reply to Miquel Raynal
Quoted 19 lines · Miquel Raynal

Hi Joe,

Joe Perches <[email protected]> wrote on Tue, 10 Mar 2020 21:51:27 -0700:

Quoted 6 lines

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Quoted 8 lines
---
 drivers/gpu/drm/ingenic/ingenic-drm.c           | 2 +-
 drivers/mmc/host/jz4740_mmc.c                   | 6 ++----
 drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
 drivers/mtd/nand/raw/ingenic/jz4725b_bch.c      | 4 ++--
 drivers/mtd/nand/raw/ingenic/jz4780_bch.c       | 4 ++--
 sound/soc/codecs/jz4770.c                       | 2 +-
 6 files changed, 9 insertions(+), 11 deletions(-)
Quoted 5 lines

I like very much the new way to advertise for fallthrough statements, but I am not willing to take any patch converting a single driver anymore. I had too many from Gustavo when these comments had to be inserted. I would really prefer a MTD-wide or a NAND-wide or at least a raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/).

I understand completely.

This set was done to generate patches by
nominally maintained subsystems.

If you want something else:

The easiest thing for you to do would be to
run the cvt_fallthrough.pl script yourself.

$ cvt_fallthrough.pl drivers/mtd/nand/raw/

That would produce:

$ git diff --shortstat drivers/mtd/nand/raw
 9 files changed, 18 insertions(+), 24 deletions(-)

or

$ cvt_fallthrough.pl drivers/mtd/

which would produce:

$ git diff --shortstat drivers/mtd/
 22 files changed, 45 insertions(+), 60 deletions(-)

cheers, Joe

#47 lore raw

PATCH 14/491 DECSTATION PLATFORM SUPPORT: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/mips/dec/tc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/dec/tc.c +1 -1
index 732027c..dba583 100644
@@ -52,7 +52,7 @@ int __init tc_bus_get_info(struct tc_bus *tbus)
 	case MACH_DS5900:
 		tbus->ext_slot_base = 0x20000000;
 		tbus->ext_slot_size = 0x20000000;
-		/* fall through */
+		fallthrough;
 	case MACH_DS5000_1XX:
 		tbus->num_tcslots = 3;
 		break;
Signature · 1 line
2.24.0
maintainer Acked-by on v1 14/491
#48 lore raw

Re: [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: Use fallthrough;

Quoted 15 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/mips/dec/tc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/dec/tc.c +0 -0
index 732027c..dba583 100644

arch/mips/dec/tc.c int __init tc_bus_get_info(struct tc_bus *tbus) · line 58

Quoted 8 lines
arch/mips/dec/tc.c +1 -1
@@ -52,7 +52,7 @@ int __init tc_bus_get_info(struct tc_bus *tbus)
 	case MACH_DS5900:
 		tbus->ext_slot_base = 0x20000000;
 		tbus->ext_slot_size = 0x20000000;
-		/* fall through */
+		fallthrough;
 	case MACH_DS5000_1XX:
 		tbus->num_tcslots = 3;
 		break;

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
#49 lore raw

PATCH 15/491 KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/mips/kvm/emulate.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/mips/kvm/emulate.c +4 -4
index 754094..8c80333 100644
@@ -64,7 +64,7 @@ static int kvm_compute_return_epc(struct kvm_vcpu *vcpu, unsigned long instpc,
 		switch (insn.r_format.func) {
 		case jalr_op:
 			arch->gprs[insn.r_format.rd] = epc + 8;
-			/* Fall through */
+			fallthrough;
 		case jr_op:
 			nextpc = arch->gprs[insn.r_format.rs];
 			break;
@@ -140,7 +140,7 @@ static int kvm_compute_return_epc(struct kvm_vcpu *vcpu, unsigned long instpc,
 		/* These are unconditional and in j_format. */
 	case jal_op:
 		arch->gprs[31] = instpc + 8;
-		/* fall through */
+		fallthrough;
 	case j_op:
 		epc += 4;
 		epc >>= 28;
@@ -1724,14 +1724,14 @@ enum emulation_result kvm_mips_emulate_load(union mips_instruction inst,
 
 	case lhu_op:
 		vcpu->mmio_needed = 1;	/* unsigned */
-		/* fall through */
+		fallthrough;
 	case lh_op:
 		run->mmio.len = 2;
 		break;
 
 	case lbu_op:
 		vcpu->mmio_needed = 1;	/* unsigned */
-		/* fall through */
+		fallthrough;
 	case lb_op:
 		run->mmio.len = 1;
 		break;
Signature · 1 line
2.24.0
maintainer Acked-by on v1 15/491
#50 lore raw

Re: [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): Use fallthrough;

Quoted 10 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/mips/kvm/emulate.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
#51 lore raw

PATCH 16/491 KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/powerpc/kvm/book3s_32_mmu.c | 2 +-
 arch/powerpc/kvm/book3s_64_mmu.c | 2 +-
 arch/powerpc/kvm/book3s_pr.c     | 2 +-
 arch/powerpc/kvm/booke.c         | 6 +++---
 arch/powerpc/kvm/powerpc.c       | 1 -
 5 files changed, 6 insertions(+), 7 deletions(-)
arch/powerpc/kvm/book3s_32_mmu.c +1 -1
index f21e734..3fbd57 100644
@@ -234,7 +234,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
 				case 2:
 				case 6:
 					pte->may_write = true;
-					/* fall through */
+					fallthrough;
 				case 3:
 				case 5:
 				case 7:
arch/powerpc/kvm/book3s_64_mmu.c +1 -1
index 5991332..26b8b2 100644
@@ -311,7 +311,7 @@ static int kvmppc_mmu_book3s_64_xlate(struct kvm_vcpu *vcpu, gva_t eaddr,
 	case 2:
 	case 6:
 		gpte->may_write = true;
-		/* fall through */
+		fallthrough;
 	case 3:
 	case 5:
 	case 7:
arch/powerpc/kvm/book3s_pr.c +1 -1
index 729a0f..7db3695 100644
@@ -740,7 +740,7 @@ int kvmppc_handle_pagefault(struct kvm_run *run, struct kvm_vcpu *vcpu,
 		    (vcpu->arch.hflags & BOOK3S_HFLAG_SPLIT_HACK) &&
 		    ((pte.raddr & SPLIT_HACK_MASK) = SPLIT_HACK_OFFS))
 			pte.raddr &= ~SPLIT_HACK_MASK;
-		/* fall through */
+		fallthrough;
 	case MSR_IR:
 		vcpu->arch.mmu.esid_to_vsid(vcpu, eaddr >> SID_SHIFT, &vsid);
 
arch/powerpc/kvm/booke.c +3 -3
index 7b27604..be47815 100644
@@ -421,11 +421,11 @@ static int kvmppc_booke_irqprio_deliver(struct kvm_vcpu *vcpu,
 	case BOOKE_IRQPRIO_DATA_STORAGE:
 	case BOOKE_IRQPRIO_ALIGNMENT:
 		update_dear = true;
-		/* fall through */
+		fallthrough;
 	case BOOKE_IRQPRIO_INST_STORAGE:
 	case BOOKE_IRQPRIO_PROGRAM:
 		update_esr = true;
-		/* fall through */
+		fallthrough;
 	case BOOKE_IRQPRIO_ITLB_MISS:
 	case BOOKE_IRQPRIO_SYSCALL:
 	case BOOKE_IRQPRIO_FP_UNAVAIL:
@@ -459,7 +459,7 @@ static int kvmppc_booke_irqprio_deliver(struct kvm_vcpu *vcpu,
 	case BOOKE_IRQPRIO_DECREMENTER:
 	case BOOKE_IRQPRIO_FIT:
 		keep_irq = true;
-		/* fall through */
+		fallthrough;
 	case BOOKE_IRQPRIO_EXTERNAL:
 	case BOOKE_IRQPRIO_DBELL:
 		allowed = vcpu->arch.shared->msr & MSR_EE;
arch/powerpc/kvm/powerpc.c +0 -1
index 1af96fb5..c242a79 100644
@@ -525,7 +525,6 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
 		r = 1;
 		break;
 	case KVM_CAP_PPC_GUEST_DEBUG_SSTEP:
-		/* fall through */
 	case KVM_CAP_PPC_PAIRED_SINGLES:
 	case KVM_CAP_PPC_OSI:
 	case KVM_CAP_PPC_GET_PVINFO:
Signature · 1 line
2.24.0
Acked-by on v1 16/491
#52 lore raw

Re: [PATCH -next 016/491] KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): Use fallthrough;

Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

The subject line should look like "KVM: PPC: Use fallthrough".

Apart from that,

How are these patches going upstream? Do you want me to take this via my tree?

Paul.

#53 lore raw

Re: [PATCH -next 016/491] KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): Use fallthrough;

Quoted 9 lines · Paul Mackerras
Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

The subject line should look like "KVM: PPC: Use fallthrough".

There's no way to generate a subject line like that via a script so far as I can tell.

Quoted 6 lines

Apart from that,

How are these patches going upstream? Do you want me to take this via my tree?

If you want.

Ideally, these changes would go in treewide via a script run by Linus at an -rc1, but if the change is OK with you, it'd be fine to have you apply it now.

cheers, Joe

#54 lore raw

Re: [PATCH -next 016/491] KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): Use fallthrough;

Quoted 18 lines · Joe Perches
Quoted 9 lines · Paul Mackerras
Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

The subject line should look like "KVM: PPC: Use fallthrough".

There's no way to generate a subject line like that via a script so far as I can tell.

Quoted 4 lines

Apart from that,

Quoted 8 lines
Quoted 2 lines

How are these patches going upstream? Do you want me to take this via my tree?

If you want.

Ideally, these changes would go in treewide via a script run by Linus at an -rc1, but if the change is OK with you, it'd be fine to have you apply it now.

I have taken this patch in my kvm-ppc-next branch.

Thanks,
Paul.

#55 lore raw

PATCH 17/491 CELL BROADBAND ENGINE ARCHITECTURE: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/powerpc/platforms/cell/spufs/switch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/platforms/cell/spufs/switch.c +1 -1
index 5c3f5d0..d56b4e3 100644
@@ -177,7 +177,7 @@ static inline void save_mfc_cntl(struct spu_state *csa, struct spu *spu)
 		POLL_WHILE_FALSE((in_be64(&priv2->mfc_control_RW) &
 				  MFC_CNTL_SUSPEND_DMA_STATUS_MASK) ==
 				 MFC_CNTL_SUSPEND_COMPLETE);
-		/* fall through */
+		fallthrough;
 	case MFC_CNTL_SUSPEND_COMPLETE:
 		if (csa)
 			csa->priv2.mfc_control_RW =
Signature · 1 line
2.24.0
#57 lore raw

Re: [PATCH -next 017/491] CELL BROADBAND ENGINE ARCHITECTURE: Use fallthrough;

In reply to Joe Perches
Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/addf3727ad28bd159ae2da433b48daf2ffb339f7

cheers

#58 lore raw

PATCH 18/491 KERNEL VIRTUAL MACHINE for s390 (KVM/s390): Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/s390/kvm/gaccess.c   | 23 +++++++++++++----------
 arch/s390/kvm/interrupt.c |  2 +-
 arch/s390/kvm/kvm-s390.c  |  4 ++--
 arch/s390/mm/gmap.c       |  6 +++---
 4 files changed, 19 insertions(+), 16 deletions(-)
arch/s390/kvm/gaccess.c +13 -10
index 07d30f..47a67a 100644
@@ -505,7 +505,7 @@ static int trans_exc(struct kvm_vcpu *vcpu, int code, unsigned long gva,
 		switch (prot) {
 		case PROT_TYPE_IEP:
 			tec->b61 = 1;
-			/* FALL THROUGH */
+			fallthrough;
 		case PROT_TYPE_LA:
 			tec->b56 = 1;
 			break;
@@ -514,12 +514,12 @@ static int trans_exc(struct kvm_vcpu *vcpu, int code, unsigned long gva,
 			break;
 		case PROT_TYPE_ALC:
 			tec->b60 = 1;
-			/* FALL THROUGH */
+			fallthrough;
 		case PROT_TYPE_DAT:
 			tec->b61 = 1;
 			break;
 		}
-		/* FALL THROUGH */
+		fallthrough;
 	case PGM_ASCE_TYPE:
 	case PGM_PAGE_TRANSLATION:
 	case PGM_REGION_FIRST_TRANS:
@@ -534,7 +534,7 @@ static int trans_exc(struct kvm_vcpu *vcpu, int code, unsigned long gva,
 		tec->addr = gva >> PAGE_SHIFT;
 		tec->fsi = mode == GACC_STORE ? FSI_STORE : FSI_FETCH;
 		tec->as = psw_bits(vcpu->arch.sie_block->gpsw).as;
-		/* FALL THROUGH */
+		fallthrough;
 	case PGM_ALEN_TRANSLATION:
 	case PGM_ALE_SEQUENCE:
 	case PGM_ASTE_VALIDITY:
@@ -677,7 +677,7 @@ static unsigned long guest_translate(struct kvm_vcpu *vcpu, unsigned long gva,
 			dat_protection |= rfte.p;
 		ptr = rfte.rto * PAGE_SIZE + vaddr.rsx * 8;
 	}
-		/* fallthrough */
+		fallthrough;
 	case ASCE_TYPE_REGION2: {
 		union region2_table_entry rste;
 
@@ -695,7 +695,7 @@ static unsigned long guest_translate(struct kvm_vcpu *vcpu, unsigned long gva,
 			dat_protection |= rste.p;
 		ptr = rste.rto * PAGE_SIZE + vaddr.rtx * 8;
 	}
-		/* fallthrough */
+		fallthrough;
 	case ASCE_TYPE_REGION3: {
 		union region3_table_entry rtte;
 
@@ -723,7 +723,7 @@ static unsigned long guest_translate(struct kvm_vcpu *vcpu, unsigned long gva,
 			dat_protection |= rtte.fc0.p;
 		ptr = rtte.fc0.sto * PAGE_SIZE + vaddr.sx * 8;
 	}
-		/* fallthrough */
+		fallthrough;
 	case ASCE_TYPE_SEGMENT: {
 		union segment_table_entry ste;
 
@@ -1050,7 +1050,8 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr,
 		rc = gmap_shadow_r2t(sg, saddr, rfte.val, *fake);
 		if (rc)
 			return rc;
-	} /* fallthrough */
+	}
+		fallthrough;
 	case ASCE_TYPE_REGION2: {
 		union region2_table_entry rste;
 
@@ -1076,7 +1077,8 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr,
 		rc = gmap_shadow_r3t(sg, saddr, rste.val, *fake);
 		if (rc)
 			return rc;
-	} /* fallthrough */
+	}
+		fallthrough;
 	case ASCE_TYPE_REGION3: {
 		union region3_table_entry rtte;
 
@@ -1111,7 +1113,8 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr,
 		rc = gmap_shadow_sgt(sg, saddr, rtte.val, *fake);
 		if (rc)
 			return rc;
-	} /* fallthrough */
+	}
+		fallthrough;
 	case ASCE_TYPE_SEGMENT: {
 		union segment_table_entry ste;
 
arch/s390/kvm/interrupt.c +1 -1
index 028167d6..819110 100644
@@ -886,7 +886,7 @@ static int __must_check __deliver_prog(struct kvm_vcpu *vcpu)
 	case PGM_PRIMARY_AUTHORITY:
 	case PGM_SECONDARY_AUTHORITY:
 		nullifying = true;
-		/* fall through */
+		fallthrough;
 	case PGM_SPACE_SWITCH:
 		rc = put_guest_lc(vcpu, pgm_info.trans_exc_code,
 				  (u64 *)__LC_TRANS_EXC_CODE);
arch/s390/kvm/kvm-s390.c +2 -2
index 6b1842a..d590f3 100644
@@ -3752,7 +3752,7 @@ int kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu,
 		rc = kvm_s390_pv_set_cpu_state(vcpu, PV_CPU_STATE_OPR_LOAD);
 		break;
 	case KVM_MP_STATE_CHECK_STOP:
-		/* fall through - CHECK_STOP and LOAD are not supported yet */
+		fallthrough;	/* CHECK_STOP and LOAD are not supported yet */
 	default:
 		rc = -ENXIO;
 	}
@@ -4985,7 +4985,7 @@ void kvm_arch_commit_memory_region(struct kvm *kvm,
 					old->npages * PAGE_SIZE);
 		if (rc)
 			break;
-		/* FALLTHROUGH */
+		fallthrough;
 	case KVM_MR_CREATE:
 		rc = gmap_map_segment(kvm->arch.gmap, mem->userspace_addr,
 				      mem->guest_phys_addr, mem->memory_size);
arch/s390/mm/gmap.c +3 -3
index 27926a0..03c899 100644
@@ -804,7 +804,7 @@ static inline unsigned long *gmap_table_walk(struct gmap *gmap,
 		if (*table & _REGION_ENTRY_INVALID)
 			return NULL;
 		table = (unsigned long *)(*table & _REGION_ENTRY_ORIGIN);
-		/* Fallthrough */
+		fallthrough;
 	case _ASCE_TYPE_REGION2:
 		table += (gaddr & _REGION2_INDEX) >> _REGION2_SHIFT;
 		if (level == 3)
@@ -812,7 +812,7 @@ static inline unsigned long *gmap_table_walk(struct gmap *gmap,
 		if (*table & _REGION_ENTRY_INVALID)
 			return NULL;
 		table = (unsigned long *)(*table & _REGION_ENTRY_ORIGIN);
-		/* Fallthrough */
+		fallthrough;
 	case _ASCE_TYPE_REGION3:
 		table += (gaddr & _REGION3_INDEX) >> _REGION3_SHIFT;
 		if (level == 2)
@@ -820,7 +820,7 @@ static inline unsigned long *gmap_table_walk(struct gmap *gmap,
 		if (*table & _REGION_ENTRY_INVALID)
 			return NULL;
 		table = (unsigned long *)(*table & _REGION_ENTRY_ORIGIN);
-		/* Fallthrough */
+		fallthrough;
 	case _ASCE_TYPE_SEGMENT:
 		table += (gaddr & _SEGMENT_INDEX) >> _SEGMENT_SHIFT;
 		if (level == 1)
Signature · 1 line
2.24.0
#59 lore raw

Re: [PATCH -next 018/491] KERNEL VIRTUAL MACHINE for s390 (KVM/s390): Use fallthrough;

Quoted 4 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

That link does not work. lore asks if this is the right one
https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/

Shall I fix that up when applying?

#60 lore raw

Re: [PATCH -next 018/491] KERNEL VIRTUAL MACHINE for s390 (KVM/s390): Use fallthrough;

In reply to Joe Perches
Quoted 4 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

I have applied this with a fixed link.

Quoted 8 lines
---
 arch/s390/kvm/gaccess.c   | 23 +++++++++++++----------
 arch/s390/kvm/interrupt.c |  2 +-
 arch/s390/kvm/kvm-s390.c  |  4 ++--
 arch/s390/mm/gmap.c       |  6 +++---
 4 files changed, 19 insertions(+), 16 deletions(-)

[...]

#61 lore raw

PATCH 19/491 Hyper-V CORE AND DRIVERS: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/hv/hv_kvp.c             | 4 +---
 drivers/hv/vmbus_drv.c          | 2 +-
 drivers/video/fbdev/hyperv_fb.c | 4 ++--
 3 files changed, 4 insertions(+), 6 deletions(-)
drivers/hv/hv_kvp.c +1 -3
index e74b144..da4686 100644
@@ -353,9 +353,7 @@ static void process_ib_ipinfo(void *in_msg, void *out_msg, int op)
 				MAX_IP_ADDR_SIZE);
 
 		out->body.kvp_ip_val.dhcp_enabled = in->kvp_ip_val.dhcp_enabled;
-
-		/* fallthrough */
-
+		fallthrough;
 	case KVP_OP_GET_IP_INFO:
 		utf16s_to_utf8s((wchar_t *)in->kvp_ip_val.adapter_id,
 				MAX_ADAPTER_ID_SIZE,
drivers/hv/vmbus_drv.c +1 -1
index 029378..0befc0 100644
@@ -1188,7 +1188,7 @@ static void vmbus_chan_sched(struct hv_per_cpu_context *hv_cpu)
 
 			case HV_CALL_BATCHED:
 				hv_begin_read(&channel->inbound);
-				/* fallthrough */
+				fallthrough;
 			case HV_CALL_DIRECT:
 				tasklet_schedule(&channel->callback_event);
 			}
drivers/video/fbdev/hyperv_fb.c +2 -2
index e4c3c8b..02411d 100644
@@ -648,13 +648,13 @@ static int synthvid_connect_vsp(struct hv_device *hdev)
 		ret = synthvid_negotiate_ver(hdev, SYNTHVID_VERSION_WIN10);
 		if (!ret)
 			break;
-		/* Fallthrough */
+		fallthrough;
 	case VERSION_WIN8:
 	case VERSION_WIN8_1:
 		ret = synthvid_negotiate_ver(hdev, SYNTHVID_VERSION_WIN8);
 		if (!ret)
 			break;
-		/* Fallthrough */
+		fallthrough;
 	case VERSION_WS2008:
 	case VERSION_WIN7:
 		ret = synthvid_negotiate_ver(hdev, SYNTHVID_VERSION_WIN7);
Signature · 1 line
2.24.0
#63 lore raw

PATCH 20/491 XEN HYPERVISOR INTERFACE: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/block/xen-blkfront.c               | 5 ++---
 drivers/net/xen-netfront.c                 | 2 +-
 drivers/pci/xen-pcifront.c                 | 2 +-
 drivers/scsi/xen-scsifront.c               | 2 +-
 drivers/xen/pvcalls-front.c                | 2 +-
 drivers/xen/xen-acpi-memhotplug.c          | 2 +-
 drivers/xen/xen-pciback/xenbus.c           | 2 +-
 drivers/xen/xen-scsiback.c                 | 2 +-
 drivers/xen/xenbus/xenbus_probe_frontend.c | 6 ++----
 9 files changed, 11 insertions(+), 14 deletions(-)
drivers/block/xen-blkfront.c +2 -3
index 9df516..fb07ee1 100644
@@ -1402,7 +1402,6 @@ static enum blk_req_status blkif_rsp_to_req_status(int rsp)
 	case BLKIF_RSP_EOPNOTSUPP:
 		return REQ_EOPNOTSUPP;
 	case BLKIF_RSP_ERROR:
-		/* Fallthrough. */
 	default:
 		return REQ_ERROR;
 	}
@@ -1642,7 +1641,7 @@ static irqreturn_t blkif_interrupt(int irq, void *dev_id)
 				info->feature_flush = 0;
 				xlvbd_flush(info);
 			}
-			/* fall through */
+			fallthrough;
 		case BLKIF_OP_READ:
 		case BLKIF_OP_WRITE:
 			if (unlikely(bret->status != BLKIF_RSP_OKAY))
@@ -2480,7 +2479,7 @@ static void blkback_changed(struct xenbus_device *dev,
 	case XenbusStateClosed:
 		if (dev->state == XenbusStateClosed)
 			break;
-		/* fall through */
+		fallthrough;
 	case XenbusStateClosing:
 		if (info)
 			blkfront_closing(info);
drivers/net/xen-netfront.c +1 -1
index 482c6c..2001606 100644
@@ -2038,7 +2038,7 @@ static void netback_changed(struct xenbus_device *dev,
 	case XenbusStateClosed:
 		if (dev->state == XenbusStateClosed)
 			break;
-		/* Fall through - Missed the backend's CLOSING state. */
+		fallthrough;	/* Missed the backend's CLOSING state */
 	case XenbusStateClosing:
 		xenbus_frontend_closed(dev);
 		break;
drivers/pci/xen-pcifront.c +1 -1
index d1b16c..093ab8 100644
@@ -1103,7 +1103,7 @@ static void __ref pcifront_backend_changed(struct xenbus_device *xdev,
 	case XenbusStateClosed:
 		if (xdev->state == XenbusStateClosed)
 			break;
-		/* fall through - Missed the backend's CLOSING state. */
+		fallthrough;	/* Missed the backend's CLOSING state */
 	case XenbusStateClosing:
 		dev_warn(&xdev->dev, "backend going away!\n");
 		pcifront_try_disconnect(pdev);
drivers/scsi/xen-scsifront.c +1 -1
index f0068e..259fc248 100644
@@ -1111,7 +1111,7 @@ static void scsifront_backend_changed(struct xenbus_device *dev,
 	case XenbusStateClosed:
 		if (dev->state == XenbusStateClosed)
 			break;
-		/* fall through - Missed the backend's Closing state */
+		fallthrough;	/* Missed the backend's Closing state */
 	case XenbusStateClosing:
 		scsifront_disconnect(info);
 		break;
drivers/xen/pvcalls-front.c +1 -1
index 57592a6..0fccf0 100644
@@ -1260,7 +1260,7 @@ static void pvcalls_front_changed(struct xenbus_device *dev,
 		if (dev->state == XenbusStateClosed)
 			break;
 		/* Missed the backend's CLOSING state */
-		/* fall through */
+		fallthrough;
 	case XenbusStateClosing:
 		xenbus_frontend_closed(dev);
 		break;
drivers/xen/xen-acpi-memhotplug.c +1 -1
index 745721..f914b72 100644
@@ -229,7 +229,7 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
 	case ACPI_NOTIFY_BUS_CHECK:
 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
 			"\nReceived BUS CHECK notification for device\n"));
-		/* Fall Through */
+		fallthrough;
 	case ACPI_NOTIFY_DEVICE_CHECK:
 		if (event == ACPI_NOTIFY_DEVICE_CHECK)
 			ACPI_DEBUG_PRINT((ACPI_DB_INFO,
drivers/xen/xen-pciback/xenbus.c +1 -1
index 833b2d..a108740 100644
@@ -544,7 +544,7 @@ static void xen_pcibk_frontend_changed(struct xenbus_device *xdev,
 		xenbus_switch_state(xdev, XenbusStateClosed);
 		if (xenbus_dev_is_online(xdev))
 			break;
-		/* fall through - if not online */
+		fallthrough;	/* if not online */
 	case XenbusStateUnknown:
 		dev_dbg(&xdev->dev, "frontend is gone! unregister device\n");
 		device_unregister(&xdev->dev);
drivers/xen/xen-scsiback.c +1 -1
index ba0942e..9daef2 100644
@@ -1184,7 +1184,7 @@ static void scsiback_frontend_changed(struct xenbus_device *dev,
 		xenbus_switch_state(dev, XenbusStateClosed);
 		if (xenbus_dev_is_online(dev))
 			break;
-		/* fall through - if not online */
+		fallthrough;	/* if not online */
 	case XenbusStateUnknown:
 		device_unregister(&dev->dev);
 		break;
drivers/xen/xenbus/xenbus_probe_frontend.c +2 -4
index 8a1650..708917 100644
@@ -402,13 +402,11 @@ static void xenbus_reset_frontend(char *fe, char *be, int be_state)
 	case XenbusStateConnected:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateClosing);
 		xenbus_reset_wait_for_backend(be, XenbusStateClosing);
-		/* fall through */
-
+		fallthrough;
 	case XenbusStateClosing:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateClosed);
 		xenbus_reset_wait_for_backend(be, XenbusStateClosed);
-		/* fall through */
-
+		fallthrough;
 	case XenbusStateClosed:
 		xenbus_printf(XBT_NIL, fe, "state", "%d", XenbusStateInitialising);
 		xenbus_reset_wait_for_backend(be, XenbusStateInitWait);
Signature · 1 line
2.24.0
#65 lore raw

PATCH 21/491 KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86): Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/x86/kvm/emulate.c  |  2 +-
 arch/x86/kvm/hyperv.c   |  2 +-
 arch/x86/kvm/irq_comm.c |  2 +-
 arch/x86/kvm/lapic.c    |  6 +++---
 arch/x86/kvm/mmu/mmu.c  |  2 +-
 arch/x86/kvm/svm.c      |  2 +-
 arch/x86/kvm/vmx/vmx.c  | 15 +++++++--------
 arch/x86/kvm/x86.c      | 12 ++++--------
 8 files changed, 19 insertions(+), 24 deletions(-)
arch/x86/kvm/emulate.c +1 -1
index bc00642..bae4d8 100644
@@ -3025,7 +3025,7 @@ static void string_registers_quirk(struct x86_emulate_ctxt *ctxt)
 	case 0xa4:	/* movsb */
 	case 0xa5:	/* movsd/w */
 		*reg_rmw(ctxt, VCPU_REGS_RSI) &= (u32)-1;
-		/* fall through */
+		fallthrough;
 	case 0xaa:	/* stosb */
 	case 0xab:	/* stosd/w */
 		*reg_rmw(ctxt, VCPU_REGS_RDI) &= (u32)-1;
arch/x86/kvm/hyperv.c +1 -1
index a86fda7..934bfb4 100644
@@ -1652,7 +1652,7 @@ int kvm_hv_hypercall(struct kvm_vcpu *vcpu)
 		ret = kvm_hvcall_signal_event(vcpu, fast, ingpa);
 		if (ret != HV_STATUS_INVALID_PORT_ID)
 			break;
-		/* fall through - maybe userspace knows this conn_id. */
+		fallthrough;	/* maybe userspace knows this conn_id */
 	case HVCALL_POST_MESSAGE:
 		/* don't bother userspace if it has no way to handle it */
 		if (unlikely(rep || !vcpu_to_synic(vcpu)->active)) {
arch/x86/kvm/irq_comm.c +1 -1
index c47d2a..4aa1c2e 100644
@@ -285,7 +285,7 @@ int kvm_set_routing_entry(struct kvm *kvm,
 		switch (ue->u.irqchip.irqchip) {
 		case KVM_IRQCHIP_PIC_SLAVE:
 			e->irqchip.pin += PIC_NUM_PINS / 2;
-			/* fall through */
+			fallthrough;
 		case KVM_IRQCHIP_PIC_MASTER:
 			if (ue->u.irqchip.pin >= PIC_NUM_PINS / 2)
 				return -EINVAL;
arch/x86/kvm/lapic.c +3 -3
index e3099c..64b7a9c 100644
@@ -1023,7 +1023,7 @@ static int __apic_accept_irq(struct kvm_lapic *apic, int delivery_mode,
 	switch (delivery_mode) {
 	case APIC_DM_LOWEST:
 		vcpu->arch.apic_arb_prio++;
-		/* fall through */
+		fallthrough;
 	case APIC_DM_FIXED:
 		if (unlikely(trig_mode && !level))
 			break;
@@ -1311,7 +1311,7 @@ static u32 __apic_read(struct kvm_lapic *apic, unsigned int offset)
 		break;
 	case APIC_TASKPRI:
 		report_tpr_access(apic, false);
-		/* fall thru */
+		fallthrough;
 	default:
 		val = kvm_lapic_get_reg(apic, offset);
 		break;
@@ -1952,7 +1952,7 @@ int kvm_lapic_reg_write(struct kvm_lapic *apic, u32 reg, u32 val)
 
 	case APIC_LVT0:
 		apic_manage_nmi_watchdog(apic, val);
-		/* fall through */
+		fallthrough;
 	case APIC_LVTTHMR:
 	case APIC_LVTPC:
 	case APIC_LVT1:
arch/x86/kvm/mmu/mmu.c +1 -1
index 87e9ba..8593cd 100644
@@ -4475,7 +4475,7 @@ __reset_rsvds_bits_mask(struct kvm_vcpu *vcpu,
 			rsvd_bits(maxphyaddr, 51);
 		rsvd_check->rsvd_bits_mask[1][4] =
 			rsvd_check->rsvd_bits_mask[0][4];
-		/* fall through */
+		fallthrough;
 	case PT64_ROOT_4LEVEL:
 		rsvd_check->rsvd_bits_mask[0][3] = exb_bit_rsvd |
 			nonleaf_bit8_rsvd | rsvd_bits(7, 7) |
arch/x86/kvm/svm.c +1 -1
index 910005..73fa903 100644
@@ -4449,7 +4449,7 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr)
 	case MSR_IA32_APICBASE:
 		if (kvm_vcpu_apicv_active(vcpu))
 			avic_update_vapic_bar(to_svm(vcpu), data);
-		/* Fall through */
+		fallthrough;
 	default:
 		return kvm_set_msr_common(vcpu, msr);
 	}
arch/x86/kvm/vmx/vmx.c +7 -8
index 69c5bd..1577cd 100644
@@ -4538,12 +4538,12 @@ static bool rmode_exception(struct kvm_vcpu *vcpu, int vec)
 			vmcs_read32(VM_EXIT_INSTRUCTION_LEN);
 		if (vcpu->guest_debug & KVM_GUESTDBG_USE_SW_BP)
 			return false;
-		/* fall through */
+		fallthrough;
 	case DB_VECTOR:
 		if (vcpu->guest_debug &
 			(KVM_GUESTDBG_SINGLESTEP | KVM_GUESTDBG_USE_HW_BP))
 			return false;
-		/* fall through */
+		fallthrough;
 	case DE_VECTOR:
 	case OF_VECTOR:
 	case BR_VECTOR:
@@ -4692,7 +4692,7 @@ static int handle_exception_nmi(struct kvm_vcpu *vcpu)
 		}
 		kvm_run->debug.arch.dr6 = dr6 | DR6_FIXED_1;
 		kvm_run->debug.arch.dr7 = vmcs_readl(GUEST_DR7);
-		/* fall through */
+		fallthrough;
 	case BP_VECTOR:
 		/*
 		 * Update instruction length as we may reinject #BP from
@@ -5119,7 +5119,7 @@ static int handle_task_switch(struct kvm_vcpu *vcpu)
 				error_code =
 					vmcs_read32(IDT_VECTORING_ERROR_CODE);
 			}
-			/* fall through */
+			fallthrough;
 		case INTR_TYPE_SOFT_EXCEPTION:
 			kvm_clear_exception_queue(vcpu);
 			break;
@@ -5469,8 +5469,7 @@ static int handle_invpcid(struct kvm_vcpu *vcpu)
 		 * global flush. If needed, we could optimize this later by
 		 * keeping track of global entries in shadow page tables.
 		 */
-
-		/* fall-through */
+		fallthrough;
 	case INVPCID_TYPE_ALL_INCL_GLOBAL:
 		kvm_mmu_unload(vcpu);
 		return kvm_skip_emulated_instruction(vcpu);
@@ -6401,7 +6400,7 @@ static void __vmx_complete_interrupts(struct kvm_vcpu *vcpu,
 		break;
 	case INTR_TYPE_SOFT_EXCEPTION:
 		vcpu->arch.event_exit_inst_len = vmcs_read32(instr_len_field);
-		/* fall through */
+		fallthrough;
 	case INTR_TYPE_HARD_EXCEPTION:
 		if (idt_vectoring_info & VECTORING_INFO_DELIVER_CODE_MASK) {
 			u32 err = vmcs_read32(error_code_field);
@@ -6411,7 +6410,7 @@ static void __vmx_complete_interrupts(struct kvm_vcpu *vcpu,
 		break;
 	case INTR_TYPE_SOFT_INTR:
 		vcpu->arch.event_exit_inst_len = vmcs_read32(instr_len_field);
-		/* fall through */
+		fallthrough;
 	case INTR_TYPE_EXT_INTR:
 		kvm_queue_interrupt(vcpu, vector, type == INTR_TYPE_SOFT_INTR);
 		break;
arch/x86/kvm/x86.c +4 -8
index 2bbc0e0..e6280e 100644
@@ -1071,7 +1071,6 @@ static int __kvm_set_dr(struct kvm_vcpu *vcpu, int dr, unsigned long val)
 			vcpu->arch.eff_db[dr] = val;
 		break;
 	case 4:
-		/* fall through */
 	case 6:
 		if (val & 0xffffffff00000000ULL)
 			return -1; /* #GP */
@@ -1079,7 +1078,6 @@ static int __kvm_set_dr(struct kvm_vcpu *vcpu, int dr, unsigned long val)
 		kvm_update_dr6(vcpu);
 		break;
 	case 5:
-		/* fall through */
 	default: /* 7 */
 		if (!kvm_dr7_valid(val))
 			return -1; /* #GP */
@@ -1110,7 +1108,6 @@ int kvm_get_dr(struct kvm_vcpu *vcpu, int dr, unsigned long *val)
 		*val = vcpu->arch.db[array_index_nospec(dr, size)];
 		break;
 	case 4:
-		/* fall through */
 	case 6:
 		if (vcpu->guest_debug & KVM_GUESTDBG_USE_HW_BP)
 			*val = vcpu->arch.dr6;
@@ -1118,7 +1115,6 @@ int kvm_get_dr(struct kvm_vcpu *vcpu, int dr, unsigned long *val)
 			*val = kvm_x86_ops->get_dr6(vcpu);
 		break;
 	case 5:
-		/* fall through */
 	default: /* 7 */
 		*val = vcpu->arch.dr7;
 		break;
@@ -2885,7 +2881,8 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
 
 	case MSR_K7_PERFCTR0 ... MSR_K7_PERFCTR3:
 	case MSR_P6_PERFCTR0 ... MSR_P6_PERFCTR1:
-		pr = true; /* fall through */
+		pr = true;
+		fallthrough;
 	case MSR_K7_EVNTSEL0 ... MSR_K7_EVNTSEL3:
 	case MSR_P6_EVNTSEL0 ... MSR_P6_EVNTSEL1:
 		if (kvm_pmu_is_valid_msr(vcpu, msr))
@@ -4181,8 +4178,7 @@ static int kvm_vcpu_ioctl_enable_cap(struct kvm_vcpu *vcpu,
 	case KVM_CAP_HYPERV_SYNIC2:
 		if (cap->args[0])
 			return -EINVAL;
-		/* fall through */
-
+		fallthrough;
 	case KVM_CAP_HYPERV_SYNIC:
 		if (!irqchip_in_kernel(vcpu->kvm))
 			return -EINVAL;
@@ -8478,7 +8474,7 @@ static inline int vcpu_block(struct kvm *kvm, struct kvm_vcpu *vcpu)
 		vcpu->arch.pv.pv_unhalted = false;
 		vcpu->arch.mp_state =
 			KVM_MP_STATE_RUNNABLE;
-		/* fall through */
+		fallthrough;
 	case KVM_MP_STATE_RUNNABLE:
 		vcpu->arch.apf.halted = false;
 		break;
Signature · 1 line
2.24.0
maintainer Acked-by on v1 21/491
#66 lore raw

Re: [PATCH -next 021/491] KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86): Use fallthrough;

Quoted 236 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/x86/kvm/emulate.c  |  2 +-
 arch/x86/kvm/hyperv.c   |  2 +-
 arch/x86/kvm/irq_comm.c |  2 +-
 arch/x86/kvm/lapic.c    |  6 +++---
 arch/x86/kvm/mmu/mmu.c  |  2 +-
 arch/x86/kvm/svm.c      |  2 +-
 arch/x86/kvm/vmx/vmx.c  | 15 +++++++--------
 arch/x86/kvm/x86.c      | 12 ++++--------
 8 files changed, 19 insertions(+), 24 deletions(-)
arch/x86/kvm/emulate.c +1 -1
index bc00642..bae4d8 100644
@@ -3025,7 +3025,7 @@ static void string_registers_quirk(struct x86_emulate_ctxt *ctxt)
 	case 0xa4:	/* movsb */
 	case 0xa5:	/* movsd/w */
 		*reg_rmw(ctxt, VCPU_REGS_RSI) &= (u32)-1;
-		/* fall through */
+		fallthrough;
 	case 0xaa:	/* stosb */
 	case 0xab:	/* stosd/w */
 		*reg_rmw(ctxt, VCPU_REGS_RDI) &= (u32)-1;
arch/x86/kvm/hyperv.c +1 -1
index a86fda7..934bfb4 100644
@@ -1652,7 +1652,7 @@ int kvm_hv_hypercall(struct kvm_vcpu *vcpu)
 		ret = kvm_hvcall_signal_event(vcpu, fast, ingpa);
 		if (ret != HV_STATUS_INVALID_PORT_ID)
 			break;
-		/* fall through - maybe userspace knows this conn_id. */
+		fallthrough;	/* maybe userspace knows this conn_id */
 	case HVCALL_POST_MESSAGE:
 		/* don't bother userspace if it has no way to handle it */
 		if (unlikely(rep || !vcpu_to_synic(vcpu)->active)) {
arch/x86/kvm/irq_comm.c +1 -1
index c47d2a..4aa1c2e 100644
@@ -285,7 +285,7 @@ int kvm_set_routing_entry(struct kvm *kvm,
 		switch (ue->u.irqchip.irqchip) {
 		case KVM_IRQCHIP_PIC_SLAVE:
 			e->irqchip.pin += PIC_NUM_PINS / 2;
-			/* fall through */
+			fallthrough;
 		case KVM_IRQCHIP_PIC_MASTER:
 			if (ue->u.irqchip.pin >= PIC_NUM_PINS / 2)
 				return -EINVAL;
arch/x86/kvm/lapic.c +3 -3
index e3099c..64b7a9c 100644
@@ -1023,7 +1023,7 @@ static int __apic_accept_irq(struct kvm_lapic *apic, int delivery_mode,
 	switch (delivery_mode) {
 	case APIC_DM_LOWEST:
 		vcpu->arch.apic_arb_prio++;
-		/* fall through */
+		fallthrough;
 	case APIC_DM_FIXED:
 		if (unlikely(trig_mode && !level))
 			break;
@@ -1311,7 +1311,7 @@ static u32 __apic_read(struct kvm_lapic *apic, unsigned int offset)
 		break;
 	case APIC_TASKPRI:
 		report_tpr_access(apic, false);
-		/* fall thru */
+		fallthrough;
 	default:
 		val = kvm_lapic_get_reg(apic, offset);
 		break;
@@ -1952,7 +1952,7 @@ int kvm_lapic_reg_write(struct kvm_lapic *apic, u32 reg, u32 val)
 
 	case APIC_LVT0:
 		apic_manage_nmi_watchdog(apic, val);
-		/* fall through */
+		fallthrough;
 	case APIC_LVTTHMR:
 	case APIC_LVTPC:
 	case APIC_LVT1:
arch/x86/kvm/mmu/mmu.c +1 -1
index 87e9ba..8593cd 100644
@@ -4475,7 +4475,7 @@ __reset_rsvds_bits_mask(struct kvm_vcpu *vcpu,
 			rsvd_bits(maxphyaddr, 51);
 		rsvd_check->rsvd_bits_mask[1][4] =
 			rsvd_check->rsvd_bits_mask[0][4];
-		/* fall through */
+		fallthrough;
 	case PT64_ROOT_4LEVEL:
 		rsvd_check->rsvd_bits_mask[0][3] = exb_bit_rsvd |
 			nonleaf_bit8_rsvd | rsvd_bits(7, 7) |
arch/x86/kvm/svm.c +1 -1
index 910005..73fa903 100644
@@ -4449,7 +4449,7 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr)
 	case MSR_IA32_APICBASE:
 		if (kvm_vcpu_apicv_active(vcpu))
 			avic_update_vapic_bar(to_svm(vcpu), data);
-		/* Fall through */
+		fallthrough;
 	default:
 		return kvm_set_msr_common(vcpu, msr);
 	}
arch/x86/kvm/vmx/vmx.c +7 -8
index 69c5bd..1577cd 100644
@@ -4538,12 +4538,12 @@ static bool rmode_exception(struct kvm_vcpu *vcpu, int vec)
 			vmcs_read32(VM_EXIT_INSTRUCTION_LEN);
 		if (vcpu->guest_debug & KVM_GUESTDBG_USE_SW_BP)
 			return false;
-		/* fall through */
+		fallthrough;
 	case DB_VECTOR:
 		if (vcpu->guest_debug &
 			(KVM_GUESTDBG_SINGLESTEP | KVM_GUESTDBG_USE_HW_BP))
 			return false;
-		/* fall through */
+		fallthrough;
 	case DE_VECTOR:
 	case OF_VECTOR:
 	case BR_VECTOR:
@@ -4692,7 +4692,7 @@ static int handle_exception_nmi(struct kvm_vcpu *vcpu)
 		}
 		kvm_run->debug.arch.dr6 = dr6 | DR6_FIXED_1;
 		kvm_run->debug.arch.dr7 = vmcs_readl(GUEST_DR7);
-		/* fall through */
+		fallthrough;
 	case BP_VECTOR:
 		/*
 		 * Update instruction length as we may reinject #BP from
@@ -5119,7 +5119,7 @@ static int handle_task_switch(struct kvm_vcpu *vcpu)
 				error_code =
 					vmcs_read32(IDT_VECTORING_ERROR_CODE);
 			}
-			/* fall through */
+			fallthrough;
 		case INTR_TYPE_SOFT_EXCEPTION:
 			kvm_clear_exception_queue(vcpu);
 			break;
@@ -5469,8 +5469,7 @@ static int handle_invpcid(struct kvm_vcpu *vcpu)
 		 * global flush. If needed, we could optimize this later by
 		 * keeping track of global entries in shadow page tables.
 		 */
-
-		/* fall-through */
+		fallthrough;
 	case INVPCID_TYPE_ALL_INCL_GLOBAL:
 		kvm_mmu_unload(vcpu);
 		return kvm_skip_emulated_instruction(vcpu);
@@ -6401,7 +6400,7 @@ static void __vmx_complete_interrupts(struct kvm_vcpu *vcpu,
 		break;
 	case INTR_TYPE_SOFT_EXCEPTION:
 		vcpu->arch.event_exit_inst_len = vmcs_read32(instr_len_field);
-		/* fall through */
+		fallthrough;
 	case INTR_TYPE_HARD_EXCEPTION:
 		if (idt_vectoring_info & VECTORING_INFO_DELIVER_CODE_MASK) {
 			u32 err = vmcs_read32(error_code_field);
@@ -6411,7 +6410,7 @@ static void __vmx_complete_interrupts(struct kvm_vcpu *vcpu,
 		break;
 	case INTR_TYPE_SOFT_INTR:
 		vcpu->arch.event_exit_inst_len = vmcs_read32(instr_len_field);
-		/* fall through */
+		fallthrough;
 	case INTR_TYPE_EXT_INTR:
 		kvm_queue_interrupt(vcpu, vector, type == INTR_TYPE_SOFT_INTR);
 		break;
arch/x86/kvm/x86.c +3 -7
index 2bbc0e0..e6280e 100644
@@ -1071,7 +1071,6 @@ static int __kvm_set_dr(struct kvm_vcpu *vcpu, int dr, unsigned long val)
 			vcpu->arch.eff_db[dr] = val;
 		break;
 	case 4:
-		/* fall through */
 	case 6:
 		if (val & 0xffffffff00000000ULL)
 			return -1; /* #GP */
@@ -1079,7 +1078,6 @@ static int __kvm_set_dr(struct kvm_vcpu *vcpu, int dr, unsigned long val)
 		kvm_update_dr6(vcpu);
 		break;
 	case 5:
-		/* fall through */
 	default: /* 7 */
 		if (!kvm_dr7_valid(val))
 			return -1; /* #GP */
@@ -1110,7 +1108,6 @@ int kvm_get_dr(struct kvm_vcpu *vcpu, int dr, unsigned long *val)
 		*val = vcpu->arch.db[array_index_nospec(dr, size)];
 		break;
 	case 4:
-		/* fall through */
 	case 6:
 		if (vcpu->guest_debug & KVM_GUESTDBG_USE_HW_BP)
 			*val = vcpu->arch.dr6;
@@ -1118,7 +1115,6 @@ int kvm_get_dr(struct kvm_vcpu *vcpu, int dr, unsigned long *val)
 			*val = kvm_x86_ops->get_dr6(vcpu);
 		break;
 	case 5:
-		/* fall through */
 	default: /* 7 */
 		*val = vcpu->arch.dr7;
 		break;
@@ -2885,7 +2881,8 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
 
 	case MSR_K7_PERFCTR0 ... MSR_K7_PERFCTR3:
 	case MSR_P6_PERFCTR0 ... MSR_P6_PERFCTR1:
-		pr = true; /* fall through */
+		pr = true;
+		fallthrough;
 	case MSR_K7_EVNTSEL0 ... MSR_K7_EVNTSEL3:
 	case MSR_P6_EVNTSEL0 ... MSR_P6_EVNTSEL1:
 		if (kvm_pmu_is_valid_msr(vcpu, msr))
@@ -4181,8 +4178,7 @@ static int kvm_vcpu_ioctl_enable_cap(struct kvm_vcpu *vcpu,
 	case KVM_CAP_HYPERV_SYNIC2:
 		if (cap->args[0])
 			return -EINVAL;
-		/* fall through */
-
+		fallthrough;
 	case KVM_CAP_HYPERV_SYNIC:
 		if (!irqchip_in_kernel(vcpu->kvm))
 			return -EINVAL;

arch/x86/kvm/x86.c static inline int vcpu_block(struct kvm *kvm, struct kvm_vcpu *vcpu) · line 8480

Quoted 8 lines
arch/x86/kvm/x86.c +1 -1
@@ -8478,7 +8474,7 @@ static inline int vcpu_block(struct kvm *kvm, struct kvm_vcpu *vcpu)
 		vcpu->arch.pv.pv_unhalted = false;
 		vcpu->arch.mp_state =
 			KVM_MP_STATE_RUNNABLE;
-		/* fall through */
+		fallthrough;
 	case KVM_MP_STATE_RUNNABLE:
 		vcpu->arch.apf.halted = false;
 		break;
#67 lore raw

PATCH 22/491 X86 MCE INFRASTRUCTURE: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/x86/kernel/cpu/mce/inject.c | 2 +-
 arch/x86/kernel/cpu/mce/intel.c  | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)
arch/x86/kernel/cpu/mce/inject.c +1 -1
index 3413b41..b5e3bab 100644
@@ -199,7 +199,7 @@ static int raise_local(void)
 			 * calling irq_enter, but the necessary
 			 * machinery isn't exported currently.
 			 */
-			/*FALL THROUGH*/
+			fallthrough;
 		case MCJ_CTX_PROCESS:
 			raise_exception(m, NULL);
 			break;
arch/x86/kernel/cpu/mce/intel.c +1 -3
index d8f9230..5be647 100644
@@ -192,9 +192,7 @@ unsigned long cmci_intel_adjust_timer(unsigned long interval)
 		__this_cpu_write(cmci_storm_state, CMCI_STORM_SUBSIDED);
 		if (!atomic_sub_return(1, &cmci_storm_on_cpus))
 			pr_notice("CMCI storm subsided: switching to interrupt mode\n");
-
-		/* FALLTHROUGH */
-
+		fallthrough;
 	case CMCI_STORM_SUBSIDED:
 		/*
 		 * We wait for all CPUs to go back to SUBSIDED state. When that
Signature · 1 line
2.24.0
maintainer Acked-by on v1 22/491
#68 lore raw

Re: [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: Use fallthrough;

Quoted 1 line · Joe Perches

Subject: Re: [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: Use fallthrough;

Make that subject prefix "x86/mce: ..."

Quoted 30 lines

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 arch/x86/kernel/cpu/mce/inject.c | 2 +-
 arch/x86/kernel/cpu/mce/intel.c  | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)
arch/x86/kernel/cpu/mce/inject.c +1 -1
index 3413b41..b5e3bab 100644
@@ -199,7 +199,7 @@ static int raise_local(void)
 			 * calling irq_enter, but the necessary
 			 * machinery isn't exported currently.
 			 */
-			/*FALL THROUGH*/
+			fallthrough;
 		case MCJ_CTX_PROCESS:
 			raise_exception(m, NULL);
 			break;
arch/x86/kernel/cpu/mce/intel.c +0 -0
index d8f9230..5be647 100644

arch/x86/kernel/cpu/mce/intel.c unsigned long cmci_intel_adjust_timer(unsigned long interval) · line 198

Quoted 10 lines
arch/x86/kernel/cpu/mce/intel.c +1 -3
@@ -192,9 +192,7 @@ unsigned long cmci_intel_adjust_timer(unsigned long interval)
 		__this_cpu_write(cmci_storm_state, CMCI_STORM_SUBSIDED);
 		if (!atomic_sub_return(1, &cmci_storm_on_cpus))
 			pr_notice("CMCI storm subsided: switching to interrupt mode\n");
-
-		/* FALLTHROUGH */
-
+		fallthrough;
 	case CMCI_STORM_SUBSIDED:
 		/*
 		 * We wait for all CPUs to go back to SUBSIDED state. When that

With that:

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#69 lore raw

PATCH 23/491 AMD KFD: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c +1 -1
index d6549e..6529ca 100644
@@ -79,7 +79,7 @@ static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev,
 		dev_warn(adev->dev,
 			 "Invalid sdma engine id (%d), using engine id 0\n",
 			 engine_id);
-		/* fall through */
+		fallthrough;
 	case 0:
 		sdma_engine_reg_base = SOC15_REG_OFFSET(SDMA0, 0,
 				mmSDMA0_RLC0_RB_CNTL) - mmSDMA0_RLC0_RB_CNTL;
Signature · 6 lines
2.24.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer Acked-by on v1 23/491
#70 lore raw

Re: [PATCH -next 023/491] AMD KFD: Use fallthrough;

Quoted 4 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

The link seems to be broken. This one works: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/

Quoted 2 lines
Quoted 9 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c +0 -0
index d6549e..6529ca 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev, · line 85

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c +1 -1
@@ -79,7 +79,7 @@ static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev,
  		dev_warn(adev->dev,
  			 "Invalid sdma engine id (%d), using engine id 0\n",
  			 engine_id);
-		/* fall through */
+		fallthrough;
  	case 0:
  		sdma_engine_reg_base = SOC15_REG_OFFSET(SDMA0, 0,
  				mmSDMA0_RLC0_RB_CNTL) - mmSDMA0_RLC0_RB_CNTL;

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#71 lore raw

Re: [PATCH -next 023/491] AMD KFD: Use fallthrough;

Quoted 8 lines · Felix Kuehling
Quoted 4 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

The link seems to be broken. This one works:
https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/

Thanks.

I neglected to use a backslash on the generating script. In the script in 0/491,

likely should have been:

#72 lore raw

Re: [PATCH -next 023/491] AMD KFD: Use fallthrough;

Applied. Thanks. Link fixed locally.

Alex

Quoted 20 lines · Joe Perches
Quoted 8 lines · Felix Kuehling
Quoted 4 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

The link seems to be broken. This one works:
https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe@perches.com/

Thanks.

I neglected to use a backslash on the generating script. In the script in 0/491,

likely should have been:

Quoted 7 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#73 lore raw

PATCH 24/491 AMD DISPLAY CORE: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 4 ++--
 drivers/gpu/drm/amd/display/dc/dce/dce_aux.c       | 2 +-
 drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c +2 -2
index 2f1c958..37fa7b 100644
@@ -267,7 +267,7 @@ static struct atom_display_object_path_v2 *get_bios_object(
 					&& id.enum_id == obj_id.enum_id)
 				return &bp->object_info_tbl.v1_4->display_path[i];
 		}
-		/* fall through */
+		fallthrough;
 	case OBJECT_TYPE_CONNECTOR:
 	case OBJECT_TYPE_GENERIC:
 		/* Both Generic and Connector Object ID
@@ -280,7 +280,7 @@ static struct atom_display_object_path_v2 *get_bios_object(
 					&& id.enum_id == obj_id.enum_id)
 				return &bp->object_info_tbl.v1_4->display_path[i];
 		}
-		/* fall through */
+		fallthrough;
 	default:
 		return NULL;
 	}
drivers/gpu/drm/amd/display/dc/dce/dce_aux.c +1 -1
index 68c4049..743042 100644
@@ -645,7 +645,7 @@ bool dce_aux_transfer_with_retries(struct ddc_service *ddc,
 			case AUX_TRANSACTION_REPLY_AUX_DEFER:
 			case AUX_TRANSACTION_REPLY_I2C_OVER_AUX_DEFER:
 				retry_on_defer = true;
-				/* fall through */
+				fallthrough;
 			case AUX_TRANSACTION_REPLY_I2C_OVER_AUX_NACK:
 				if (++aux_defer_retries >= AUX_MAX_DEFER_RETRIES) {
 					goto fail;
drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c +1 -1
index 8aa937f..51481e 100644
@@ -479,7 +479,7 @@ static void program_grph_pixel_format(
 	case SURFACE_PIXEL_FORMAT_GRPH_ABGR16161616F:
 		sign = 1;
 		floating = 1;
-		/* fall through */
+		fallthrough;
 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616F: /* shouldn't this get float too? */
 	case SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616:
 		grph_depth = 3;
Signature · 6 lines
2.24.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#74 lore raw

Re: [PATCH -next 024/491] AMD DISPLAY CORE: Use fallthrough;

Applied. thanks! (link fixed locally).

Alex

Quoted 64 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 4 ++--
 drivers/gpu/drm/amd/display/dc/dce/dce_aux.c       | 2 +-
 drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c +2 -2
index 2f1c958..37fa7b 100644
@@ -267,7 +267,7 @@ static struct atom_display_object_path_v2 *get_bios_object(
                                        && id.enum_id == obj_id.enum_id)
                                return &bp->object_info_tbl.v1_4->display_path[i];
                }
-               /* fall through */
+               fallthrough;
        case OBJECT_TYPE_CONNECTOR:
        case OBJECT_TYPE_GENERIC:
                /* Both Generic and Connector Object ID
@@ -280,7 +280,7 @@ static struct atom_display_object_path_v2 *get_bios_object(
                                        && id.enum_id == obj_id.enum_id)
                                return &bp->object_info_tbl.v1_4->display_path[i];
                }
-               /* fall through */
+               fallthrough;
        default:
                return NULL;
        }
drivers/gpu/drm/amd/display/dc/dce/dce_aux.c +1 -1
index 68c4049..743042 100644
@@ -645,7 +645,7 @@ bool dce_aux_transfer_with_retries(struct ddc_service *ddc,
                        case AUX_TRANSACTION_REPLY_AUX_DEFER:
                        case AUX_TRANSACTION_REPLY_I2C_OVER_AUX_DEFER:
                                retry_on_defer = true;
-                               /* fall through */
+                               fallthrough;
                        case AUX_TRANSACTION_REPLY_I2C_OVER_AUX_NACK:
                                if (++aux_defer_retries >= AUX_MAX_DEFER_RETRIES) {
                                        goto fail;
drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c +1 -2
index 8aa937f..51481e 100644
@@ -479,7 +479,7 @@ static void program_grph_pixel_format(
        case SURFACE_PIXEL_FORMAT_GRPH_ABGR16161616F:
                sign = 1;
                floating = 1;
-               /* fall through */
+               fallthrough;
        case SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616F: /* shouldn't this get float too? */
        case SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616:
                grph_depth = 3;
--

2.24.0

Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#75 lore raw

PATCH 25/491 AMD POWERPLAY: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +3 -3
index bf04cf..fc5236c 100644
@@ -1250,7 +1250,7 @@ static void smu7_set_dpm_event_sources(struct pp_hwmgr *hwmgr, uint32_t sources)
 	switch (sources) {
 	default:
 		pr_err("Unknown throttling event sources.");
-		/* fall through */
+		fallthrough;
 	case 0:
 		protection = false;
 		/* src is unused */
@@ -3698,12 +3698,12 @@ static int smu7_request_link_speed_change_before_state_change(
 			data->force_pcie_gen = PP_PCIEGen2;
 			if (current_link_speed == PP_PCIEGen2)
 				break;
-			/* fall through */
+			fallthrough;
 		case PP_PCIEGen2:
 			if (0 == amdgpu_acpi_pcie_performance_request(hwmgr->adev, PCIE_PERF_REQ_GEN2, false))
 				break;
 #endif
-			/* fall through */
+			fallthrough;
 		default:
 			data->force_pcie_gen = smu7_get_current_pcie_speed(hwmgr);
 			break;
Signature · 6 lines
2.24.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#76 lore raw

Re: [PATCH -next 025/491] AMD POWERPLAY: Use fallthrough;

Applied. thanks! (link fixed locally).

Alex

Quoted 42 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +3 -4
index bf04cf..fc5236c 100644
@@ -1250,7 +1250,7 @@ static void smu7_set_dpm_event_sources(struct pp_hwmgr *hwmgr, uint32_t sources)
        switch (sources) {
        default:
                pr_err("Unknown throttling event sources.");
-               /* fall through */
+               fallthrough;
        case 0:
                protection = false;
                /* src is unused */
@@ -3698,12 +3698,12 @@ static int smu7_request_link_speed_change_before_state_change(
                        data->force_pcie_gen = PP_PCIEGen2;
                        if (current_link_speed == PP_PCIEGen2)
                                break;
-                       /* fall through */
+                       fallthrough;
                case PP_PCIEGen2:
                        if (0 == amdgpu_acpi_pcie_performance_request(hwmgr->adev, PCIE_PERF_REQ_GEN2, false))
                                break;
 #endif
-                       /* fall through */
+                       fallthrough;
                default:
                        data->force_pcie_gen = smu7_get_current_pcie_speed(hwmgr);
                        break;
--

2.24.0

Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#77 lore raw

PATCH 26/491 INTEL GVT-g DRIVERS (Intel GPU Virtualization): Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/gpu/drm/i915/gvt/handlers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gvt/handlers.c +1 -1
index 1793f69..0e792f9 100644
@@ -1225,7 +1225,7 @@ static int handle_g2v_notification(struct intel_vgpu *vgpu, int notification)
 	switch (notification) {
 	case VGT_G2V_PPGTT_L3_PAGE_TABLE_CREATE:
 		root_entry_type = GTT_TYPE_PPGTT_ROOT_L3_ENTRY;
-		/* fall through */
+		fallthrough;
 	case VGT_G2V_PPGTT_L4_PAGE_TABLE_CREATE:
 		mm = intel_vgpu_get_ppgtt_mm(vgpu, root_entry_type, pdps);
 		return PTR_ERR_OR_ZERO(mm);
Signature · 6 lines
2.24.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#78 lore raw

PATCH 27/491 AMD XGBE DRIVER: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/amd/xgbe/xgbe-drv.c +3 -3
index b71f9b0..a51abf 100644
@@ -1612,7 +1612,7 @@ static int xgbe_set_hwtstamp_settings(struct xgbe_prv_data *pdata,
 	/* PTP v2, UDP, any kind of event packet */
 	case HWTSTAMP_FILTER_PTP_V2_L4_EVENT:
 		XGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSVER2ENA, 1);
-		/* Fall through - to PTP v1, UDP, any kind of event packet */
+		fallthrough;	/* to PTP v1, UDP, any kind of event packet */
 	case HWTSTAMP_FILTER_PTP_V1_L4_EVENT:
 		XGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSIPV4ENA, 1);
 		XGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSIPV6ENA, 1);
@@ -1623,7 +1623,7 @@ static int xgbe_set_hwtstamp_settings(struct xgbe_prv_data *pdata,
 	/* PTP v2, UDP, Sync packet */
 	case HWTSTAMP_FILTER_PTP_V2_L4_SYNC:
 		XGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSVER2ENA, 1);
-		/* Fall through - to PTP v1, UDP, Sync packet */
+		fallthrough;	/* to PTP v1, UDP, Sync packet */
 	case HWTSTAMP_FILTER_PTP_V1_L4_SYNC:
 		XGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSIPV4ENA, 1);
 		XGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSIPV6ENA, 1);
@@ -1634,7 +1634,7 @@ static int xgbe_set_hwtstamp_settings(struct xgbe_prv_data *pdata,
 	/* PTP v2, UDP, Delay_req packet */
 	case HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ:
 		XGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSVER2ENA, 1);
-		/* Fall through - to PTP v1, UDP, Delay_req packet */
+		fallthrough;	/* to PTP v1, UDP, Delay_req packet */
 	case HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ:
 		XGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSIPV4ENA, 1);
 		XGMAC_SET_BITS(mac_tscr, MAC_TSCR, TSIPV6ENA, 1);
Signature · 1 line
2.24.0
#79 lore raw

PATCH 28/491 BROADCOM BNX2X 10 GIGABIT ETHERNET DRIVER: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c  | 14 +++++++-------
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c  |  6 ++----
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c |  4 ++--
 3 files changed, 11 insertions(+), 13 deletions(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c +7 -7
index 9638d65..07bc87 100644
@@ -4708,14 +4708,14 @@ static void bnx2x_sync_link(struct link_params *params,
 			LINK_STATUS_SPEED_AND_DUPLEX_MASK) {
 		case LINK_10THD:
 			vars->duplex = DUPLEX_HALF;
-			/* Fall thru */
+			fallthrough;
 		case LINK_10TFD:
 			vars->line_speed = SPEED_10;
 			break;
 
 		case LINK_100TXHD:
 			vars->duplex = DUPLEX_HALF;
-			/* Fall thru */
+			fallthrough;
 		case LINK_100T4:
 		case LINK_100TXFD:
 			vars->line_speed = SPEED_100;
@@ -4723,14 +4723,14 @@ static void bnx2x_sync_link(struct link_params *params,
 
 		case LINK_1000THD:
 			vars->duplex = DUPLEX_HALF;
-			/* Fall thru */
+			fallthrough;
 		case LINK_1000TFD:
 			vars->line_speed = SPEED_1000;
 			break;
 
 		case LINK_2500THD:
 			vars->duplex = DUPLEX_HALF;
-			/* Fall thru */
+			fallthrough;
 		case LINK_2500TFD:
 			vars->line_speed = SPEED_2500;
 			break;
@@ -6335,7 +6335,7 @@ int bnx2x_set_led(struct link_params *params,
 		 */
 		if (!vars->link_up)
 			break;
-		/* fall through */
+		fallthrough;
 	case LED_MODE_ON:
 		if (((params->phy[EXT_PHY1].type ==
 			  PORT_HW_CFG_XGXS_EXT_PHY_TYPE_BCM8727) ||
@@ -12503,13 +12503,13 @@ static void bnx2x_phy_def_cfg(struct link_params *params,
 	switch (link_config  & PORT_FEATURE_LINK_SPEED_MASK) {
 	case PORT_FEATURE_LINK_SPEED_10M_HALF:
 		phy->req_duplex = DUPLEX_HALF;
-		/* fall through */
+		fallthrough;
 	case PORT_FEATURE_LINK_SPEED_10M_FULL:
 		phy->req_line_speed = SPEED_10;
 		break;
 	case PORT_FEATURE_LINK_SPEED_100M_HALF:
 		phy->req_duplex = DUPLEX_HALF;
-		/* fall through */
+		fallthrough;
 	case PORT_FEATURE_LINK_SPEED_100M_FULL:
 		phy->req_line_speed = SPEED_100;
 		break;
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +2 -4
index db5107e7..d0580d 100644
@@ -8583,12 +8583,10 @@ int bnx2x_set_int_mode(struct bnx2x *bp)
 		BNX2X_DEV_INFO("Failed to enable multiple MSI-X (%d), set number of queues to %d\n",
 			       bp->num_queues,
 			       1 + bp->num_cnic_queues);
-
-		/* fall through */
+		fallthrough;
 	case BNX2X_INT_MODE_MSI:
 		bnx2x_enable_msi(bp);
-
-		/* fall through */
+		fallthrough;
 	case BNX2X_INT_MODE_INTX:
 		bp->num_ethernet_queues = 1;
 		bp->num_queues = bp->num_ethernet_queues + bp->num_cnic_queues;
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +2 -2
index 5097a44..eeaeb9 100644
@@ -1830,7 +1830,7 @@ int bnx2x_iov_eq_sp_event(struct bnx2x *bp, union event_ring_elem *elem)
 		DP(BNX2X_MSG_IOV, "got VF [%d:%d] RSS update ramrod\n",
 		   vf->abs_vfid, qidx);
 		bnx2x_vf_handle_rss_update_eqe(bp, vf);
-		/* fall through */
+		fallthrough;
 	case EVENT_RING_OPCODE_VF_FLR:
 		/* Do nothing for now */
 		return 0;
@@ -2228,7 +2228,7 @@ int bnx2x_vf_free(struct bnx2x *bp, struct bnx2x_virtf *vf)
 		rc = bnx2x_vf_close(bp, vf);
 		if (rc)
 			goto op_err;
-		/* Fall through - to release resources */
+		fallthrough;	/* to release resources */
 	case VF_ACQUIRED:
 		DP(BNX2X_MSG_IOV, "about to free resources\n");
 		bnx2x_vf_free_resc(bp, vf);
Signature · 1 line
2.24.0
#80 lore raw

PATCH 29/491 BROADCOM BNXT_EN 50 GIGABIT ETHERNET DRIVER: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c       | 17 ++++++++---------
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c   |  4 ++--
 drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c   |  4 ++--
 3 files changed, 12 insertions(+), 13 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +8 -9
index 663dcf..f964c2 100644
@@ -1923,7 +1923,7 @@ u32 bnxt_fw_health_readl(struct bnxt *bp, int reg_idx)
 		break;
 	case BNXT_FW_HEALTH_REG_TYPE_GRC:
 		reg_off = fw_health->mapped_regs[reg_idx];
-		/* fall through */
+		fallthrough;
 	case BNXT_FW_HEALTH_REG_TYPE_BAR0:
 		val = readl(bp->bar0 + reg_off);
 		break;
@@ -1966,11 +1966,11 @@ static int bnxt_async_event_process(struct bnxt *bp,
 		}
 		set_bit(BNXT_LINK_SPEED_CHNG_SP_EVENT, &bp->sp_event);
 	}
-	/* fall through */
+		fallthrough;
 	case ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CHANGE:
 	case ASYNC_EVENT_CMPL_EVENT_ID_PORT_PHY_CFG_CHANGE:
 		set_bit(BNXT_LINK_CFG_CHANGE_SP_EVENT, &bp->sp_event);
-		/* fall through */
+		fallthrough;
 	case ASYNC_EVENT_CMPL_EVENT_ID_LINK_STATUS_CHANGE:
 		set_bit(BNXT_LINK_CHNG_SP_EVENT, &bp->sp_event);
 		break;
@@ -9400,8 +9400,7 @@ static int bnxt_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 	switch (cmd) {
 	case SIOCGMIIPHY:
 		mdio->phy_id = bp->link_info.phy_addr;
-
-		/* fallthru */
+		fallthrough;
 	case SIOCGMIIREG: {
 		u16 mii_regval = 0;
 
@@ -10644,7 +10643,7 @@ static void bnxt_fw_reset_writel(struct bnxt *bp, int reg_idx)
 		writel(reg_off & BNXT_GRC_BASE_MASK,
 		       bp->bar0 + BNXT_GRCPF_REG_WINDOW_BASE_OUT + 4);
 		reg_off = (reg_off & BNXT_GRC_OFFSET_MASK) + 0x2000;
-		/* fall through */
+		fallthrough;
 	case BNXT_FW_HEALTH_REG_TYPE_BAR0:
 		writel(val, bp->bar0 + reg_off);
 		break;
@@ -10757,7 +10756,7 @@ static void bnxt_fw_reset_task(struct work_struct *work)
 		}
 		bp->fw_reset_state = BNXT_FW_RESET_STATE_RESET_FW;
 	}
-	/* fall through */
+		fallthrough;
 	case BNXT_FW_RESET_STATE_RESET_FW:
 		bnxt_reset_all(bp);
 		bp->fw_reset_state = BNXT_FW_RESET_STATE_ENABLE_DEV;
@@ -10780,7 +10779,7 @@ static void bnxt_fw_reset_task(struct work_struct *work)
 		}
 		pci_set_master(bp->pdev);
 		bp->fw_reset_state = BNXT_FW_RESET_STATE_POLL_FW;
-		/* fall through */
+		fallthrough;
 	case BNXT_FW_RESET_STATE_POLL_FW:
 		bp->hwrm_cmd_timeout = SHORT_HWRM_CMD_TIMEOUT;
 		rc = __bnxt_hwrm_ver_get(bp, true);
@@ -10795,7 +10794,7 @@ static void bnxt_fw_reset_task(struct work_struct *work)
 		}
 		bp->hwrm_cmd_timeout = DFLT_HWRM_CMD_TIMEOUT;
 		bp->fw_reset_state = BNXT_FW_RESET_STATE_OPENING;
-		/* fall through */
+		fallthrough;
 	case BNXT_FW_RESET_STATE_OPENING:
 		while (!rtnl_trylock()) {
 			bnxt_queue_fw_reset_work(bp, HZ / 10);
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +2 -2
index 677bab..af76ba6 100644
@@ -1029,7 +1029,7 @@ static int bnxt_grxfh(struct bnxt *bp, struct ethtool_rxnfc *cmd)
 		if (bp->rss_hash_cfg & VNIC_RSS_CFG_REQ_HASH_TYPE_UDP_IPV4)
 			cmd->data |= RXH_IP_SRC | RXH_IP_DST |
 				     RXH_L4_B_0_1 | RXH_L4_B_2_3;
-		/* fall through */
+		fallthrough;
 	case SCTP_V4_FLOW:
 	case AH_ESP_V4_FLOW:
 	case AH_V4_FLOW:
@@ -1048,7 +1048,7 @@ static int bnxt_grxfh(struct bnxt *bp, struct ethtool_rxnfc *cmd)
 		if (bp->rss_hash_cfg & VNIC_RSS_CFG_REQ_HASH_TYPE_UDP_IPV6)
 			cmd->data |= RXH_IP_SRC | RXH_IP_DST |
 				     RXH_L4_B_0_1 | RXH_L4_B_2_3;
-		/* fall through */
+		fallthrough;
 	case SCTP_V6_FLOW:
 	case AH_ESP_V6_FLOW:
 	case AH_V6_FLOW:
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c +2 -2
index c6f6f20..a974cb2 100644
@@ -200,10 +200,10 @@ bool bnxt_rx_xdp(struct bnxt *bp, struct bnxt_rx_ring_info *rxr, u16 cons,
 		break;
 	default:
 		bpf_warn_invalid_xdp_action(act);
-		/* Fall thru */
+		fallthrough;
 	case XDP_ABORTED:
 		trace_xdp_exception(bp->dev, xdp_prog, act);
-		/* Fall thru */
+		fallthrough;
 	case XDP_DROP:
 		bnxt_reuse_rx_data(rxr, cons, page);
 		break;
Signature · 1 line
2.24.0
#81 lore raw

PATCH 30/491 BROADCOM GENET ETHERNET DRIVER: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++--
 drivers/net/ethernet/broadcom/genet/bcmmii.c   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/broadcom/genet/bcmgenet.c +2 -2
index c2fda12..f8c15ec 100644
@@ -963,10 +963,10 @@ static void bcmgenet_update_mib_counters(struct bcmgenet_priv *priv)
 			continue;
 		case BCMGENET_STAT_RUNT:
 			offset += BCMGENET_STAT_OFFSET;
-			/* fall through */
+			fallthrough;
 		case BCMGENET_STAT_MIB_TX:
 			offset += BCMGENET_STAT_OFFSET;
-			/* fall through */
+			fallthrough;
 		case BCMGENET_STAT_MIB_RX:
 			val = bcmgenet_umac_readl(priv,
 						  UMAC_MIB_START + j + offset);
drivers/net/ethernet/broadcom/genet/bcmmii.c +1 -1
index d3003cb..b8e704f 100644
@@ -216,7 +216,7 @@ int bcmgenet_mii_config(struct net_device *dev, bool init)
 	switch (priv->phy_interface) {
 	case PHY_INTERFACE_MODE_INTERNAL:
 		phy_name = "internal PHY";
-		/* fall through */
+		fallthrough;
 	case PHY_INTERFACE_MODE_MOCA:
 		/* Irrespective of the actually configured PHY speed (100 or
 		 * 1000) GENETv4 only has an internal GPHY so we will just end
Signature · 1 line
2.24.0
#82 lore raw

Re: [PATCH -next 030/491] BROADCOM GENET ETHERNET DRIVER: Use fallthrough;

Quoted 6 lines · Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

Please fix the subject to be:

net: bcmgenet: Use fallthrough;

to match commits done to this file.

Signature · 1 line
Florian
#83 lore raw

PATCH 31/491 BROCADE BNA 10 GIGABIT ETHERNET DRIVER: Use fallthrough;

In reply to Joe Perches

Convert the various uses of fallthrough comments to fallthrough;

Done via script

---
 drivers/net/ethernet/brocade/bna/bfa_ioc.c   | 8 +++-----
 drivers/net/ethernet/brocade/bna/bna_enet.c  | 2 +-
 drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 3 +--
 3 files changed, 5 insertions(+), 8 deletions(-)
drivers/net/ethernet/brocade/bna/bfa_ioc.c +3 -5
index e17bfc..e9248c 100644
@@ -321,7 +321,7 @@ bfa_ioc_sm_getattr(struct bfa_ioc *ioc, enum ioc_event event)
 	case IOC_E_PFFAILED:
 	case IOC_E_HWERROR:
 		del_timer(&ioc->ioc_timer);
-		/* fall through */
+		fallthrough;
 	case IOC_E_TIMEOUT:
 		ioc->cbfn->enable_cbfn(ioc->bfa, BFA_STATUS_IOC_FAILURE);
 		bfa_fsm_set_state(ioc, bfa_ioc_sm_fail);
@@ -780,8 +780,7 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
 
 	case IOCPF_E_INITFAIL:
 		del_timer(&ioc->iocpf_timer);
-		/* fall through */
-
+		fallthrough;
 	case IOCPF_E_TIMEOUT:
 		bfa_nw_ioc_hw_sem_release(ioc);
 		if (event == IOCPF_E_TIMEOUT)
@@ -849,8 +848,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf *iocpf, enum iocpf_event event)
 
 	case IOCPF_E_FAIL:
 		del_timer(&ioc->iocpf_timer);
-		/* fall through*/
-
+		fallthrough;
 	case IOCPF_E_TIMEOUT:
 		bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);
 		bfa_fsm_set_state(iocpf, bfa_iocpf_sm_disabling_sync);
drivers/net/ethernet/brocade/bna/bna_enet.c +1 -1
index 40107a9..a2c983 100644
@@ -1084,7 +1084,7 @@ bna_enet_sm_cfg_wait(struct bna_enet *enet,
 
 	case ENET_E_CHLD_STOPPED:
 		bna_enet_rx_start(enet);
-		/* Fall through */
+		fallthrough;
 	case ENET_E_FWRESP_PAUSE:
 		if (enet->flags & BNA_ENET_F_PAUSE_CHANGED) {
 			enet->flags &= ~BNA_ENET_F_PAUSE_CHANGED;
drivers/net/ethernet/brocade/bna/bna_tx_rx.c +1 -2
index b5ecbfe..cd2bfb 100644
@@ -1636,8 +1636,7 @@ bna_bfi_rx_enet_start(struct bna_rx *rx)
 						&q1->qpt);
 			cfg_req->q_cfg[i].qs.rx_buffer_size =
 				htons((u16)q1->buffer_size);
-			/* Fall through */
-
+			fallthrough;
 		case BNA_RXP_SINGLE:
 			/* Large/Single RxQ */
 			bfi_enet_datapath_q_init(&cfg_req->q_cfg[i].ql.q,
Signature · 1 line
2.24.0