Skip to contentSkip to conversation

Staging: iio: adc: eliminate spaces at the start of [email protected]

PATCH In review Enrique Vargas 2 participants 2 messages Mar 12, 2020 – Mar 15, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: iio: adc: eliminate spaces at the start of [email protected]

Eliminate WARNING found with checkpatch.pl related to spaces inconsistency on identation.

---
 drivers/staging/iio/adc/ad7192.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/adc/ad7192.c +2 -2
index bf3e2a9cc07f..51b1cd3ad1de 100644
@@ -156,8 +156,8 @@
  */
 
 enum {
-   AD7192_SYSCALIB_ZERO_SCALE,
-   AD7192_SYSCALIB_FULL_SCALE,
+	AD7192_SYSCALIB_ZERO_SCALE,
+	AD7192_SYSCALIB_FULL_SCALE,
 };
 
 struct ad7192_state {
Signature · 1 line
2.17.1
#1 lore raw

Hi Enrique,

For some reason, an address you wanted to Cc: ended up in the subject.

A couple of comments:

- well, yes, I see you're removing spaces at the start of some lines, but you're also replacing them by tabs, and doing it in an enum... maybe that could be part of the commit title?

Also,

Quoted 2 lines · On Thu, 12 Mar 2020 08:09:11 -0600 Enrique Vargas <[email protected]>…

Eliminate WARNING found with checkpatch.pl related to spaces inconsistency on identation.

^^^ indentation.

The rest looks good to me! Can you please send a new version?

Signature · 1 line
Stefano