package/ffmpeg: fix typo "--enable-bsfs" -> "--enable-bsf"
PATCH 1/1 package/ffmpeg: fix typo "--enable-bsfs" -> "--enable-bsf"
Fix ffmpeg configuration when BR2_PACKAGE_FFMPEG_BSFS is not default ("all"):
Unknown option "--enable-bsfs=h264_metadata".
See ./configure --help for available options.
package/pkg-generic.mk:254: recipe for target '/root/buildroot/output/build/ffmpeg-4.2.2/.stamp_configured' failed
The option is named according to the scheme "--enable-SINGULAR=..." / "--disable-PLURAL".
The typo is present since the release 2014.02:
--- package/ffmpeg/ffmpeg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/ffmpeg/ffmpeg.mk +1 -1
@@ -135,7 +135,7 @@ endif ifneq ($(call qstrip,$(BR2_PACKAGE_FFMPEG_BSFS)),all) FFMPEG_CONF_OPTS += --disable-bsfs \ - $(foreach x,$(call qstrip,$(BR2_PACKAGE_FFMPEG_BSFS)),--enable-bsfs=$(x)) + $(foreach x,$(call qstrip,$(BR2_PACKAGE_FFMPEG_BSFS)),--enable-bsf=$(x)) endif ifneq ($(call qstrip,$(BR2_PACKAGE_FFMPEG_PROTOCOLS)),all)
Signature · 1 line
2.17.1
Thomas Petazzoni
AppliedPATCH 1/1 package/ffmpeg: fix typo "--enable-bsfs" -> "--enable-bsf"
Quoted 9 lines · On Thu, 12 Mar 2020 20:45:17 +0100 Anatoly Borodin <[email protected]>…
Fix ffmpeg configuration when
BR2_PACKAGE_FFMPEG_BSFSis not default ("all"):Unknown option "--enable-bsfs=h264_metadata".
See ./configure --help for available options.
package/pkg-generic.mk:254: recipe for target '/root/buildroot/output/build/ffmpeg-4.2.2/.stamp_configured' failedThe option is named according to the scheme "--enable-SINGULAR=..." / "--disable-PLURAL".
Quoted 8 lines
The typo is present since the release 2014.02:
Signed-off-by Anatoly Borodin <[email protected]>--- package/ffmpeg/ffmpeg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/ffmpeg: fix typo "--enable-bsfs" -> "--enable-bsf"
In reply to Anatoly BorodinQuoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Anatoly" == Anatoly Borodin <[email protected]> writes:
Fix ffmpeg configuration when
BR2_PACKAGE_FFMPEG_BSFSis not default ("all"):
Unknown option "--enable-bsfs=h264_metadata".
See ./configure --help for available options.
package/pkg-generic.mk:254: recipe for target '/root/buildroot/output/build/ffmpeg-4.2.2/.stamp_configured' failed
Quoted 8 lines
The option is named according to the scheme "--enable-SINGULAR=..." / "--disable-PLURAL".
The typo is present since the release 2014.02:
Signed-off-by Anatoly Borodin <[email protected]>
Committed to 2019.02.x, 2019.11.x and 2020.02.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard