Staging: wilc1000: cfg80211: Use kmemdup instead of kmalloc and memcpy
PATCH 1/1 Staging: wilc1000: cfg80211: Use kmemdup instead of kmalloc and memcpy
Replace calls to kmalloc followed by a memcpy with a direct call to kmemdup.
The Coccinelle semantic patch used to make this change is as follows:
@@
expression from,to,size,flag;
statement S;
@@
- to = \(kmalloc\|kzalloc\)(size,flag);
+ to = kmemdup(from,size,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
Signed-off-by Shreeya Patel <[email protected]>
--- drivers/staging/wilc1000/cfg80211.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/wilc1000/cfg80211.c +1 -2
@@ -1142,14 +1142,13 @@ static int mgmt_tx(struct wiphy *wiphy, goto out; } - mgmt_tx->buff =kmalloc (len,GFP_KERNEL ); + mgmt_tx->buff =kmemdup (buf, len,GFP_KERNEL );if (!mgmt_tx->buff) { ret = -ENOMEM ;kfree (mgmt_tx); goto out; } -memcpy (mgmt_tx->buff, buf, len); mgmt_tx->size = len;if (ieee80211_is_probe_resp (mgmt->frame_control)) {
Signature · 1 line
2.17.1
Quoted 14 lines · On Fri, 13 Mar 2020 16:54:51 +0530 Shreeya Patel…
Replace calls to kmalloc followed by a memcpy with a direct call to kmemdup.
The Coccinelle semantic patch used to make this change is as follows:
@@
expression from,to,size,flag;
statement S;
@@(quoted diff) +1
-2- to = \(kmalloc\|kzalloc\)(size,flag); + to = kmemdup(from,size,flag); if (to==NULL || ...) S - memcpy(to, from, size);
Quoted 1 line
Signed-off-by Shreeya Patel <[email protected]>
Reviewed-by Stefano Brivio <[email protected]>
Signature · 1 line
Stefano