Skip to contentSkip to conversation

rcu-tasks: fix a modpost warning for rcu_tasks_rude_wait_gp

PATCH In review Qiujun Huang 2 participants 2 messages Mar 13, 2020 RCU

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rcu-tasks: fix a modpost warning for rcu_tasks_rude_wait_gp

Found by gcc:
WARNING: modpost: "rcu_tasks_rude_wait_gp" [vmlinux] is a static EXPORT_SYMBOL_GPL

---
 kernel/rcu/tasks.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/tasks.h +1 -1
index cd071b5d4274..04d3c583a9fc 100644
@@ -447,7 +447,7 @@ static void rcu_tasks_be_rude(struct work_struct *work)
 }
 
 // Wait for one rude RCU-tasks grace period.
-static void rcu_tasks_rude_wait_gp(struct rcu_tasks *rtp)
+void rcu_tasks_rude_wait_gp(struct rcu_tasks *rtp)
 {
 	schedule_on_each_cpu(rcu_tasks_be_rude);
 }
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 5 lines · Qiujun Huang

Found by gcc:
WARNING: modpost: "rcu_tasks_rude_wait_gp" [vmlinux] is a static EXPORT_SYMBOL_GPL

Good eyes, thank you!

However, the fix is instead to remove the EXPORT_SYMBOL_GPL(). I will squash the removal of this line into a04838a348a9 ("rcu-tasks: Add an RCU-tasks rude variant"), crediting you with catching this bug.

Again, thank you!

Thanx, Paul

Quoted 20 lines
---
 kernel/rcu/tasks.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/tasks.h +1 -1
index cd071b5d4274..04d3c583a9fc 100644
@@ -447,7 +447,7 @@ static void rcu_tasks_be_rude(struct work_struct *work)
 }
 
 // Wait for one rude RCU-tasks grace period.
-static void rcu_tasks_rude_wait_gp(struct rcu_tasks *rtp)
+void rcu_tasks_rude_wait_gp(struct rcu_tasks *rtp)
 {
 	schedule_on_each_cpu(rcu_tasks_be_rude);
 }
Signature · 1 line
2.17.1