Skip to contentSkip to conversation

crypto/nitrox: add 3DES-CBC support

PATCH Applied Nagadheeraj Rottela 2 participants 6 messages Mar 13, 2020 – Apr 5, 2020 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto/nitrox: add 3DES-CBC support

This patch adds 3DES CBC mode cipher algorithm.

---
 app/test/test_cryptodev.c                       |  1 +
 app/test/test_cryptodev_des_test_vectors.h      |  6 ++++--
 doc/guides/cryptodevs/features/nitrox.ini       |  1 +
 doc/guides/cryptodevs/nitrox.rst                |  2 ++
 drivers/crypto/nitrox/nitrox_sym.c              |  4 ++++
 drivers/crypto/nitrox/nitrox_sym_capabilities.c | 21 ++++++++++++++++++++-
 6 files changed, 32 insertions(+), 3 deletions(-)
app/test/test_cryptodev.c +1 -0
index 7b1ef5c86..e8dd8f754 100644
@@ -13117,6 +13117,7 @@ static struct unit_test_suite cryptodev_nitrox_testsuite  = {
 		TEST_CASE_ST(ut_setup, ut_teardown,
 				test_device_configure_invalid_queue_pair_ids),
 		TEST_CASE_ST(ut_setup, ut_teardown, test_AES_chain_all),
+		TEST_CASE_ST(ut_setup, ut_teardown, test_3DES_chain_all),
 
 		TEST_CASES_END() /**< NULL terminate unit test array */
 	}
app/test/test_cryptodev_des_test_vectors.h +4 -2
index 0a362d980..d8a62d2b5 100644
@@ -1115,7 +1115,8 @@ static const struct blockcipher_test_case triple_des_chain_test_cases[] = {
 			BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
 			BLOCKCIPHER_TEST_TARGET_PMD_CCP |
 			BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
-			BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
+			BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2 |
+			BLOCKCIPHER_TEST_TARGET_PMD_NITROX
 	},
 	{
 		.test_descr = "3DES-192-CBC HMAC-SHA1 Decryption Digest Verify",
@@ -1129,7 +1130,8 @@ static const struct blockcipher_test_case triple_des_chain_test_cases[] = {
 			BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
 			BLOCKCIPHER_TEST_TARGET_PMD_CCP |
 			BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
-			BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
+			BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2 |
+			BLOCKCIPHER_TEST_TARGET_PMD_NITROX
 	},
 	{
 		.test_descr = "3DES-192-CBC SHA1 Encryption Digest",
doc/guides/cryptodevs/features/nitrox.ini +1 -0
index ddc3c05f4..183494731 100644
@@ -20,6 +20,7 @@ OOP LB  In LB  Out     = Y
 AES CBC (128)  = Y
 AES CBC (192)  = Y
 AES CBC (256)  = Y
+3DES CBC       = Y
 
 ;
 ; Supported authentication algorithms of the 'nitrox' crypto driver.
doc/guides/cryptodevs/nitrox.rst +2 -0
index f8a527c05..85f5212b6 100644
@@ -18,6 +18,7 @@ Nitrox crypto PMD has support for:
 Cipher algorithms:
 
 * ``RTE_CRYPTO_CIPHER_AES_CBC``
+* ``RTE_CRYPTO_CIPHER_3DES_CBC``
 
 Hash algorithms:
 
@@ -29,6 +30,7 @@ Limitations
 -----------
 
 * AES_CBC Cipher Only combination is not supported.
+* 3DES Cipher Only combination is not supported.
 * Session-less APIs are not supported.
 
 Installation
drivers/crypto/nitrox/nitrox_sym.c +4 -0
index 56410c44d..c7aa3fd1b 100644
@@ -314,6 +314,10 @@ get_flexi_cipher_type(enum rte_crypto_cipher_algorithm algo, bool *is_aes)
 		type = CIPHER_AES_CBC;
 		*is_aes = true;
 		break;
+	case RTE_CRYPTO_CIPHER_3DES_CBC:
+		type = CIPHER_3DES_CBC;
+		*is_aes = false;
+		break;
 	default:
 		type = CIPHER_INVALID;
 		NITROX_LOG(ERR, "Algorithm not supported %d\n", algo);
drivers/crypto/nitrox/nitrox_sym_capabilities.c +20 -1
index 47ceead73..dc4df9185 100644
@@ -88,7 +88,26 @@ static const struct rte_cryptodev_capabilities nitrox_capabilities[] = {
 			}, }
 		}, }
 	},
-
+	{	/* 3DES CBC */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+			{.cipher = {
+				.algo = RTE_CRYPTO_CIPHER_3DES_CBC,
+				.block_size = 8,
+				.key_size = {
+					.min = 24,
+					.max = 24,
+					.increment = 0
+				},
+				.iv_size = {
+					.min = 8,
+					.max = 8,
+					.increment = 0
+				}
+			}, }
+		}, }
+	},
 	RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
 };
 
Signature · 1 line
2.13.6
#2 lore raw
Quoted 9 lines

-----Original Message-----
From: Akhil Goyal <[email protected]>
Sent: Thursday, March 26, 2020 12:18 AM
To: Nagadheeraj Rottela <[email protected]>
Cc: [email protected]; Srikanth Jampala <[email protected]>
Subject: [EXT] RE: [PATCH] crypto/nitrox: add 3DES-CBC support

External Email

Quoted 7 lines

----------------------------------------------------------------------

Quoted 5 lines

This patch adds 3DES CBC mode cipher algorithm.

---

Is it worth mentioning in release notes?

I added that description to avoid below checkpatch warning:

### crypto/nitrox: add 3DES-CBC support

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 83 lines checked

0/1 valid patch

#3 lore raw
Quoted 10 lines
Quoted 7 lines

----------------------------------------------------------------------

Quoted 5 lines

This patch adds 3DES CBC mode cipher algorithm.

---

Is it worth mentioning in release notes?

I added that description to avoid below checkpatch warning:

Quoted 8 lines

### crypto/nitrox: add 3DES-CBC support

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 83 lines checked

0/1 valid patch

I think you misinterpreted my comment.
I was talking about release notes and not patch description.

#4 lore raw
Quoted 26 lines

-----Original Message-----
From: Akhil Goyal <[email protected]>
Sent: Wednesday, April 1, 2020 7:38 PM
To: Nagadheeraj Rottela <[email protected]>
Cc: [email protected]; Srikanth Jampala <[email protected]>
Subject: [EXT] RE: [PATCH] crypto/nitrox: add 3DES-CBC support

External Email

----------------------------------------------------------------------

Quoted 16 lines
Quoted 8 lines

--------------------------------------------------------------------
--

Quoted 5 lines

This patch adds 3DES CBC mode cipher algorithm.

---

Is it worth mentioning in release notes?

I added that description to avoid below checkpatch warning:

### crypto/nitrox: add 3DES-CBC support

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

Quoted 6 lines
Quoted 3 lines

total: 0 errors, 1 warnings, 83 lines checked

0/1 valid patch

I think you misinterpreted my comment.
I was talking about release notes and not patch description.

I haven't added that description in the release notes. I only added description in the Limitations section.

Applied
#5 lore raw
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 7 lines

--

Quoted 5 lines

This patch adds 3DES CBC mode cipher algorithm.

---

Is it worth mentioning in release notes?

I added that description to avoid below checkpatch warning:

### crypto/nitrox: add 3DES-CBC support

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 83 lines checked

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

0/1 valid patch

I think you misinterpreted my comment.
I was talking about release notes and not patch description.

I haven't added that description in the release notes. I only added description in the Limitations section.

OK, it seems you do not want to add this in release notes.

Applied to dpdk-next-crypto

Thanks.