Skip to contentSkip to conversation

Document some limitations of --auth-user-pass

PATCH In review [email protected]... 4 participants 7 messages Mar 13, 2020 – Apr 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Document some limitations of --auth-user-pass

From: Samuli Seppänen <[email protected]...>

URL: https://community.openvpn.net/openvpn/ticket/757

---
 doc/openvpn.8 | 6 ++++++
 1 file changed, 6 insertions(+)
doc/openvpn.8 +6 -0
index 864f94e8..9e54890e 100644
@@ -4127,6 +4127,12 @@ The server configuration must specify an
 .B \-\-auth\-user\-pass\-verify
 script to verify the username/password provided by
 the client.
+
+Note that OpenVPN GUI on Windows does not prompt for the
+password if the file contains only the username. However,
+OpenVPN versions from 2.4 up bundle OpenVPN GUI version 11
+which is able to cache usernames and passwords internally.
+
 .\"*********************************************************
 .TP
 .B \-\-auth\-retry type
Signature · 1 line
2.21.1
#1 lore raw
Quoted 13 lines · On 13/03/2020 14:01, [email protected]... wrote:

From: Samuli Seppänen <[email protected]...>

URL: https://community.openvpn.net/openvpn/ticket/757

---
 doc/openvpn.8 | 6 ++++++
 1 file changed, 6 insertions(+)
doc/openvpn.8 +0 -0
index 864f94e8..9e54890e 100644

doc/openvpn.8 The server configuration must specify an · line 4135

Quoted 9 lines
doc/openvpn.8 +6 -0
@@ -4127,6 +4127,12 @@ The server configuration must specify an
 .B \-\-auth\-user\-pass\-verify
 script to verify the username/password provided by
 the client.
+
+Note that OpenVPN GUI on Windows does not prompt for the
+password if the file contains only the username. However,
+OpenVPN versions from 2.4 up bundle OpenVPN GUI version 11
+which is able to cache usernames and passwords internally.
+

Could we rephrase this, to not live in the past. This will go into master and probably also release/2.4. I also doubt anyone using man pages on 2.3 would even read this. If there are Windows users on 2.3, there are no excuse not to upgrade - unless it's an enterprise deployment, where end users most likely would not even care (they should anyway complain to their IT department regardless, for using outdated security software).

I would just rephrase it to say:

OpenVPN GUI v11 and newer uses its own internal username/password storage independent of the --auth-user-pass file provided. The file argument is ignored on such installations.

(or something like that)

Signature · 4 lines
kind regards,

David Sommerseth
OpenVPN Inc
#2 lore raw

Hi,

Quoted 32 lines · David Sommerseth
Quoted 13 lines · On 13/03/2020 14:01, [email protected]... wrote:

From: Samuli Seppänen <[email protected]...>

URL: https://community.openvpn.net/openvpn/ticket/757

---
 doc/openvpn.8 | 6 ++++++
 1 file changed, 6 insertions(+)
doc/openvpn.8 +0 -0
index 864f94e8..9e54890e 100644

doc/openvpn.8 The server configuration must specify an · line 4135

Quoted 9 lines
doc/openvpn.8 +6 -0
@@ -4127,6 +4127,12 @@ The server configuration must specify an
 .B \-\-auth\-user\-pass\-verify
 script to verify the username/password provided by
 the client.
+
+Note that OpenVPN GUI on Windows does not prompt for the
+password if the file contains only the username. However,
+OpenVPN versions from 2.4 up bundle OpenVPN GUI version 11
+which is able to cache usernames and passwords internally.
+

Could we rephrase this, to not live in the past. This will go into master and probably also release/2.4. I also doubt anyone using man pages on 2.3 would even read this. If there are Windows users on 2.3, there are no excuse not to upgrade - unless it's an enterprise deployment, where end users most likely would not even care (they should anyway complain to their IT department regardless, for using outdated security software).

Quoted 5 lines

I would just rephrase it to say:

OpenVPN GUI v11 and newer uses its own internal username/password storage independent of the --auth-user-pass file provided. The file argument is ignored on such installations.

I wish it behaved like that. Unfortunately the file argument is not ignored in such cases. If the file has only username, openvpn.exe reads it from the file and then fails to prompt for password as there is no console available.

I propose to change this behaviour to: if --management-query-passwords is set (which the GUI does), ignore the file given in auth-user-pass and prompt both username and password from management. I think its only logical for a later option (in this case the one set by the GUI) to override a previous one. Anyway we do already ignore it if the file is "stdin".

Selva

#3 lore raw

On 16/03/2020 14:48, Selva Nair wrote:
[...snip...]

Quoted 10 lines
Quoted 5 lines

I would just rephrase it to say:

OpenVPN GUI v11 and newer uses its own internal username/password storage independent of the --auth-user-pass file provided. The file argument is ignored on such installations.

I wish it behaved like that. Unfortunately the file argument is not ignored in such cases. If the file has only username, openvpn.exe reads it from the file and then fails to prompt for password as there is no console available.

Ouch ... that is a pointless misbehavior. Lets try to fix that.

Quoted 6 lines

I propose to change this behaviour to: if --management-query-passwords is set (which the GUI does), ignore the file given in auth-user-pass and prompt both username and password from management. I think its only logical for a later option (in this case the one set by the GUI) to override a previous one. Anyway we do already ignore it if the file is "stdin".

Agreed!

Signature · 4 lines
kind regards,

David Sommerseth
OpenVPN Inc
#4 lore raw

Hi,

Quoted 8 lines · David Sommerseth

On 16/03/2020 14:48, Selva Nair wrote:
[...snip...]

Quoted 6 lines
Quoted 5 lines

I would just rephrase it to say:

OpenVPN GUI v11 and newer uses its own internal username/password storage independent of the --auth-user-pass file provided. The file argument is ignored on such installations.

Quoted 6 lines
Quoted 4 lines

I wish it behaved like that. Unfortunately the file argument is not ignored in such cases. If the file has only username, openvpn.exe reads it from the file and then fails to prompt for password as there is no console available.

Ouch ... that is a pointless misbehavior. Lets try to fix that.

Have you recovered from your latest adventures in "password query code in OpenVPN" already? :-)

Not sure if the management commands permit the "we have a username but no password" flow today... Arne, Selva?

But yes, this needs to be either a clear error, or "work correctly"

Quoted 8 lines
Quoted 6 lines

I propose to change this behaviour to: if --management-query-passwords is set (which the GUI does), ignore the file given in auth-user-pass and prompt both username and password from management. I think its only logical for a later option (in this case the one set by the GUI) to override a previous one. Anyway we do already ignore it if the file is "stdin".

Agreed!

No, as this will break working configs *if* both username + password are in the file (did we ever merge the "inline auth-user-pass" patch?).

gert

Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]...
#5 lore raw

Hi,

Quoted 34 lines · Gert Doering

Hi,

Quoted 8 lines · David Sommerseth

On 16/03/2020 14:48, Selva Nair wrote:
[...snip...]

Quoted 6 lines
Quoted 5 lines

I would just rephrase it to say:

OpenVPN GUI v11 and newer uses its own internal username/password storage independent of the --auth-user-pass file provided. The file argument is ignored on such installations.

Quoted 6 lines
Quoted 4 lines

I wish it behaved like that. Unfortunately the file argument is not ignored in such cases. If the file has only username, openvpn.exe reads it from the file and then fails to prompt for password as there is no console available.

Ouch ... that is a pointless misbehavior. Lets try to fix that.

Have you recovered from your latest adventures in "password query code in OpenVPN" already? :-)

Not sure if the management commands permit the "we have a username but no password" flow today... Arne, Selva?

But yes, this needs to be either a clear error, or "work correctly"

Quoted 7 lines
Quoted 6 lines

I propose to change this behaviour to: if --management-query-passwords is set (which the GUI does), ignore the file given in auth-user-pass and prompt both username and password from management. I think its only logical for a later option (in this case the one set by the GUI) to override a previous one. Anyway we do already ignore it if the file is "stdin".

Quoted 4 lines
Quoted 1 line

Agreed!

No, as this will break working configs *if* both username + password are in the file (did we ever merge the "inline auth-user-pass" patch?).

See the patch in mail for what looks like an acceptable solution to me.

Selva

#6 lore raw
In reply to [email protected]...

Hi,

Quoted 5 lines · On Fri, Mar 13, 2020 at 03:01:33PM +0200, [email protected]... wrote:

From: Samuli Seppänen <[email protected]...>

URL: https://community.openvpn.net/openvpn/ticket/757

---

I'm going to mark that patch in patchwork as "changes requested", given that Selva changed the issue towards "if this happens, we'll just ignore the stored username and ask management for both user+password".

Not sure if we still need a documentation patch, but if we want one, it will have to be different text :)

gert

Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]...