ARM: dts: dra7: Add bus_dma_limit for L3 bus
PATCH v2 1/1 ARM: dts: dra7: Add bus_dma_limit for L3 bus
The L3 interconnect's memory map is from 0x0 to 0xffffffff. Out of this, System memory (SDRAM) can be accessed from 0x80000000 to 0xffffffff (2GB)
DRA7 does support 4GB of SDRAM but upper 2GB can only be accessed by the MPU subsystem.
Add the dma-ranges property to reflect the physical address limit of the L3 bus.
Issues ere observed only with SATA on DRA7-EVM with 4GB RAM and CONFIG_ARM_LPAE enabled. This is because the controller supports 64-bit DMA and its driver sets the dma_mask to 64-bit thus resulting in DMA accesses beyond L3 limit of 2G.
Setting the correct bus_dma_limit fixes the issue.
---
Changelog:
v2:
- Revised patch with minimal intrusion. i.e. don't change #size-cells of device node.
arch/arm/boot/dts/dra7.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/dra7.dtsi +1 -0
@@ -148,6 +148,7 @@ #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x0 0x0 0xc0000000>; + dma-ranges = <0x80000000 0x0 0x80000000 0x80000000>; ti,hwmods = "l3_main_1", "l3_main_2"; reg = <0x0 0x44000000 0x0 0x1000000>, <0x0 0x45000000 0x0 0x1000>;
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Quoted 10 lines · Roger Quadros
The L3 interconnect's memory map is from
0x0to0xffffffff. Out of this, System memory (SDRAM) can be accessed from0x80000000to0xffffffff(2GB)DRA7 does support 4GB of SDRAM but upper 2GB can only be accessed by the MPU subsystem.
Add the dma-ranges property to reflect the physical address limit of the L3 bus.
Quoted 6 lines
Issues ere observed only with SATA on DRA7-EVM with 4GB RAM and
CONFIG_ARM_LPAEenabled. This is because the controller supports 64-bit DMA and its driver sets thedma_maskto 64-bit thus resulting in DMA accesses beyond L3 limit of 2G.Setting the correct
bus_dma_limitfixes the issue.
Thanks applying into fixes.
Tony
Quoted 10 lines · Roger Quadros
The L3 interconnect's memory map is from
0x0to0xffffffff. Out of this, System memory (SDRAM) can be accessed from0x80000000to0xffffffff(2GB)DRA7 does support 4GB of SDRAM but upper 2GB can only be accessed by the MPU subsystem.
Add the dma-ranges property to reflect the physical address limit of the L3 bus.
Quoted 6 lines
Issues ere observed only with SATA on DRA7-EVM with 4GB RAM and
CONFIG_ARM_LPAEenabled. This is because the controller supports 64-bit DMA and its driver sets thedma_maskto 64-bit thus resulting in DMA accesses beyond L3 limit of 2G.Setting the correct
bus_dma_limitfixes the issue.
Neat! In principle you should no longer need the specific dma-ranges on the PCIe nodes, since AIUI those really only represent a subset of this general limitation, but given the other inheritance issue you saw it's probably safer to leave them as-is for now.
FWIW,
Quoted 25 lines
Signed-off-by Roger Quadros <[email protected]>---
Changelog:
v2:
- Revised patch with minimal intrusion. i.e. don't change #size-cells of device node.arch/arm/boot/dts/dra7.dtsi | 1 + 1 file changed, 1 insertion(+)arch/arm/boot/dts/dra7.dtsi +1
-0@@ -148,6 +148,7 @@ #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x0 0x0 0xc0000000>; + dma-ranges = <0x80000000 0x0 0x80000000 0x80000000>; ti,hwmods = "l3_main_1", "l3_main_2"; reg = <0x0 0x44000000 0x0 0x1000000>, <0x0 0x45000000 0x0 0x1000>;
Quoted 16 lines · Robin Murphy
Quoted 15 lines · Roger Quadros
The L3 interconnect's memory map is from
0x0to0xffffffff. Out of this, System memory (SDRAM) can be accessed from0x80000000to0xffffffff(2GB)DRA7 does support 4GB of SDRAM but upper 2GB can only be accessed by the MPU subsystem.
Add the dma-ranges property to reflect the physical address limit of the L3 bus.
Issues ere observed only with SATA on DRA7-EVM with 4GB RAM and
CONFIG_ARM_LPAEenabled. This is because the controller supports 64-bit DMA and its driver sets thedma_maskto 64-bit thus resulting in DMA accesses beyond L3 limit of 2G.
Quoted 6 lines
Quoted 1 line
Setting the correct
bus_dma_limitfixes the issue.Neat! In principle you should no longer need the specific dma-ranges on the PCIe nodes, since AIUI those really only represent a subset of this general limitation, but given the other inheritance issue you saw it's probably safer to leave them as-is for now.
Also, Roger, I think omap5 needs a similar patch too, right? At least pyra has omap5 with 4GB and SATA connector.
Quoted 3 lines
FWIW,
Reviewed-by Robin Murphy <[email protected]>
Sorry missed that as I just pushed out the fix.
Regards,
Tony
Quoted 19 lines · Tony Lindgren
Quoted 18 lines · Robin Murphy
Quoted 16 lines · Roger Quadros
The L3 interconnect's memory map is from
0x0to0xffffffff. Out of this, System memory (SDRAM) can be accessed from0x80000000to0xffffffff(2GB)DRA7 does support 4GB of SDRAM but upper 2GB can only be accessed by the MPU subsystem.
Add the dma-ranges property to reflect the physical address limit of the L3 bus.
Issues ere observed only with SATA on DRA7-EVM with 4GB RAM and
CONFIG_ARM_LPAEenabled. This is because the controller supports 64-bit DMA and its driver sets thedma_maskto 64-bit thus resulting in DMA accesses beyond L3 limit of 2G.Setting the correct
bus_dma_limitfixes the issue.
Quoted 7 lines
Quoted 4 lines
Neat! In principle you should no longer need the specific dma-ranges on the PCIe nodes, since AIUI those really only represent a subset of this general limitation, but given the other inheritance issue you saw it's probably safer to leave them as-is for now.
Also, Roger, I think omap5 needs a similar patch too, right? At least pyra has omap5 with 4GB and SATA connector.
Yes Tony, I'll send a patch for omap5 as well.
Quoted 11 lines
Quoted 4 lines
FWIW,
Reviewed-by Robin Murphy <[email protected]>Sorry missed that as I just pushed out the fix.
Regards,
Tony
Signature · 4 lines
cheers, -roger Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki