Skip to contentSkip to conversation

hw/arm/pxa2xx: Do not wire up OHCI for PXA255

PATCH Applied Guenter Roeck 2 participants 4 messages Mar 13, 2020 – Mar 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/arm/pxa2xx: Do not wire up OHCI for PXA255

PXA255 does not support a USB OHCI controller, so don't wire it up.

---
 hw/arm/pxa2xx.c | 3 ---
 1 file changed, 3 deletions(-)
hw/arm/pxa2xx.c +0 -3
index 56a36202d7..336c9bad4a 100644
@@ -2290,9 +2290,6 @@ PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size)
         s->ssp[i] = (SSIBus *)qdev_get_child_bus(dev, "ssi");
     }
 
-    sysbus_create_simple("sysbus-ohci", 0x4c000000,
-                         qdev_get_gpio_in(s->pic, PXA2XX_PIC_USBH1));
-
     s->pcmcia[0] = pxa2xx_pcmcia_init(address_space, 0x20000000);
     s->pcmcia[1] = pxa2xx_pcmcia_init(address_space, 0x30000000);
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Guenter Roeck

PXA255 does not support a USB OHCI controller, so don't wire it up.

---
 hw/arm/pxa2xx.c | 3 ---
 1 file changed, 3 deletions(-)
hw/arm/pxa2xx.c +0 -0
index 56a36202d7..336c9bad4a 100644

hw/arm/pxa2xx.c PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size) · line 2295

Quoted 9 lines
hw/arm/pxa2xx.c +0 -3
@@ -2290,9 +2290,6 @@ PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size)
         s->ssp[i] = (SSIBus *)qdev_get_child_bus(dev, "ssi");
     }
 
-    sysbus_create_simple("sysbus-ohci", 0x4c000000,
-                         qdev_get_gpio_in(s->pic, PXA2XX_PIC_USBH1));
-
     s->pcmcia[0] = pxa2xx_pcmcia_init(address_space, 0x20000000);
     s->pcmcia[1] = pxa2xx_pcmcia_init(address_space, 0x30000000);
 

How did you notice this bug? Was it just reading the code?

thanks
-- PMM

#2 lore raw
Quoted 17 lines · Peter Maydell
Quoted 16 lines · Guenter Roeck

PXA255 does not support a USB OHCI controller, so don't wire it up.

---
 hw/arm/pxa2xx.c | 3 ---
 1 file changed, 3 deletions(-)
hw/arm/pxa2xx.c +0 -0
index 56a36202d7..336c9bad4a 100644
@@ -2290,9 +2290,6 @@ PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size)
         s->ssp[i] = (SSIBus *)qdev_get_child_bus(dev, "ssi");
     }
 
Quoted 9 lines

hw/arm/pxa2xx.c PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size) · line 2295

Quoted 6 lines
hw/arm/pxa2xx.c +0 -3
-    sysbus_create_simple("sysbus-ohci", 0x4c000000,
-                         qdev_get_gpio_in(s->pic, PXA2XX_PIC_USBH1));
-
     s->pcmcia[0] = pxa2xx_pcmcia_init(address_space, 0x20000000);
     s->pcmcia[1] = pxa2xx_pcmcia_init(address_space, 0x30000000);
 

How did you notice this bug? Was it just reading the code?

I found that it was wired up and I tried to enable it from Linux, which failed. After that, I dug up the chip manual and realized that the pxa255 hardware does not support it.

Guenter